* [meta-raspberrypi][PATCH] Make CMDLINE overridable from outside
@ 2017-04-28 15:37 Gianfranco Costamagna
2017-05-12 19:13 ` Paul Barker
0 siblings, 1 reply; 4+ messages in thread
From: Gianfranco Costamagna @ 2017-04-28 15:37 UTC (permalink / raw)
To: yocto; +Cc: Gianfranco Costamagna
currently there is no way to override the default CMDLINE, lets set if only if not already set from outside
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
---
recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index cf61cce..9265d55 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -21,7 +21,7 @@ KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
KERNEL_DEFCONFIG_raspberrypi3-64 ?= "bcmrpi3_defconfig"
# CMDLINE for raspberrypi
-CMDLINE = "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
+CMDLINE ?= "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
# Add the kernel debugger over console kernel command line option if enabled
CMDLINE_append = ' ${@base_conditional("ENABLE_KGDB", "1", "kgdboc=serial0,115200", "", d)}'
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-raspberrypi][PATCH] Make CMDLINE overridable from outside
2017-04-28 15:37 [meta-raspberrypi][PATCH] Make CMDLINE overridable from outside Gianfranco Costamagna
@ 2017-05-12 19:13 ` Paul Barker
2017-05-12 19:58 ` Andrei Gherzan
0 siblings, 1 reply; 4+ messages in thread
From: Paul Barker @ 2017-05-12 19:13 UTC (permalink / raw)
To: Gianfranco Costamagna; +Cc: yocto, Gianfranco Costamagna
On Fri, Apr 28, 2017 at 4:37 PM, Gianfranco Costamagna
<costamagna.gianfranco@gmail.com> wrote:
> currently there is no way to override the default CMDLINE, lets set if only if not already set from outside
>
> Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
> ---
> recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index cf61cce..9265d55 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -21,7 +21,7 @@ KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
> KERNEL_DEFCONFIG_raspberrypi3-64 ?= "bcmrpi3_defconfig"
>
> # CMDLINE for raspberrypi
> -CMDLINE = "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
> +CMDLINE ?= "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>
> # Add the kernel debugger over console kernel command line option if enabled
> CMDLINE_append = ' ${@base_conditional("ENABLE_KGDB", "1", "kgdboc=serial0,115200", "", d)}'
> --
> 2.7.4
>
This looks good, I'll add it to my queue to test next week unless
Andrei has time to pick it up. We've all been a bit busy, sorry you've
not had a response sooner!
--
Paul Barker
Co-Founder & Principal Engineer
Togán Labs Ltd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-raspberrypi][PATCH] Make CMDLINE overridable from outside
2017-05-12 19:13 ` Paul Barker
@ 2017-05-12 19:58 ` Andrei Gherzan
0 siblings, 0 replies; 4+ messages in thread
From: Andrei Gherzan @ 2017-05-12 19:58 UTC (permalink / raw)
To: Paul Barker; +Cc: yocto, Gianfranco Costamagna, Gianfranco Costamagna
On Fri, May 12, 2017 at 8:13 PM, Paul Barker <pbarker@toganlabs.com> wrote:
> On Fri, Apr 28, 2017 at 4:37 PM, Gianfranco Costamagna
> <costamagna.gianfranco@gmail.com> wrote:
>> currently there is no way to override the default CMDLINE, lets set if only if not already set from outside
>>
>> Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
>> ---
>> recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>> index cf61cce..9265d55 100644
>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>> @@ -21,7 +21,7 @@ KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
>> KERNEL_DEFCONFIG_raspberrypi3-64 ?= "bcmrpi3_defconfig"
>>
>> # CMDLINE for raspberrypi
>> -CMDLINE = "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>> +CMDLINE ?= "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>>
>> # Add the kernel debugger over console kernel command line option if enabled
>> CMDLINE_append = ' ${@base_conditional("ENABLE_KGDB", "1", "kgdboc=serial0,115200", "", d)}'
>> --
>> 2.7.4
>>
>
> This looks good, I'll add it to my queue to test next week unless
> Andrei has time to pick it up. We've all been a bit busy, sorry you've
> not had a response sooner!
My fault. Completely missed this one. I added a review in github. All
it needs is a commit summary tweak.
Andrei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [meta-raspberrypi][PATCH] Make CMDLINE overridable from outside
@ 2017-04-28 15:17 Gianfranco Costamagna
0 siblings, 0 replies; 4+ messages in thread
From: Gianfranco Costamagna @ 2017-04-28 15:17 UTC (permalink / raw)
To: yocto; +Cc: Gianfranco Costamagna
currently there is no way to override the default CMDLINE, lets set if only if not already set from outside
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
---
recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index cf61cce..9265d55 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -21,7 +21,7 @@ KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
KERNEL_DEFCONFIG_raspberrypi3-64 ?= "bcmrpi3_defconfig"
# CMDLINE for raspberrypi
-CMDLINE = "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
+CMDLINE ?= "dwc_otg.lpm_enable=0 console=serial0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
# Add the kernel debugger over console kernel command line option if enabled
CMDLINE_append = ' ${@base_conditional("ENABLE_KGDB", "1", "kgdboc=serial0,115200", "", d)}'
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-12 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 15:37 [meta-raspberrypi][PATCH] Make CMDLINE overridable from outside Gianfranco Costamagna
2017-05-12 19:13 ` Paul Barker
2017-05-12 19:58 ` Andrei Gherzan
-- strict thread matches above, loose matches on Subject: below --
2017-04-28 15:17 Gianfranco Costamagna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.