From: Pantelis Antoniou <pantelis.antoniou@konsulko.com> To: frowand.list@gmail.com Cc: Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux Kernel list <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root Date: Fri, 13 Jun 2014 10:07:33 +0300 [thread overview] Message-ID: <CC628CCC-7C30-48BA-8A2A-49E60ED72854@konsulko.com> (raw) In-Reply-To: <539A91E2.7000606@gmail.com> Hi Frank, On Jun 13, 2014, at 8:53 AM, Frank Rowand wrote: > From: Frank Rowand <frank.rowand@sonymobile.com> > > Pantelis Antoniou reports that of_find_node_by_path() is borked because > of_allnodes is not guaranteed to contain the root of the tree after using > any of the dynamic update functions because some other nodes ends up as > of_allnodes. > > Fixes: c22e650e66b8 of: Make of_find_node_by_path() handle /aliases > > Signed-off-by: Frank Rowand <frank.rowand@sonymobile.com> > --- > > > Pantelis, > > Can you test whether the problem you reported in irc? > > This patch has not been tested, not even compile tested. > I can verify that this fixes the problem. Please make sure this gets applied to mainline otherwise every arch which updates DT on runtime is going to break in subtle ways. Regards -- Pantelis Tested-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > > drivers/of/base.c | 8 6 + 2 - 0 ! > 1 file changed, 6 insertions(+), 2 deletions(-) > > Index: b/drivers/of/base.c > =================================================================== > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1948,6 +1948,9 @@ int of_reconfig_notify(unsigned long act > > /** > * of_attach_node - Plug a device node into the tree and global list. > + * > + * Put the device node after of_allnodes in the global list so that > + * of_allnodes remains the root. > */ > int of_attach_node(struct device_node *np) > { > @@ -1958,11 +1961,12 @@ int of_attach_node(struct device_node *n > if (rc) > return rc; > > + BUG_ON(!of_allnodes); > raw_spin_lock_irqsave(&devtree_lock, flags); > np->sibling = np->parent->child; > - np->allnext = of_allnodes; > + np->allnext = of_allnodes->allnext; > np->parent->child = np; > - of_allnodes = np; > + of_allnodes->allnext = np; > of_node_clear_flag(np, OF_DETACHED); > raw_spin_unlock_irqrestore(&devtree_lock, flags); > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Pantelis Antoniou <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> To: frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Kernel list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root Date: Fri, 13 Jun 2014 10:07:33 +0300 [thread overview] Message-ID: <CC628CCC-7C30-48BA-8A2A-49E60ED72854@konsulko.com> (raw) In-Reply-To: <539A91E2.7000606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Hi Frank, On Jun 13, 2014, at 8:53 AM, Frank Rowand wrote: > From: Frank Rowand <frank.rowand-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org> > > Pantelis Antoniou reports that of_find_node_by_path() is borked because > of_allnodes is not guaranteed to contain the root of the tree after using > any of the dynamic update functions because some other nodes ends up as > of_allnodes. > > Fixes: c22e650e66b8 of: Make of_find_node_by_path() handle /aliases > > Signed-off-by: Frank Rowand <frank.rowand-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org> > --- > > > Pantelis, > > Can you test whether the problem you reported in irc? > > This patch has not been tested, not even compile tested. > I can verify that this fixes the problem. Please make sure this gets applied to mainline otherwise every arch which updates DT on runtime is going to break in subtle ways. Regards -- Pantelis Tested-by: Pantelis Antoniou <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> > > drivers/of/base.c | 8 6 + 2 - 0 ! > 1 file changed, 6 insertions(+), 2 deletions(-) > > Index: b/drivers/of/base.c > =================================================================== > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1948,6 +1948,9 @@ int of_reconfig_notify(unsigned long act > > /** > * of_attach_node - Plug a device node into the tree and global list. > + * > + * Put the device node after of_allnodes in the global list so that > + * of_allnodes remains the root. > */ > int of_attach_node(struct device_node *np) > { > @@ -1958,11 +1961,12 @@ int of_attach_node(struct device_node *n > if (rc) > return rc; > > + BUG_ON(!of_allnodes); > raw_spin_lock_irqsave(&devtree_lock, flags); > np->sibling = np->parent->child; > - np->allnext = of_allnodes; > + np->allnext = of_allnodes->allnext; > np->parent->child = np; > - of_allnodes = np; > + of_allnodes->allnext = np; > of_node_clear_flag(np, OF_DETACHED); > raw_spin_unlock_irqrestore(&devtree_lock, flags); > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-13 7:07 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-13 5:53 [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root Frank Rowand 2014-06-13 5:53 ` Frank Rowand 2014-06-13 7:07 ` Pantelis Antoniou [this message] 2014-06-13 7:07 ` Pantelis Antoniou 2014-06-13 13:52 ` Rob Herring 2014-06-13 13:52 ` Rob Herring 2014-06-13 15:06 ` Grant Likely 2014-06-14 15:00 ` Grant Likely 2014-06-14 15:00 ` Grant Likely 2014-06-15 3:36 ` Frank Rowand 2014-06-15 3:36 ` Frank Rowand 2014-06-15 3:39 ` Frank Rowand 2014-06-15 3:39 ` Frank Rowand 2014-06-15 3:42 ` Frank Rowand 2014-06-15 3:42 ` Frank Rowand 2014-06-13 16:49 ` Frank Rowand 2014-06-13 21:12 ` Rob Herring 2014-06-13 21:12 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CC628CCC-7C30-48BA-8A2A-49E60ED72854@konsulko.com \ --to=pantelis.antoniou@konsulko.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=grant.likely@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.