All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Connor Kuehl" <ckuehl@redhat.com>
To: "Miroslav Rezanina" <mrezanin@redhat.com>, <qemu-devel@nongnu.org>
Cc: pbonzini@redhat.com
Subject: Re: [PATCH] Fix libpmem configuration option
Date: Wed, 07 Jul 2021 17:22:43 -0700	[thread overview]
Message-ID: <CCNBVYIWGWRJ.BW9EYUEODQZW@redhat> (raw)
In-Reply-To: <20210707075144.82717-1-mrezanin@redhat.com>

On Wed Jul 7, 2021 at 12:51 AM PDT, Miroslav Rezanina wrote:
> For some reason, libpmem option setting was set to work in an opposite
> way (--enable-libpmem disabled it and vice versa). Fixing this so
> configuration works properly.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 7994bdee92..ffa93cc5fd 100755
> --- a/configure
> +++ b/configure
> @@ -1501,9 +1501,9 @@ for opt do
> ;;
> --disable-debug-mutex) debug_mutex=no
> ;;
> - --enable-libpmem) libpmem=disabled
> + --enable-libpmem) libpmem="enabled"
> ;;
> - --disable-libpmem) libpmem=enabled
> + --disable-libpmem) libpmem="disabled"
> ;;
> --enable-xkbcommon) xkbcommon="enabled"
> ;;
> --
> 2.27.0

Good catch.

Reviewed-by: Connor Kuehl <ckuehl@redhat.com>

or

Tested-by: Connor Kuehl <ckuehl@redhat.com>



  parent reply	other threads:[~2021-07-08  0:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  7:51 [PATCH] Fix libpmem configuration option Miroslav Rezanina
2021-07-07  8:14 ` Philippe Mathieu-Daudé
2021-07-08  0:22 ` Connor Kuehl [this message]
2021-07-08  4:48 ` Pankaj Gupta
2021-07-08  9:54 ` Li, Zhijian/李 智坚

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CCNBVYIWGWRJ.BW9EYUEODQZW@redhat \
    --to=ckuehl@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.