[PATCH 1/2] Support option --disable-optimization

[PATCH 1/2] Support option --disable-optimization

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

---
 configure.ac |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/configure.ac b/configure.ac
index 887c91a..a85fda3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -14,6 +14,13 @@ PKG_PROG_PKG_CONFIG
 AC_PROG_CXX
 AC_PROG_INSTALL
 
+AC_ARG_ENABLE(optimization, AC_HELP_STRING([--disable-optimization],
+			[disable code optimization through compiler]), [
+	if (test "${enableval}" = "no"); then
+		CXXFLAGS="$CXXFLAGS -O0"
+	fi
+])
+
 PKG_CHECK_MODULES(QT, QtCore QtGui QtXml QtNetwork, dummy=yes,
 						AC_MSG_ERROR(Qt is required))
 AC_SUBST(QT_CFLAGS)
-- 
1.7.0.4

[PATCH 2/2] Change sw2 only when cmd is not empty

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

---
 src/phonesim.cpp |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/phonesim.cpp b/src/phonesim.cpp
index d5d7d87..8210f51 100644
--- a/src/phonesim.cpp
+++ b/src/phonesim.cpp
@@ -923,9 +923,10 @@ bool SimRules::simCsimOk( const QByteArray& payload )
 
     if ( toolkitApp ) {
         QByteArray cmd = toolkitApp->fetch();
-        if ( !cmd.isEmpty() )
+        if ( !cmd.isEmpty() ) {
             sw1 = 0x91;
             sw2 = cmd.size();
+        }
     }
 
     resp += sw1;
-- 
1.7.0.4

RE: [PATCH 1/2] Support option --disable-optimization

[Gu, Yang]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Hi,
	Forget to mention, this patch series (2 patches) is against phonesim.

>-----Original Message-----
>From: Gu, Yang
>Sent: Thursday, July 08, 2010 6:57 PM
>To: ofono(a)ofono.org
>Cc: Gu, Yang
>Subject: [PATCH 1/2] Support option --disable-optimization
>
>---
> configure.ac |    7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 887c91a..a85fda3 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -14,6 +14,13 @@ PKG_PROG_PKG_CONFIG
> AC_PROG_CXX
> AC_PROG_INSTALL
>
>+AC_ARG_ENABLE(optimization, AC_HELP_STRING([--disable-optimization],
>+			[disable code optimization through compiler]), [
>+	if (test "${enableval}" = "no"); then
>+		CXXFLAGS="$CXXFLAGS -O0"
>+	fi
>+])
>+
> PKG_CHECK_MODULES(QT, QtCore QtGui QtXml QtNetwork, dummy=yes,
> 						AC_MSG_ERROR(Qt is required))
> AC_SUBST(QT_CFLAGS)
>--
>1.7.0.4



Regards,
-Yang

RE: [PATCH 1/2] Support option --disable-optimization

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Hi Yang,

> 	Forget to mention, this patch series (2 patches) is against phonesim.

I figured that. Both patches have been applied. Thanks.

Regards

Marcel