fixes pushed for review

fixes pushed for review

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hello,

I pushed a couple of simple patches, including a fix
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5803

I chose to set Package.size = -1 for packages brought in just to satisfy
dependencies since I wanted to avoid changing the DB schema.

Can you please review
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=adamian/fixes

​Thanks,
Alex​


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1526 bytes --]

Re: fixes pushed for review

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

Hello,

This is a new push for review, contrib/adamian/fixes. Ravi, I think this
will get you forward with the all the task types you need.

- two new patches added
- the 5803 patch now filters the invalid packages (size == -1) from the UI
views.

Alex


On Mon, Feb 10, 2014 at 3:08 PM, Damian, Alexandru <
alexandru.damian@intel.com> wrote:

> Hello,
>
> I pushed a couple of simple patches, including a fix
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=5803
>
> I chose to set Package.size = -1 for packages brought in just to satisfy
> dependencies since I wanted to avoid changing the DB schema.
>
> Can you please review
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=adamian/fixes
>
> ​Thanks,
> Alex​
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 3040 bytes --]

Re: fixes pushed for review

[Barros Pena, Belen]

Hi Alex,

Comments below.

Cheers

Belén

On 13/02/2014 16:33, "Damian, Alexandru" <alexandru.damian@intel.com>
wrote:

>Hello,
>
>
>This is a new push for review, contrib/adamian/fixes. Ravi, I think this
>will get you forward with the all the task types you need.
>
>- two new patches added

The fix for the empty tasks seems to be working. A search for do_build in
a clean core-image-minimal build returns a whole bunch of not executed -
empty tasks, which seems correct. Also, not executed tasks now show as Not
executed everywhere (they used to be shown as Prebuilt in the recipe
details pages). However, the empty filter does not seem to work: if I
click the filter button next to the Outcome column and select the Empty
tasks radio button, I get 0 tasks.

There is something funny going on with the package details in you branch
as well: basically, Toaster does not distinguish between packages built
and packages installed. If I select the eglibc package, for example, I
should be told that the package is installed in core-image-minimal, but I
am told the package is not included in any image instead. That doesn't
seem right, although I think this is working in toaster/master.


>- the 5803 patch now filters the invalid packages (size == -1) from the
>UI views.

This seems to be working.

>
>
>Alex
>
>
>
>On Mon, Feb 10, 2014 at 3:08 PM, Damian, Alexandru
><alexandru.damian@intel.com> wrote:
>
>Hello,
>
>
>I pushed a couple of simple patches, including a fix
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=5803
>
>
>
>I chose to set Package.size = -1 for packages brought in just to satisfy
>dependencies since I wanted to avoid changing the DB schema.
>
>
>Can you please review
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=adamian/f
>ixes
>
>
>
>​Thanks,
>Alex​
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>
>
>
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>