From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Greg KH <greg@kroah.com>,
dann frazier <dann.frazier@canonical.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Peng Tao <bergwolf@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>
Subject: Re: [PATCH] staging/lustre: disable virtual block device for 64K pages
Date: Fri, 27 Jun 2014 11:20:06 +0000 [thread overview]
Message-ID: <CFD2ABC9.ADA2F%andreas.dilger@intel.com> (raw)
In-Reply-To: <4592947.kMtdJTsB2U@wuerfel>
The patch looks mostly OK, though I see there is also a
CONFIG_PPC_256K_PAGES
define that should probably be handled.
Cheers, Andreas
On 2014/06/20, 6:23 AM, "Arnd Bergmann" <arnd@arndb.de> wrote:
>The lustre virtual block device cannot handle 64K pages and fails at
>compile
>time. To avoid running into this error, let's disable the Kconfig option
>for this driver in cases it doesn't support.
>
>Reported-by: Dann Frazier <dann.frazier@canonical.com>
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>---
>On Thursday 19 June 2014 12:10:51 Greg KH wrote:
>> On Thu, Jun 19, 2014 at 12:33:21PM -0600, dann frazier wrote:
>> > drivers/staging/lustre/lustre/llite/lloop.c:523:18: error: previously
>>used here
>> > CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8)));
>> > ^
>>
>> Looks like lustre can't handle 64K page sizes, so it refuses to build :(
>>
>> I sugest turning this code off, you really don't want to be running it
>> anyway...
>
>something like this?
>
>diff --git a/drivers/staging/lustre/lustre/Kconfig
>b/drivers/staging/lustre/lustre/Kconfig
>index 209e4c7..4f65ba1 100644
>--- a/drivers/staging/lustre/lustre/Kconfig
>+++ b/drivers/staging/lustre/lustre/Kconfig
>@@ -57,4 +57,5 @@ config LUSTRE_TRANSLATE_ERRNOS
> config LUSTRE_LLITE_LLOOP
> tristate "Lustre virtual block device"
> depends on LUSTRE_FS && BLOCK
>+ depends on !PPC_64K_PAGES && !ARM64_64K_PAGES
> default m
>
>
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
WARNING: multiple messages have this Message-ID (diff)
From: andreas.dilger@intel.com (Dilger, Andreas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging/lustre: disable virtual block device for 64K pages
Date: Fri, 27 Jun 2014 11:20:06 +0000 [thread overview]
Message-ID: <CFD2ABC9.ADA2F%andreas.dilger@intel.com> (raw)
In-Reply-To: <4592947.kMtdJTsB2U@wuerfel>
The patch looks mostly OK, though I see there is also a
CONFIG_PPC_256K_PAGES
define that should probably be handled.
Cheers, Andreas
On 2014/06/20, 6:23 AM, "Arnd Bergmann" <arnd@arndb.de> wrote:
>The lustre virtual block device cannot handle 64K pages and fails at
>compile
>time. To avoid running into this error, let's disable the Kconfig option
>for this driver in cases it doesn't support.
>
>Reported-by: Dann Frazier <dann.frazier@canonical.com>
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>---
>On Thursday 19 June 2014 12:10:51 Greg KH wrote:
>> On Thu, Jun 19, 2014 at 12:33:21PM -0600, dann frazier wrote:
>> > drivers/staging/lustre/lustre/llite/lloop.c:523:18: error: previously
>>used here
>> > CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8)));
>> > ^
>>
>> Looks like lustre can't handle 64K page sizes, so it refuses to build :(
>>
>> I sugest turning this code off, you really don't want to be running it
>> anyway...
>
>something like this?
>
>diff --git a/drivers/staging/lustre/lustre/Kconfig
>b/drivers/staging/lustre/lustre/Kconfig
>index 209e4c7..4f65ba1 100644
>--- a/drivers/staging/lustre/lustre/Kconfig
>+++ b/drivers/staging/lustre/lustre/Kconfig
>@@ -57,4 +57,5 @@ config LUSTRE_TRANSLATE_ERRNOS
> config LUSTRE_LLITE_LLOOP
> tristate "Lustre virtual block device"
> depends on LUSTRE_FS && BLOCK
>+ depends on !PPC_64K_PAGES && !ARM64_64K_PAGES
> default m
>
>
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
next prev parent reply other threads:[~2014-06-27 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 18:33 lustre virtual block device doesn't build w/ CONFIG_ARM64_64K_PAGES=y dann frazier
2014-06-19 18:33 ` dann frazier
2014-06-19 19:10 ` Greg KH
2014-06-19 19:10 ` Greg KH
2014-06-20 12:23 ` [PATCH] staging/lustre: disable virtual block device for 64K pages Arnd Bergmann
2014-06-20 12:23 ` Arnd Bergmann
2014-06-27 11:20 ` Dilger, Andreas [this message]
2014-06-27 11:20 ` Dilger, Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CFD2ABC9.ADA2F%andreas.dilger@intel.com \
--to=andreas.dilger@intel.com \
--cc=arnd@arndb.de \
--cc=bergwolf@gmail.com \
--cc=dann.frazier@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.