Viewing Task details feature

Viewing Task details feature

[Ravi Chintakunta]

I have pushed my code for "Viewing a task details" to my branch: ravi/task-details-feature.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task-details-feature&id=c900b846ca8679b8a36938d06a3de8635e22e45f

I also added a fix in reload_params function in base.html, that was failing when the original page URL did not have any parameters.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task-details-feature&id=0a59ec4f35ca9d7f3a7d2460e88fe17839248a3a

Please note that with the ongoing backend work for the Tasks sstate, I could not get much testing for tasks with different execution status. The UI is in place and I believe it will work with the backend fixes.


Thanks,
Ravi

Re: Viewing Task details feature

[Reyna, David]

Hi Ravi,

I did a quick review (it looked good to me), mostly to insure that your changes and my pending changes for "Tasks/DiskIO/CPU/Time" do not collide. I am happy to report that our respective work should cleanly merged.

I did notice that for "projecttags.py" this small warning.

  \ No newline at end of file

On that general subject, I wonder how all of our respective additions to "projecttags.py" merge, since we are each trying to merge to the _changing_ end of that file.

David


> -----Original Message-----
> From: Ravi Chintakunta [mailto:ravi.chintakunta@timesys.com]
> Sent: Monday, February 17, 2014 8:53 PM
> To: 'Damian, Alexandru'; 'Barros Pena, Belen'; Reyna, David; Lerner, Dave;
> 'Zhang, Jessica'
> Cc: 'toaster@yoctoproject.org'
> Subject: Viewing Task details feature
> 
> I have pushed my code for "Viewing a task details" to my branch: ravi/task-
> details-feature.
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task-
> details-feature&id=c900b846ca8679b8a36938d06a3de8635e22e45f
> 
> I also added a fix in reload_params function in base.html, that was failing
> when the original page URL did not have any parameters.
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task-
> details-feature&id=0a59ec4f35ca9d7f3a7d2460e88fe17839248a3a
> 
> Please note that with the ongoing backend work for the Tasks sstate, I could
> not get much testing for tasks with different execution status. The UI is in
> place and I believe it will work with the backend fixes.
> 
> 
> Thanks,
> Ravi

Re: Viewing Task details feature

[Ravi Chintakunta]

Hi David,

>  
>  I did a quick review (it looked good to me), mostly to insure that
>  your changes and my pending changes for "Tasks/DiskIO/CPU/Time" do not
>  collide. I am happy to report that our respective work should cleanly
>  merged.
>  

Cool, thanks.

>  I did notice that for "projecttags.py" this small warning.
>  
>    \ No newline at end of file
>  

I did not add a new line at the end of the file and that might be from the git diff.

Thanks,
Ravi

Re: Viewing Task details feature

[Barros Pena, Belen]

Hi all. I had a look to the ravi/task-details-feature branch.

The review is not complete, but I thought it better to share the issues I
found to see if we can take this branch asap into toaster/master to start
seeing how it plays with the latest back end changes to the tasks. This is
my list:

* Sometimes, when I click on a task, I get an error. It seems to be
related to the page trying to open a local file that no longer exists.
From my list, this is in the only critical issue. This is the full trace:

Environment:
Request Method: GET

Request URL: http://localhost:8000/gui/build/47/task/50266

Django Version: 1.5

Python Version: 2.7.3
Installed Applications:
('django.contrib.staticfiles',
 'django.contrib.humanize',
 'orm',
 'toastermain',
 'toastergui',
 'bldviewer',
 'south')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware')

Traceback:

File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py" in
get_response
  115.                         response = callback(request,
*callback_args, **callback_kwargs)
File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in task
  368.         lines = read_file(task.logfile)
File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in
read_file
  198.     with open(file, 'r') as f:

Exception Type: IOError at /gui/build/47/task/50266

Exception Value: [Errno 2] No such file or directory:
u'/home/yocto/poky/build/tmp/work/x86_64-linux/m4-native/1.4.17-r0/temp/log
.do_fetch.15180¹

* For executed - succeeded tasks, the heading of the outcome section
should have the class .green applied. We are reusing the task_color
project tag, but that only sets the .muted class for not executed tasks,
so we¹ll need to amend the tag or use something else. We need to keep in
mind that the .green class should only be set in that heading for the task
details page, and not in the tasks table.

* For executed - failed tasks with script type shell, the python stack
trace section should not show (right now, it shows empty). For Python
tasks, we need to put a mechanism in place to link a build¹s messages to a
task when applicable
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a failed
Python task is not linked to an entry in the orm_logmessage table, the
python stack trace section should not show.

* In the Prebuilt tasks, the outcome of the ³Match to tasks in previous
builds² search doesn¹t seem right:

** it shows tasks from more recent builds than the one I am searching
from. This search should only search across tasks from builds that are
older than the one I am searching from. From the spec: "A "match" button
to find executed tasks from previous builds (recorded by Toaster) with the
same task signature as the prebuilt task.²

** it is also returning the same task for other recipes, and different
tasks for different recipes (in gcc- targets), something we were not
expecting to see. I believe Alex is looking into this.

** the page reloads to show the search results, which means that when you
click the back button you are brought to the same page without the search
results. This is a bit funny. Any chance we could use an ajax call to load
the search results without reloading the page?

* In the results table:

** the date format in the Completed on table is wrong. It should match the
one used in the builds table

** we are missing the help on hover for the Task and Outcome columns (for
an example, go to 
http://www.yoctoproject.org/toaster/task-details-notexecuted-prebuilt.html,
 click on the ³match to tasks in previous builds² button and hover over a
task cell or an outcome cell)

** the content of each cell should be a link to the corresponding task
details page 

** I was not expecting to see more than one result from the same build,
but some seem to be coming in. That means that we need a secondary sorting
criteria, which should be recipe name

* Cached tasks are not showing the log. They should display the path to
the log file generated by the _setscene task

* In the "Not executed" section of the Cached tasks:

** The "Task inputs signature" should be above the sstate attempt
notification

** The task order number should link back to the tasks table. To see this
in action, visit 
http://www.yoctoproject.org/toaster/task-details-executed-sstate-success.ht
ml and click on the task order number

* The task script type should not show for not executed tasks

Any questions, let me know.

Cheers

Belén



On 18/02/2014 12:25, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
wrote:

>Hi David,
>
>>  
>>  I did a quick review (it looked good to me), mostly to insure that
>>  your changes and my pending changes for "Tasks/DiskIO/CPU/Time" do not
>>  collide. I am happy to report that our respective work should cleanly
>>  merged.
>>  
>
>Cool, thanks.
>
>>  I did notice that for "projecttags.py" this small warning.
>>  
>>    \ No newline at end of file
>>  
>
>I did not add a new line at the end of the file and that might be from
>the git diff.
>
>Thanks,
>Ravi

Re: Viewing Task details feature

[Ravi Chintakunta]

Hi Belen,

Thanks for the review. As I said, with the ongoing backend work and lack of all Task variants in my test database, I could not get through much testing.

Can you or Alex upload the test database for us to use?

I will rebase my code on top of the latest master and fix these bugs.

Thanks,
Ravi

>  
>  * Sometimes, when I click on a task, I get an error. It seems to be
>  related to the page trying to open a local file that no longer exists.
>  From my list, this is in the only critical issue. This is the full
>  trace:
>  
>  Environment:
>  Request Method: GET
>  
>  Request URL: http://localhost:8000/gui/build/47/task/50266
>  
>  Django Version: 1.5
>  
>  Python Version: 2.7.3
>  Installed Applications:
>  ('django.contrib.staticfiles',
>   'django.contrib.humanize',
>   'orm',
>   'toastermain',
>   'toastergui',
>   'bldviewer',
>   'south')
>  Installed Middleware:
>  ('django.middleware.common.CommonMiddleware',
>   'django.contrib.sessions.middleware.SessionMiddleware',
>   'django.middleware.csrf.CsrfViewMiddleware',
>   'django.contrib.auth.middleware.AuthenticationMiddleware',
>   'django.contrib.messages.middleware.MessageMiddleware')
>  
>  Traceback:
>  
>  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py"
>  in
>  get_response
>    115.                         response = callback(request,
>  *callback_args, **callback_kwargs)
>  File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in
>  task
>    368.         lines = read_file(task.logfile)
>  File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in
>  read_file
>    198.     with open(file, 'r') as f:
>  
>  Exception Type: IOError at /gui/build/47/task/50266
>  
>  Exception Value: [Errno 2] No such file or directory:
>  u'/home/yocto/poky/build/tmp/work/x86_64-linux/m4-native/1.4.17-
>  r0/temp/log
>  .do_fetch.15180¹
>  
>  * For executed - succeeded tasks, the heading of the outcome section
>  should have the class .green applied. We are reusing the task_color
>  project tag, but that only sets the .muted class for not executed
>  tasks,
>  so we¹ll need to amend the tag or use something else. We need to keep
>  in
>  mind that the .green class should only be set in that heading for the
>  task
>  details page, and not in the tasks table.
>  
>  * For executed - failed tasks with script type shell, the python stack
>  trace section should not show (right now, it shows empty). For Python
>  tasks, we need to put a mechanism in place to link a build¹s messages
>  to a
>  task when applicable
>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a failed
>  Python task is not linked to an entry in the orm_logmessage table, the
>  python stack trace section should not show.
>  
>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>  previous
>  builds² search doesn¹t seem right:
>  
>  ** it shows tasks from more recent builds than the one I am searching
>  from. This search should only search across tasks from builds that are
>  older than the one I am searching from. From the spec: "A "match"
>  button
>  to find executed tasks from previous builds (recorded by Toaster) with
>  the
>  same task signature as the prebuilt task.²
>  
>  ** it is also returning the same task for other recipes, and different
>  tasks for different recipes (in gcc- targets), something we were not
>  expecting to see. I believe Alex is looking into this.
>  
>  ** the page reloads to show the search results, which means that when
>  you
>  click the back button you are brought to the same page without the
>  search
>  results. This is a bit funny. Any chance we could use an ajax call to
>  load
>  the search results without reloading the page?
>  
>  * In the results table:
>  
>  ** the date format in the Completed on table is wrong. It should match
>  the
>  one used in the builds table
>  
>  ** we are missing the help on hover for the Task and Outcome columns
>  (for
>  an example, go to
>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>  prebuilt.html,
>   click on the ³match to tasks in previous builds² button and hover
>  over a
>  task cell or an outcome cell)
>  
>  ** the content of each cell should be a link to the corresponding task
>  details page
>  
>  ** I was not expecting to see more than one result from the same
>  build,
>  but some seem to be coming in. That means that we need a secondary
>  sorting
>  criteria, which should be recipe name
>  
>  * Cached tasks are not showing the log. They should display the path
>  to
>  the log file generated by the _setscene task
>  
>  * In the "Not executed" section of the Cached tasks:
>  
>  ** The "Task inputs signature" should be above the sstate attempt
>  notification
>  
>  ** The task order number should link back to the tasks table. To see
>  this
>  in action, visit
>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>  success.ht
>  ml and click on the task order number
>  
>  * The task script type should not show for not executed tasks
>  
>  Any questions, let me know.
>  
>  Cheers
>  
>  Belén
>  
>  
>  
>  On 18/02/2014 12:25, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
>  wrote:
>  
>  >Hi David,
>  >
>  >>
>  >>  I did a quick review (it looked good to me), mostly to insure that
>  >>  your changes and my pending changes for "Tasks/DiskIO/CPU/Time" do
>  not
>  >>  collide. I am happy to report that our respective work should
>  cleanly
>  >>  merged.
>  >>
>  >
>  >Cool, thanks.
>  >
>  >>  I did notice that for "projecttags.py" this small warning.
>  >>
>  >>    \ No newline at end of file
>  >>
>  >
>  >I did not add a new line at the end of the file and that might be
>  from
>  >the git diff.
>  >
>  >Thanks,
>  >Ravi
>  

Re: Viewing Task details feature

[Barros Pena, Belen]

On 19/02/2014 19:53, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
wrote:

>Hi Belen,
>
>Thanks for the review. As I said, with the ongoing backend work and lack
>of all Task variants in my test database, I could not get through much
>testing.
>
>Can you or Alex upload the test database for us to use?

Hi Ravi,

I will try to put something together for tomorrow. It will include a clean
build (with lots of executed tasks), a build that makes copious use of
sstate objects (lots of cached tasks) and a rebuild of the same target
(loads of prebuilt and covered tasks). I will also make sure to include a
failed _setscene task so that we can test a task with sstate_result =
failed.

Belén


>
>I will rebase my code on top of the latest master and fix these bugs.
>
>Thanks,
>Ravi
>
>>  
>>  * Sometimes, when I click on a task, I get an error. It seems to be
>>  related to the page trying to open a local file that no longer exists.
>>  From my list, this is in the only critical issue. This is the full
>>  trace:
>>  
>>  Environment:
>>  Request Method: GET
>>  
>>  Request URL: http://localhost:8000/gui/build/47/task/50266
>>  
>>  Django Version: 1.5
>>  
>>  Python Version: 2.7.3
>>  Installed Applications:
>>  ('django.contrib.staticfiles',
>>   'django.contrib.humanize',
>>   'orm',
>>   'toastermain',
>>   'toastergui',
>>   'bldviewer',
>>   'south')
>>  Installed Middleware:
>>  ('django.middleware.common.CommonMiddleware',
>>   'django.contrib.sessions.middleware.SessionMiddleware',
>>   'django.middleware.csrf.CsrfViewMiddleware',
>>   'django.contrib.auth.middleware.AuthenticationMiddleware',
>>   'django.contrib.messages.middleware.MessageMiddleware')
>>  
>>  Traceback:
>>  
>>  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py"
>>  in
>>  get_response
>>    115.                         response = callback(request,
>>  *callback_args, **callback_kwargs)
>>  File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in
>>  task
>>    368.         lines = read_file(task.logfile)
>>  File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in
>>  read_file
>>    198.     with open(file, 'r') as f:
>>  
>>  Exception Type: IOError at /gui/build/47/task/50266
>>  
>>  Exception Value: [Errno 2] No such file or directory:
>>  u'/home/yocto/poky/build/tmp/work/x86_64-linux/m4-native/1.4.17-
>>  r0/temp/log
>>  .do_fetch.15180¹
>>  
>>  * For executed - succeeded tasks, the heading of the outcome section
>>  should have the class .green applied. We are reusing the task_color
>>  project tag, but that only sets the .muted class for not executed
>>  tasks,
>>  so we¹ll need to amend the tag or use something else. We need to keep
>>  in
>>  mind that the .green class should only be set in that heading for the
>>  task
>>  details page, and not in the tasks table.
>>  
>>  * For executed - failed tasks with script type shell, the python stack
>>  trace section should not show (right now, it shows empty). For Python
>>  tasks, we need to put a mechanism in place to link a build¹s messages
>>  to a
>>  task when applicable
>>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a failed
>>  Python task is not linked to an entry in the orm_logmessage table, the
>>  python stack trace section should not show.
>>  
>>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>>  previous
>>  builds² search doesn¹t seem right:
>>  
>>  ** it shows tasks from more recent builds than the one I am searching
>>  from. This search should only search across tasks from builds that are
>>  older than the one I am searching from. From the spec: "A "match"
>>  button
>>  to find executed tasks from previous builds (recorded by Toaster) with
>>  the
>>  same task signature as the prebuilt task.²
>>  
>>  ** it is also returning the same task for other recipes, and different
>>  tasks for different recipes (in gcc- targets), something we were not
>>  expecting to see. I believe Alex is looking into this.
>>  
>>  ** the page reloads to show the search results, which means that when
>>  you
>>  click the back button you are brought to the same page without the
>>  search
>>  results. This is a bit funny. Any chance we could use an ajax call to
>>  load
>>  the search results without reloading the page?
>>  
>>  * In the results table:
>>  
>>  ** the date format in the Completed on table is wrong. It should match
>>  the
>>  one used in the builds table
>>  
>>  ** we are missing the help on hover for the Task and Outcome columns
>>  (for
>>  an example, go to
>>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>>  prebuilt.html,
>>   click on the ³match to tasks in previous builds² button and hover
>>  over a
>>  task cell or an outcome cell)
>>  
>>  ** the content of each cell should be a link to the corresponding task
>>  details page
>>  
>>  ** I was not expecting to see more than one result from the same
>>  build,
>>  but some seem to be coming in. That means that we need a secondary
>>  sorting
>>  criteria, which should be recipe name
>>  
>>  * Cached tasks are not showing the log. They should display the path
>>  to
>>  the log file generated by the _setscene task
>>  
>>  * In the "Not executed" section of the Cached tasks:
>>  
>>  ** The "Task inputs signature" should be above the sstate attempt
>>  notification
>>  
>>  ** The task order number should link back to the tasks table. To see
>>  this
>>  in action, visit
>>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>>  success.ht
>>  ml and click on the task order number
>>  
>>  * The task script type should not show for not executed tasks
>>  
>>  Any questions, let me know.
>>  
>>  Cheers
>>  
>>  Belén
>>  
>>  
>>  
>>  On 18/02/2014 12:25, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
>>  wrote:
>>  
>>  >Hi David,
>>  >
>>  >>
>>  >>  I did a quick review (it looked good to me), mostly to insure that
>>  >>  your changes and my pending changes for "Tasks/DiskIO/CPU/Time" do
>>  not
>>  >>  collide. I am happy to report that our respective work should
>>  cleanly
>>  >>  merged.
>>  >>
>>  >
>>  >Cool, thanks.
>>  >
>>  >>  I did notice that for "projecttags.py" this small warning.
>>  >>
>>  >>    \ No newline at end of file
>>  >>
>>  >
>>  >I did not add a new line at the end of the file and that might be
>>  from
>>  >the git diff.
>>  >
>>  >Thanks,
>>  >Ravi
>>  
>

Re: Viewing Task details feature

[Ravi Chintakunta]

Hi Belen,

Thanks for the review. I pushed the fixes to my branch. I rebased and merged my changes to the previous commit. 

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d

Comments inline.

>  * Sometimes, when I click on a task, I get an error. It seems to be
>  related to the page trying to open a local file that no longer exists.
>  From my list, this is in the only critical issue. This is the full
>  trace:
>  

Fixed.

>  
>  * For executed - succeeded tasks, the heading of the outcome section
>  should have the class .green applied. We are reusing the task_color
>  project tag, but that only sets the .muted class for not executed
>  tasks,
>  so we¹ll need to amend the tag or use something else. We need to keep
>  in
>  mind that the .green class should only be set in that heading for the
>  task
>  details page, and not in the tasks table.
>  

Fixed. Reused the task_color project tag by adding a show_green argument.

>  * For executed - failed tasks with script type shell, the python stack
>  trace section should not show (right now, it shows empty). For Python
>  tasks, we need to put a mechanism in place to link a build¹s messages
>  to a
>  task when applicable
>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a failed
>  Python task is not linked to an entry in the orm_logmessage table, the
>  python stack trace section should not show.

I believe the backend or orm_logmessage is still under development.

>  
>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>  previous
>  builds² search doesn¹t seem right:
>  
>  ** it shows tasks from more recent builds than the one I am searching
>  from. This search should only search across tasks from builds that are
>  older than the one I am searching from. From the spec: "A "match"
>  button
>  to find executed tasks from previous builds (recorded by Toaster) with
>  the
>  same task signature as the prebuilt task.²
>  

Fixed.

>  ** it is also returning the same task for other recipes, and different
>  tasks for different recipes (in gcc- targets), something we were not
>  expecting to see. I believe Alex is looking into this.
>  
>  ** the page reloads to show the search results, which means that when
>  you
>  click the back button you are brought to the same page without the
>  search
>  results. This is a bit funny. Any chance we could use an ajax call to
>  load
>  the search results without reloading the page?
>  

I will fix this later when we include an ajax library.

>  * In the results table:
>  
>  ** the date format in the Completed on table is wrong. It should match
>  the
>  one used in the builds table
>  

Fixed.

>  ** we are missing the help on hover for the Task and Outcome columns
>  (for
>  an example, go to
>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>  prebuilt.html,
>   click on the ³match to tasks in previous builds² button and hover
>  over a
>  task cell or an outcome cell)
>  

Added the help for outcome and not for task. The help for task will be added when we fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748


>  ** the content of each cell should be a link to the corresponding task
>  details page
>  

Fixed.

>  ** I was not expecting to see more than one result from the same
>  build,
>  but some seem to be coming in. That means that we need a secondary
>  sorting
>  criteria, which should be recipe name
>  

I did not understand this.

>  * Cached tasks are not showing the log. They should display the path
>  to
>  the log file generated by the _setscene task

Fixed.

>  
>  * In the "Not executed" section of the Cached tasks:
>  
>  ** The "Task inputs signature" should be above the sstate attempt
>  notification

Fixed.

>  
>  ** The task order number should link back to the tasks table. To see
>  this
>  in action, visit
>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>  success.ht
>  ml and click on the task order number

Fixed. But the navigation works only if the task is on the first page. With the pagination, we do not know on which page the linked task appears. We have to add logic to find the page number based on the task.

>  
>  * The task script type should not show for not executed tasks

Fixed.

>  
>  Any questions, let me know.
>  

Thanks, 
Ravi

Re: Viewing Task details feature

[Barros Pena, Belen]

Hi Ravi,

Thanks for this. Most of the stuff is fixed. The only problem I think we
still need to fix before merging is related to the "Match to tasks in
previous builds" search in the Prebuilt tasks. Results are returning
_setscene tasks. This should not happen: _setscene tasks do not exist as
separate tasks in Toaster (that is why they don't have an execution order
number). They are always show merged with another task:

* With a Not executed - Cached task when the _setscene task completes
successfully (i.e. when its outcome is 0)
* With an Executed (Succeeded or Failed) task when the _setscene task
fails (i.e when its outcome is 4)

So, if using the database I sent, you select the build completed on
21/02/14 at 11:00, go to the tasks and there select task order number
1161, and you click the Match to tasks in previous builds button, the
second result is libffi do_populate_sysroot_setscene from a previous
build. That link is going to /gui/build/2/task/4122, when in reality it
should be going to /gui/build/2/task/2348, which is the corresponding
Cached task libffi do_populate_sysroot.

I hope this makes sense. Let me know if you have any questions.

Cheers

Belén

On 24/02/2014 20:02, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
wrote:

>Hi Belen,
>
>Thanks for the review. I pushed the fixes to my branch. I rebased and
>merged my changes to the previous commit.
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task
>-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d
>
>Comments inline.
>
>>  * Sometimes, when I click on a task, I get an error. It seems to be
>>  related to the page trying to open a local file that no longer exists.
>>  From my list, this is in the only critical issue. This is the full
>>  trace:
>>  
>
>Fixed.
>
>>  
>>  * For executed - succeeded tasks, the heading of the outcome section
>>  should have the class .green applied. We are reusing the task_color
>>  project tag, but that only sets the .muted class for not executed
>>  tasks,
>>  so we¹ll need to amend the tag or use something else. We need to keep
>>  in
>>  mind that the .green class should only be set in that heading for the
>>  task
>>  details page, and not in the tasks table.
>>  
>
>Fixed. Reused the task_color project tag by adding a show_green argument.
>
>>  * For executed - failed tasks with script type shell, the python stack
>>  trace section should not show (right now, it shows empty). For Python
>>  tasks, we need to put a mechanism in place to link a build¹s messages
>>  to a
>>  task when applicable
>>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a failed
>>  Python task is not linked to an entry in the orm_logmessage table, the
>>  python stack trace section should not show.
>
>I believe the backend or orm_logmessage is still under development.
>
>>  
>>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>>  previous
>>  builds² search doesn¹t seem right:
>>  
>>  ** it shows tasks from more recent builds than the one I am searching
>>  from. This search should only search across tasks from builds that are
>>  older than the one I am searching from. From the spec: "A "match"
>>  button
>>  to find executed tasks from previous builds (recorded by Toaster) with
>>  the
>>  same task signature as the prebuilt task.²
>>  
>
>Fixed.
>
>>  ** it is also returning the same task for other recipes, and different
>>  tasks for different recipes (in gcc- targets), something we were not
>>  expecting to see. I believe Alex is looking into this.
>>  
>>  ** the page reloads to show the search results, which means that when
>>  you
>>  click the back button you are brought to the same page without the
>>  search
>>  results. This is a bit funny. Any chance we could use an ajax call to
>>  load
>>  the search results without reloading the page?
>>  
>
>I will fix this later when we include an ajax library.
>
>>  * In the results table:
>>  
>>  ** the date format in the Completed on table is wrong. It should match
>>  the
>>  one used in the builds table
>>  
>
>Fixed.
>
>>  ** we are missing the help on hover for the Task and Outcome columns
>>  (for
>>  an example, go to
>>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>>  prebuilt.html,
>>   click on the ³match to tasks in previous builds² button and hover
>>  over a
>>  task cell or an outcome cell)
>>  
>
>Added the help for outcome and not for task. The help for task will be
>added when we fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748
>
>
>>  ** the content of each cell should be a link to the corresponding task
>>  details page
>>  
>
>Fixed.
>
>>  ** I was not expecting to see more than one result from the same
>>  build,
>>  but some seem to be coming in. That means that we need a secondary
>>  sorting
>>  criteria, which should be recipe name
>>  
>
>I did not understand this.
>
>>  * Cached tasks are not showing the log. They should display the path
>>  to
>>  the log file generated by the _setscene task
>
>Fixed.
>
>>  
>>  * In the "Not executed" section of the Cached tasks:
>>  
>>  ** The "Task inputs signature" should be above the sstate attempt
>>  notification
>
>Fixed.
>
>>  
>>  ** The task order number should link back to the tasks table. To see
>>  this
>>  in action, visit
>>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>>  success.ht
>>  ml and click on the task order number
>
>Fixed. But the navigation works only if the task is on the first page.
>With the pagination, we do not know on which page the linked task
>appears. We have to add logic to find the page number based on the task.
>
>>  
>>  * The task script type should not show for not executed tasks
>
>Fixed.
>
>>  
>>  Any questions, let me know.
>>  
>
>Thanks, 
>Ravi

Re: Viewing Task details feature

[Barros Pena, Belen]

Sorry, Ravi. Just one more thing. For Python failed tasks, it looks like
you are getting the content of the Python stack trace from the log file.
Unfortunately, we cannot do this. Toaster needs to work on remote build
infrastructure, so we cannot rely on local file access.

The content of the python stack trace is stored in the orm_logmessage
table. That is where it should be retrieved from, although in order to do
that we need to link the entries in orm_logmessage to the task that
generated them (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847)

Cheers

Belén

On 25/02/2014 12:12, "Barros Pena, Belen" <belen.barros.pena@intel.com>
wrote:

>Hi Ravi,
>
>Thanks for this. Most of the stuff is fixed. The only problem I think we
>still need to fix before merging is related to the "Match to tasks in
>previous builds" search in the Prebuilt tasks. Results are returning
>_setscene tasks. This should not happen: _setscene tasks do not exist as
>separate tasks in Toaster (that is why they don't have an execution order
>number). They are always show merged with another task:
>
>* With a Not executed - Cached task when the _setscene task completes
>successfully (i.e. when its outcome is 0)
>* With an Executed (Succeeded or Failed) task when the _setscene task
>fails (i.e when its outcome is 4)
>
>So, if using the database I sent, you select the build completed on
>21/02/14 at 11:00, go to the tasks and there select task order number
>1161, and you click the Match to tasks in previous builds button, the
>second result is libffi do_populate_sysroot_setscene from a previous
>build. That link is going to /gui/build/2/task/4122, when in reality it
>should be going to /gui/build/2/task/2348, which is the corresponding
>Cached task libffi do_populate_sysroot.
>
>I hope this makes sense. Let me know if you have any questions.
>
>Cheers
>
>Belén
>
>On 24/02/2014 20:02, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
>wrote:
>
>>Hi Belen,
>>
>>Thanks for the review. I pushed the fixes to my branch. I rebased and
>>merged my changes to the previous commit.
>>
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/tas
>>k
>>-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d
>>
>>Comments inline.
>>
>>>  * Sometimes, when I click on a task, I get an error. It seems to be
>>>  related to the page trying to open a local file that no longer exists.
>>>  From my list, this is in the only critical issue. This is the full
>>>  trace:
>>>  
>>
>>Fixed.
>>
>>>  
>>>  * For executed - succeeded tasks, the heading of the outcome section
>>>  should have the class .green applied. We are reusing the task_color
>>>  project tag, but that only sets the .muted class for not executed
>>>  tasks,
>>>  so we¹ll need to amend the tag or use something else. We need to keep
>>>  in
>>>  mind that the .green class should only be set in that heading for the
>>>  task
>>>  details page, and not in the tasks table.
>>>  
>>
>>Fixed. Reused the task_color project tag by adding a show_green argument.
>>
>>>  * For executed - failed tasks with script type shell, the python stack
>>>  trace section should not show (right now, it shows empty). For Python
>>>  tasks, we need to put a mechanism in place to link a build¹s messages
>>>  to a
>>>  task when applicable
>>>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a failed
>>>  Python task is not linked to an entry in the orm_logmessage table, the
>>>  python stack trace section should not show.
>>
>>I believe the backend or orm_logmessage is still under development.
>>
>>>  
>>>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>>>  previous
>>>  builds² search doesn¹t seem right:
>>>  
>>>  ** it shows tasks from more recent builds than the one I am searching
>>>  from. This search should only search across tasks from builds that are
>>>  older than the one I am searching from. From the spec: "A "match"
>>>  button
>>>  to find executed tasks from previous builds (recorded by Toaster) with
>>>  the
>>>  same task signature as the prebuilt task.²
>>>  
>>
>>Fixed.
>>
>>>  ** it is also returning the same task for other recipes, and different
>>>  tasks for different recipes (in gcc- targets), something we were not
>>>  expecting to see. I believe Alex is looking into this.
>>>  
>>>  ** the page reloads to show the search results, which means that when
>>>  you
>>>  click the back button you are brought to the same page without the
>>>  search
>>>  results. This is a bit funny. Any chance we could use an ajax call to
>>>  load
>>>  the search results without reloading the page?
>>>  
>>
>>I will fix this later when we include an ajax library.
>>
>>>  * In the results table:
>>>  
>>>  ** the date format in the Completed on table is wrong. It should match
>>>  the
>>>  one used in the builds table
>>>  
>>
>>Fixed.
>>
>>>  ** we are missing the help on hover for the Task and Outcome columns
>>>  (for
>>>  an example, go to
>>>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>>>  prebuilt.html,
>>>   click on the ³match to tasks in previous builds² button and hover
>>>  over a
>>>  task cell or an outcome cell)
>>>  
>>
>>Added the help for outcome and not for task. The help for task will be
>>added when we fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748
>>
>>
>>>  ** the content of each cell should be a link to the corresponding task
>>>  details page
>>>  
>>
>>Fixed.
>>
>>>  ** I was not expecting to see more than one result from the same
>>>  build,
>>>  but some seem to be coming in. That means that we need a secondary
>>>  sorting
>>>  criteria, which should be recipe name
>>>  
>>
>>I did not understand this.
>>
>>>  * Cached tasks are not showing the log. They should display the path
>>>  to
>>>  the log file generated by the _setscene task
>>
>>Fixed.
>>
>>>  
>>>  * In the "Not executed" section of the Cached tasks:
>>>  
>>>  ** The "Task inputs signature" should be above the sstate attempt
>>>  notification
>>
>>Fixed.
>>
>>>  
>>>  ** The task order number should link back to the tasks table. To see
>>>  this
>>>  in action, visit
>>>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>>>  success.ht
>>>  ml and click on the task order number
>>
>>Fixed. But the navigation works only if the task is on the first page.
>>With the pagination, we do not know on which page the linked task
>>appears. We have to add logic to find the page number based on the task.
>>
>>>  
>>>  * The task script type should not show for not executed tasks
>>
>>Fixed.
>>
>>>  
>>>  Any questions, let me know.
>>>  
>>
>>Thanks, 
>>Ravi
>

Re: Viewing Task details feature

[Ravi Chintakunta]

Hi Belen,

For the matching tasks, I am displaying all the tasks that have the same sstate_checksum and are from a previous build.

I did not understand the merging of setscene tasks with other tasks. 

In the example you gave, I am not sure how to link task 4122 and task 2348. Can you guide me?

Thanks,
Ravi



>  -----Original Message-----
>  From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>  Sent: Tuesday, February 25, 2014 7:12 AM
>  To: Ravi Chintakunta; Damian, Alexandru
>  Cc: 'toaster@yoctoproject.org'
>  Subject: Re: Viewing Task details feature
>  
>  Hi Ravi,
>  
>  Thanks for this. Most of the stuff is fixed. The only problem I think
>  we
>  still need to fix before merging is related to the "Match to tasks in
>  previous builds" search in the Prebuilt tasks. Results are returning
>  _setscene tasks. This should not happen: _setscene tasks do not exist
>  as
>  separate tasks in Toaster (that is why they don't have an execution
>  order
>  number). They are always show merged with another task:
>  
>  * With a Not executed - Cached task when the _setscene task completes
>  successfully (i.e. when its outcome is 0)
>  * With an Executed (Succeeded or Failed) task when the _setscene task
>  fails (i.e when its outcome is 4)
>  
>  So, if using the database I sent, you select the build completed on
>  21/02/14 at 11:00, go to the tasks and there select task order number
>  1161, and you click the Match to tasks in previous builds button, the
>  second result is libffi do_populate_sysroot_setscene from a previous
>  build. That link is going to /gui/build/2/task/4122, when in reality
>  it
>  should be going to /gui/build/2/task/2348, which is the corresponding
>  Cached task libffi do_populate_sysroot.
>  
>  I hope this makes sense. Let me know if you have any questions.
>  
>  Cheers
>  
>  Belén
>  
>  On 24/02/2014 20:02, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
>  wrote:
>  
>  >Hi Belen,
>  >
>  >Thanks for the review. I pushed the fixes to my branch. I rebased and
>  >merged my changes to the previous commit.
>  >
>  >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>  contrib/commit/?h=ravi/task
>  >-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d
>  >
>  >Comments inline.
>  >
>  >>  * Sometimes, when I click on a task, I get an error. It seems to
>  be
>  >>  related to the page trying to open a local file that no longer
>  exists.
>  >>  From my list, this is in the only critical issue. This is the full
>  >>  trace:
>  >>
>  >
>  >Fixed.
>  >
>  >>
>  >>  * For executed - succeeded tasks, the heading of the outcome
>  section
>  >>  should have the class .green applied. We are reusing the
>  task_color
>  >>  project tag, but that only sets the .muted class for not executed
>  >>  tasks,
>  >>  so we¹ll need to amend the tag or use something else. We need to
>  keep
>  >>  in
>  >>  mind that the .green class should only be set in that heading for
>  the
>  >>  task
>  >>  details page, and not in the tasks table.
>  >>
>  >
>  >Fixed. Reused the task_color project tag by adding a show_green
>  argument.
>  >
>  >>  * For executed - failed tasks with script type shell, the python
>  stack
>  >>  trace section should not show (right now, it shows empty). For
>  Python
>  >>  tasks, we need to put a mechanism in place to link a build¹s
>  messages
>  >>  to a
>  >>  task when applicable
>  >>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a
>  failed
>  >>  Python task is not linked to an entry in the orm_logmessage table,
>  the
>  >>  python stack trace section should not show.
>  >
>  >I believe the backend or orm_logmessage is still under development.
>  >
>  >>
>  >>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>  >>  previous
>  >>  builds² search doesn¹t seem right:
>  >>
>  >>  ** it shows tasks from more recent builds than the one I am
>  searching
>  >>  from. This search should only search across tasks from builds that
>  are
>  >>  older than the one I am searching from. From the spec: "A "match"
>  >>  button
>  >>  to find executed tasks from previous builds (recorded by Toaster)
>  with
>  >>  the
>  >>  same task signature as the prebuilt task.²
>  >>
>  >
>  >Fixed.
>  >
>  >>  ** it is also returning the same task for other recipes, and
>  different
>  >>  tasks for different recipes (in gcc- targets), something we were
>  not
>  >>  expecting to see. I believe Alex is looking into this.
>  >>
>  >>  ** the page reloads to show the search results, which means that
>  when
>  >>  you
>  >>  click the back button you are brought to the same page without the
>  >>  search
>  >>  results. This is a bit funny. Any chance we could use an ajax call
>  to
>  >>  load
>  >>  the search results without reloading the page?
>  >>
>  >
>  >I will fix this later when we include an ajax library.
>  >
>  >>  * In the results table:
>  >>
>  >>  ** the date format in the Completed on table is wrong. It should
>  match
>  >>  the
>  >>  one used in the builds table
>  >>
>  >
>  >Fixed.
>  >
>  >>  ** we are missing the help on hover for the Task and Outcome
>  columns
>  >>  (for
>  >>  an example, go to
>  >>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>  >>  prebuilt.html,
>  >>   click on the ³match to tasks in previous builds² button and hover
>  >>  over a
>  >>  task cell or an outcome cell)
>  >>
>  >
>  >Added the help for outcome and not for task. The help for task will
>  be
>  >added when we fix
>  https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748
>  >
>  >
>  >>  ** the content of each cell should be a link to the corresponding
>  task
>  >>  details page
>  >>
>  >
>  >Fixed.
>  >
>  >>  ** I was not expecting to see more than one result from the same
>  >>  build,
>  >>  but some seem to be coming in. That means that we need a secondary
>  >>  sorting
>  >>  criteria, which should be recipe name
>  >>
>  >
>  >I did not understand this.
>  >
>  >>  * Cached tasks are not showing the log. They should display the
>  path
>  >>  to
>  >>  the log file generated by the _setscene task
>  >
>  >Fixed.
>  >
>  >>
>  >>  * In the "Not executed" section of the Cached tasks:
>  >>
>  >>  ** The "Task inputs signature" should be above the sstate attempt
>  >>  notification
>  >
>  >Fixed.
>  >
>  >>
>  >>  ** The task order number should link back to the tasks table. To
>  see
>  >>  this
>  >>  in action, visit
>  >>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>  >>  success.ht
>  >>  ml and click on the task order number
>  >
>  >Fixed. But the navigation works only if the task is on the first
>  page.
>  >With the pagination, we do not know on which page the linked task
>  >appears. We have to add logic to find the page number based on the
>  task.
>  >
>  >>
>  >>  * The task script type should not show for not executed tasks
>  >
>  >Fixed.
>  >
>  >>
>  >>  Any questions, let me know.
>  >>
>  >
>  >Thanks,
>  >Ravi
>  

Re: Viewing Task details feature

[Ravi Chintakunta]

Hi Belen,

I think the backend for this is not yet implemented. I do not see any entries in the logmessage table. Can I fix this when the backend is ready?

Thanks,
Ravi

>  -----Original Message-----
>  From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>  Sent: Tuesday, February 25, 2014 9:32 AM
>  To: Ravi Chintakunta; Damian, Alexandru
>  Cc: 'toaster@yoctoproject.org'
>  Subject: Re: Viewing Task details feature
>  
>  Sorry, Ravi. Just one more thing. For Python failed tasks, it looks
>  like
>  you are getting the content of the Python stack trace from the log
>  file.
>  Unfortunately, we cannot do this. Toaster needs to work on remote
>  build
>  infrastructure, so we cannot rely on local file access.
>  
>  The content of the python stack trace is stored in the orm_logmessage
>  table. That is where it should be retrieved from, although in order to
>  do
>  that we need to link the entries in orm_logmessage to the task that
>  generated them
>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847)
>  
>  Cheers
>  
>  Belén
>  
>  On 25/02/2014 12:12, "Barros Pena, Belen"
>  <belen.barros.pena@intel.com>
>  wrote:
>  
>  >Hi Ravi,
>  >
>  >Thanks for this. Most of the stuff is fixed. The only problem I think
>  we
>  >still need to fix before merging is related to the "Match to tasks in
>  >previous builds" search in the Prebuilt tasks. Results are returning
>  >_setscene tasks. This should not happen: _setscene tasks do not exist
>  as
>  >separate tasks in Toaster (that is why they don't have an execution
>  order
>  >number). They are always show merged with another task:
>  >
>  >* With a Not executed - Cached task when the _setscene task completes
>  >successfully (i.e. when its outcome is 0)
>  >* With an Executed (Succeeded or Failed) task when the _setscene task
>  >fails (i.e when its outcome is 4)
>  >
>  >So, if using the database I sent, you select the build completed on
>  >21/02/14 at 11:00, go to the tasks and there select task order number
>  >1161, and you click the Match to tasks in previous builds button, the
>  >second result is libffi do_populate_sysroot_setscene from a previous
>  >build. That link is going to /gui/build/2/task/4122, when in reality
>  it
>  >should be going to /gui/build/2/task/2348, which is the corresponding
>  >Cached task libffi do_populate_sysroot.
>  >
>  >I hope this makes sense. Let me know if you have any questions.
>  >
>  >Cheers
>  >
>  >Belén
>  >
>  >On 24/02/2014 20:02, "Ravi Chintakunta"
>  <ravi.chintakunta@timesys.com>
>  >wrote:
>  >
>  >>Hi Belen,
>  >>
>  >>Thanks for the review. I pushed the fixes to my branch. I rebased
>  and
>  >>merged my changes to the previous commit.
>  >>
>  >>http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>  contrib/commit/?h=ravi/tas
>  >>k
>  >>-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d
>  >>
>  >>Comments inline.
>  >>
>  >>>  * Sometimes, when I click on a task, I get an error. It seems to
>  be
>  >>>  related to the page trying to open a local file that no longer
>  exists.
>  >>>  From my list, this is in the only critical issue. This is the
>  full
>  >>>  trace:
>  >>>
>  >>
>  >>Fixed.
>  >>
>  >>>
>  >>>  * For executed - succeeded tasks, the heading of the outcome
>  section
>  >>>  should have the class .green applied. We are reusing the
>  task_color
>  >>>  project tag, but that only sets the .muted class for not executed
>  >>>  tasks,
>  >>>  so we¹ll need to amend the tag or use something else. We need to
>  keep
>  >>>  in
>  >>>  mind that the .green class should only be set in that heading for
>  the
>  >>>  task
>  >>>  details page, and not in the tasks table.
>  >>>
>  >>
>  >>Fixed. Reused the task_color project tag by adding a show_green
>  argument.
>  >>
>  >>>  * For executed - failed tasks with script type shell, the python
>  stack
>  >>>  trace section should not show (right now, it shows empty). For
>  Python
>  >>>  tasks, we need to put a mechanism in place to link a build¹s
>  messages
>  >>>  to a
>  >>>  task when applicable
>  >>>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a
>  failed
>  >>>  Python task is not linked to an entry in the orm_logmessage
>  table, the
>  >>>  python stack trace section should not show.
>  >>
>  >>I believe the backend or orm_logmessage is still under development.
>  >>
>  >>>
>  >>>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>  >>>  previous
>  >>>  builds² search doesn¹t seem right:
>  >>>
>  >>>  ** it shows tasks from more recent builds than the one I am
>  searching
>  >>>  from. This search should only search across tasks from builds
>  that are
>  >>>  older than the one I am searching from. From the spec: "A "match"
>  >>>  button
>  >>>  to find executed tasks from previous builds (recorded by Toaster)
>  with
>  >>>  the
>  >>>  same task signature as the prebuilt task.²
>  >>>
>  >>
>  >>Fixed.
>  >>
>  >>>  ** it is also returning the same task for other recipes, and
>  different
>  >>>  tasks for different recipes (in gcc- targets), something we were
>  not
>  >>>  expecting to see. I believe Alex is looking into this.
>  >>>
>  >>>  ** the page reloads to show the search results, which means that
>  when
>  >>>  you
>  >>>  click the back button you are brought to the same page without
>  the
>  >>>  search
>  >>>  results. This is a bit funny. Any chance we could use an ajax
>  call to
>  >>>  load
>  >>>  the search results without reloading the page?
>  >>>
>  >>
>  >>I will fix this later when we include an ajax library.
>  >>
>  >>>  * In the results table:
>  >>>
>  >>>  ** the date format in the Completed on table is wrong. It should
>  match
>  >>>  the
>  >>>  one used in the builds table
>  >>>
>  >>
>  >>Fixed.
>  >>
>  >>>  ** we are missing the help on hover for the Task and Outcome
>  columns
>  >>>  (for
>  >>>  an example, go to
>  >>>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>  >>>  prebuilt.html,
>  >>>   click on the ³match to tasks in previous builds² button and
>  hover
>  >>>  over a
>  >>>  task cell or an outcome cell)
>  >>>
>  >>
>  >>Added the help for outcome and not for task. The help for task will
>  be
>  >>added when we fix
>  https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748
>  >>
>  >>
>  >>>  ** the content of each cell should be a link to the corresponding
>  task
>  >>>  details page
>  >>>
>  >>
>  >>Fixed.
>  >>
>  >>>  ** I was not expecting to see more than one result from the same
>  >>>  build,
>  >>>  but some seem to be coming in. That means that we need a
>  secondary
>  >>>  sorting
>  >>>  criteria, which should be recipe name
>  >>>
>  >>
>  >>I did not understand this.
>  >>
>  >>>  * Cached tasks are not showing the log. They should display the
>  path
>  >>>  to
>  >>>  the log file generated by the _setscene task
>  >>
>  >>Fixed.
>  >>
>  >>>
>  >>>  * In the "Not executed" section of the Cached tasks:
>  >>>
>  >>>  ** The "Task inputs signature" should be above the sstate attempt
>  >>>  notification
>  >>
>  >>Fixed.
>  >>
>  >>>
>  >>>  ** The task order number should link back to the tasks table. To
>  see
>  >>>  this
>  >>>  in action, visit
>  >>>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>  >>>  success.ht
>  >>>  ml and click on the task order number
>  >>
>  >>Fixed. But the navigation works only if the task is on the first
>  page.
>  >>With the pagination, we do not know on which page the linked task
>  >>appears. We have to add logic to find the page number based on the
>  task.
>  >>
>  >>>
>  >>>  * The task script type should not show for not executed tasks
>  >>
>  >>Fixed.
>  >>
>  >>>
>  >>>  Any questions, let me know.
>  >>>
>  >>
>  >>Thanks,
>  >>Ravi
>  >
>  

Re: Viewing Task details feature

[Barros Pena, Belen]

On 25/02/2014 15:17, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
wrote:

>Hi Belen,
>
>I think the backend for this is not yet implemented. I do not see any
>entries in the logmessage table.

The table is definitely being populated, but only when a build throws
errors or warnings. Probably none were included in the database I sent (my
bad: sorry about that). But we still don't have the linking between the
entries and the tasks.

> Can I fix this when the backend is ready?

Of course.

Thanks!

Belén

>
>Thanks,
>Ravi
>
>>  -----Original Message-----
>>  From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>>  Sent: Tuesday, February 25, 2014 9:32 AM
>>  To: Ravi Chintakunta; Damian, Alexandru
>>  Cc: 'toaster@yoctoproject.org'
>>  Subject: Re: Viewing Task details feature
>>  
>>  Sorry, Ravi. Just one more thing. For Python failed tasks, it looks
>>  like
>>  you are getting the content of the Python stack trace from the log
>>  file.
>>  Unfortunately, we cannot do this. Toaster needs to work on remote
>>  build
>>  infrastructure, so we cannot rely on local file access.
>>  
>>  The content of the python stack trace is stored in the orm_logmessage
>>  table. That is where it should be retrieved from, although in order to
>>  do
>>  that we need to link the entries in orm_logmessage to the task that
>>  generated them
>>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847)
>>  
>>  Cheers
>>  
>>  Belén
>>  
>>  On 25/02/2014 12:12, "Barros Pena, Belen"
>>  <belen.barros.pena@intel.com>
>>  wrote:
>>  
>>  >Hi Ravi,
>>  >
>>  >Thanks for this. Most of the stuff is fixed. The only problem I think
>>  we
>>  >still need to fix before merging is related to the "Match to tasks in
>>  >previous builds" search in the Prebuilt tasks. Results are returning
>>  >_setscene tasks. This should not happen: _setscene tasks do not exist
>>  as
>>  >separate tasks in Toaster (that is why they don't have an execution
>>  order
>>  >number). They are always show merged with another task:
>>  >
>>  >* With a Not executed - Cached task when the _setscene task completes
>>  >successfully (i.e. when its outcome is 0)
>>  >* With an Executed (Succeeded or Failed) task when the _setscene task
>>  >fails (i.e when its outcome is 4)
>>  >
>>  >So, if using the database I sent, you select the build completed on
>>  >21/02/14 at 11:00, go to the tasks and there select task order number
>>  >1161, and you click the Match to tasks in previous builds button, the
>>  >second result is libffi do_populate_sysroot_setscene from a previous
>>  >build. That link is going to /gui/build/2/task/4122, when in reality
>>  it
>>  >should be going to /gui/build/2/task/2348, which is the corresponding
>>  >Cached task libffi do_populate_sysroot.
>>  >
>>  >I hope this makes sense. Let me know if you have any questions.
>>  >
>>  >Cheers
>>  >
>>  >Belén
>>  >
>>  >On 24/02/2014 20:02, "Ravi Chintakunta"
>>  <ravi.chintakunta@timesys.com>
>>  >wrote:
>>  >
>>  >>Hi Belen,
>>  >>
>>  >>Thanks for the review. I pushed the fixes to my branch. I rebased
>>  and
>>  >>merged my changes to the previous commit.
>>  >>
>>  >>http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>>  contrib/commit/?h=ravi/tas
>>  >>k
>>  >>-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d
>>  >>
>>  >>Comments inline.
>>  >>
>>  >>>  * Sometimes, when I click on a task, I get an error. It seems to
>>  be
>>  >>>  related to the page trying to open a local file that no longer
>>  exists.
>>  >>>  From my list, this is in the only critical issue. This is the
>>  full
>>  >>>  trace:
>>  >>>
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>
>>  >>>  * For executed - succeeded tasks, the heading of the outcome
>>  section
>>  >>>  should have the class .green applied. We are reusing the
>>  task_color
>>  >>>  project tag, but that only sets the .muted class for not executed
>>  >>>  tasks,
>>  >>>  so we¹ll need to amend the tag or use something else. We need to
>>  keep
>>  >>>  in
>>  >>>  mind that the .green class should only be set in that heading for
>>  the
>>  >>>  task
>>  >>>  details page, and not in the tasks table.
>>  >>>
>>  >>
>>  >>Fixed. Reused the task_color project tag by adding a show_green
>>  argument.
>>  >>
>>  >>>  * For executed - failed tasks with script type shell, the python
>>  stack
>>  >>>  trace section should not show (right now, it shows empty). For
>>  Python
>>  >>>  tasks, we need to put a mechanism in place to link a build¹s
>>  messages
>>  >>>  to a
>>  >>>  task when applicable
>>  >>>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a
>>  failed
>>  >>>  Python task is not linked to an entry in the orm_logmessage
>>  table, the
>>  >>>  python stack trace section should not show.
>>  >>
>>  >>I believe the backend or orm_logmessage is still under development.
>>  >>
>>  >>>
>>  >>>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>>  >>>  previous
>>  >>>  builds² search doesn¹t seem right:
>>  >>>
>>  >>>  ** it shows tasks from more recent builds than the one I am
>>  searching
>>  >>>  from. This search should only search across tasks from builds
>>  that are
>>  >>>  older than the one I am searching from. From the spec: "A "match"
>>  >>>  button
>>  >>>  to find executed tasks from previous builds (recorded by Toaster)
>>  with
>>  >>>  the
>>  >>>  same task signature as the prebuilt task.²
>>  >>>
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>  ** it is also returning the same task for other recipes, and
>>  different
>>  >>>  tasks for different recipes (in gcc- targets), something we were
>>  not
>>  >>>  expecting to see. I believe Alex is looking into this.
>>  >>>
>>  >>>  ** the page reloads to show the search results, which means that
>>  when
>>  >>>  you
>>  >>>  click the back button you are brought to the same page without
>>  the
>>  >>>  search
>>  >>>  results. This is a bit funny. Any chance we could use an ajax
>>  call to
>>  >>>  load
>>  >>>  the search results without reloading the page?
>>  >>>
>>  >>
>>  >>I will fix this later when we include an ajax library.
>>  >>
>>  >>>  * In the results table:
>>  >>>
>>  >>>  ** the date format in the Completed on table is wrong. It should
>>  match
>>  >>>  the
>>  >>>  one used in the builds table
>>  >>>
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>  ** we are missing the help on hover for the Task and Outcome
>>  columns
>>  >>>  (for
>>  >>>  an example, go to
>>  >>>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>>  >>>  prebuilt.html,
>>  >>>   click on the ³match to tasks in previous builds² button and
>>  hover
>>  >>>  over a
>>  >>>  task cell or an outcome cell)
>>  >>>
>>  >>
>>  >>Added the help for outcome and not for task. The help for task will
>>  be
>>  >>added when we fix
>>  https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748
>>  >>
>>  >>
>>  >>>  ** the content of each cell should be a link to the corresponding
>>  task
>>  >>>  details page
>>  >>>
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>  ** I was not expecting to see more than one result from the same
>>  >>>  build,
>>  >>>  but some seem to be coming in. That means that we need a
>>  secondary
>>  >>>  sorting
>>  >>>  criteria, which should be recipe name
>>  >>>
>>  >>
>>  >>I did not understand this.
>>  >>
>>  >>>  * Cached tasks are not showing the log. They should display the
>>  path
>>  >>>  to
>>  >>>  the log file generated by the _setscene task
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>
>>  >>>  * In the "Not executed" section of the Cached tasks:
>>  >>>
>>  >>>  ** The "Task inputs signature" should be above the sstate attempt
>>  >>>  notification
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>
>>  >>>  ** The task order number should link back to the tasks table. To
>>  see
>>  >>>  this
>>  >>>  in action, visit
>>  >>>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>>  >>>  success.ht
>>  >>>  ml and click on the task order number
>>  >>
>>  >>Fixed. But the navigation works only if the task is on the first
>>  page.
>>  >>With the pagination, we do not know on which page the linked task
>>  >>appears. We have to add logic to find the page number based on the
>>  task.
>>  >>
>>  >>>
>>  >>>  * The task script type should not show for not executed tasks
>>  >>
>>  >>Fixed.
>>  >>
>>  >>>
>>  >>>  Any questions, let me know.
>>  >>>
>>  >>
>>  >>Thanks,
>>  >>Ravi
>>  >
>>  
>

Re: Viewing Task details feature

[Barros Pena, Belen]

On 25/02/2014 15:14, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
wrote:

>Hi Belen,
>
>For the matching tasks, I am displaying all the tasks that have the same
>sstate_checksum and are from a previous build.
>
>I did not understand the merging of setscene tasks with other tasks.
>
>In the example you gave, I am not sure how to link task 4122 and task
>2348. Can you guide me?

You need Alex to answer this (he is away until next Tuesday). But in
/gui/build/2/task/2348 you are showing the log of
do_populate_sysroot_setscene, but the order number of do_populate_sysroot,
so you are already somehow connecting both tasks :)

Cheers

Belén

>
>Thanks,
>Ravi
>
>
>
>>  -----Original Message-----
>>  From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>>  Sent: Tuesday, February 25, 2014 7:12 AM
>>  To: Ravi Chintakunta; Damian, Alexandru
>>  Cc: 'toaster@yoctoproject.org'
>>  Subject: Re: Viewing Task details feature
>>  
>>  Hi Ravi,
>>  
>>  Thanks for this. Most of the stuff is fixed. The only problem I think
>>  we
>>  still need to fix before merging is related to the "Match to tasks in
>>  previous builds" search in the Prebuilt tasks. Results are returning
>>  _setscene tasks. This should not happen: _setscene tasks do not exist
>>  as
>>  separate tasks in Toaster (that is why they don't have an execution
>>  order
>>  number). They are always show merged with another task:
>>  
>>  * With a Not executed - Cached task when the _setscene task completes
>>  successfully (i.e. when its outcome is 0)
>>  * With an Executed (Succeeded or Failed) task when the _setscene task
>>  fails (i.e when its outcome is 4)
>>  
>>  So, if using the database I sent, you select the build completed on
>>  21/02/14 at 11:00, go to the tasks and there select task order number
>>  1161, and you click the Match to tasks in previous builds button, the
>>  second result is libffi do_populate_sysroot_setscene from a previous
>>  build. That link is going to /gui/build/2/task/4122, when in reality
>>  it
>>  should be going to /gui/build/2/task/2348, which is the corresponding
>>  Cached task libffi do_populate_sysroot.
>>  
>>  I hope this makes sense. Let me know if you have any questions.
>>  
>>  Cheers
>>  
>>  Belén
>>  
>>  On 24/02/2014 20:02, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
>>  wrote:
>>  
>>  >Hi Belen,
>>  >
>>  >Thanks for the review. I pushed the fixes to my branch. I rebased and
>>  >merged my changes to the previous commit.
>>  >
>>  >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>>  contrib/commit/?h=ravi/task
>>  >-details-feature&id=dafb97eba06d889867444afe8df975559e3e042d
>>  >
>>  >Comments inline.
>>  >
>>  >>  * Sometimes, when I click on a task, I get an error. It seems to
>>  be
>>  >>  related to the page trying to open a local file that no longer
>>  exists.
>>  >>  From my list, this is in the only critical issue. This is the full
>>  >>  trace:
>>  >>
>>  >
>>  >Fixed.
>>  >
>>  >>
>>  >>  * For executed - succeeded tasks, the heading of the outcome
>>  section
>>  >>  should have the class .green applied. We are reusing the
>>  task_color
>>  >>  project tag, but that only sets the .muted class for not executed
>>  >>  tasks,
>>  >>  so we¹ll need to amend the tag or use something else. We need to
>>  keep
>>  >>  in
>>  >>  mind that the .green class should only be set in that heading for
>>  the
>>  >>  task
>>  >>  details page, and not in the tasks table.
>>  >>
>>  >
>>  >Fixed. Reused the task_color project tag by adding a show_green
>>  argument.
>>  >
>>  >>  * For executed - failed tasks with script type shell, the python
>>  stack
>>  >>  trace section should not show (right now, it shows empty). For
>>  Python
>>  >>  tasks, we need to put a mechanism in place to link a build¹s
>>  messages
>>  >>  to a
>>  >>  task when applicable
>>  >>  (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5847). If a
>>  failed
>>  >>  Python task is not linked to an entry in the orm_logmessage table,
>>  the
>>  >>  python stack trace section should not show.
>>  >
>>  >I believe the backend or orm_logmessage is still under development.
>>  >
>>  >>
>>  >>  * In the Prebuilt tasks, the outcome of the ³Match to tasks in
>>  >>  previous
>>  >>  builds² search doesn¹t seem right:
>>  >>
>>  >>  ** it shows tasks from more recent builds than the one I am
>>  searching
>>  >>  from. This search should only search across tasks from builds that
>>  are
>>  >>  older than the one I am searching from. From the spec: "A "match"
>>  >>  button
>>  >>  to find executed tasks from previous builds (recorded by Toaster)
>>  with
>>  >>  the
>>  >>  same task signature as the prebuilt task.²
>>  >>
>>  >
>>  >Fixed.
>>  >
>>  >>  ** it is also returning the same task for other recipes, and
>>  different
>>  >>  tasks for different recipes (in gcc- targets), something we were
>>  not
>>  >>  expecting to see. I believe Alex is looking into this.
>>  >>
>>  >>  ** the page reloads to show the search results, which means that
>>  when
>>  >>  you
>>  >>  click the back button you are brought to the same page without the
>>  >>  search
>>  >>  results. This is a bit funny. Any chance we could use an ajax call
>>  to
>>  >>  load
>>  >>  the search results without reloading the page?
>>  >>
>>  >
>>  >I will fix this later when we include an ajax library.
>>  >
>>  >>  * In the results table:
>>  >>
>>  >>  ** the date format in the Completed on table is wrong. It should
>>  match
>>  >>  the
>>  >>  one used in the builds table
>>  >>
>>  >
>>  >Fixed.
>>  >
>>  >>  ** we are missing the help on hover for the Task and Outcome
>>  columns
>>  >>  (for
>>  >>  an example, go to
>>  >>  http://www.yoctoproject.org/toaster/task-details-notexecuted-
>>  >>  prebuilt.html,
>>  >>   click on the ³match to tasks in previous builds² button and hover
>>  >>  over a
>>  >>  task cell or an outcome cell)
>>  >>
>>  >
>>  >Added the help for outcome and not for task. The help for task will
>>  be
>>  >added when we fix
>>  https://bugzilla.yoctoproject.org/show_bug.cgi?id=5748
>>  >
>>  >
>>  >>  ** the content of each cell should be a link to the corresponding
>>  task
>>  >>  details page
>>  >>
>>  >
>>  >Fixed.
>>  >
>>  >>  ** I was not expecting to see more than one result from the same
>>  >>  build,
>>  >>  but some seem to be coming in. That means that we need a secondary
>>  >>  sorting
>>  >>  criteria, which should be recipe name
>>  >>
>>  >
>>  >I did not understand this.
>>  >
>>  >>  * Cached tasks are not showing the log. They should display the
>>  path
>>  >>  to
>>  >>  the log file generated by the _setscene task
>>  >
>>  >Fixed.
>>  >
>>  >>
>>  >>  * In the "Not executed" section of the Cached tasks:
>>  >>
>>  >>  ** The "Task inputs signature" should be above the sstate attempt
>>  >>  notification
>>  >
>>  >Fixed.
>>  >
>>  >>
>>  >>  ** The task order number should link back to the tasks table. To
>>  see
>>  >>  this
>>  >>  in action, visit
>>  >>  http://www.yoctoproject.org/toaster/task-details-executed-sstate-
>>  >>  success.ht
>>  >>  ml and click on the task order number
>>  >
>>  >Fixed. But the navigation works only if the task is on the first
>>  page.
>>  >With the pagination, we do not know on which page the linked task
>>  >appears. We have to add logic to find the page number based on the
>>  task.
>>  >
>>  >>
>>  >>  * The task script type should not show for not executed tasks
>>  >
>>  >Fixed.
>>  >
>>  >>
>>  >>  Any questions, let me know.
>>  >>
>>  >
>>  >Thanks,
>>  >Ravi
>>  
>

Re: Viewing Task details feature

[Ravi Chintakunta]

>  
>  >Hi Belen,
>  >
>  >For the matching tasks, I am displaying all the tasks that have the
>  same
>  >sstate_checksum and are from a previous build.
>  >
>  >I did not understand the merging of setscene tasks with other tasks.
>  >
>  >In the example you gave, I am not sure how to link task 4122 and task
>  >2348. Can you guide me?
>  
>  You need Alex to answer this (he is away until next Tuesday). But in
>  /gui/build/2/task/2348 you are showing the log of
>  do_populate_sysroot_setscene, but the order number of
>  do_populate_sysroot,
>  so you are already somehow connecting both tasks :)
>  
OK, this can be a question for Alex.

For cached tasks (eg. 2348), I get the related setscene task that has the same task name with '_setscene" appended, executed, in the same build and for the same recipe. 

And to get the related task for a setscene task, is it OK to find the task that has the task name with '_setscene' removed, not executed, in the same build and for the same recipe?

Also is there any other way to identify a setscene task other than the task name being appended by _setscene?

Thanks,
Ravi

Re: Viewing Task details feature

[Barros Pena, Belen]

On 26/02/2014 15:34, "Ravi Chintakunta" <ravi.chintakunta@timesys.com>
wrote:

>>  
>>  >Hi Belen,
>>  >
>>  >For the matching tasks, I am displaying all the tasks that have the
>>  same
>>  >sstate_checksum and are from a previous build.
>>  >
>>  >I did not understand the merging of setscene tasks with other tasks.
>>  >
>>  >In the example you gave, I am not sure how to link task 4122 and task
>>  >2348. Can you guide me?
>>  
>>  You need Alex to answer this (he is away until next Tuesday). But in
>>  /gui/build/2/task/2348 you are showing the log of
>>  do_populate_sysroot_setscene, but the order number of
>>  do_populate_sysroot,
>>  so you are already somehow connecting both tasks :)
>>  
>OK, this can be a question for Alex.
>
>For cached tasks (eg. 2348), I get the related setscene task that has the
>same task name with '_setscene" appended, executed, in the same build and
>for the same recipe.
>
>And to get the related task for a setscene task, is it OK to find the
>task that has the task name with '_setscene' removed, not executed, in
>the same build and for the same recipe?
>
>Also is there any other way to identify a setscene task other than the
>task name being appended by _setscene?

Not that I know of, but once again, Alex will have the right answer :)

>
>Thanks,
>Ravi
>
>
>
>