All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Yuiko.Oshino@microchip.com>
To: <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<Nisar.Sayed@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy
Date: Wed, 27 Oct 2021 14:21:50 +0000	[thread overview]
Message-ID: <CH0PR11MB55611B20B0E62E95C74027338E859@CH0PR11MB5561.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YXMVdkXIenVuD3gV@lunn.ch>

>-----Original Message-----
>From: Andrew Lunn <andrew@lunn.ch>
>Sent: Friday, October 22, 2021 3:48 PM
>To: Yuiko Oshino - C18177 <Yuiko.Oshino@microchip.com>
>Cc: davem@davemloft.net; netdev@vger.kernel.org; Nisar Sayed - I17970
><Nisar.Sayed@microchip.com>; UNGLinuxDriver
><UNGLinuxDriver@microchip.com>
>Subject: Re: [PATCH net-next] net: phy: microchip_t1: add cable test support for
>lan87xx phy
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>> +/* MISC Control 1 Register */
>> +#define LAN87XX_CTRL_1                          (0x11)
>> +#define LAN87XX_MASK_RGMII_TXC_DLY_EN           (0x4000)
>> +#define LAN87XX_MASK_RGMII_RXC_DLY_EN           (0x2000)
>
>Interesting to know, but not used in this patch.
>
>Please can you write a patch to actually make use of these bits, and do the right
>thing when phydev->interface is one of the four PHY_INTERFACE_MODE_RGMII
>values.
>
>         Andrew

Thank you, Andrew.
We will consider to make a use of these in another patch.
Yuiko

  reply	other threads:[~2021-10-27 14:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 18:36 [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy Yuiko Oshino
2021-10-22 19:48 ` Andrew Lunn
2021-10-27 14:21   ` Yuiko.Oshino [this message]
2021-10-22 19:56 ` Andrew Lunn
2021-10-27 14:30   ` Yuiko.Oshino
2021-10-27 14:46     ` Andrew Lunn
2021-10-27 14:54       ` Yuiko.Oshino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH0PR11MB55611B20B0E62E95C74027338E859@CH0PR11MB5561.namprd11.prod.outlook.com \
    --to=yuiko.oshino@microchip.com \
    --cc=Nisar.Sayed@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.