* Re: [igt-dev] [PATCH] tests/amdgpu: Add test description for amd_abm
@ 2021-03-29 14:05 Pillai, Aurabindo
0 siblings, 0 replies; 4+ messages in thread
From: Pillai, Aurabindo @ 2021-03-29 14:05 UTC (permalink / raw)
To: Siqueira, Rodrigo, Aurabindo Pillai; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --]
[AMD Official Use Only - Internal Distribution Only]
Hi Siqueira,
Sorry about the change id, posted a v2
--
Thanks & Regards,
Aurabindo Pillai
________________________________
From: Siqueira, Rodrigo
Sent: Monday, March 29, 2021 9:44 AM
To: Aurabindo Pillai
Cc: igt-dev@lists.freedesktop.org; Pillai, Aurabindo
Subject: Re: [PATCH] tests/amdgpu: Add test description for amd_abm
Hi Aurabindo,
On 03/29, Aurabindo Pillai wrote:
> From: Aurabindo Pillai <aurabindo.pillai@amd.com>
>
> Add overall test description for amd_abm
>
> Change-Id: I4baa52ea66189688b12a82befbbd842ba3d3a24d
We don't need this Change-id in IGT.
Aside from the above comment, everything LGTM.
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Let me know if you need help for applying this change in IGT.
Thanks
Siqueira
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> tests/amdgpu/amd_abm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index 0505f17e..a1e48533 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -32,6 +32,8 @@
> #include <fcntl.h>
> #include <time.h>
>
> +IGT_TEST_DESCRIPTION("Tests Adaptive Backlight Modulation on supported hardware");
> +
> #define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0"
>
> typedef struct data {
> --
> 2.31.0
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: Type: text/html, Size: 3572 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] [PATCH] tests/amdgpu: Add test description for amd_abm
@ 2021-03-29 13:06 Aurabindo Pillai
2021-03-29 13:44 ` Rodrigo Siqueira
0 siblings, 1 reply; 4+ messages in thread
From: Aurabindo Pillai @ 2021-03-29 13:06 UTC (permalink / raw)
To: igt-dev
From: Aurabindo Pillai <aurabindo.pillai@amd.com>
Add overall test description for amd_abm
Change-Id: I4baa52ea66189688b12a82befbbd842ba3d3a24d
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
tests/amdgpu/amd_abm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index 0505f17e..a1e48533 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -32,6 +32,8 @@
#include <fcntl.h>
#include <time.h>
+IGT_TEST_DESCRIPTION("Tests Adaptive Backlight Modulation on supported hardware");
+
#define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0"
typedef struct data {
--
2.31.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH] tests/amdgpu: Add test description for amd_abm
2021-03-29 13:06 Aurabindo Pillai
@ 2021-03-29 13:44 ` Rodrigo Siqueira
0 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Siqueira @ 2021-03-29 13:44 UTC (permalink / raw)
To: Aurabindo Pillai; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 1080 bytes --]
Hi Aurabindo,
On 03/29, Aurabindo Pillai wrote:
> From: Aurabindo Pillai <aurabindo.pillai@amd.com>
>
> Add overall test description for amd_abm
>
> Change-Id: I4baa52ea66189688b12a82befbbd842ba3d3a24d
We don't need this Change-id in IGT.
Aside from the above comment, everything LGTM.
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Let me know if you need help for applying this change in IGT.
Thanks
Siqueira
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> tests/amdgpu/amd_abm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index 0505f17e..a1e48533 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -32,6 +32,8 @@
> #include <fcntl.h>
> #include <time.h>
>
> +IGT_TEST_DESCRIPTION("Tests Adaptive Backlight Modulation on supported hardware");
> +
> #define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0"
>
> typedef struct data {
> --
> 2.31.0
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] [PATCH] tests/amdgpu: Add test description for amd_abm
@ 2021-03-15 15:22 Aurabindo Pillai
0 siblings, 0 replies; 4+ messages in thread
From: Aurabindo Pillai @ 2021-03-15 15:22 UTC (permalink / raw)
To: igt-dev; +Cc: Aurabindo Pillai
From: Aurabindo Pillai <aurabindo.pillai@amd.com>
Add overall test description for amd_abm
Change-Id: I4baa52ea66189688b12a82befbbd842ba3d3a24d
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
tests/amdgpu/amd_abm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index 0505f17e..a1e48533 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -32,6 +32,8 @@
#include <fcntl.h>
#include <time.h>
+IGT_TEST_DESCRIPTION("Tests Adaptive Backlight Modulation on supported hardware");
+
#define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0"
typedef struct data {
--
2.30.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-29 14:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 14:05 [igt-dev] [PATCH] tests/amdgpu: Add test description for amd_abm Pillai, Aurabindo
-- strict thread matches above, loose matches on Subject: below --
2021-03-29 13:06 Aurabindo Pillai
2021-03-29 13:44 ` Rodrigo Siqueira
2021-03-15 15:22 Aurabindo Pillai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.