* [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran
@ 2022-04-22 16:08 David Yu
2022-04-22 16:26 ` Liu, Shaoyun
0 siblings, 1 reply; 4+ messages in thread
From: David Yu @ 2022-04-22 16:08 UTC (permalink / raw)
To: amd-gfx; +Cc: David Yu
Load ta fw during psp_init_sriov_microcode to enable XGMI. It is required to be loaded by both guest and host starting from Arcturus. Cap fw needs to be loaded first.
Fix previously patch that was pushed by mistake.
Signed-off-by: David Yu <David.Yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 895251f42853..0bd22ebcc3d1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -275,8 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
ret = psp_init_cap_microcode(psp, "sienna_cichlid");
break;
case IP_VERSION(13, 0, 2):
- ret = psp_init_ta_microcode(psp, "aldebaran");
- ret &= psp_init_cap_microcode(psp, "aldebaran");
+ ret = psp_init_cap_microcode(psp, "aldebaran");
+ ret &= psp_init_ta_microcode(psp, "aldebaran");
break;
default:
BUG();
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran
2022-04-22 16:08 [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran David Yu
@ 2022-04-22 16:26 ` Liu, Shaoyun
0 siblings, 0 replies; 4+ messages in thread
From: Liu, Shaoyun @ 2022-04-22 16:26 UTC (permalink / raw)
To: Yu, David, amd-gfx; +Cc: Yu, David
[AMD Official Use Only]
Looks ok to me .
You can add reviewed-by: Shaoyun.liu <Shaoyun.liu@amd.com>
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of David Yu
Sent: Friday, April 22, 2022 12:09 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yu, David <David.Yu@amd.com>
Subject: [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran
Load ta fw during psp_init_sriov_microcode to enable XGMI. It is required to be loaded by both guest and host starting from Arcturus. Cap fw needs to be loaded first.
Fix previously patch that was pushed by mistake.
Signed-off-by: David Yu <David.Yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 895251f42853..0bd22ebcc3d1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -275,8 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
ret = psp_init_cap_microcode(psp, "sienna_cichlid");
break;
case IP_VERSION(13, 0, 2):
- ret = psp_init_ta_microcode(psp, "aldebaran");
- ret &= psp_init_cap_microcode(psp, "aldebaran");
+ ret = psp_init_cap_microcode(psp, "aldebaran");
+ ret &= psp_init_ta_microcode(psp, "aldebaran");
break;
default:
BUG();
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran
2022-04-22 14:58 David Yu
@ 2022-04-22 15:02 ` Liu, Shaoyun
0 siblings, 0 replies; 4+ messages in thread
From: Liu, Shaoyun @ 2022-04-22 15:02 UTC (permalink / raw)
To: Yu, David, amd-gfx; +Cc: Yu, David
[AMD Official Use Only]
Please add some more info in the description to explain why we need to add TA in SRIOV guest .
Regard
Shaoyun.liu
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of David Yu
Sent: Friday, April 22, 2022 10:58 AM
To: amd-gfx@lists.freedesktop.org
Cc: Yu, David <David.Yu@amd.com>
Subject: [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran
Load ta fw during psp_init_sriov_microcode to enable XGMI
Signed-off-by: David Yu <David.Yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index f6527aa19238..895251f42853 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -275,7 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
ret = psp_init_cap_microcode(psp, "sienna_cichlid");
break;
case IP_VERSION(13, 0, 2):
- ret = psp_init_cap_microcode(psp, "aldebaran");
+ ret = psp_init_ta_microcode(psp, "aldebaran");
+ ret &= psp_init_cap_microcode(psp, "aldebaran");
break;
default:
BUG();
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran
@ 2022-04-22 14:58 David Yu
2022-04-22 15:02 ` Liu, Shaoyun
0 siblings, 1 reply; 4+ messages in thread
From: David Yu @ 2022-04-22 14:58 UTC (permalink / raw)
To: amd-gfx; +Cc: David Yu
Load ta fw during psp_init_sriov_microcode to enable XGMI
Signed-off-by: David Yu <David.Yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index f6527aa19238..895251f42853 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -275,7 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
ret = psp_init_cap_microcode(psp, "sienna_cichlid");
break;
case IP_VERSION(13, 0, 2):
- ret = psp_init_cap_microcode(psp, "aldebaran");
+ ret = psp_init_ta_microcode(psp, "aldebaran");
+ ret &= psp_init_cap_microcode(psp, "aldebaran");
break;
default:
BUG();
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-22 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 16:08 [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran David Yu
2022-04-22 16:26 ` Liu, Shaoyun
-- strict thread matches above, loose matches on Subject: below --
2022-04-22 14:58 David Yu
2022-04-22 15:02 ` Liu, Shaoyun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.