* [PATCH] power: reset: pwr-mlxbf: change rst_pwr_hid and low_pwr_hid from global to local variables
@ 2022-06-29 19:20 Tom Rix
2022-06-29 19:24 ` Asmaa Mnebhi
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-06-29 19:20 UTC (permalink / raw)
To: sre, asmaa; +Cc: linux-pm, linux-kernel, Tom Rix
sparse reports
drivers/power/reset/pwr-mlxbf.c:19:12: warning: symbol 'rst_pwr_hid' was not declared. Should it be static?
drivers/power/reset/pwr-mlxbf.c:20:12: warning: symbol 'low_pwr_hid' was not declared. Should it be static?
Both rst_pwr_hid and low_pwr_hid are only used in a single function
so they should be local variables.
Fixes: a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/power/reset/pwr-mlxbf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/power/reset/pwr-mlxbf.c b/drivers/power/reset/pwr-mlxbf.c
index 1c4904c0e1f5..12dedf841a44 100644
--- a/drivers/power/reset/pwr-mlxbf.c
+++ b/drivers/power/reset/pwr-mlxbf.c
@@ -16,9 +16,6 @@
#include <linux/reboot.h>
#include <linux/types.h>
-const char *rst_pwr_hid = "MLNXBF24";
-const char *low_pwr_hid = "MLNXBF29";
-
struct pwr_mlxbf {
struct work_struct send_work;
const char *hid;
@@ -31,6 +28,8 @@ static void pwr_mlxbf_send_work(struct work_struct *work)
static irqreturn_t pwr_mlxbf_irq(int irq, void *ptr)
{
+ const char *rst_pwr_hid = "MLNXBF24";
+ const char *low_pwr_hid = "MLNXBF29";
struct pwr_mlxbf *priv = ptr;
if (!strncmp(priv->hid, rst_pwr_hid, 8))
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] power: reset: pwr-mlxbf: change rst_pwr_hid and low_pwr_hid from global to local variables
2022-06-29 19:20 [PATCH] power: reset: pwr-mlxbf: change rst_pwr_hid and low_pwr_hid from global to local variables Tom Rix
@ 2022-06-29 19:24 ` Asmaa Mnebhi
0 siblings, 0 replies; 2+ messages in thread
From: Asmaa Mnebhi @ 2022-06-29 19:24 UTC (permalink / raw)
To: Tom Rix, sre; +Cc: linux-pm, linux-kernel
Acked-by: Asmaa Mnebhi <asmaa@nvidia.com>
-----Original Message-----
From: Tom Rix <trix@redhat.com>
Sent: Wednesday, June 29, 2022 3:21 PM
To: sre@kernel.org; Asmaa Mnebhi <asmaa@nvidia.com>
Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix <trix@redhat.com>
Subject: [PATCH] power: reset: pwr-mlxbf: change rst_pwr_hid and low_pwr_hid from global to local variables
sparse reports
drivers/power/reset/pwr-mlxbf.c:19:12: warning: symbol 'rst_pwr_hid' was not declared. Should it be static?
drivers/power/reset/pwr-mlxbf.c:20:12: warning: symbol 'low_pwr_hid' was not declared. Should it be static?
Both rst_pwr_hid and low_pwr_hid are only used in a single function so they should be local variables.
Fixes: a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/power/reset/pwr-mlxbf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/power/reset/pwr-mlxbf.c b/drivers/power/reset/pwr-mlxbf.c index 1c4904c0e1f5..12dedf841a44 100644
--- a/drivers/power/reset/pwr-mlxbf.c
+++ b/drivers/power/reset/pwr-mlxbf.c
@@ -16,9 +16,6 @@
#include <linux/reboot.h>
#include <linux/types.h>
-const char *rst_pwr_hid = "MLNXBF24";
-const char *low_pwr_hid = "MLNXBF29";
-
struct pwr_mlxbf {
struct work_struct send_work;
const char *hid;
@@ -31,6 +28,8 @@ static void pwr_mlxbf_send_work(struct work_struct *work)
static irqreturn_t pwr_mlxbf_irq(int irq, void *ptr) {
+ const char *rst_pwr_hid = "MLNXBF24";
+ const char *low_pwr_hid = "MLNXBF29";
struct pwr_mlxbf *priv = ptr;
if (!strncmp(priv->hid, rst_pwr_hid, 8))
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 19:20 [PATCH] power: reset: pwr-mlxbf: change rst_pwr_hid and low_pwr_hid from global to local variables Tom Rix
2022-06-29 19:24 ` Asmaa Mnebhi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.