* [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
@ 2022-11-08 20:07 Neal Frager via buildroot
2022-11-21 9:12 ` Frager, Neal via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Neal Frager via buildroot @ 2022-11-08 20:07 UTC (permalink / raw)
To: buildroot; +Cc: luca.ceresoli, thomas.petazzoni, Neal Frager
If a user requests a u-boot binary in elf format,
they may actually want the stripped u-boot.elf version.
This patch provides the stripped u-boot.elf binary.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
boot/uboot/uboot.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 0439ec5e4b..216efc5a13 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb
endif
ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
-UBOOT_BINS += u-boot
+UBOOT_BINS += u-boot u-boot.elf
# To make elf usable for debuging on ARC use special target
ifeq ($(BR2_arc),y)
UBOOT_MAKE_TARGET += mdbtrick
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
2022-11-08 20:07 [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support Neal Frager via buildroot
@ 2022-11-21 9:12 ` Frager, Neal via buildroot
2022-11-21 14:49 ` Luca Ceresoli via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Frager, Neal via buildroot @ 2022-11-21 9:12 UTC (permalink / raw)
To: Frager, Neal, buildroot; +Cc: luca.ceresoli, thomas.petazzoni
Hello everyone,
Just a friendly reminder regarding this patch. Any feedback?
If a user requests a u-boot binary in elf format, they may actually want the stripped u-boot.elf version.
This patch provides the stripped u-boot.elf binary.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
boot/uboot/uboot.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 0439ec5e4b..216efc5a13 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb endif
ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
-UBOOT_BINS += u-boot
+UBOOT_BINS += u-boot u-boot.elf
# To make elf usable for debuging on ARC use special target ifeq ($(BR2_arc),y) UBOOT_MAKE_TARGET += mdbtrick
--
2.17.1
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
2022-11-21 9:12 ` Frager, Neal via buildroot
@ 2022-11-21 14:49 ` Luca Ceresoli via buildroot
2022-11-21 18:04 ` Frager, Neal via buildroot
2022-11-21 18:28 ` Frager, Neal via buildroot
0 siblings, 2 replies; 6+ messages in thread
From: Luca Ceresoli via buildroot @ 2022-11-21 14:49 UTC (permalink / raw)
To: Frager, Neal; +Cc: thomas.petazzoni, buildroot
Hello Neal,
On Mon, 21 Nov 2022 09:12:05 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:
> Hello everyone,
>
> Just a friendly reminder regarding this patch. Any feedback?
>
> If a user requests a u-boot binary in elf format, they may actually want the stripped u-boot.elf version.
> This patch provides the stripped u-boot.elf binary.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> boot/uboot/uboot.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 0439ec5e4b..216efc5a13 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb endif
>
> ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
> -UBOOT_BINS += u-boot
> +UBOOT_BINS += u-boot u-boot.elf
This assumes BR2_TARGET_UBOOT_FORMAT_ELF will always result in
building u-boot.elf, but I don't think this is true for all platforms.
At a quick test with a RISC-V build and BR2_TARGET_UBOOT_FORMAT_ELF=y I
got a failure with your patch applied because u-boot is produced but
u-boot.elf isn't.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
2022-11-21 14:49 ` Luca Ceresoli via buildroot
@ 2022-11-21 18:04 ` Frager, Neal via buildroot
2022-11-21 18:28 ` Frager, Neal via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Frager, Neal via buildroot @ 2022-11-21 18:04 UTC (permalink / raw)
To: Luca Ceresoli; +Cc: thomas.petazzoni, buildroot
[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]
Hi Luca,
> Hello everyone,
>
> Just a friendly reminder regarding this patch. Any feedback?
>
> If a user requests a u-boot binary in elf format, they may actually want the stripped u-boot.elf version.
> This patch provides the stripped u-boot.elf binary.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> boot/uboot/uboot.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index
> 0439ec5e4b..216efc5a13 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb endif
>
> ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
> -UBOOT_BINS += u-boot
> +UBOOT_BINS += u-boot u-boot.elf
> This assumes BR2_TARGET_UBOOT_FORMAT_ELF will always result in building u-boot.elf, but I don't think this is true for all platforms.
> At a quick test with a RISC-V build and BR2_TARGET_UBOOT_FORMAT_ELF=y I got a failure with your patch applied because u-boot is produced but u-boot.elf isn't.
Thank you for this feedback. I was not aware that some platforms generate a u-boot file, but not a u-boot.elf file.
I could just use the u-boot file with the versal builds, but I would prefer to use the u-boot.elf file, so that I fully match the way PetaLinux and Yocto work.
Do you have any suggestions for getting the u-boot.elf file, if it is not available for all platforms?
Would it be acceptable to add a define specific to this version of elf file such as BR2_TARGET_UBOOT_FORMAT_STRIPPED_ELF? This would still fail, of course, if built with a RISC-V configuration, so I am not sure what to do.
Best regards,
Neal Frager
AMD
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14756 bytes --]
[-- Attachment #3: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
2022-11-21 14:49 ` Luca Ceresoli via buildroot
2022-11-21 18:04 ` Frager, Neal via buildroot
@ 2022-11-21 18:28 ` Frager, Neal via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Frager, Neal via buildroot @ 2022-11-21 18:28 UTC (permalink / raw)
To: Luca Ceresoli; +Cc: thomas.petazzoni, buildroot
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
Hi Luca,
> Hello everyone,
>
> Just a friendly reminder regarding this patch. Any feedback?
>
> If a user requests a u-boot binary in elf format, they may actually want the stripped u-boot.elf version.
> This patch provides the stripped u-boot.elf binary.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> boot/uboot/uboot.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index
> 0439ec5e4b..216efc5a13 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb endif
>
> ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
> -UBOOT_BINS += u-boot
> +UBOOT_BINS += u-boot u-boot.elf
> This assumes BR2_TARGET_UBOOT_FORMAT_ELF will always result in building u-boot.elf, but I don't think this is true for all platforms.
> At a quick test with a RISC-V build and BR2_TARGET_UBOOT_FORMAT_ELF=y I got a failure with your patch applied because u-boot is produced but u-boot.elf isn't.
Do you know if all ARM 64-bit architectures generate a u-boot.elf by default?
We could do this then:
ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
UBOOT_BINS += u-boot
# To make elf usable for debuging on ARC use special target
Ifeq ($(BR2_aarch64),y)
UBOOT_BINS += u-boot.elf
endif
ifeq ($(BR2_arc),y)
UBOOT_MAKE_TARGET += mdbtrick
endif
endif
What do you think?
Best regards,
Neal Frager
AMD
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14604 bytes --]
[-- Attachment #3: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
@ 2022-11-08 20:11 Neal Frager via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Neal Frager via buildroot @ 2022-11-08 20:11 UTC (permalink / raw)
To: buildroot; +Cc: luca.ceresoli, thomas.petazzoni, Neal Frager
If a user requests a u-boot binary in elf format,
they may actually want the stripped u-boot.elf version.
This patch provides the stripped u-boot.elf binary.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
boot/uboot/uboot.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 0439ec5e4b..216efc5a13 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb
endif
ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
-UBOOT_BINS += u-boot
+UBOOT_BINS += u-boot u-boot.elf
# To make elf usable for debuging on ARC use special target
ifeq ($(BR2_arc),y)
UBOOT_MAKE_TARGET += mdbtrick
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-21 18:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 20:07 [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support Neal Frager via buildroot
2022-11-21 9:12 ` Frager, Neal via buildroot
2022-11-21 14:49 ` Luca Ceresoli via buildroot
2022-11-21 18:04 ` Frager, Neal via buildroot
2022-11-21 18:28 ` Frager, Neal via buildroot
2022-11-08 20:11 Neal Frager via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.