* [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset
@ 2022-10-17 7:10 Neal Frager via buildroot
2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Neal Frager via buildroot @ 2022-10-17 7:10 UTC (permalink / raw)
To: buildroot
Cc: luca.ceresoli, Neal Frager, kris.chaplin, wesley, giulio.benetti,
michal.simek, yann.morin.1998
This patch will solve the problem of the pmufw built by the
zynqmp-pmufw-builder where soft resets crash for the zcu102.
Details of the issue can be found here:
https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
configs/zynqmp_zcu102_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/zynqmp_zcu102_defconfig b/configs/zynqmp_zcu102_defconfig
index 217fa0814b..66c24c4b64 100644
--- a/configs/zynqmp_zcu102_defconfig
+++ b/configs/zynqmp_zcu102_defconfig
@@ -29,7 +29,7 @@ BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
BR2_TARGET_UBOOT_SPL=y
BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
BR2_TARGET_UBOOT_ZYNQMP=y
-BR2_TARGET_UBOOT_ZYNQMP_PMUFW="https://github.com/lucaceresoli/zynqmp-pmufw-binaries/raw/v2022.1/bin/pmufw-v2022.1.bin"
+BR2_TARGET_UBOOT_ZYNQMP_PMUFW="https://github.com/Xilinx/ubuntu-firmware/raw/v2022.1_22.04_1/xlnx-firmware/zcu102/zcu102_pmufw.elf"
BR2_TARGET_UBOOT_ZYNQMP_PM_CFG="board/zynqmp/zcu102/pm_cfg_obj.c"
BR2_TARGET_UBOOT_FORMAT_ITB=y
BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: fix pmufw sw reset 2022-10-17 7:10 [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset Neal Frager via buildroot @ 2022-10-17 7:10 ` Neal Frager via buildroot 2022-10-18 7:05 ` Luca Ceresoli via buildroot ` (2 more replies) 2022-10-17 13:58 ` [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: " Luca Ceresoli via buildroot ` (2 subsequent siblings) 3 siblings, 3 replies; 10+ messages in thread From: Neal Frager via buildroot @ 2022-10-17 7:10 UTC (permalink / raw) To: buildroot Cc: luca.ceresoli, Neal Frager, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 This patch will solve the problem of the pmufw built by the zynqmp-pmufw-builder where soft resets crash for the zcu106. Details of the issue can be found here: https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ Signed-off-by: Neal Frager <neal.frager@amd.com> --- configs/zynqmp_zcu106_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/zynqmp_zcu106_defconfig b/configs/zynqmp_zcu106_defconfig index 3d98dffe01..896fea0ab2 100644 --- a/configs/zynqmp_zcu106_defconfig +++ b/configs/zynqmp_zcu106_defconfig @@ -29,7 +29,7 @@ BR2_TARGET_UBOOT_NEEDS_OPENSSL=y BR2_TARGET_UBOOT_SPL=y BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin" BR2_TARGET_UBOOT_ZYNQMP=y -BR2_TARGET_UBOOT_ZYNQMP_PMUFW="https://github.com/lucaceresoli/zynqmp-pmufw-binaries/raw/v2022.1/bin/pmufw-v2022.1.bin" +BR2_TARGET_UBOOT_ZYNQMP_PMUFW="https://github.com/Xilinx/ubuntu-firmware/raw/v2022.1_22.04_1/xlnx-firmware/zcu106/zcu106_pmufw.elf" BR2_TARGET_UBOOT_ZYNQMP_PM_CFG="board/zynqmp/zcu106/pm_cfg_obj.c" BR2_TARGET_UBOOT_FORMAT_ITB=y BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y -- 2.17.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: fix pmufw sw reset 2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot @ 2022-10-18 7:05 ` Luca Ceresoli via buildroot 2022-10-18 19:42 ` Peter Korsgaard 2022-11-02 22:57 ` Peter Korsgaard 2 siblings, 0 replies; 10+ messages in thread From: Luca Ceresoli via buildroot @ 2022-10-18 7:05 UTC (permalink / raw) To: Neal Frager Cc: buildroot, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 On Mon, 17 Oct 2022 01:10:02 -0600 Neal Frager <neal.frager@amd.com> wrote: > This patch will solve the problem of the pmufw built by the > zynqmp-pmufw-builder where soft resets crash for the zcu106. > Details of the issue can be found here: > > https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ > > Signed-off-by: Neal Frager <neal.frager@amd.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: fix pmufw sw reset 2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot 2022-10-18 7:05 ` Luca Ceresoli via buildroot @ 2022-10-18 19:42 ` Peter Korsgaard 2022-11-02 22:57 ` Peter Korsgaard 2 siblings, 0 replies; 10+ messages in thread From: Peter Korsgaard @ 2022-10-18 19:42 UTC (permalink / raw) To: Neal Frager Cc: luca.ceresoli, buildroot, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 >>>>> "Neal" == Neal Frager <neal.frager@amd.com> writes: > This patch will solve the problem of the pmufw built by the > zynqmp-pmufw-builder where soft resets crash for the zcu106. > Details of the issue can be found here: > https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ > Signed-off-by: Neal Frager <neal.frager@amd.com> Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: fix pmufw sw reset 2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot 2022-10-18 7:05 ` Luca Ceresoli via buildroot 2022-10-18 19:42 ` Peter Korsgaard @ 2022-11-02 22:57 ` Peter Korsgaard 2 siblings, 0 replies; 10+ messages in thread From: Peter Korsgaard @ 2022-11-02 22:57 UTC (permalink / raw) To: Neal Frager Cc: luca.ceresoli, buildroot, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 >>>>> "Neal" == Neal Frager <neal.frager@amd.com> writes: > This patch will solve the problem of the pmufw built by the > zynqmp-pmufw-builder where soft resets crash for the zcu106. > Details of the issue can be found here: > https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ > Signed-off-by: Neal Frager <neal.frager@amd.com> Committed to 2022.08.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset 2022-10-17 7:10 [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset Neal Frager via buildroot 2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot @ 2022-10-17 13:58 ` Luca Ceresoli via buildroot 2022-10-17 14:15 ` Frager, Neal via buildroot 2022-10-18 19:41 ` Peter Korsgaard 2022-11-02 22:57 ` Peter Korsgaard 3 siblings, 1 reply; 10+ messages in thread From: Luca Ceresoli via buildroot @ 2022-10-17 13:58 UTC (permalink / raw) To: Neal Frager Cc: buildroot, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 On Mon, 17 Oct 2022 01:10:01 -0600 Neal Frager <neal.frager@amd.com> wrote: > This patch will solve the problem of the pmufw built by the > zynqmp-pmufw-builder where soft resets crash for the zcu102. > Details of the issue can be found here: > > https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ > > Signed-off-by: Neal Frager <neal.frager@amd.com> > --- > configs/zynqmp_zcu102_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/zynqmp_zcu102_defconfig b/configs/zynqmp_zcu102_defconfig > index 217fa0814b..66c24c4b64 100644 > --- a/configs/zynqmp_zcu102_defconfig > +++ b/configs/zynqmp_zcu102_defconfig > @@ -29,7 +29,7 @@ BR2_TARGET_UBOOT_NEEDS_OPENSSL=y > BR2_TARGET_UBOOT_SPL=y > BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin" > BR2_TARGET_UBOOT_ZYNQMP=y > -BR2_TARGET_UBOOT_ZYNQMP_PMUFW="https://github.com/lucaceresoli/zynqmp-pmufw-binaries/raw/v2022.1/bin/pmufw-v2022.1.bin" > +BR2_TARGET_UBOOT_ZYNQMP_PMUFW="https://github.com/Xilinx/ubuntu-firmware/raw/v2022.1_22.04_1/xlnx-firmware/zcu102/zcu102_pmufw.elf" Why are these binaries board-specific? I thought this used to be only needed for the "community workflow" before U-Boot SPL was able to load a pmufw cfg object. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset 2022-10-17 13:58 ` [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: " Luca Ceresoli via buildroot @ 2022-10-17 14:15 ` Frager, Neal via buildroot 2022-10-18 7:04 ` Luca Ceresoli via buildroot 0 siblings, 1 reply; 10+ messages in thread From: Frager, Neal via buildroot @ 2022-10-17 14:15 UTC (permalink / raw) To: Luca Ceresoli Cc: buildroot, Chaplin, Kris, wesley, giulio.benetti, Simek, Michal, yann.morin.1998 Hi Luca, > Why are these binaries board-specific? I thought this used to be only > needed for the "community workflow" before U-Boot SPL was able to load > a pmufw cfg object. Good question! I had a feeling you would ask this. In the case of the zcu102, zcu104 and zcu106, the pmufw binary is not board specific. The same pmufw binary will work on all 3 boards and even custom hardware, if a developer wants to use it unchanged. But since the pmu reset gpios are customisable among other things, the kria kv260 actually uses a different pmufw configuration. And developers may wish to modify the pmufw for their target as well. Since the Xilinx firmware repository is created using the petalinux prebuilt images for each target hardware, we chose to have a pmufw.elf in each board directory to match what comes from the petalinux builds. That said, since the Xilinx repository has a pmufw.elf in each individual board directory, I thought it would be cleaner for buildroot to use the pmufw.elf for each specific target. Even if the zcu102 and zcu106 pmufw.elf binaries are really interchangeable. What do you think? Best regards, Neal Frager AMD _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset 2022-10-17 14:15 ` Frager, Neal via buildroot @ 2022-10-18 7:04 ` Luca Ceresoli via buildroot 0 siblings, 0 replies; 10+ messages in thread From: Luca Ceresoli via buildroot @ 2022-10-18 7:04 UTC (permalink / raw) To: Frager, Neal Cc: buildroot, Chaplin, Kris, wesley, giulio.benetti, Simek, Michal, yann.morin.1998 Hi Neal, Michal, On Mon, 17 Oct 2022 14:15:16 +0000 "Frager, Neal" <neal.frager@amd.com> wrote: > Hi Luca, > > > Why are these binaries board-specific? I thought this used to be only > > needed for the "community workflow" before U-Boot SPL was able to load > > a pmufw cfg object. > > Good question! I had a feeling you would ask this. ;-) > In the case of the zcu102, zcu104 and zcu106, the pmufw binary is not board specific. The same pmufw binary will work on all 3 boards and even custom hardware, if a developer wants to use it unchanged. OK, I see. (@Michal) I compared the zcu102 and zcu106 binaries and they are different, thus I wondered. > But since the pmu reset gpios are customisable among other things, the kria kv260 actually uses a different pmufw configuration. And developers may wish to modify the pmufw for their target as well. > > Since the Xilinx firmware repository is created using the petalinux prebuilt images for each target hardware, we chose to have a pmufw.elf in each board directory to match what comes from the petalinux builds. Sure, knowing the process clarifies the reason for having different places for firmwares that are equivalent. > That said, since the Xilinx repository has a pmufw.elf in each individual board directory, I thought it would be cleaner for buildroot to use the pmufw.elf for each specific target. Even if the zcu102 and zcu106 pmufw.elf binaries are really interchangeable. Sure it is. Thank you both for the clarifications! Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset 2022-10-17 7:10 [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset Neal Frager via buildroot 2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot 2022-10-17 13:58 ` [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: " Luca Ceresoli via buildroot @ 2022-10-18 19:41 ` Peter Korsgaard 2022-11-02 22:57 ` Peter Korsgaard 3 siblings, 0 replies; 10+ messages in thread From: Peter Korsgaard @ 2022-10-18 19:41 UTC (permalink / raw) To: Neal Frager Cc: luca.ceresoli, buildroot, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 >>>>> "Neal" == Neal Frager <neal.frager@amd.com> writes: > This patch will solve the problem of the pmufw built by the > zynqmp-pmufw-builder where soft resets crash for the zcu102. > Details of the issue can be found here: > https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ > Signed-off-by: Neal Frager <neal.frager@amd.com> Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset 2022-10-17 7:10 [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset Neal Frager via buildroot ` (2 preceding siblings ...) 2022-10-18 19:41 ` Peter Korsgaard @ 2022-11-02 22:57 ` Peter Korsgaard 3 siblings, 0 replies; 10+ messages in thread From: Peter Korsgaard @ 2022-11-02 22:57 UTC (permalink / raw) To: Neal Frager Cc: luca.ceresoli, buildroot, kris.chaplin, wesley, giulio.benetti, michal.simek, yann.morin.1998 >>>>> "Neal" == Neal Frager <neal.frager@amd.com> writes: > This patch will solve the problem of the pmufw built by the > zynqmp-pmufw-builder where soft resets crash for the zcu102. > Details of the issue can be found here: > https://lore.kernel.org/buildroot/87ilqccu3k.fsf@dell.be.48ers.dk/ > Signed-off-by: Neal Frager <neal.frager@amd.com> Committed to 2022.08.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-11-02 22:57 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-10-17 7:10 [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: fix pmufw sw reset Neal Frager via buildroot 2022-10-17 7:10 ` [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: " Neal Frager via buildroot 2022-10-18 7:05 ` Luca Ceresoli via buildroot 2022-10-18 19:42 ` Peter Korsgaard 2022-11-02 22:57 ` Peter Korsgaard 2022-10-17 13:58 ` [Buildroot] [PATCH v1 1/2] configs/zynqmp_zcu102_defconfig: " Luca Ceresoli via buildroot 2022-10-17 14:15 ` Frager, Neal via buildroot 2022-10-18 7:04 ` Luca Ceresoli via buildroot 2022-10-18 19:41 ` Peter Korsgaard 2022-11-02 22:57 ` Peter Korsgaard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.