From: <Kavyasree.Kotagiri@microchip.com> To: <krzysztof.kozlowski@linaro.org> Cc: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>, <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>, <UNGLinuxDriver@microchip.com> Subject: RE: [PATCH 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Date: Tue, 7 Jun 2022 06:55:30 +0000 [thread overview] Message-ID: <CO1PR11MB4865DEDC51BE3AAE0F8C6FDC92A59@CO1PR11MB4865.namprd11.prod.outlook.com> (raw) In-Reply-To: <CO1PR11MB4865475C31FACD142BB9752592A29@CO1PR11MB4865.namprd11.prod.outlook.com> > > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > > --- > > > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ > > > 2 files changed, 97 insertions(+), 63 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > flexcom.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > new file mode 100644 > > > index 000000000000..221bd840b49e > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > @@ -0,0 +1,97 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Device tree bindings for Atmel Flexcom (Flexible Serial > > Communication Unit) > > > > There was a v2 of the same patch to which already commented. Now you > > send the same patch, without comments applied as v1. This does not make > > any sense. > > > > Please version your patches correctly and do not ignore received feedback. > > > > Hi, > > FYI, lan966x flexcom chip-select driver support is moved to atmel-flexcom.c > rather than > implementing a new mux driver. So, I sent new version now with driver > changes in drives/mfd/atmel-flexcom.c > I once again gone through your v2 comments. I missed this comment > "s/Device tree bindings//". > Except that I addressed remaining all other comments for dt-bindings > patches. > > Hi, Please let me know what you mean by " s/Device tree bindings//" comment? Thanks, Kavya > > Best regards, > > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: <Kavyasree.Kotagiri@microchip.com> To: <krzysztof.kozlowski@linaro.org> Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, UNGLinuxDriver@microchip.com, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Subject: RE: [PATCH 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Date: Tue, 7 Jun 2022 06:55:30 +0000 [thread overview] Message-ID: <CO1PR11MB4865DEDC51BE3AAE0F8C6FDC92A59@CO1PR11MB4865.namprd11.prod.outlook.com> (raw) In-Reply-To: <CO1PR11MB4865475C31FACD142BB9752592A29@CO1PR11MB4865.namprd11.prod.outlook.com> > > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > > --- > > > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ > > > 2 files changed, 97 insertions(+), 63 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > flexcom.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > new file mode 100644 > > > index 000000000000..221bd840b49e > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > @@ -0,0 +1,97 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Device tree bindings for Atmel Flexcom (Flexible Serial > > Communication Unit) > > > > There was a v2 of the same patch to which already commented. Now you > > send the same patch, without comments applied as v1. This does not make > > any sense. > > > > Please version your patches correctly and do not ignore received feedback. > > > > Hi, > > FYI, lan966x flexcom chip-select driver support is moved to atmel-flexcom.c > rather than > implementing a new mux driver. So, I sent new version now with driver > changes in drives/mfd/atmel-flexcom.c > I once again gone through your v2 comments. I missed this comment > "s/Device tree bindings//". > Except that I addressed remaining all other comments for dt-bindings > patches. > > Hi, Please let me know what you mean by " s/Device tree bindings//" comment? Thanks, Kavya > > Best regards, > > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-07 6:55 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-03 12:17 [PATCH 0/3] Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri 2022-06-03 12:17 ` Kavyasree Kotagiri 2022-06-03 12:18 ` [PATCH 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Kavyasree Kotagiri 2022-06-03 12:18 ` Kavyasree Kotagiri 2022-06-03 20:34 ` Rob Herring 2022-06-03 20:34 ` Rob Herring 2022-06-06 13:01 ` Krzysztof Kozlowski 2022-06-06 13:01 ` Krzysztof Kozlowski 2022-06-06 13:25 ` Kavyasree.Kotagiri 2022-06-06 13:25 ` Kavyasree.Kotagiri 2022-06-07 6:55 ` Kavyasree.Kotagiri [this message] 2022-06-07 6:55 ` Kavyasree.Kotagiri 2022-06-07 7:04 ` Krzysztof Kozlowski 2022-06-07 7:04 ` Krzysztof Kozlowski 2022-06-03 12:18 ` [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x Kavyasree Kotagiri 2022-06-03 12:18 ` Kavyasree Kotagiri 2022-06-03 20:36 ` Rob Herring 2022-06-03 20:36 ` Rob Herring 2022-06-06 13:03 ` Krzysztof Kozlowski 2022-06-06 13:03 ` Krzysztof Kozlowski 2022-06-06 13:28 ` Kavyasree.Kotagiri 2022-06-06 13:28 ` Kavyasree.Kotagiri 2022-06-07 7:05 ` Krzysztof Kozlowski 2022-06-07 7:05 ` Krzysztof Kozlowski 2022-06-07 7:54 ` Kavyasree.Kotagiri 2022-06-07 7:54 ` Kavyasree.Kotagiri 2022-06-07 7:56 ` Krzysztof Kozlowski 2022-06-07 7:56 ` Krzysztof Kozlowski 2022-06-03 12:18 ` [PATCH 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri 2022-06-03 12:18 ` Kavyasree Kotagiri 2022-06-06 8:44 ` Claudiu.Beznea 2022-06-06 8:44 ` Claudiu.Beznea
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CO1PR11MB4865DEDC51BE3AAE0F8C6FDC92A59@CO1PR11MB4865.namprd11.prod.outlook.com \ --to=kavyasree.kotagiri@microchip.com \ --cc=Claudiu.Beznea@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.