From: "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com> To: Andrew Lunn <andrew@lunn.ch> Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>, "alexandre.torgue@st.com" <alexandre.torgue@st.com>, "joabreu@synopsys.com" <joabreu@synopsys.com>, "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>, "Voon, Weifeng" <weifeng.voon@intel.com>, "Ong, Boon Leong" <boon.leong.ong@intel.com>, "qiangqing.zhang@nxp.com" <qiangqing.zhang@nxp.com>, "Wong, Vee Khee" <vee.khee.wong@intel.com>, "fugang.duan@nxp.com" <fugang.duan@nxp.com>, "Chuah, Kim Tatt" <kim.tatt.chuah@intel.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "hkallweit1@gmail.com" <hkallweit1@gmail.com> Subject: RE: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac Date: Mon, 5 Apr 2021 14:23:20 +0000 [thread overview] Message-ID: <CO1PR11MB5044B1F80C412E6F0CAFD5509D779@CO1PR11MB5044.namprd11.prod.outlook.com> (raw) In-Reply-To: <YGsMbBW9h4H1y/T8@lunn.ch> > -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Monday, 5 April, 2021 9:11 PM > To: Sit, Michael Wei Hong <michael.wei.hong.sit@intel.com> > Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com; > joabreu@synopsys.com; davem@davemloft.net; > kuba@kernel.org; mcoquelin.stm32@gmail.com; > linux@armlinux.org.uk; Voon, Weifeng > <weifeng.voon@intel.com>; Ong, Boon Leong > <boon.leong.ong@intel.com>; qiangqing.zhang@nxp.com; Wong, > Vee Khee <vee.khee.wong@intel.com>; fugang.duan@nxp.com; > Chuah, Kim Tatt <kim.tatt.chuah@intel.com>; > netdev@vger.kernel.org; linux-stm32@st-md- > mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; hkallweit1@gmail.com > Subject: Re: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for > stmmac > > On Mon, Apr 05, 2021 at 07:29:51PM +0800, Michael Sit Wei Hong > wrote: > > This patchset enables 2.5Gbps speed mode for stmmac. > > Link speed mode is detected and configured at serdes power > up sequence. > > For 2.5G, we do not use SGMII in-band AN, we check the link > speed mode > > in the serdes and disable the in-band AN accordingly. > > > > Changes: > > v1 -> v2 > > patch 1/2 > > -Remove MAC supported link speed masking > > > > patch 2/2 > > -Add supported link speed masking in the PCS > > So there still some confusion here. > > ------------ -------- > |MAC - PCS |---serdes---| PHY |--- copper > ------------ -------- > > > You have a MAC and an PCS in the stmmac IP block. That then has > some > sort of SERDES interface, running 1000BaseX, SGMII, SGMII > overclocked > at 2.5G or 25000BaseX. Connected to the SERDES you have a PHY > which > converts to copper, giving you 2500BaseT. > > You said earlier, that the PHY can only do 2500BaseT. So it should > be > the PHY driver which sets supported to 2500BaseT and no other > speeds. > > You should think about when somebody uses this MAC with a > different > PHY, one that can do the full range of 10/half through to 2.5G > full. What generally happens is that the PHY performs auto-neg to > determine the link speed. For 10M-1G speeds the PHY will > configure its > SERDES interface to SGMII and phylink will ask the PCS to also be > configured to SGMII. If the PHY negotiates 2500BaseT, it will > configure its side of the SERDES to 2500BaseX or SGMII > overclocked at > 2.5G. Again, phylink will ask the PCS to match what the PHY is > doing. > > So, where exactly is the limitation in your hardware? PCS or PHY? The limitation in the hardware is at the PCS side where it is either running in SGMII 2.5G or SGMII 1G speeds. When running on SGMII 2.5G speeds, we disable the in-band AN and use 2.5G speed only > > Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com> To: Andrew Lunn <andrew@lunn.ch> Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>, "alexandre.torgue@st.com" <alexandre.torgue@st.com>, "joabreu@synopsys.com" <joabreu@synopsys.com>, "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>, "Voon, Weifeng" <weifeng.voon@intel.com>, "Ong, Boon Leong" <boon.leong.ong@intel.com>, "qiangqing.zhang@nxp.com" <qiangqing.zhang@nxp.com>, "Wong, Vee Khee" <vee.khee.wong@intel.com>, "fugang.duan@nxp.com" <fugang.duan@nxp.com>, "Chuah, Kim Tatt" <kim.tatt.chuah@intel.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "hkallweit1@gmail.com" <hkallweit1@gmail.com> Subject: RE: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac Date: Mon, 5 Apr 2021 14:23:20 +0000 [thread overview] Message-ID: <CO1PR11MB5044B1F80C412E6F0CAFD5509D779@CO1PR11MB5044.namprd11.prod.outlook.com> (raw) In-Reply-To: <YGsMbBW9h4H1y/T8@lunn.ch> > -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Monday, 5 April, 2021 9:11 PM > To: Sit, Michael Wei Hong <michael.wei.hong.sit@intel.com> > Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com; > joabreu@synopsys.com; davem@davemloft.net; > kuba@kernel.org; mcoquelin.stm32@gmail.com; > linux@armlinux.org.uk; Voon, Weifeng > <weifeng.voon@intel.com>; Ong, Boon Leong > <boon.leong.ong@intel.com>; qiangqing.zhang@nxp.com; Wong, > Vee Khee <vee.khee.wong@intel.com>; fugang.duan@nxp.com; > Chuah, Kim Tatt <kim.tatt.chuah@intel.com>; > netdev@vger.kernel.org; linux-stm32@st-md- > mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; hkallweit1@gmail.com > Subject: Re: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for > stmmac > > On Mon, Apr 05, 2021 at 07:29:51PM +0800, Michael Sit Wei Hong > wrote: > > This patchset enables 2.5Gbps speed mode for stmmac. > > Link speed mode is detected and configured at serdes power > up sequence. > > For 2.5G, we do not use SGMII in-band AN, we check the link > speed mode > > in the serdes and disable the in-band AN accordingly. > > > > Changes: > > v1 -> v2 > > patch 1/2 > > -Remove MAC supported link speed masking > > > > patch 2/2 > > -Add supported link speed masking in the PCS > > So there still some confusion here. > > ------------ -------- > |MAC - PCS |---serdes---| PHY |--- copper > ------------ -------- > > > You have a MAC and an PCS in the stmmac IP block. That then has > some > sort of SERDES interface, running 1000BaseX, SGMII, SGMII > overclocked > at 2.5G or 25000BaseX. Connected to the SERDES you have a PHY > which > converts to copper, giving you 2500BaseT. > > You said earlier, that the PHY can only do 2500BaseT. So it should > be > the PHY driver which sets supported to 2500BaseT and no other > speeds. > > You should think about when somebody uses this MAC with a > different > PHY, one that can do the full range of 10/half through to 2.5G > full. What generally happens is that the PHY performs auto-neg to > determine the link speed. For 10M-1G speeds the PHY will > configure its > SERDES interface to SGMII and phylink will ask the PCS to also be > configured to SGMII. If the PHY negotiates 2500BaseT, it will > configure its side of the SERDES to 2500BaseX or SGMII > overclocked at > 2.5G. Again, phylink will ask the PCS to match what the PHY is > doing. > > So, where exactly is the limitation in your hardware? PCS or PHY? The limitation in the hardware is at the PCS side where it is either running in SGMII 2.5G or SGMII 1G speeds. When running on SGMII 2.5G speeds, we disable the in-band AN and use 2.5G speed only > > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-05 14:23 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-05 11:29 [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac Michael Sit Wei Hong 2021-04-05 11:29 ` Michael Sit Wei Hong 2021-04-05 11:29 ` [PATCH net-next v2 1/2] net: stmmac: enable 2.5Gbps link speed Michael Sit Wei Hong 2021-04-05 11:29 ` Michael Sit Wei Hong 2021-04-05 11:29 ` [PATCH net-next v2 2/2] net: pcs: configure xpcs 2.5G speed mode Michael Sit Wei Hong 2021-04-05 11:29 ` Michael Sit Wei Hong 2021-04-05 13:11 ` [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac Andrew Lunn 2021-04-05 13:11 ` Andrew Lunn 2021-04-05 14:23 ` Sit, Michael Wei Hong [this message] 2021-04-05 14:23 ` Sit, Michael Wei Hong 2021-04-05 14:35 ` Andrew Lunn 2021-04-05 14:35 ` Andrew Lunn 2021-04-06 9:05 ` Voon, Weifeng 2021-04-06 9:05 ` Voon, Weifeng 2021-04-06 20:06 ` Andrew Lunn 2021-04-06 20:06 ` Andrew Lunn 2021-04-07 3:02 ` Voon, Weifeng 2021-04-07 3:02 ` Voon, Weifeng 2021-04-07 12:44 ` Andrew Lunn 2021-04-07 12:44 ` Andrew Lunn 2021-04-07 13:00 ` Russell King - ARM Linux admin 2021-04-07 13:00 ` Russell King - ARM Linux admin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CO1PR11MB5044B1F80C412E6F0CAFD5509D779@CO1PR11MB5044.namprd11.prod.outlook.com \ --to=michael.wei.hong.sit@intel.com \ --cc=alexandre.torgue@st.com \ --cc=andrew@lunn.ch \ --cc=boon.leong.ong@intel.com \ --cc=davem@davemloft.net \ --cc=fugang.duan@nxp.com \ --cc=hkallweit1@gmail.com \ --cc=joabreu@synopsys.com \ --cc=kim.tatt.chuah@intel.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux@armlinux.org.uk \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=qiangqing.zhang@nxp.com \ --cc=vee.khee.wong@intel.com \ --cc=weifeng.voon@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.