From: Yuval Mintz <Yuval.Mintz@qlogic.com> To: "sunil.kovvuri@gmail.com" <sunil.kovvuri@gmail.com>, netdev <netdev@vger.kernel.org> Cc: linux-kernel <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Sunil Goutham <sgoutham@cavium.com> Subject: RE: [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs Date: Thu, 11 Aug 2016 09:36:10 +0000 [thread overview] Message-ID: <CO2PR11MB008837F849AB5891E076DF41971E0@CO2PR11MB0088.namprd11.prod.outlook.com> (raw) In-Reply-To: <1470811373-28277-5-git-send-email-sunil.kovvuri@gmail.com> > 81xx has only 4 CPUs, so it doesn't make sense to initialize entire Qset i.e 8 > queues by default. Made changes to queue initialization to init queues equal to > number of CPUs or > 8 queues whichever is lesser. Also this will be applicable to VMs with VNIC VF > attached and having less VCPUs ... > - qcount = MAX_CMP_QUEUES_PER_QS; > + qcount = min_t(int, MAX_CMP_QUEUES_PER_QS, num_online_cpus()); We have netif_get_num_default_rss_queues() which does this.
WARNING: multiple messages have this Message-ID (diff)
From: Yuval.Mintz@qlogic.com (Yuval Mintz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs Date: Thu, 11 Aug 2016 09:36:10 +0000 [thread overview] Message-ID: <CO2PR11MB008837F849AB5891E076DF41971E0@CO2PR11MB0088.namprd11.prod.outlook.com> (raw) In-Reply-To: <1470811373-28277-5-git-send-email-sunil.kovvuri@gmail.com> > 81xx has only 4 CPUs, so it doesn't make sense to initialize entire Qset i.e 8 > queues by default. Made changes to queue initialization to init queues equal to > number of CPUs or > 8 queues whichever is lesser. Also this will be applicable to VMs with VNIC VF > attached and having less VCPUs ... > - qcount = MAX_CMP_QUEUES_PER_QS; > + qcount = min_t(int, MAX_CMP_QUEUES_PER_QS, num_online_cpus()); We have netif_get_num_default_rss_queues() which does this.
next prev parent reply other threads:[~2016-08-11 12:09 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-10 6:42 [PATCH 00/21] net: thunderx: Support for newer chips and miscellaneous patches sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 01/21] net: thunderx: Moved HW capability info from macros to structure sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 02/21] net: thunderx: Add VNIC's PCI devid on future chips sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 03/21] net: thunderx: Add support for 81xx and 83xx chips sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-11 9:36 ` Yuval Mintz [this message] 2016-08-11 9:36 ` Yuval Mintz 2016-08-11 9:36 ` Yuval Mintz 2016-08-11 9:57 ` Sunil Kovvuri 2016-08-11 9:57 ` Sunil Kovvuri 2016-08-11 9:57 ` Sunil Kovvuri 2016-08-10 6:42 ` [PATCH 05/21] net: thunderx: Enable CQE_RX desc's extension fields sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 06/21] net: thunderx: Enable mailbox interrupts on 81xx/83xx sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 07/21] net: thunderx: Support for different LMAC types within BGX sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 08/21] net: thunderx: Add 81xx support to BGX driver sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 09/21] net: thunderx: Add QSGMII interface type support sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 10/21] net: thunderx: Add RGMII " sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 11/21] net: thunderx: Add support for 16 LMACs of 83xx sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-11 2:45 ` kbuild test robot 2016-08-11 2:45 ` kbuild test robot 2016-08-11 2:45 ` kbuild test robot 2016-08-10 6:42 ` [PATCH 12/21] net: thunderx: Support for 83xx mixed QLM/DLM config sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 13/21] net: thunderx: Use netdev's name for naming VF's interrupts sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 14/21] net: thunderx: Use skb_add_rx_frag() for split buffer Rx pkts sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 15/21] net: thunderx: Improvement for MBX interface debug messages sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 16/21] net: thunderx: Reset RXQ HW stats when interface is brought down sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 17/21] net: thunderx: Don't set mac address for secondary Qset VFs sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 18/21] net: thunderx: Use napi_consume_skb for bulk free sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 19/21] net: thunderx: Configure tunnelling protocol parsing sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 20/21] net: thunderx: Use netdev_rss_key_fill() helper sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri 2016-08-10 6:42 ` [PATCH 21/21] net: thunderx: Don't set RX_PACKET_DIS while initializing sunil.kovvuri 2016-08-10 6:42 ` sunil.kovvuri at gmail.com 2016-08-10 6:42 ` sunil.kovvuri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CO2PR11MB008837F849AB5891E076DF41971E0@CO2PR11MB0088.namprd11.prod.outlook.com \ --to=yuval.mintz@qlogic.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=sgoutham@cavium.com \ --cc=sunil.kovvuri@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.