* [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result
@ 2021-07-06 15:25 Lee Shawn C
2021-07-06 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Lee Shawn C @ 2021-07-06 15:25 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou, William Tseng
After DPRX link training, intel_dp_link_train_phy() did not
return the training result properly. If link training failed,
i915 driver would not run into link train fallback function.
And no hotplug uevent would be received by user space application.
Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode link training")
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 08bceae40aa8..e44788b2c564 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -849,7 +849,7 @@ intel_dp_link_train_all_phys(struct intel_dp *intel_dp,
}
if (ret)
- intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
+ ret = intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
if (intel_dp->set_idle_link_train)
intel_dp->set_idle_link_train(intel_dp, crtc_state);
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: return proper DPRX link training result 2021-07-06 15:25 [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Lee Shawn C @ 2021-07-06 16:41 ` Patchwork 2021-07-06 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-07-06 23:21 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled 2 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2021-07-06 16:41 UTC (permalink / raw) To: Lee Shawn C; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2275 bytes --] == Series Details == Series: drm/i915/dp: return proper DPRX link training result URL : https://patchwork.freedesktop.org/series/92245/ State : success == Summary == CI Bug Log - changes from CI_DRM_10306 -> Patchwork_20537 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20537: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@kms_addfb_basic@too-wide: - {fi-tgl-1115g4}: [PASS][1] -> [DMESG-WARN][2] +88 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/fi-tgl-1115g4/igt@kms_addfb_basic@too-wide.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/fi-tgl-1115g4/igt@kms_addfb_basic@too-wide.html Known issues ------------ Here are the changes found in Patchwork_20537 that come from known issues: ### IGT changes ### {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1385]: https://gitlab.freedesktop.org/drm/intel/issues/1385 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 Participating hosts (41 -> 36) ------------------------------ Missing (5): fi-kbl-7567u fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10306 -> Patchwork_20537 CI-20190529: 20190529 CI_DRM_10306: 134ea1b1bddc580a8a246b05299291c9a7b0c7f5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6129: 687589e76f787d26ee2b539e551a9be06bd41ce3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20537: 20604bc02b52087dd40ce7964d5f67a018940a74 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 20604bc02b52 drm/i915/dp: return proper DPRX link training result == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/index.html [-- Attachment #1.2: Type: text/html, Size: 2678 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: return proper DPRX link training result 2021-07-06 15:25 [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Lee Shawn C 2021-07-06 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-07-06 20:51 ` Patchwork 2021-07-06 23:21 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled 2 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2021-07-06 20:51 UTC (permalink / raw) To: Lee Shawn C; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30275 bytes --] == Series Details == Series: drm/i915/dp: return proper DPRX link training result URL : https://patchwork.freedesktop.org/series/92245/ State : success == Summary == CI Bug Log - changes from CI_DRM_10306_full -> Patchwork_20537_full ==================================================== Summary ------- **SUCCESS** No regressions found. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20537_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_mmap_gtt@basic-small-bo-tiledx: - {shard-rkl}: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-6/igt@gem_mmap_gtt@basic-small-bo-tiledx.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-1/igt@gem_mmap_gtt@basic-small-bo-tiledx.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs: - {shard-rkl}: [FAIL][3] ([i915#3678]) -> [SKIP][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-2/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html Known issues ------------ Here are the changes found in Patchwork_20537_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@clone: - shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +4 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-snb7/igt@gem_ctx_persistence@clone.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#3063] / [i915#3648]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb7/igt@gem_eio@unwedge-stress.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-tglb6/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb3/igt@gem_exec_fair@basic-pace@vcs1.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-snb: NOTRUN -> [FAIL][12] ([i915#3633]) +2 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-snb6/igt@gem_exec_reloc@basic-wide-active@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][13] -> [SKIP][14] ([i915#2190]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb1/igt@gem_huc_copy@huc-copy.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-tglb6/igt@gem_huc_copy@huc-copy.html - shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#2190]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl8/igt@gem_huc_copy@huc-copy.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][16] ([i915#2658]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl6/igt@gem_pread@exhaustion.html * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [PASS][17] -> [FAIL][18] ([i915#454]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#1937]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][20] -> [INCOMPLETE][21] ([i915#2782]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-snb7/igt@i915_selftest@live@hangcheck.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-skl: NOTRUN -> [FAIL][22] ([i915#3722]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl2/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271]) +39 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-glk3/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_rc_ccs: - shard-skl: NOTRUN -> [FAIL][24] ([i915#3678]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl4/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_rc_ccs.html * igt@kms_cdclk@mode-transition: - shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271]) +126 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl2/igt@kms_cdclk@mode-transition.html * igt@kms_chamelium@dp-hpd-fast: - shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +4 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl8/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_chamelium@hdmi-mode-timings: - shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_color@pipe-a-ctm-0-75: - shard-skl: [PASS][28] -> [DMESG-WARN][29] ([i915#1982]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl10/igt@kms_color@pipe-a-ctm-0-75.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl5/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: - shard-snb: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +12 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-b-gamma: - shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +9 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl6/igt@kms_color_chamelium@pipe-b-gamma.html * igt@kms_color_chamelium@pipe-d-ctm-max: - shard-glk: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-glk3/igt@kms_color_chamelium@pipe-d-ctm-max.html * igt@kms_content_protection@atomic-dpms: - shard-kbl: NOTRUN -> [TIMEOUT][33] ([i915#1319]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_content_protection@atomic-dpms.html * igt@kms_content_protection@legacy: - shard-apl: NOTRUN -> [TIMEOUT][34] ([i915#1319]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl8/igt@kms_content_protection@legacy.html * igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding: - shard-tglb: [PASS][35] -> [DMESG-WARN][36] ([i915#2868]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html * igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge: - shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271]) +60 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl3/igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][38] -> [FAIL][39] ([i915#2346]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [PASS][40] -> [FAIL][41] ([i915#2346] / [i915#533]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-expired-vblank@c-edp1: - shard-skl: [PASS][42] -> [FAIL][43] ([i915#79]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][44] -> [DMESG-WARN][45] ([i915#180]) +6 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@b-dp1: - shard-apl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1: - shard-skl: [PASS][48] -> [FAIL][49] ([i915#2122]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl5/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl7/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-snb: NOTRUN -> [SKIP][50] ([fdo#109271]) +305 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-snb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile: - shard-skl: NOTRUN -> [INCOMPLETE][51] ([i915#3699]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt: - shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271]) +65 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl2/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render: - shard-skl: [PASS][53] -> [FAIL][54] ([i915#49]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html * igt@kms_hdr@bpc-switch: - shard-skl: NOTRUN -> [FAIL][55] ([i915#1188]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl2/igt@kms_hdr@bpc-switch.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d: - shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533]) +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl8/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-kbl: NOTRUN -> [FAIL][58] ([i915#265]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265]) +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-kbl: NOTRUN -> [FAIL][60] ([fdo#108145] / [i915#265]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [PASS][64] -> [SKIP][65] ([fdo#109441]) +3 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb2/igt@kms_psr@psr2_no_drrs.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb3/igt@kms_psr@psr2_no_drrs.html * igt@kms_sysfs_edid_timing: - shard-apl: NOTRUN -> [FAIL][66] ([IGT#2]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl2/igt@kms_sysfs_edid_timing.html * igt@kms_vblank@pipe-d-wait-idle: - shard-skl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#533]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl8/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-fb-id: - shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2437]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-glk3/igt@kms_writeback@writeback-fb-id.html - shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2437]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl3/igt@kms_writeback@writeback-fb-id.html - shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2437]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl2/igt@kms_writeback@writeback-fb-id.html * igt@sysfs_clients@create: - shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2994]) +2 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-apl6/igt@sysfs_clients@create.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-skl: [INCOMPLETE][72] ([i915#146] / [i915#198]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl5/igt@gem_ctx_isolation@preservation-s3@vecs0.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl8/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][74] ([i915#2842]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][76] ([i915#2842]) -> [PASS][77] [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-glk: [FAIL][78] ([i915#2842]) -> [PASS][79] [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk1/igt@gem_exec_fair@basic-pace@rcs0.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_reloc@basic-parallel: - shard-tglb: [TIMEOUT][80] ([i915#3737]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb7/igt@gem_exec_reloc@basic-parallel.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-tglb1/igt@gem_exec_reloc@basic-parallel.html * igt@gem_exec_reloc@basic-scanout@vecs0: - {shard-rkl}: [SKIP][82] ([i915#3639]) -> [PASS][83] +3 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@gem_exec_reloc@basic-scanout@vecs0.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@gem_exec_reloc@basic-scanout@vecs0.html * igt@gem_exec_whisper@basic-queues: - shard-glk: [DMESG-WARN][84] ([i915#118] / [i915#95]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk3/igt@gem_exec_whisper@basic-queues.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-glk5/igt@gem_exec_whisper@basic-queues.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-iclb: [FAIL][86] ([i915#2428]) -> [PASS][87] +1 similar issue [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy-odd.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_request_retire@retire-vma-not-inactive: - {shard-rkl}: [INCOMPLETE][88] -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@gem_request_retire@retire-vma-not-inactive.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-2/igt@gem_request_retire@retire-vma-not-inactive.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - {shard-rkl}: [SKIP][90] ([i915#3721]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_big_fb@y-tiled-8bpp-rotate-180: - {shard-rkl}: [SKIP][92] ([i915#3638]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html * igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs: - {shard-rkl}: [FAIL][94] ([i915#3678]) -> [PASS][95] +1 similar issue [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html * igt@kms_color@pipe-a-ctm-green-to-red: - {shard-rkl}: [SKIP][96] ([i915#1149] / [i915#1849]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_color@pipe-a-ctm-green-to-red.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_color@pipe-a-ctm-green-to-red.html * igt@kms_cursor_crc@pipe-c-cursor-dpms: - {shard-rkl}: [SKIP][98] ([fdo#112022]) -> [PASS][99] +7 similar issues [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-2/igt@kms_cursor_crc@pipe-c-cursor-dpms.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_cursor_crc@pipe-c-cursor-dpms.html * igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge: - {shard-rkl}: [SKIP][100] ([i915#1849]) -> [PASS][101] +18 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge.html * igt@kms_cursor_legacy@short-flip-before-cursor-toggle: - {shard-rkl}: [SKIP][102] ([fdo#111825]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_cursor_legacy@short-flip-before-cursor-toggle.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_cursor_legacy@short-flip-before-cursor-toggle.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled: - shard-skl: [FAIL][104] ([i915#3451]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl8/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl9/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled: - {shard-rkl}: [SKIP][106] ([fdo#111314]) -> [PASS][107] +3 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1: - shard-skl: [FAIL][108] ([i915#2122]) -> [PASS][109] +2 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [FAIL][110] ([i915#1188]) -> [PASS][111] [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl3/igt@kms_hdr@bpc-switch-suspend.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: - shard-kbl: [DMESG-WARN][112] ([i915#180]) -> [PASS][113] +2 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][114] ([fdo#108145] / [i915#265]) -> [PASS][115] +1 similar issue [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_cursor@pipe-b-overlay-size-64: - {shard-rkl}: [SKIP][116] ([i915#1845]) -> [PASS][117] +7 similar issues [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_plane_cursor@pipe-b-overlay-size-64.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_plane_cursor@pipe-b-overlay-size-64.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_psr@sprite_plane_move: - {shard-rkl}: [SKIP][120] ([i915#1072]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-5/igt@kms_psr@sprite_plane_move.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-6/igt@kms_psr@sprite_plane_move.html * igt@perf@polling-parameterized: - shard-skl: [FAIL][122] ([i915#1542]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl5/igt@perf@polling-parameterized.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl5/igt@perf@polling-parameterized.html * igt@perf@polling-small-buf: - shard-skl: [FAIL][124] ([i915#1722]) -> [PASS][125] [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl10/igt@perf@polling-small-buf.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl5/igt@perf@polling-small-buf.html * igt@perf_pmu@module-unload: - shard-skl: [DMESG-WARN][126] ([i915#1982] / [i915#262]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-skl5/igt@perf_pmu@module-unload.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-skl8/igt@perf_pmu@module-unload.html * igt@sysfs_timeslice_duration@timeout@vecs0: - {shard-rkl}: [FAIL][128] -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-rkl-2/igt@sysfs_timeslice_duration@timeout@vecs0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-rkl-2/igt@sysfs_timeslice_duration@timeout@vecs0.html #### Warnings #### * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][130] ([i915#2849]) -> [FAIL][131] ([i915#2842]) [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][132] ([i915#1804] / [i915#2684]) -> [WARN][133] ([i915#2684]) [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][134] ([i915#2684]) -> [WARN][135] ([i915#1804] / [i915#2684]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-0: - shard-iclb: [SKIP][136] ([i915#2920]) -> [SKIP][137] ([i915#658]) [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb3/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2: - shard-iclb: [SKIP][138] ([i915#658]) -> [SKIP][139] ([i915#2920]) +2 similar issues [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html * igt@runner@aborted: - shard-kbl: ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#2722] / [i915#3002] / [i915#3363]) -> ([FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#602]) [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl3/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl2/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl2/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl4/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl7/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl7/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl7/igt@runner@aborted.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl6/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl6/igt@runner@aborted.html [149]: http == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20537/index.html [-- Attachment #1.2: Type: text/html, Size: 33792 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-07-06 15:25 [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Lee Shawn C 2021-07-06 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-07-06 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-07-06 23:21 ` Almahallawy, Khaled 2021-07-07 1:33 ` Lee, Shawn C 2 siblings, 1 reply; 14+ messages in thread From: Almahallawy, Khaled @ 2021-07-06 23:21 UTC (permalink / raw) To: Lee, Shawn C, intel-gfx, Deak, Imre; +Cc: Chiou, Cooper, Tseng, William I believe Imre’s LT fallback: https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: https://chromium-review.googlesource.com/c/chromium/src/+/3003487 should address Chrome concerns for LT failure and LTTPRs Thanks Khaled On Tue, 2021-07-06 at 23:25 +0800, Lee Shawn C wrote: > After DPRX link training, intel_dp_link_train_phy() did not > return the training result properly. If link training failed, > i915 driver would not run into link train fallback function. > And no hotplug uevent would be received by user space application. > > Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode > link training") > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Cooper Chiou <cooper.chiou@intel.com> > Cc: William Tseng <william.tseng@intel.com> > Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index 08bceae40aa8..e44788b2c564 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -849,7 +849,7 @@ intel_dp_link_train_all_phys(struct intel_dp > *intel_dp, > } > > if (ret) > - intel_dp_link_train_phy(intel_dp, crtc_state, > DP_PHY_DPRX); > + ret = intel_dp_link_train_phy(intel_dp, crtc_state, > DP_PHY_DPRX); > > if (intel_dp->set_idle_link_train) > intel_dp->set_idle_link_train(intel_dp, crtc_state); _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-07-06 23:21 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled @ 2021-07-07 1:33 ` Lee, Shawn C 2021-08-18 15:09 ` Lee, Shawn C 0 siblings, 1 reply; 14+ messages in thread From: Lee, Shawn C @ 2021-07-07 1:33 UTC (permalink / raw) To: Almahallawy, Khaled, intel-gfx, Deak, Imre; +Cc: Chiou, Cooper, Tseng, William On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: >I believe Imre's LT fallback: >https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: >https://chromium-review.googlesource.com/c/chromium/src/+/3003487 >should address Chrome concerns for LT failure and LTTPRs > Thanks for comment! The new fallback patch should help on this DPRX problem. One more thing. If driver did not handle DPRX link train failed properly. It would impact link layer compliance test case in below. 400.3.1.3 400.3.1.4 400.3.1.6 400.3.1.12 400.3.1.13 400.3.1.14 Best regards, Shawn >Thanks >Khaled > >On Tue, 2021-07-06 at 23:25 +0800, Lee Shawn C wrote: >> After DPRX link training, intel_dp_link_train_phy() did not return the >> training result properly. If link training failed, >> i915 driver would not run into link train fallback function. >> And no hotplug uevent would be received by user space application. >> >> Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode >> link training") >> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> >> Cc: Imre Deak <imre.deak@intel.com> >> Cc: Jani Nikula <jani.nikula@linux.intel.com> >> Cc: Cooper Chiou <cooper.chiou@intel.com> >> Cc: William Tseng <william.tseng@intel.com> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> b/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> index 08bceae40aa8..e44788b2c564 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> @@ -849,7 +849,7 @@ intel_dp_link_train_all_phys(struct intel_dp >> *intel_dp, >> } >> >> if (ret) >> - intel_dp_link_train_phy(intel_dp, crtc_state, >> DP_PHY_DPRX); >> + ret = intel_dp_link_train_phy(intel_dp, crtc_state, >> DP_PHY_DPRX); >> >> if (intel_dp->set_idle_link_train) >> intel_dp->set_idle_link_train(intel_dp, crtc_state); > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-07-07 1:33 ` Lee, Shawn C @ 2021-08-18 15:09 ` Lee, Shawn C 2021-08-18 16:17 ` Imre Deak 0 siblings, 1 reply; 14+ messages in thread From: Lee, Shawn C @ 2021-08-18 15:09 UTC (permalink / raw) To: 20210706152541.25021-1-shawn.c.lee, Almahallawy, Khaled, intel-gfx, Deak, Imre Cc: Chiou, Cooper, Tseng, William On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: >>I believe Imre's LT fallback: >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 >>should address Chrome concerns for LT failure and LTTPRs >> > >Thanks for comment! The new fallback patch should help on this DPRX problem. >One more thing. If driver did not handle DPRX link train failed properly. >It would impact link layer compliance test case in below. > >400.3.1.3 >400.3.1.4 >400.3.1.6 >400.3.1.12 >400.3.1.13 >400.3.1.14 > >Best regards, >Shawn > Hi all, before Imre's patch series land on upstream driver. The link train failed handling works for LTTPR only. But DPRX does not. Could you please consider to have this change as temporary solution? Thanks! Best regards, Shawn >>Thanks >>Khaled >> >>On Tue, 2021-07-06 at 23:25 +0800, Lee Shawn C wrote: >>> After DPRX link training, intel_dp_link_train_phy() did not return >>> the training result properly. If link training failed, >>> i915 driver would not run into link train fallback function. >>> And no hotplug uevent would be received by user space application. >>> >>> Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode >>> link training") >>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> >>> Cc: Imre Deak <imre.deak@intel.com> >>> Cc: Jani Nikula <jani.nikula@linux.intel.com> >>> Cc: Cooper Chiou <cooper.chiou@intel.com> >>> Cc: William Tseng <william.tseng@intel.com> >>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> >>> --- >>> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c >>> b/drivers/gpu/drm/i915/display/intel_dp_link_training.c >>> index 08bceae40aa8..e44788b2c564 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c >>> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c >>> @@ -849,7 +849,7 @@ intel_dp_link_train_all_phys(struct intel_dp >>> *intel_dp, >>> } >>> >>> if (ret) >>> - intel_dp_link_train_phy(intel_dp, crtc_state, >>> DP_PHY_DPRX); >>> + ret = intel_dp_link_train_phy(intel_dp, crtc_state, >>> DP_PHY_DPRX); >>> >>> if (intel_dp->set_idle_link_train) >>> intel_dp->set_idle_link_train(intel_dp, crtc_state); >> >_______________________________________________ >Intel-gfx mailing list >Intel-gfx@lists.freedesktop.org >https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-18 15:09 ` Lee, Shawn C @ 2021-08-18 16:17 ` Imre Deak 2021-08-20 22:20 ` Ville Syrjälä 0 siblings, 1 reply; 14+ messages in thread From: Imre Deak @ 2021-08-18 16:17 UTC (permalink / raw) To: 20210706152541.25021-1-shawn.c.lee Cc: Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: > >>I believe Imre's LT fallback: > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > >>should address Chrome concerns for LT failure and LTTPRs > >> > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > >One more thing. If driver did not handle DPRX link train failed properly. > >It would impact link layer compliance test case in below. > > > >400.3.1.3 > >400.3.1.4 > >400.3.1.6 > >400.3.1.12 > >400.3.1.13 > >400.3.1.14 > > > >Best regards, > >Shawn > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > handling works for LTTPR only. But DPRX does not. Could you please consider to have > this change as temporary solution? Thanks! I sent already fixing this, see https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ but it fell through the cracks. Applied now your patch, thanks. > > Best regards, > Shawn > > >>Thanks > >>Khaled > >> > >>On Tue, 2021-07-06 at 23:25 +0800, Lee Shawn C wrote: > >>> After DPRX link training, intel_dp_link_train_phy() did not return > >>> the training result properly. If link training failed, > >>> i915 driver would not run into link train fallback function. > >>> And no hotplug uevent would be received by user space application. > >>> > >>> Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode > >>> link training") > >>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > >>> Cc: Imre Deak <imre.deak@intel.com> > >>> Cc: Jani Nikula <jani.nikula@linux.intel.com> > >>> Cc: Cooper Chiou <cooper.chiou@intel.com> > >>> Cc: William Tseng <william.tseng@intel.com> > >>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> > >>> --- > >>> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > >>> b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > >>> index 08bceae40aa8..e44788b2c564 100644 > >>> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > >>> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > >>> @@ -849,7 +849,7 @@ intel_dp_link_train_all_phys(struct intel_dp > >>> *intel_dp, > >>> } > >>> > >>> if (ret) > >>> - intel_dp_link_train_phy(intel_dp, crtc_state, > >>> DP_PHY_DPRX); > >>> + ret = intel_dp_link_train_phy(intel_dp, crtc_state, > >>> DP_PHY_DPRX); > >>> > >>> if (intel_dp->set_idle_link_train) > >>> intel_dp->set_idle_link_train(intel_dp, crtc_state); > >> > >_______________________________________________ > >Intel-gfx mailing list > >Intel-gfx@lists.freedesktop.org > >https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-18 16:17 ` Imre Deak @ 2021-08-20 22:20 ` Ville Syrjälä 2021-08-20 23:02 ` Imre Deak 2021-08-23 8:38 ` Saarinen, Jani 0 siblings, 2 replies; 14+ messages in thread From: Ville Syrjälä @ 2021-08-20 22:20 UTC (permalink / raw) To: Imre Deak Cc: Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: > > >>I believe Imre's LT fallback: > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > >>should address Chrome concerns for LT failure and LTTPRs > > >> > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > >One more thing. If driver did not handle DPRX link train failed properly. > > >It would impact link layer compliance test case in below. > > > > > >400.3.1.3 > > >400.3.1.4 > > >400.3.1.6 > > >400.3.1.12 > > >400.3.1.13 > > >400.3.1.14 > > > > > >Best regards, > > >Shawn > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > > handling works for LTTPR only. But DPRX does not. Could you please consider to have > > this change as temporary solution? Thanks! > > I sent already fixing this, see > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ > > but it fell through the cracks. Applied now your patch, thanks. We seem to have a tgl that fails consistently at DPRX link training: https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html Previously the error went unnoticed. -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-20 22:20 ` Ville Syrjälä @ 2021-08-20 23:02 ` Imre Deak 2021-08-26 17:31 ` Rodrigo Vivi 2021-08-30 6:45 ` Imre Deak 2021-08-23 8:38 ` Saarinen, Jani 1 sibling, 2 replies; 14+ messages in thread From: Imre Deak @ 2021-08-20 23:02 UTC (permalink / raw) To: Ville Syrjälä Cc: Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: > > > >>I believe Imre's LT fallback: > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > > >>should address Chrome concerns for LT failure and LTTPRs > > > >> > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > >It would impact link layer compliance test case in below. > > > > > > > >400.3.1.3 > > > >400.3.1.4 > > > >400.3.1.6 > > > >400.3.1.12 > > > >400.3.1.13 > > > >400.3.1.14 > > > > > > > >Best regards, > > > >Shawn > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > > > handling works for LTTPR only. But DPRX does not. Could you please consider to have > > > this change as temporary solution? Thanks! > > > > I sent already fixing this, see > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ > > > > but it fell through the cracks. Applied now your patch, thanks. > > We seem to have a tgl that fails consistently at DPRX link training: > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html > > Previously the error went unnoticed. Yea, didn't notice this. Can't see anything obvious, besides that it's a DPCD rev 1.1 monitor, so maybe not compatible with LTTPRs. I follow up if I find something. > > -- > Ville Syrjälä > Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-20 23:02 ` Imre Deak @ 2021-08-26 17:31 ` Rodrigo Vivi 2021-08-30 6:45 ` Imre Deak 1 sibling, 0 replies; 14+ messages in thread From: Rodrigo Vivi @ 2021-08-26 17:31 UTC (permalink / raw) To: Imre Deak Cc: Ville Syrjälä, Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William On Sat, Aug 21, 2021 at 02:02:03AM +0300, Imre Deak wrote: > On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > > > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: > > > > >>I believe Imre's LT fallback: > > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > > > >>should address Chrome concerns for LT failure and LTTPRs > > > > >> > > > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > > >It would impact link layer compliance test case in below. > > > > > > > > > >400.3.1.3 > > > > >400.3.1.4 > > > > >400.3.1.6 > > > > >400.3.1.12 > > > > >400.3.1.13 > > > > >400.3.1.14 > > > > > > > > > >Best regards, > > > > >Shawn > > > > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > > > > handling works for LTTPR only. But DPRX does not. Could you please consider to have > > > > this change as temporary solution? Thanks! > > > > > > I sent already fixing this, see > > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ > > > > > > but it fell through the cracks. Applied now your patch, thanks. > > > > We seem to have a tgl that fails consistently at DPRX link training: > > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html > > > > Previously the error went unnoticed. > > Yea, didn't notice this. Can't see anything obvious, besides that it's a > DPCD rev 1.1 monitor, so maybe not compatible with LTTPRs. I follow up > if I find something. I opened this thread exactly to tell that I'm avoiding this patch on this week's pull request targeting 5.14 exactly because I saw something strange with CI_DIF_604 on TGL that doesn't happen without this patch CI_DIF_603. Since I don't know what's going on there I'm also avoiding d7f213c131ad ("drm/i915/dp: Use max params for panels < eDP 1.4") just in case... > > > > > -- > > Ville Syrjälä > > Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-20 23:02 ` Imre Deak 2021-08-26 17:31 ` Rodrigo Vivi @ 2021-08-30 6:45 ` Imre Deak 2021-08-30 7:05 ` Saarinen, Jani 1 sibling, 1 reply; 14+ messages in thread From: Imre Deak @ 2021-08-30 6:45 UTC (permalink / raw) To: Ville Syrjälä Cc: Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William On Sat, Aug 21, 2021 at 02:02:03AM +0300, Imre Deak wrote: > On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > > > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote: > > > > >>I believe Imre's LT fallback: > > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > > > >>should address Chrome concerns for LT failure and LTTPRs > > > > >> > > > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > > >It would impact link layer compliance test case in below. > > > > > > > > > >400.3.1.3 > > > > >400.3.1.4 > > > > >400.3.1.6 > > > > >400.3.1.12 > > > > >400.3.1.13 > > > > >400.3.1.14 > > > > > > > > > >Best regards, > > > > >Shawn > > > > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > > > > handling works for LTTPR only. But DPRX does not. Could you please consider to have > > > > this change as temporary solution? Thanks! > > > > > > I sent already fixing this, see > > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ > > > > > > but it fell through the cracks. Applied now your patch, thanks. > > > > We seem to have a tgl that fails consistently at DPRX link training: > > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html > > > > Previously the error went unnoticed. > > Yea, didn't notice this. Can't see anything obvious, besides that it's a > DPCD rev 1.1 monitor, so maybe not compatible with LTTPRs. I follow up > if I find something. Power cycling the machine and replugging the monitor and Type C dongle and native DP cable fixed it. So, it could be a flaky connection (unlikely, because detection worked), or the port in a stuck state even across warm-reboots. The latter would mean the machine wasn't power cycled for a long time and that's likely because the pstore kernel didn't boot (grub failed to load it due to a missing initrd). One possibile root cause is the TypeC PHY getting stuck across warm reboots issue (and nothing recovering it besides a power-cycle), that was fixed by 151ec347b06a2fb ("drm/i915: Force a TypeC PHY disconnect during suspend/shutdown") I'll re-check this after more CI testruns. > > -- > > Ville Syrjälä > > Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-30 6:45 ` Imre Deak @ 2021-08-30 7:05 ` Saarinen, Jani 0 siblings, 0 replies; 14+ messages in thread From: Saarinen, Jani @ 2021-08-30 7:05 UTC (permalink / raw) To: Deak, Imre, Ville Syrjälä Cc: Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William Hi, > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Imre Deak > Sent: maanantai 30. elokuuta 2021 9.45 > To: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Lee, Shawn C <shawn.c.lee@intel.com>; Almahallawy, Khaled > <khaled.almahallawy@intel.com>; intel-gfx@lists.freedesktop.org; Chiou, Cooper > <cooper.chiou@intel.com>; Tseng, William <william.tseng@intel.com> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result > > On Sat, Aug 21, 2021 at 02:02:03AM +0300, Imre Deak wrote: > > On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > > > > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> > wrote: > > > > > >>I believe Imre's LT fallback: > > > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and > Chrome user space fix: > > > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003 > > > > > >>487 should address Chrome concerns for LT failure and LTTPRs > > > > > >> > > > > > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX > problem. > > > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > > > >It would impact link layer compliance test case in below. > > > > > > > > > > > >400.3.1.3 > > > > > >400.3.1.4 > > > > > >400.3.1.6 > > > > > >400.3.1.12 > > > > > >400.3.1.13 > > > > > >400.3.1.14 > > > > > > > > > > > >Best regards, > > > > > >Shawn > > > > > > > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The > > > > > link train failed handling works for LTTPR only. But DPRX does > > > > > not. Could you please consider to have this change as temporary solution? > Thanks! > > > > > > > > I sent already fixing this, see > > > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.de > > > > ak@intel.com/ > > > > > > > > but it fell through the cracks. Applied now your patch, thanks. > > > > > > We seem to have a tgl that fails consistently at DPRX link training: > > > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html > > > > > > Previously the error went unnoticed. > > > > Yea, didn't notice this. Can't see anything obvious, besides that it's > > a DPCD rev 1.1 monitor, so maybe not compatible with LTTPRs. I follow > > up if I find something. > > Power cycling the machine and replugging the monitor and Type C dongle and native > DP cable fixed it. So, it could be a flaky connection (unlikely, because detection > worked), or the port in a stuck state even across warm-reboots. The latter would > mean the machine wasn't power cycled for a long time and that's likely because the > pstore kernel didn't boot (grub failed to load it due to a missing initrd). Thanks Imre for checking. > > One possibile root cause is the TypeC PHY getting stuck across warm reboots issue > (and nothing recovering it besides a power-cycle), that was fixed by > 151ec347b06a2fb ("drm/i915: Force a TypeC PHY disconnect during > suspend/shutdown") > > I'll re-check this after more CI testruns. Ack but now looks indeed green again. > > > > -- > > > Ville Syrjälä > > > Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-20 22:20 ` Ville Syrjälä 2021-08-20 23:02 ` Imre Deak @ 2021-08-23 8:38 ` Saarinen, Jani 2021-08-23 15:13 ` Vudum, Lakshminarayana 1 sibling, 1 reply; 14+ messages in thread From: Saarinen, Jani @ 2021-08-23 8:38 UTC (permalink / raw) To: Ville Syrjälä, Deak, Imre, Vudum, Lakshminarayana Cc: Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William Hi, > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjälä > Sent: lauantai 21. elokuuta 2021 1.20 > To: Deak, Imre <imre.deak@intel.com> > Cc: Lee, Shawn C <shawn.c.lee@intel.com>; Almahallawy, Khaled > <khaled.almahallawy@intel.com>; intel-gfx@lists.freedesktop.org; Chiou, Cooper > <cooper.chiou@intel.com>; Tseng, William <william.tseng@intel.com> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> > wrote: > > > >>I believe Imre's LT fallback: > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome > user space fix: > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > > >>should address Chrome concerns for LT failure and LTTPRs > > > >> > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > >It would impact link layer compliance test case in below. > > > > > > > >400.3.1.3 > > > >400.3.1.4 > > > >400.3.1.6 > > > >400.3.1.12 > > > >400.3.1.13 > > > >400.3.1.14 > > > > > > > >Best regards, > > > >Shawn > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link > > > train failed handling works for LTTPR only. But DPRX does not. Could > > > you please consider to have this change as temporary solution? Thanks! > > > > I sent already fixing this, see > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@i > > ntel.com/ > > > > but it fell through the cracks. Applied now your patch, thanks. > > We seem to have a tgl that fails consistently at DPRX link training: > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html Yes, @Vudum, Lakshminarayana what is gitlab issue for this? > > Previously the error went unnoticed. > > -- > Ville Syrjälä > Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result 2021-08-23 8:38 ` Saarinen, Jani @ 2021-08-23 15:13 ` Vudum, Lakshminarayana 0 siblings, 0 replies; 14+ messages in thread From: Vudum, Lakshminarayana @ 2021-08-23 15:13 UTC (permalink / raw) To: Saarinen, Jani, Ville Syrjälä, Deak, Imre Cc: Lee, Shawn C, Almahallawy, Khaled, intel-gfx, Chiou, Cooper, Tseng, William Here is the gitlab issue https://gitlab.freedesktop.org/drm/intel/-/issues/4002 Lakshmi. -----Original Message----- From: Saarinen, Jani <jani.saarinen@intel.com> Sent: Monday, August 23, 2021 1:39 AM To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Deak, Imre <imre.deak@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Cc: Lee, Shawn C <shawn.c.lee@intel.com>; Almahallawy, Khaled <khaled.almahallawy@intel.com>; intel-gfx@lists.freedesktop.org; Chiou, Cooper <cooper.chiou@intel.com>; Tseng, William <william.tseng@intel.com> Subject: RE: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Hi, > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Ville Syrjälä > Sent: lauantai 21. elokuuta 2021 1.20 > To: Deak, Imre <imre.deak@intel.com> > Cc: Lee, Shawn C <shawn.c.lee@intel.com>; Almahallawy, Khaled > <khaled.almahallawy@intel.com>; intel-gfx@lists.freedesktop.org; > Chiou, Cooper <cooper.chiou@intel.com>; Tseng, William > <william.tseng@intel.com> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link > training result > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote: > > > >On Tue, 2021-07-07, Almahallawy, Khaled > > > ><khaled.almahallawy@intel.com> > wrote: > > > >>I believe Imre's LT fallback: > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix > > > >>and Chrome > user space fix: > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/300348 > > > >>7 should address Chrome concerns for LT failure and LTTPRs > > > >> > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > >It would impact link layer compliance test case in below. > > > > > > > >400.3.1.3 > > > >400.3.1.4 > > > >400.3.1.6 > > > >400.3.1.12 > > > >400.3.1.13 > > > >400.3.1.14 > > > > > > > >Best regards, > > > >Shawn > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The > > > link train failed handling works for LTTPR only. But DPRX does > > > not. Could you please consider to have this change as temporary solution? Thanks! > > > > I sent already fixing this, see > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak > > @i > > ntel.com/ > > > > but it fell through the cracks. Applied now your patch, thanks. > > We seem to have a tgl that fails consistently at DPRX link training: > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html Yes, @Vudum, Lakshminarayana what is gitlab issue for this? [Lakshmi] https://gitlab.freedesktop.org/drm/intel/-/issues/4002 > > Previously the error went unnoticed. > > -- > Ville Syrjälä > Intel ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-08-30 7:05 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-06 15:25 [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Lee Shawn C 2021-07-06 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-07-06 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-07-06 23:21 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled 2021-07-07 1:33 ` Lee, Shawn C 2021-08-18 15:09 ` Lee, Shawn C 2021-08-18 16:17 ` Imre Deak 2021-08-20 22:20 ` Ville Syrjälä 2021-08-20 23:02 ` Imre Deak 2021-08-26 17:31 ` Rodrigo Vivi 2021-08-30 6:45 ` Imre Deak 2021-08-30 7:05 ` Saarinen, Jani 2021-08-23 8:38 ` Saarinen, Jani 2021-08-23 15:13 ` Vudum, Lakshminarayana
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.