All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dsi: unregister gmbus if LFP display was MIPI panel
@ 2021-09-16 10:21 Lee Shawn C
  2021-09-16 10:32 ` Jani Nikula
                   ` (15 more replies)
  0 siblings, 16 replies; 22+ messages in thread
From: Lee Shawn C @ 2021-09-16 10:21 UTC (permalink / raw)
  To: intel-gfx
  Cc: Lee Shawn C, Jani Nikula, Vandita Kulkarni, Cooper Chiou, William Tseng

Gmbus driver would setup all Intel i2c GMBuses. But DDC bus
may configured as gpio and reserved for MIPI driver to control
panel power on/off sequence.

Using i2c tool to communicate to peripherals via i2c interface
reversed for gmbus(DDC). There will be some high/low pulse
appear on DDC SCL and SDA (might be host sent out i2c slave
address). MIPI panel would be impacted due to unexpected signal
then caused abnormal display or shut down issue.

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index 060bc8fb0d30..d2504e291fcb 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1999,6 +1999,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
 	struct intel_connector *intel_connector;
 	struct drm_connector *connector;
 	struct drm_display_mode *fixed_mode;
+	struct intel_gmbus *bus;
 	enum port port;
 
 	if (!intel_bios_is_dsi_present(dev_priv, &port))
@@ -2092,6 +2093,19 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
 	icl_dphy_param_init(intel_dsi);
 
 	icl_dsi_add_properties(intel_connector);
+
+	/*
+	 * DDC bus may configured as gpio and reserved for MIPI driver
+	 * to control panel power on/off sequence. so, unregister gmbus
+	 * if MIPI was LFP display.
+	 */
+	bus = &dev_priv->gmbus[GMBUS_PIN_1_BXT];
+	i2c_del_adapter(&bus->adapter);
+
+	if (dev_priv->vbt.dsi.config->dual_link) {
+		bus = &dev_priv->gmbus[GMBUS_PIN_2_BXT];
+		i2c_del_adapter(&bus->adapter);
+	}
 	return;
 
 err:
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2021-10-05  1:29 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 10:21 [Intel-gfx] [PATCH] drm/i915/dsi: unregister gmbus if LFP display was MIPI panel Lee Shawn C
2021-09-16 10:32 ` Jani Nikula
2021-09-16 11:03   ` Lee, Shawn C
2021-09-16 11:12     ` Jani Nikula
2021-09-16 10:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-16 12:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-16 14:08 ` [Intel-gfx] [PATCH] drm/i915/dsi: do not register gmbus if it was reserved for MIPI display Lee Shawn C
2021-09-16 20:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: unregister gmbus if LFP display was MIPI panel (rev2) Patchwork
2021-09-16 20:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-09-16 21:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-17  0:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-17  4:35 ` [Intel-gfx] [PATCH] drm/i915/dsi: do not register gmbus if it was reserved for MIPI display Lee Shawn C
2021-09-17 10:59   ` Jani Nikula
2021-09-17 12:35     ` Lee, Shawn C
2021-09-17  4:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: unregister gmbus if LFP display was MIPI panel (rev3) Patchwork
2021-09-17  5:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-17  6:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-23  2:33 ` [Intel-gfx] [v4] drm/i915/dsi: do not register gmbus if it was reserved for MIPI display Lee Shawn C
2021-10-05  1:28   ` Lee, Shawn C
2021-09-23  3:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: unregister gmbus if LFP display was MIPI panel (rev4) Patchwork
2021-09-23  3:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-23  5:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.