* [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS
@ 2021-08-02 2:53 Kevin Wang
2021-08-02 7:41 ` Lazar, Lijo
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wang @ 2021-08-02 2:53 UTC (permalink / raw)
To: amd-gfx, lijo.lazar; +Cc: Kevin Wang
correct smu feature mapping: FEATURE_DATA_CALCULATIONS
Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
---
drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 +
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h b/drivers/gpu/drm/amd/pm/inc/smu_types.h
index 1d3765b873df..6239c30fcd5f 100644
--- a/drivers/gpu/drm/amd/pm/inc/smu_types.h
+++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h
@@ -282,6 +282,7 @@ enum smu_clk_type {
__SMU_DUMMY_MAP(TDC), \
__SMU_DUMMY_MAP(THERMAL), \
__SMU_DUMMY_MAP(GFX_PER_CU_CG), \
+ __SMU_DUMMY_MAP(DATA_CALCULATIONS), \
__SMU_DUMMY_MAP(RM), \
__SMU_DUMMY_MAP(DS_DCEFCLK), \
__SMU_DUMMY_MAP(ACDC), \
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
index 856eeaf293b8..4af602d6ee02 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
@@ -64,7 +64,6 @@
#define FEATURE_MASK(feature) (1ULL << feature)
#define SMC_DPM_FEATURE ( \
- FEATURE_MASK(FEATURE_DATA_CALCULATIONS) | \
FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT) | \
FEATURE_MASK(FEATURE_DPM_UCLK_BIT) | \
FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT) | \
@@ -150,7 +149,7 @@ static const struct cmn2asic_mapping aldebaran_clk_map[SMU_CLK_COUNT] = {
};
static const struct cmn2asic_mapping aldebaran_feature_mask_map[SMU_FEATURE_COUNT] = {
- ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_PREFETCHER_BIT, FEATURE_DATA_CALCULATIONS),
+ ALDEBARAN_FEA_MAP(SMU_FEATURE_DATA_CALCULATIONS_BIT, FEATURE_DATA_CALCULATIONS),
ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_GFXCLK_BIT, FEATURE_DPM_GFXCLK_BIT),
ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_UCLK_BIT, FEATURE_DPM_UCLK_BIT),
ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_SOCCLK_BIT, FEATURE_DPM_SOCCLK_BIT),
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS
2021-08-02 2:53 [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS Kevin Wang
@ 2021-08-02 7:41 ` Lazar, Lijo
2021-08-02 7:42 ` Wang, Kevin(Yang)
0 siblings, 1 reply; 3+ messages in thread
From: Lazar, Lijo @ 2021-08-02 7:41 UTC (permalink / raw)
To: Kevin Wang, amd-gfx
On 8/2/2021 8:23 AM, Kevin Wang wrote:
> correct smu feature mapping: FEATURE_DATA_CALCULATIONS
>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 +
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h b/drivers/gpu/drm/amd/pm/inc/smu_types.h
> index 1d3765b873df..6239c30fcd5f 100644
> --- a/drivers/gpu/drm/amd/pm/inc/smu_types.h
> +++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h
> @@ -282,6 +282,7 @@ enum smu_clk_type {
> __SMU_DUMMY_MAP(TDC), \
> __SMU_DUMMY_MAP(THERMAL), \
> __SMU_DUMMY_MAP(GFX_PER_CU_CG), \
> + __SMU_DUMMY_MAP(DATA_CALCULATIONS), \
> __SMU_DUMMY_MAP(RM), \
> __SMU_DUMMY_MAP(DS_DCEFCLK), \
> __SMU_DUMMY_MAP(ACDC), \
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 856eeaf293b8..4af602d6ee02 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -64,7 +64,6 @@
>
> #define FEATURE_MASK(feature) (1ULL << feature)
> #define SMC_DPM_FEATURE ( \
> - FEATURE_MASK(FEATURE_DATA_CALCULATIONS) | \
Data calculations should be enabled for DPM. Undo this change before
submitting.
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
> FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT) | \
> FEATURE_MASK(FEATURE_DPM_UCLK_BIT) | \
> FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT) | \
> @@ -150,7 +149,7 @@ static const struct cmn2asic_mapping aldebaran_clk_map[SMU_CLK_COUNT] = {
> };
>
> static const struct cmn2asic_mapping aldebaran_feature_mask_map[SMU_FEATURE_COUNT] = {
> - ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_PREFETCHER_BIT, FEATURE_DATA_CALCULATIONS),
> + ALDEBARAN_FEA_MAP(SMU_FEATURE_DATA_CALCULATIONS_BIT, FEATURE_DATA_CALCULATIONS),
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_GFXCLK_BIT, FEATURE_DPM_GFXCLK_BIT),
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_UCLK_BIT, FEATURE_DPM_UCLK_BIT),
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_SOCCLK_BIT, FEATURE_DPM_SOCCLK_BIT),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS
2021-08-02 7:41 ` Lazar, Lijo
@ 2021-08-02 7:42 ` Wang, Kevin(Yang)
0 siblings, 0 replies; 3+ messages in thread
From: Wang, Kevin(Yang) @ 2021-08-02 7:42 UTC (permalink / raw)
To: Lazar, Lijo, amd-gfx
[-- Attachment #1: Type: text/plain, Size: 3076 bytes --]
[AMD Official Use Only]
________________________________
From: Lazar, Lijo <Lijo.Lazar@amd.com>
Sent: Monday, August 2, 2021 3:41 PM
To: Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS
On 8/2/2021 8:23 AM, Kevin Wang wrote:
> correct smu feature mapping: FEATURE_DATA_CALCULATIONS
>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 +
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h b/drivers/gpu/drm/amd/pm/inc/smu_types.h
> index 1d3765b873df..6239c30fcd5f 100644
> --- a/drivers/gpu/drm/amd/pm/inc/smu_types.h
> +++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h
> @@ -282,6 +282,7 @@ enum smu_clk_type {
> __SMU_DUMMY_MAP(TDC), \
> __SMU_DUMMY_MAP(THERMAL), \
> __SMU_DUMMY_MAP(GFX_PER_CU_CG), \
> + __SMU_DUMMY_MAP(DATA_CALCULATIONS), \
> __SMU_DUMMY_MAP(RM), \
> __SMU_DUMMY_MAP(DS_DCEFCLK), \
> __SMU_DUMMY_MAP(ACDC), \
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 856eeaf293b8..4af602d6ee02 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -64,7 +64,6 @@
>
> #define FEATURE_MASK(feature) (1ULL << feature)
> #define SMC_DPM_FEATURE ( \
> - FEATURE_MASK(FEATURE_DATA_CALCULATIONS) | \
Data calculations should be enabled for DPM. Undo this change before
submitting.
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
[kevin]:
thanks, lijo. I agree with you, and I will correct it before submit.
Best Regards,
Kevin
> FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT) | \
> FEATURE_MASK(FEATURE_DPM_UCLK_BIT) | \
> FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT) | \
> @@ -150,7 +149,7 @@ static const struct cmn2asic_mapping aldebaran_clk_map[SMU_CLK_COUNT] = {
> };
>
> static const struct cmn2asic_mapping aldebaran_feature_mask_map[SMU_FEATURE_COUNT] = {
> - ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_PREFETCHER_BIT, FEATURE_DATA_CALCULATIONS),
> + ALDEBARAN_FEA_MAP(SMU_FEATURE_DATA_CALCULATIONS_BIT, FEATURE_DATA_CALCULATIONS),
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_GFXCLK_BIT, FEATURE_DPM_GFXCLK_BIT),
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_UCLK_BIT, FEATURE_DPM_UCLK_BIT),
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_SOCCLK_BIT, FEATURE_DPM_SOCCLK_BIT),
>
[-- Attachment #2: Type: text/html, Size: 7041 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-02 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 2:53 [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS Kevin Wang
2021-08-02 7:41 ` Lazar, Lijo
2021-08-02 7:42 ` Wang, Kevin(Yang)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.