[REGRESSION] NULL pointer dereference drm_dp_add_payload_part2

[REGRESSION] NULL pointer dereference drm_dp_add_payload_part2

[Leon Weiß]

Hello,

54d217406afe250d7a768783baaa79a035f21d38 fixed an issue in
drm_dp_add_payload_part2 that lead to a NULL pointer dereference in
case state is NULL.

The change was (accidentally?) reverted in
5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49 and the problem reappeared.

The issue is rather spurious, but I've had it appear when unplugging a
thunderbolt dock.

#regzbot introduced 5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49

Re: [REGRESSION] NULL pointer dereference drm_dp_add_payload_part2

[Lin, Wayne]

[Public]

Hi,

Thanks for the catch! Will prepare a patch to fix it.

Thanks,
Wayne Lin

________________________________________
From: Leon Weiß <leon.weiss@ruhr-uni-bochum.de>
Sent: Wednesday, February 7, 2024 16:45
To: stable@vger.kernel.org
Cc: regressions@lists.linux.dev; Lin, Wayne; lyude@redhat.com
Subject: [REGRESSION] NULL pointer dereference drm_dp_add_payload_part2

Hello,

54d217406afe250d7a768783baaa79a035f21d38 fixed an issue in
drm_dp_add_payload_part2 that lead to a NULL pointer dereference in
case state is NULL.

The change was (accidentally?) reverted in
5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49 and the problem reappeared.

The issue is rather spurious, but I've had it appear when unplugging a
thunderbolt dock.

#regzbot introduced 5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49

Re: [REGRESSION] NULL pointer dereference drm_dp_add_payload_part2

[Linux regression tracking (Thorsten Leemhuis)]

On 19.02.24 08:24, Lin, Wayne wrote:
> 
> Thanks for the catch! Will prepare a patch to fix it.

Did you do that? I could not find one on lore, but maybe I'm missing
something.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

> ________________________________________
> From: Leon Weiß <leon.weiss@ruhr-uni-bochum.de>
> Sent: Wednesday, February 7, 2024 16:45
> To: stable@vger.kernel.org
> Cc: regressions@lists.linux.dev; Lin, Wayne; lyude@redhat.com
> Subject: [REGRESSION] NULL pointer dereference drm_dp_add_payload_part2
> 
> Hello,
> 
> 54d217406afe250d7a768783baaa79a035f21d38 fixed an issue in
> drm_dp_add_payload_part2 that lead to a NULL pointer dereference in
> case state is NULL.
> 
> The change was (accidentally?) reverted in
> 5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49 and the problem reappeared.
> 
> The issue is rather spurious, but I've had it appear when unplugging a
> thunderbolt dock.
> 
> #regzbot introduced 5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49
> 
> 

RE: [REGRESSION] NULL pointer dereference drm_dp_add_payload_part2

[Lin, Wayne]

[Public]

> -----Original Message-----
> From: Linux regression tracking (Thorsten Leemhuis)
> <regressions@leemhuis.info>
> Sent: Wednesday, February 28, 2024 3:53 PM
> To: Lin, Wayne <Wayne.Lin@amd.com>; Leon Weiß <leon.weiss@ruhr-uni-
> bochum.de>; stable@vger.kernel.org
> Cc: regressions@lists.linux.dev; lyude@redhat.com
> Subject: Re: [REGRESSION] NULL pointer dereference
> drm_dp_add_payload_part2
>
> On 19.02.24 08:24, Lin, Wayne wrote:
> >
> > Thanks for the catch! Will prepare a patch to fix it.
>
> Did you do that? I could not find one on lore, but maybe I'm missing
> something.
Hi,
Sorry for the delay. Was dragged and distracted by other works.
Just pushed the patch today for code review. Thanks!

>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>
> > ________________________________________
> > From: Leon Weiß <leon.weiss@ruhr-uni-bochum.de>
> > Sent: Wednesday, February 7, 2024 16:45
> > To: stable@vger.kernel.org
> > Cc: regressions@lists.linux.dev; Lin, Wayne; lyude@redhat.com
> > Subject: [REGRESSION] NULL pointer dereference
> > drm_dp_add_payload_part2
> >
> > Hello,
> >
> > 54d217406afe250d7a768783baaa79a035f21d38 fixed an issue in
> > drm_dp_add_payload_part2 that lead to a NULL pointer dereference in
> > case state is NULL.
> >
> > The change was (accidentally?) reverted in
> > 5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49 and the problem
> reappeared.
> >
> > The issue is rather spurious, but I've had it appear when unplugging a
> > thunderbolt dock.
> >
> > #regzbot introduced 5aa1dfcdf0a429e4941e2eef75b006a8c7a8ac49
> >
> >