Re: [dpdk-dev] [PATCH v2 5/5] cryptodev: move device specific structures

[Akhil Goyal <gakhil@marvell.com>]

> > +struct rte_cryptodev_data {
> > +	/** Device ID for this instance */
> > +	uint8_t dev_id;
> > +	/** Socket ID where memory is allocated */
> > +	uint8_t socket_id;
> > +	/** Unique identifier name */
> > +	char name[RTE_CRYPTODEV_NAME_MAX_LEN];
> > +
> > +	__extension__
> > +	/** Device state: STARTED(1)/STOPPED(0) */
> > +	uint8_t dev_started : 1;
> > +
> > +	/** Session memory pool */
> > +	struct rte_mempool *session_pool;
> 
> Looks like we never used this pool ever - shall we take this chance to remove
> it?

It is getting used in qp release which checks if all sessions are cleared before releasing the QP.

> 
> > +	/** Array of pointers to queue pairs. */
> > +	void **queue_pairs;
> > +	/** Number of device queue pairs. */
> > +	uint16_t nb_queue_pairs;
> 
> queue_pairs are likely the only item we use rte_cryptodev_data in the fast-
> path.
> Also take this chance to move it to the beginning of the structure?

As per latest design, rte_cryptodev_data will not be used in fast path.
In control path, all data path params are set in the fp_array.
Hence no need to change.


> 
> > +
> > +	/** PMD-specific private data */
> > +	void *dev_private;
> > +} __rte_cache_aligned;
> > +
> 
> Not really comments but some suggestions - could be done in the future as
> the
> structure is moved to internal in this patchset.
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>