From: Appana Durga Kedareswara Rao <appanad@xilinx.com> To: Alan Tull <atull@kernel.org> Cc: Moritz Fischer <moritz.fischer@ettus.com>, Nava kishore Manne <navam@xilinx.com>, Michal Simek <michals@xilinx.com>, "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback Date: Thu, 26 Jul 2018 05:20:45 +0000 [thread overview] Message-ID: <CY1PR02MB16924F2F3373AD7EB059A088DC2B0@CY1PR02MB1692.namprd02.prod.outlook.com> (raw) In-Reply-To: <CANk1AXTvVQz5PpX_HqWQ2SKJePizbk6JmHyp3mOAZ0DZA=en5Q@mail.gmail.com> Hi Alan, Thanks for the review... <Snip> > > In Zynq Case it supports two types of the readback (Configuration registers, > Configuration data(fpga image)) which may not be the same case for other > vendors. > > Since I need to support both the use cases I have differentiated them using > module param in the zynq-fpga driver. > > > > As you said we shouldn't change the attribute's function, So in the > > zynq-fpga driver, I am planning to add another debugfs attribute for > reading back of configuration registers as it is vendor specific readback type. > > (Configuration registers ---- Usage: > /sys/kernel/debug/fpga/zynq-fpga/cfgreg_summary) > > Is it called '...summary' because it is not all the registers? Could just be > "cfg_regs"? Sure will make it cfg_regs... Are you ok with the above proposal?? if you are ok will make changes accordingly and will post v4... > > > (Configuration data(fpga image) ---- Usage: > /sys/kernel/debug/fpga/fpga0/image) > > Please let me know your thoughts for the same... > > > >> > >> > One other option is sysfs. Do you want me to implement sysfs path??? > >> > Any other suggestions??? > >> > >> You could implement another sysfs attribute for reading FPGA registers > >> with a separate ops callback. Please clarify what it is doing (not > >> all FPGAs have this function) and what that will look like when the > >> user reads the from the sysfs > > > > AFAIK we shouldn't add another sysfs/debugfs attribute for vendor-specific > readback type in the FPGA manager ops. > > Please correct me if my understanding is wrong. > > You are not wrong :) Thanks 😊 Regards, Kedar. > > > > > Regards, > > Kedar. > > > >> > >> Alan
WARNING: multiple messages have this Message-ID (diff)
From: appanad@xilinx.com (Appana Durga Kedareswara Rao) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback Date: Thu, 26 Jul 2018 05:20:45 +0000 [thread overview] Message-ID: <CY1PR02MB16924F2F3373AD7EB059A088DC2B0@CY1PR02MB1692.namprd02.prod.outlook.com> (raw) In-Reply-To: <CANk1AXTvVQz5PpX_HqWQ2SKJePizbk6JmHyp3mOAZ0DZA=en5Q@mail.gmail.com> Hi Alan, Thanks for the review... <Snip> > > In Zynq Case it supports two types of the readback (Configuration registers, > Configuration data(fpga image)) which may not be the same case for other > vendors. > > Since I need to support both the use cases I have differentiated them using > module param in the zynq-fpga driver. > > > > As you said we shouldn't change the attribute's function, So in the > > zynq-fpga driver, I am planning to add another debugfs attribute for > reading back of configuration registers as it is vendor specific readback type. > > (Configuration registers ---- Usage: > /sys/kernel/debug/fpga/zynq-fpga/cfgreg_summary) > > Is it called '...summary' because it is not all the registers? Could just be > "cfg_regs"? Sure will make it cfg_regs... Are you ok with the above proposal?? if you are ok will make changes accordingly and will post v4... > > > (Configuration data(fpga image) ---- Usage: > /sys/kernel/debug/fpga/fpga0/image) > > Please let me know your thoughts for the same... > > > >> > >> > One other option is sysfs. Do you want me to implement sysfs path??? > >> > Any other suggestions??? > >> > >> You could implement another sysfs attribute for reading FPGA registers > >> with a separate ops callback. Please clarify what it is doing (not > >> all FPGAs have this function) and what that will look like when the > >> user reads the from the sysfs > > > > AFAIK we shouldn't add another sysfs/debugfs attribute for vendor-specific > readback type in the FPGA manager ops. > > Please correct me if my understanding is wrong. > > You are not wrong :) Thanks ? Regards, Kedar. > > > > > Regards, > > Kedar. > > > >> > >> Alan
next prev parent reply other threads:[~2018-07-26 5:21 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-24 14:17 [PATCH v3 1/2] fpga: fpga-mgr: Add readback support Appana Durga Kedareswara rao 2018-07-24 14:17 ` Appana Durga Kedareswara rao 2018-07-24 14:17 ` Appana Durga Kedareswara rao 2018-07-24 14:17 ` [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback Appana Durga Kedareswara rao 2018-07-24 14:17 ` Appana Durga Kedareswara rao 2018-07-24 14:17 ` Appana Durga Kedareswara rao 2018-07-24 16:32 ` Moritz Fischer 2018-07-24 16:32 ` Moritz Fischer 2018-07-24 18:31 ` Appana Durga Kedareswara Rao 2018-07-24 18:31 ` Appana Durga Kedareswara Rao 2018-07-24 18:49 ` Alan Tull 2018-07-24 18:49 ` Alan Tull 2018-07-25 9:12 ` Appana Durga Kedareswara Rao 2018-07-25 9:12 ` Appana Durga Kedareswara Rao 2018-07-25 15:35 ` Alan Tull 2018-07-25 15:35 ` Alan Tull 2018-07-26 5:20 ` Appana Durga Kedareswara Rao [this message] 2018-07-26 5:20 ` Appana Durga Kedareswara Rao 2018-07-24 18:52 ` Alan Tull 2018-07-24 18:52 ` Alan Tull 2018-07-24 18:52 ` Alan Tull 2018-07-25 9:13 ` Appana Durga Kedareswara Rao 2018-07-25 9:13 ` Appana Durga Kedareswara Rao 2018-07-25 9:13 ` Appana Durga Kedareswara Rao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CY1PR02MB16924F2F3373AD7EB059A088DC2B0@CY1PR02MB1692.namprd02.prod.outlook.com \ --to=appanad@xilinx.com \ --cc=atull@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michals@xilinx.com \ --cc=moritz.fischer@ettus.com \ --cc=navam@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.