* [PATCH] Standardizing the info message for unimplemented functions
@ 2016-08-07 21:17 Alexandre Demers
[not found] ` <20160807211741.5485-1-alexandre.f.demers-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Demers @ 2016-08-07 21:17 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
index 07e0475..9e327be 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
@@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] = {
static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
u32 block_offset, u32 reg)
{
- DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
return 0;
}
static void dce_v6_0_audio_endpt_wreg(struct amdgpu_device *adev,
u32 block_offset, u32 reg, u32 v)
{
- DRM_INFO("xxxx: dce_v6_0_audio_endpt_wreg ----no impl!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_endpt_wreg --- not implemented!\n");
}
static bool dce_v6_0_is_in_vblank(struct amdgpu_device *adev, int crtc)
@@ -459,7 +459,7 @@ static u32 dce_v6_0_hpd_get_gpio_reg(struct amdgpu_device *adev)
static bool dce_v6_0_is_display_hung(struct amdgpu_device *adev)
{
- DRM_INFO("xxxx: dce_v6_0_is_display_hung ----no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_is_display_hung --- not implemented!\n");
return true;
}
@@ -1321,17 +1321,17 @@ static void dce_v6_0_afmt_audio_select_pin(struct drm_encoder *encoder)
static void dce_v6_0_audio_write_latency_fields(struct drm_encoder *encoder,
struct drm_display_mode *mode)
{
- DRM_INFO("xxxx: dce_v6_0_audio_write_latency_fields---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_write_latency_fields --- not implemented!\n");
}
static void dce_v6_0_audio_write_speaker_allocation(struct drm_encoder *encoder)
{
- DRM_INFO("xxxx: dce_v6_0_audio_write_speaker_allocation---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_write_speaker_allocation --- not implemented!\n");
}
static void dce_v6_0_audio_write_sad_regs(struct drm_encoder *encoder)
{
- DRM_INFO("xxxx: dce_v6_0_audio_write_sad_regs---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_write_sad_regs --- not implemented!\n");
}
*/
@@ -1339,7 +1339,7 @@ static void dce_v6_0_audio_enable(struct amdgpu_device *adev,
struct amdgpu_audio_pin *pin,
bool enable)
{
- DRM_INFO("xxxx: dce_v6_0_audio_enable---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_enable --- not implemented!\n");
}
static const u32 pin_offsets[7] =
@@ -1376,12 +1376,12 @@ static void dce_v6_0_afmt_update_ACR(struct drm_encoder *encoder, uint32_t clock
static void dce_v6_0_afmt_update_avi_infoframe(struct drm_encoder *encoder,
void *buffer, size_t size)
{
- DRM_INFO("xxxx: dce_v6_0_afmt_update_avi_infoframe---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_afmt_update_avi_infoframe --- not implemented!\n");
}
static void dce_v6_0_audio_set_dto(struct drm_encoder *encoder, u32 clock)
{
- DRM_INFO("xxxx: dce_v6_0_audio_set_dto---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_set_dto --- not implemented!\n");
}
*/
/*
@@ -1390,7 +1390,7 @@ static void dce_v6_0_audio_set_dto(struct drm_encoder *encoder, u32 clock)
static void dce_v6_0_afmt_setmode(struct drm_encoder *encoder,
struct drm_display_mode *mode)
{
- DRM_INFO("xxxx: dce_v6_0_afmt_setmode ----no impl !!!!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_afmt_setmode --- not implemented!\n");
}
static void dce_v6_0_afmt_enable(struct drm_encoder *encoder, bool enable)
@@ -2553,7 +2553,7 @@ static int dce_v6_0_wait_for_idle(void *handle)
static int dce_v6_0_soft_reset(void *handle)
{
- DRM_INFO("xxxx: dce_v6_0_soft_reset --- no impl!!\n");
+ DRM_INFO("xxxx: dce_v6_0_soft_reset --- not implemented!\n");
return 0;
}
--
2.9.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* 答复: [PATCH] Standardizing the info message for unimplemented functions
[not found] ` <20160807211741.5485-1-alexandre.f.demers-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-08-08 2:35 ` Wang, Ken
2016-08-08 5:22 ` Huang Rui
1 sibling, 0 replies; 4+ messages in thread
From: Wang, Ken @ 2016-08-08 2:35 UTC (permalink / raw)
To: Alexandre Demers, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 4764 bytes --]
Reviewed-by: Ken Wang <Qingqing.Wang@amd.com>
________________________________
发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Alexandre Demers <alexandre.f.demers@gmail.com>
发送时间: 2016年8月8日 5:17:41
收件人: amd-gfx@lists.freedesktop.org
主题: [PATCH] Standardizing the info message for unimplemented functions
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
index 07e0475..9e327be 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
@@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] = {
static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
u32 block_offset, u32 reg)
{
- DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
return 0;
}
static void dce_v6_0_audio_endpt_wreg(struct amdgpu_device *adev,
u32 block_offset, u32 reg, u32 v)
{
- DRM_INFO("xxxx: dce_v6_0_audio_endpt_wreg ----no impl!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_endpt_wreg --- not implemented!\n");
}
static bool dce_v6_0_is_in_vblank(struct amdgpu_device *adev, int crtc)
@@ -459,7 +459,7 @@ static u32 dce_v6_0_hpd_get_gpio_reg(struct amdgpu_device *adev)
static bool dce_v6_0_is_display_hung(struct amdgpu_device *adev)
{
- DRM_INFO("xxxx: dce_v6_0_is_display_hung ----no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_is_display_hung --- not implemented!\n");
return true;
}
@@ -1321,17 +1321,17 @@ static void dce_v6_0_afmt_audio_select_pin(struct drm_encoder *encoder)
static void dce_v6_0_audio_write_latency_fields(struct drm_encoder *encoder,
struct drm_display_mode *mode)
{
- DRM_INFO("xxxx: dce_v6_0_audio_write_latency_fields---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_write_latency_fields --- not implemented!\n");
}
static void dce_v6_0_audio_write_speaker_allocation(struct drm_encoder *encoder)
{
- DRM_INFO("xxxx: dce_v6_0_audio_write_speaker_allocation---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_write_speaker_allocation --- not implemented!\n");
}
static void dce_v6_0_audio_write_sad_regs(struct drm_encoder *encoder)
{
- DRM_INFO("xxxx: dce_v6_0_audio_write_sad_regs---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_write_sad_regs --- not implemented!\n");
}
*/
@@ -1339,7 +1339,7 @@ static void dce_v6_0_audio_enable(struct amdgpu_device *adev,
struct amdgpu_audio_pin *pin,
bool enable)
{
- DRM_INFO("xxxx: dce_v6_0_audio_enable---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_enable --- not implemented!\n");
}
static const u32 pin_offsets[7] =
@@ -1376,12 +1376,12 @@ static void dce_v6_0_afmt_update_ACR(struct drm_encoder *encoder, uint32_t clock
static void dce_v6_0_afmt_update_avi_infoframe(struct drm_encoder *encoder,
void *buffer, size_t size)
{
- DRM_INFO("xxxx: dce_v6_0_afmt_update_avi_infoframe---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_afmt_update_avi_infoframe --- not implemented!\n");
}
static void dce_v6_0_audio_set_dto(struct drm_encoder *encoder, u32 clock)
{
- DRM_INFO("xxxx: dce_v6_0_audio_set_dto---no imp!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_audio_set_dto --- not implemented!\n");
}
*/
/*
@@ -1390,7 +1390,7 @@ static void dce_v6_0_audio_set_dto(struct drm_encoder *encoder, u32 clock)
static void dce_v6_0_afmt_setmode(struct drm_encoder *encoder,
struct drm_display_mode *mode)
{
- DRM_INFO("xxxx: dce_v6_0_afmt_setmode ----no impl !!!!!!!!\n");
+ DRM_INFO("xxxx: dce_v6_0_afmt_setmode --- not implemented!\n");
}
static void dce_v6_0_afmt_enable(struct drm_encoder *encoder, bool enable)
@@ -2553,7 +2553,7 @@ static int dce_v6_0_wait_for_idle(void *handle)
static int dce_v6_0_soft_reset(void *handle)
{
- DRM_INFO("xxxx: dce_v6_0_soft_reset --- no impl!!\n");
+ DRM_INFO("xxxx: dce_v6_0_soft_reset --- not implemented!\n");
return 0;
}
--
2.9.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 9159 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Standardizing the info message for unimplemented functions
[not found] ` <20160807211741.5485-1-alexandre.f.demers-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-08 2:35 ` 答复: " Wang, Ken
@ 2016-08-08 5:22 ` Huang Rui
2016-08-08 14:34 ` Alexandre Demers
1 sibling, 1 reply; 4+ messages in thread
From: Huang Rui @ 2016-08-08 5:22 UTC (permalink / raw)
To: Alexandre Demers; +Cc: Ken Wang, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Sun, Aug 07, 2016 at 05:17:41PM -0400, Alexandre Demers wrote:
> Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
>
> ---
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> index 07e0475..9e327be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> @@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] = {
> static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
> u32 block_offset, u32 reg)
> {
> - DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
> + DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
> return 0;
We can make the code more simple like below:
DRM_INFO("xxxx: %s --- not implemented!\n", __func__);
Thanks,
Rui
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Standardizing the info message for unimplemented functions
2016-08-08 5:22 ` Huang Rui
@ 2016-08-08 14:34 ` Alexandre Demers
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Demers @ 2016-08-08 14:34 UTC (permalink / raw)
To: Huang Rui; +Cc: Ken Wang, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 1350 bytes --]
On Mon, 8 Aug 2016 at 01:22 Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org> wrote:
> On Sun, Aug 07, 2016 at 05:17:41PM -0400, Alexandre Demers wrote:
> > Signed-off-by: Alexandre Demers <alexandre.f.demers-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > ---
> > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > index 07e0475..9e327be 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > @@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] =
> {
> > static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
> > u32 block_offset, u32 reg)
> > {
> > - DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
> > + DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
> > return 0;
>
> We can make the code more simple like below:
>
> DRM_INFO("xxxx: %s --- not implemented!\n", __func__);
>
> Thanks,
> Rui
>
I like your suggestion. I'll send a v2 later, I also saw that I had missed
one or two of them.
That being said, I have other work that I'll send in the next few days for
review.
Cheers,
Alexandre Demers
[-- Attachment #1.2: Type: text/html, Size: 1964 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-08 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-07 21:17 [PATCH] Standardizing the info message for unimplemented functions Alexandre Demers
[not found] ` <20160807211741.5485-1-alexandre.f.demers-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-08 2:35 ` 答复: " Wang, Ken
2016-08-08 5:22 ` Huang Rui
2016-08-08 14:34 ` Alexandre Demers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.