All of lore.kernel.org
 help / color / mirror / Atom feed
From: Parshuram Raju Thombare <pthombar@cadence.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "kishon@ti.com" <kishon@ti.com>, Tom Joseph <tjoseph@cadence.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"kw@linux.com" <kw@linux.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Milind Parab <mparab@cadence.com>
Subject: RE: [PATCH] PCI: cadence: Disable Function Level Reset support
Date: Wed, 20 Oct 2021 03:38:47 +0000	[thread overview]
Message-ID: <CY4PR07MB27579495272871B120875A83C1BE9@CY4PR07MB2757.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20211018194218.GA2248370@bhelgaas>

>Add blank lines between paragraphs.
>Write the text in imperative mood, e.g.,

Ok

>  Disable FLR (Function Level Reset) support on all functions.
>It looks like this patch clears PCI_EXP_DEVCAP_FLR in the Device
>Capabilities register.  From the point of view of Linux, that means
>the device doesn't *advertise* FLR support.
>
>That's different from actualy *disabling* FLR support, but maybe
>there's internal logic in the device that ignores
>PCI_EXP_DEVCTL_BCR_FLR when PCI_EXP_DEVCAP_FLR is cleared?

Yes, this patch is just to prevent device from advertising FLR support.

Regards,
Parshuram Thombare

WARNING: multiple messages have this Message-ID (diff)
From: Parshuram Raju Thombare <pthombar@cadence.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "kishon@ti.com" <kishon@ti.com>, Tom Joseph <tjoseph@cadence.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"kw@linux.com" <kw@linux.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Milind Parab <mparab@cadence.com>
Subject: RE: [PATCH] PCI: cadence: Disable Function Level Reset support
Date: Wed, 20 Oct 2021 03:38:47 +0000	[thread overview]
Message-ID: <CY4PR07MB27579495272871B120875A83C1BE9@CY4PR07MB2757.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20211018194218.GA2248370@bhelgaas>

>Add blank lines between paragraphs.
>Write the text in imperative mood, e.g.,

Ok

>  Disable FLR (Function Level Reset) support on all functions.
>It looks like this patch clears PCI_EXP_DEVCAP_FLR in the Device
>Capabilities register.  From the point of view of Linux, that means
>the device doesn't *advertise* FLR support.
>
>That's different from actualy *disabling* FLR support, but maybe
>there's internal logic in the device that ignores
>PCI_EXP_DEVCTL_BCR_FLR when PCI_EXP_DEVCAP_FLR is cleared?

Yes, this patch is just to prevent device from advertising FLR support.

Regards,
Parshuram Thombare

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-20  3:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 18:07 [PATCH] PCI: cadence: Disable Function Level Reset support Parshuram Raju Thombare
2021-10-18 18:07 ` Parshuram Raju Thombare
2021-10-18 19:42 ` Bjorn Helgaas
2021-10-18 19:42   ` Bjorn Helgaas
2021-10-20  3:38   ` Parshuram Raju Thombare [this message]
2021-10-20  3:38     ` Parshuram Raju Thombare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR07MB27579495272871B120875A83C1BE9@CY4PR07MB2757.namprd07.prod.outlook.com \
    --to=pthombar@cadence.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kishon@ti.com \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mparab@cadence.com \
    --cc=robh@kernel.org \
    --cc=tjoseph@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.