* [PATCH] ACPICA: make acpi_protocol_lengths static
@ 2020-04-15 8:49 Jason Yan
2020-04-15 9:24 ` [Devel] " Rafael J. Wysocki
2020-04-15 16:09 ` Kaneda, Erik
0 siblings, 2 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-15 8:49 UTC (permalink / raw)
To: robert.moore, erik.kaneda, rafael.j.wysocki, lenb, linux-acpi,
devel, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following sparse warning:
drivers/acpi/acpica/exfield.c:25:10: warning: symbol
'acpi_protocol_lengths' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/acpi/acpica/exfield.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
index e85eb31e5075..3323a2ba6a31 100644
--- a/drivers/acpi/acpica/exfield.c
+++ b/drivers/acpi/acpica/exfield.c
@@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
*/
#define ACPI_INVALID_PROTOCOL_ID 0x80
#define ACPI_MAX_PROTOCOL_ID 0x0F
-const u8 acpi_protocol_lengths[] = {
+static const u8 acpi_protocol_lengths[] = {
ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
0x00, /* 2 - ATTRIB_QUICK */
--
2.21.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPICA: make acpi_protocol_lengths static
@ 2020-04-15 9:24 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2020-04-15 9:24 UTC (permalink / raw)
To: Jason Yan, Robert Moore, Erik Kaneda
Cc: Rafael Wysocki, Len Brown, ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Linux Kernel Mailing List, Hulk Robot
On Wed, Apr 15, 2020 at 10:23 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol
> 'acpi_protocol_lengths' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Erik, Bob, this one is yours. :-)
> ---
> drivers/acpi/acpica/exfield.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
> index e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> */
> #define ACPI_INVALID_PROTOCOL_ID 0x80
> #define ACPI_MAX_PROTOCOL_ID 0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
> ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
> ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
> 0x00, /* 2 - ATTRIB_QUICK */
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Devel] Re: [PATCH] ACPICA: make acpi_protocol_lengths static
@ 2020-04-15 9:24 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2020-04-15 9:24 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
On Wed, Apr 15, 2020 at 10:23 AM Jason Yan <yanaijie(a)huawei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol
> 'acpi_protocol_lengths' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci(a)huawei.com>
> Signed-off-by: Jason Yan <yanaijie(a)huawei.com>
Erik, Bob, this one is yours. :-)
> ---
> drivers/acpi/acpica/exfield.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
> index e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> */
> #define ACPI_INVALID_PROTOCOL_ID 0x80
> #define ACPI_MAX_PROTOCOL_ID 0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
> ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
> ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
> 0x00, /* 2 - ATTRIB_QUICK */
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ACPICA: make acpi_protocol_lengths static
2020-04-15 8:49 [PATCH] ACPICA: make acpi_protocol_lengths static Jason Yan
2020-04-15 9:24 ` [Devel] " Rafael J. Wysocki
@ 2020-04-15 16:09 ` Kaneda, Erik
1 sibling, 0 replies; 4+ messages in thread
From: Kaneda, Erik @ 2020-04-15 16:09 UTC (permalink / raw)
To: Jason Yan, Moore, Robert, Wysocki, Rafael J, lenb, linux-acpi,
devel, linux-kernel
Cc: Hulk Robot
> -----Original Message-----
> From: Jason Yan <yanaijie@huawei.com>
> Sent: Wednesday, April 15, 2020 1:50 AM
> To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik
> <erik.kaneda@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> lenb@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; linux-
> kernel@vger.kernel.org
> Cc: Jason Yan <yanaijie@huawei.com>; Hulk Robot <hulkci@huawei.com>
> Subject: [PATCH] ACPICA: make acpi_protocol_lengths static
>
> Fix the following sparse warning:
>
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol 'acpi_protocol_lengths'
> was not declared. Should it be static?
This has already been reported and I've made the appropriate fix in the ACPICA code base already. it should be available in the next ACPICA release
Thanks,
Erik
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/acpi/acpica/exfield.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c index
> e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> */
> #define ACPI_INVALID_PROTOCOL_ID 0x80
> #define ACPI_MAX_PROTOCOL_ID 0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
> ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
> ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
> 0x00, /* 2 - ATTRIB_QUICK */
> --
> 2.21.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-15 16:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:49 [PATCH] ACPICA: make acpi_protocol_lengths static Jason Yan
2020-04-15 9:24 ` Rafael J. Wysocki
2020-04-15 9:24 ` [Devel] " Rafael J. Wysocki
2020-04-15 16:09 ` Kaneda, Erik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.