* Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd)
@ 2017-06-30 4:29 Julia Lawall
2017-06-30 6:51 ` Ganesh GR
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2017-06-30 4:29 UTC (permalink / raw)
To: Atul Gupta; +Cc: netdev, davem, venkatesh, Ganesh Goudar, kbuild-all
The complete context isn't shown, but it seems likely that there is a goto
out_free under line 1207, with no unlock on &adap->ptp_lock.
julia
---------- Forwarded message ----------
Date: Fri, 30 Jun 2017 11:54:23 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support
Hi Atul,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-PTP-Hardware-Clock-PHC-support/20170629-200758
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
>> drivers/net/ethernet/chelsio/cxgb4/sge.c:1190:2-8: preceding lock on line 1204
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 159226c60ceb77858018f6c31d17a575b3679b8a
vim +1190 drivers/net/ethernet/chelsio/cxgb4/sge.c
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1184 /*
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1185 * The chip min packet length is 10 octets but play safe and reject
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1186 * anything shorter than an Ethernet header.
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1187 */
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1188 if (unlikely(skb->len < ETH_HLEN)) {
a7525198a drivers/net/ethernet/chelsio/cxgb4/sge.c Eric W. Biederman 2014-03-15 1189 out_free: dev_kfree_skb_any(skb);
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 @1190 return NETDEV_TX_OK;
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1191 }
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1192
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1193 /* Discard the packet if the length is greater than mtu */
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1194 max_pkt_len = ETH_HLEN + dev->mtu;
8d09e6b8b drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2016-07-28 1195 if (skb_vlan_tagged(skb))
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1196 max_pkt_len += VLAN_HLEN;
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1197 if (!skb_shinfo(skb)->gso_size && (unlikely(skb->len > max_pkt_len)))
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1198 goto out_free;
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1199
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1200 pi = netdev_priv(dev);
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1201 adap = pi->adapter;
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1202 qidx = skb_get_queue_mapping(skb);
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1203 if (ptp_enabled) {
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 @1204 spin_lock(&adap->ptp_lock);
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1205 if (!(adap->ptp_tx_skb)) {
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1206 skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1207 adap->ptp_tx_skb = skb_get(skb);
:::::: The code at line 1190 was first introduced by commit
:::::: fd3a47900b6f9fa72a4074ecb630f9dae62f1a95 cxgb4: Add packet queues and packet DMA code
:::::: TO: Dimitris Michailidis <dm@chelsio.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd)
2017-06-30 4:29 [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd) Julia Lawall
@ 2017-06-30 6:51 ` Ganesh GR
0 siblings, 0 replies; 2+ messages in thread
From: Ganesh GR @ 2017-06-30 6:51 UTC (permalink / raw)
To: Julia Lawall, Atul Gupta; +Cc: netdev, davem, Venkatesh Pottem, kbuild-all
Yes unlock missing in couple of places, Thanks Julia.
Ganesh
From: Julia Lawall <julia.lawall@lip6.fr>
Sent: Friday, June 30, 2017 9:59 AM
To: Atul Gupta
Cc: netdev@vger.kernel.org; davem@davemloft.net; Venkatesh Pottem; Ganesh GR; kbuild-all@01.org
Subject: Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd)
The complete context isn't shown, but it seems likely that there is a goto
out_free under line 1207, with no unlock on &adap->ptp_lock.
julia
---------- Forwarded message ----------
Date: Fri, 30 Jun 2017 11:54:23 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support
Hi Atul,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-PTP-Hardware-Clock-PHC-support/20170629-200758
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
>> drivers/net/ethernet/chelsio/cxgb4/sge.c:1190:2-8: preceding lock on line 1204
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 159226c60ceb77858018f6c31d17a575b3679b8a
vim +1190 drivers/net/ethernet/chelsio/cxgb4/sge.c
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1184 /*
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1185 * The chip min packet length is 10 octets but play safe and reject
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1186 * anything shorter than an Ethernet header.
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1187 */
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1188 if (unlikely(skb->len < ETH_HLEN)) {
a7525198a drivers/net/ethernet/chelsio/cxgb4/sge.c Eric W. Biederman 2014-03-15 1189 out_free: dev_kfree_skb_any(skb);
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 @1190 return NETDEV_TX_OK;
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1191 }
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1192
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1193 /* Discard the packet if the length is greater than mtu */
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1194 max_pkt_len = ETH_HLEN + dev->mtu;
8d09e6b8b drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2016-07-28 1195 if (skb_vlan_tagged(skb))
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1196 max_pkt_len += VLAN_HLEN;
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1197 if (!skb_shinfo(skb)->gso_size && (unlikely(skb->len > max_pkt_len)))
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1198 goto out_free;
637d3e997 drivers/net/ethernet/chelsio/cxgb4/sge.c Hariprasad Shenai 2015-05-05 1199
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1200 pi = netdev_priv(dev);
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1201 adap = pi->adapter;
fd3a47900 drivers/net/cxgb4/sge.c Dimitris Michailidis 2010-04-01 1202 qidx = skb_get_queue_mapping(skb);
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1203 if (ptp_enabled) {
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 @1204 spin_lock(&adap->ptp_lock);
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1205 if (!(adap->ptp_tx_skb)) {
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1206 skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
159226c60 drivers/net/ethernet/chelsio/cxgb4/sge.c Atul Gupta 2017-06-28 1207 adap->ptp_tx_skb = skb_get(skb);
:::::: The code at line 1190 was first introduced by commit
:::::: fd3a47900b6f9fa72a4074ecb630f9dae62f1a95 cxgb4: Add packet queues and packet DMA code
:::::: TO: Dimitris Michailidis <dm@chelsio.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-30 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 4:29 [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd) Julia Lawall
2017-06-30 6:51 ` Ganesh GR
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.