RE: [PATCH] drm/amdgpu: show gfx clock gating status to user

["Zhu, Rex" <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 3798 bytes --]

Sorry, update.

User just need to know the cg/pg feature's state(enable/disable), not current CG state.



Best Regards

Rex



-----Original Message-----
From: Zhu, Rex
Sent: Thursday, January 05, 2017 11:34 AM
To: Huang, Ray; Deucher, Alexander
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; Mao, David; Fu, Ping
Subject: RE: [PATCH] drm/amdgpu: show gfx clock gating status to user



As talked with David. They not only need to know whether the CG/PG is supported, but also need to know  those features state(enabled/disabled) (not current CG/PG state).



we added the profile mode, so in runtime, user can disable/enable cg.

Then user wanted to confirm the feature's state



So we may need to export cg/pg mask and feature's state.



Best Regards

Rex





-----Original Message-----

From: Huang Rui [mailto:ray.huang-5C7GfCeVMHo@public.gmane.org]

Sent: Wednesday, January 04, 2017 10:22 AM

To: Deucher, Alexander

Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>; Zhu, Rex; Mao, David; Fu, Ping

Subject: Re: [PATCH] drm/amdgpu: show gfx clock gating status to user



On Tue, Jan 03, 2017 at 11:02:09PM +0800, Deucher, Alexander wrote:

> > -----Original Message-----

> > From: Huang Rui [mailto:ray.huang-5C7GfCeVMHo@public.gmane.org]

> > Sent: Tuesday, January 03, 2017 5:47 AM

> > To: Deucher, Alexander; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx@lists.freedesktop.org>

> > Cc: Zhu, Rex; Mao, David; Fu, Ping; Huang, Ray

> > Subject: [PATCH] drm/amdgpu: show gfx clock gating status to user

> >

> > Signed-off-by: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org<mailto:ray.huang-5C7GfCeVMHo@public.gmane.org>>

> > ---

> >  drivers/gpu/drm/amd/amdgpu/amdgpu.h    | 1 +

> >  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 5 +++++

> > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c  | 2 ++

> > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c  | 2 ++

> > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c  | 3 +++

> >  5 files changed, 13 insertions(+)

> >

> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h

> > b/drivers/gpu/drm/amd/amdgpu/amdgpu.h

> > index 96eeea7..989d311 100644

> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h

> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h

> > @@ -1033,6 +1033,7 @@ struct amdgpu_gfx {

> >          struct amdgpu_irq_src              priv_inst_irq;

> >          /* gfx status */

> >          uint32_t                     gfx_current_status;

> > +          bool                             cg_enabled;

> >          /* ce ram size*/

> >          unsigned                     ce_ram_size;

> >          struct amdgpu_cu_info             cu_info;

> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

> > index a7c7657..10f2eab 100644

> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

> > @@ -1543,6 +1543,11 @@ static int amdgpu_debugfs_pm_info(struct

> > seq_file *m, void *data)

> >          struct amdgpu_device *adev = dev->dev_private;

> >          struct drm_device *ddev = adev->ddev;

> >

> > +          if (adev->gfx.cg_enabled)

> > +                   seq_printf(m, "GFX Clock Gating: Enabled\n");

> > +          else

> > +                   seq_printf(m, "GFX Clock Gating: Disabled\n");

> > +

>

>

> I think it would be better to print the cg_flags and pg_flags (both as a mask and in human readable form) so we know exactly cg and pg features are enabled.

>



It's probable better. Let me revise this patch and send it later.



Thanks,

Rui

[-- Attachment #1.2: Type: text/html, Size: 13833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx