* [PATCH] drm/amd/powerplay: add error message to remind user updating firmware
@ 2017-04-20 7:33 Huang Rui
[not found] ` <1492673633-21017-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Huang Rui @ 2017-04-20 7:33 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Alex Deucher, Evan Quan, Huang Rui
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
index 2685f02..b3f3af2 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
"Attempt to read SMC IF Version Number Failed!",
return -1);
- if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
- return -1;
+ if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+ pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+ smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+ return -EINVAL;
+ }
return 0;
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware
[not found] ` <1492673633-21017-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
@ 2017-04-20 7:47 ` Quan, Evan
2017-04-20 10:09 ` Edward O'Callaghan
2017-04-20 12:45 ` Alex Deucher
2 siblings, 0 replies; 4+ messages in thread
From: Quan, Evan @ 2017-04-20 7:47 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Deucher, Alexander, Huang, Ray
Reviewed-by: Evan Quan <evan.quan@amd.com>
>-----Original Message-----
>From: Huang Rui [mailto:ray.huang@amd.com]
>Sent: Thursday, April 20, 2017 3:34 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Quan, Evan
><Evan.Quan@amd.com>; Huang, Ray <Ray.Huang@amd.com>
>Subject: [PATCH] drm/amd/powerplay: add error message to remind user
>updating firmware
>
>Signed-off-by: Huang Rui <ray.huang@amd.com>
>---
> drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>index 2685f02..b3f3af2 100644
>--- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct
>pp_smumgr *smumgr)
> "Attempt to read SMC IF Version Number Failed!",
> return -1);
>
>- if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
>- return -1;
>+ if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
>+ pr_err("Your firmware(0x%x) doesn't match
>SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
>+ smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
>+ return -EINVAL;
>+ }
>
> return 0;
> }
>--
>2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware
[not found] ` <1492673633-21017-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-04-20 7:47 ` Quan, Evan
@ 2017-04-20 10:09 ` Edward O'Callaghan
2017-04-20 12:45 ` Alex Deucher
2 siblings, 0 replies; 4+ messages in thread
From: Edward O'Callaghan @ 2017-04-20 10:09 UTC (permalink / raw)
To: Huang Rui, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Alex Deucher, Evan Quan
[-- Attachment #1.1.1: Type: text/plain, Size: 1149 bytes --]
Reviewed-by: Edward O'Callaghan <funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
On 04/20/2017 05:33 PM, Huang Rui wrote:
> Signed-off-by: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> index 2685f02..b3f3af2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> @@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
> "Attempt to read SMC IF Version Number Failed!",
> return -1);
>
> - if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
> - return -1;
> + if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
> + pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
> + smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
> + return -EINVAL;
> + }
>
> return 0;
> }
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware
[not found] ` <1492673633-21017-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-04-20 7:47 ` Quan, Evan
2017-04-20 10:09 ` Edward O'Callaghan
@ 2017-04-20 12:45 ` Alex Deucher
2 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-04-20 12:45 UTC (permalink / raw)
To: Huang Rui; +Cc: Alex Deucher, Evan Quan, amd-gfx list
On Thu, Apr 20, 2017 at 3:33 AM, Huang Rui <ray.huang@amd.com> wrote:
> Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> index 2685f02..b3f3af2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> @@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
> "Attempt to read SMC IF Version Number Failed!",
> return -1);
>
> - if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
> - return -1;
> + if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
> + pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
> + smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
> + return -EINVAL;
> + }
>
> return 0;
> }
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-20 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 7:33 [PATCH] drm/amd/powerplay: add error message to remind user updating firmware Huang Rui
[not found] ` <1492673633-21017-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-04-20 7:47 ` Quan, Evan
2017-04-20 10:09 ` Edward O'Callaghan
2017-04-20 12:45 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.