* [syzbot] [ntfs3?] UBSAN: shift-out-of-bounds in attr_set_size
@ 2023-04-03 13:03 syzbot
2023-04-08 17:22 ` mirimmad
0 siblings, 1 reply; 3+ messages in thread
From: syzbot @ 2023-04-03 13:03 UTC (permalink / raw)
To: almaz.alexandrovich, linux-fsdevel, linux-kernel, ntfs3, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 7e364e56293b Linux 6.3-rc5
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13a94395c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=d9a438ce47536f0c
dashboard link: https://syzkaller.appspot.com/bug?extid=14a2433710a3affee84e
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/54c56bddacf4/disk-7e364e56.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/447e5d1af596/vmlinux-7e364e56.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3e2d1545e7be/bzImage-7e364e56.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+14a2433710a3affee84e@syzkaller.appspotmail.com
================================================================================
UBSAN: shift-out-of-bounds in fs/ntfs3/attrib.c:450:9
shift exponent 64 is too large for 32-bit type 'u32' (aka 'unsigned int')
CPU: 1 PID: 1832 Comm: syz-executor.1 Not tainted 6.3.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
ubsan_epilogue lib/ubsan.c:217 [inline]
__ubsan_handle_shift_out_of_bounds+0x3c3/0x420 lib/ubsan.c:387
attr_set_size+0x32c2/0x4290 fs/ntfs3/attrib.c:450
ntfs_extend_mft+0x188/0x4b0 fs/ntfs3/fsntfs.c:511
ntfs_look_free_mft+0x43d/0x10b0 fs/ntfs3/fsntfs.c:589
ntfs_create_inode+0x4d7/0x3830 fs/ntfs3/inode.c:1296
ntfs_atomic_open+0x3db/0x530 fs/ntfs3/namei.c:424
atomic_open fs/namei.c:3279 [inline]
lookup_open fs/namei.c:3387 [inline]
open_last_lookups fs/namei.c:3484 [inline]
path_openat+0x103c/0x3170 fs/namei.c:3712
do_filp_open+0x234/0x490 fs/namei.c:3742
do_sys_openat2+0x13f/0x500 fs/open.c:1348
do_sys_open fs/open.c:1364 [inline]
__do_sys_open fs/open.c:1372 [inline]
__se_sys_open fs/open.c:1368 [inline]
__x64_sys_open+0x225/0x270 fs/open.c:1368
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f99f548c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f99f622e168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007f99f55abf80 RCX: 00007f99f548c0f9
RDX: 0000000000000000 RSI: 0000000000060142 RDI: 0000000020000000
RBP: 00007f99f54e7b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd74d2bccf R14: 00007f99f622e300 R15: 0000000000022000
</TASK>
================================================================================
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] FS NTFS3: Fix shift-out-of-bounds in attr_set_size
2023-04-03 13:03 [syzbot] [ntfs3?] UBSAN: shift-out-of-bounds in attr_set_size syzbot
@ 2023-04-08 17:22 ` mirimmad
0 siblings, 0 replies; 3+ messages in thread
From: mirimmad @ 2023-04-08 17:22 UTC (permalink / raw)
Cc: skhan, Immad Mir, syzbot+14a2433710a3affee84e,
Konstantin Komarov, open list:NTFS3 FILESYSTEM, open list
From: Immad Mir <mirimmad17@gmail.com>
The bug can be fixed by changing type of 'align'
from u32 to u64
Reported-by: syzbot+14a2433710a3affee84e@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=14a2433710a3affee84e
Signed-off-by: Immad Mir <mirimmad17@gmail.com>
---
fs/ntfs3/attrib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
index 5e6bafb10..c306aa087 100644
--- a/fs/ntfs3/attrib.c
+++ b/fs/ntfs3/attrib.c
@@ -415,7 +415,7 @@ int attr_set_size(struct ntfs_inode *ni, enum ATTR_TYPE type,
CLST next_svcn, pre_alloc = -1, done = 0;
bool is_ext, is_bad = false;
bool dirty = false;
- u32 align;
+ u64 align;
struct MFT_REC *rec;
again:
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] FS NTFS3: Fix shift-out-of-bounds in attr_set_size
@ 2023-04-08 17:22 ` mirimmad
0 siblings, 0 replies; 3+ messages in thread
From: mirimmad @ 2023-04-08 17:22 UTC (permalink / raw)
Cc: skhan, Immad Mir, syzbot+14a2433710a3affee84e,
Konstantin Komarov, open list:NTFS3 FILESYSTEM, open list
From: Immad Mir <mirimmad17@gmail.com>
The bug can be fixed by changing type of 'align'
from u32 to u64
Reported-by: syzbot+14a2433710a3affee84e@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=14a2433710a3affee84e
Signed-off-by: Immad Mir <mirimmad17@gmail.com>
---
fs/ntfs3/attrib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
index 5e6bafb10..c306aa087 100644
--- a/fs/ntfs3/attrib.c
+++ b/fs/ntfs3/attrib.c
@@ -415,7 +415,7 @@ int attr_set_size(struct ntfs_inode *ni, enum ATTR_TYPE type,
CLST next_svcn, pre_alloc = -1, done = 0;
bool is_ext, is_bad = false;
bool dirty = false;
- u32 align;
+ u64 align;
struct MFT_REC *rec;
again:
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-08 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-03 13:03 [syzbot] [ntfs3?] UBSAN: shift-out-of-bounds in attr_set_size syzbot
2023-04-08 17:22 ` [PATCH] FS NTFS3: Fix " mirimmad
2023-04-08 17:22 ` mirimmad
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.