All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pingbo Wen <pingbo.wen@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [Y2038] [PATCH] hil_mlc: convert timeval to timespec64
Date: Fri, 23 Oct 2015 20:34:50 +0800	[thread overview]
Message-ID: <D1043A13-EDCD-48C7-BA2B-CE4FCFC73338@linaro.org> (raw)
In-Reply-To: <5201254.PnVcGHTDmH@wuerfel>


> 在 2015年10月23日，17:45，Arnd Bergmann <arnd@arndb.de> 写道：
> 
> On Friday 23 October 2015 17:12:38 Pingbo Wen wrote:
>> On Monday, October 19, 2015 04:58 PM, Arnd Bergmann wrote:
>>>> -            do_gettimeofday(&tv);
>>>> -        
> Handling the jiffies overflow is trivially done through the time_before()
> and time_after() helpers, like
> 
> 
> 	start = jiffies;
> 	...
> 	now = jiffies;
> 	timeout = start + HZ * timeout_usec / USEC_PER_SEC;
> 	if (time_after(now, start + timeout_jiffies)
> 		timeout();
> 	else
> 		mod_timer(timer, start + timeout_jiffies);
> 
> The time_after function works because unsigned overflow is well-defined
> in C (unlike signed overflow).
> 

Make sense, I will try this in next version.

Thanks,
Pingbo


WARNING: multiple messages have this Message-ID (diff)
From: Pingbo Wen <pingbo.wen@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] hil_mlc: convert timeval to timespec64
Date: Fri, 23 Oct 2015 20:34:50 +0800	[thread overview]
Message-ID: <D1043A13-EDCD-48C7-BA2B-CE4FCFC73338@linaro.org> (raw)
In-Reply-To: <5201254.PnVcGHTDmH@wuerfel>


> 在 2015年10月23日，17:45，Arnd Bergmann <arnd@arndb.de> 写道：
> 
> On Friday 23 October 2015 17:12:38 Pingbo Wen wrote:
>> On Monday, October 19, 2015 04:58 PM, Arnd Bergmann wrote:
>>>> -            do_gettimeofday(&tv);
>>>> -        
> Handling the jiffies overflow is trivially done through the time_before()
> and time_after() helpers, like
> 
> 
> 	start = jiffies;
> 	...
> 	now = jiffies;
> 	timeout = start + HZ * timeout_usec / USEC_PER_SEC;
> 	if (time_after(now, start + timeout_jiffies)
> 		timeout();
> 	else
> 		mod_timer(timer, start + timeout_jiffies);
> 
> The time_after function works because unsigned overflow is well-defined
> in C (unlike signed overflow).
> 

Make sense, I will try this in next version.

Thanks,
Pingbo

_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038

  reply	other threads:[~2015-10-23 12:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18  9:45 [PATCH] hil_mlc: convert timeval to timespec64 WEN Pingbo
2015-10-19  8:58 ` [Y2038] " Arnd Bergmann
2015-10-23  9:12   ` Pingbo Wen
2015-10-23  9:45     ` Arnd Bergmann
2015-10-23  9:45       ` Arnd Bergmann
2015-10-23 12:34       ` Pingbo Wen [this message]
2015-10-23 12:34         ` Pingbo Wen
2015-10-24  4:00       ` [PATCH V3 1/2] hil_mlc: convert timeval to time64_t WEN Pingbo
2015-10-24  4:00         ` WEN Pingbo
2015-10-24  4:00         ` [PATCH V3 2/2] hil_mlc: convert timeval to jiffies WEN Pingbo
2015-10-24  4:00           ` WEN Pingbo
2015-10-23  9:24   ` [PATCH V2] hil_mlc: convert timeval to ktime_t WEN Pingbo
2015-10-23  9:24     ` WEN Pingbo
2015-10-23  9:55     ` [Y2038] " Arnd Bergmann
2015-10-23 12:32       ` Pingbo Wen
2015-10-23 13:51         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D1043A13-EDCD-48C7-BA2B-CE4FCFC73338@linaro.org \
    --to=pingbo.wen@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.