All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [RFC] Handling IMAGE_INSTALL_append
@ 2015-03-04 12:13 Barros Pena, Belen
  2015-03-04 15:58 ` Reyna, David
  0 siblings, 1 reply; 5+ messages in thread
From: Barros Pena, Belen @ 2015-03-04 12:13 UTC (permalink / raw)
  To: Damian, Alexandru, Reyna, David L (Wind River); +Cc: Paul Eggleton, toaster



On 04/03/2015 11:46, "Damian, Alexandru" <alexandru.damian@intel.com>
wrote:

>This needs to be done in the backend - we can't trust whatever the
>browser is telling us, we have to check it on the server side.

Thanks, Alex. If nobody fundamentally disagrees, can I go ahead and open a
Bugzilla entry for this?

David: can I assign it to you?

Cheers

Belén

>
>
>Alex
>
>
>
>On Wed, Mar 4, 2015 at 10:38 AM, Barros Pena, Belen
><belen.barros.pena@intel.com> wrote:
>
>So what do you guys think?
>
>Thanks!
>
>Belén
>
>On 04/03/2015 00:32, "Reyna, David" <david.reyna@windriver.com> wrote:
>
>>> From my perspective, option 1 is the best one.
>>
>>And I still agree with that.
>>
>>Trying to have the user do this opens the door to trivial but blocking
>>defects, and the GUI experience is supposed to be superior and more
>>guided than the raw command line experience.
>>
>>The fall back is to have the front end interface enforce this invisibly,
>>in other words always force a leading space when it writes this value to
>>the backend but present/accept a trimmed value. This is something that
>>could be done quickly, but then we are spreading this arcane syntax rule
>>to the frontend away from the presumably more intelligent backend.
>>
>>- David
>>
>>> -----Original Message-----
>>> From: toaster-bounces@yoctoproject.org [mailto:toaster-
>>> bounces@yoctoproject.org] On Behalf Of Barros Pena, Belen
>>> Sent: Tuesday, March 03, 2015 2:47 AM
>>> To: toaster@yoctoproject.org
>>> Subject: [Toaster] [RFC] Handling IMAGE_INSTALL_append
>>>
>>> The default project configuration we ship with Toaster includes the
>>> IMAGE_INSTALL_append variable. This variable requires a space before
>>> the
>>> first package name. We have spoken before about taking 2 possible
>>> approaches to handle this:
>>>
>>> 1. Toaster takes responsibility and adds the space for you. How this
>>> could
>>> be done, I am not sure. I guess we can either somehow identify
>>> IMAGE_INSTALL_append as the type of variable that requires a space
>>> before
>>> the first list item, or we can hardcode it.
>>>
>>> 2. Users take responsibility and add the space themselves. Easier to
>>> implement (we add some help text to the field), but bound to fail
>>> (users
>>> don't read help text).
>>>
>>> From my perspective, option 1 is the best one. I don't care if we need
>>> to
>>> hardcode it. Adding this variable to the default project configuration
>>> is
>>> very much a temporary solution until we provide functionality to
>>> customise
>>> the list of packages installed by an image recipe.
>>>
>>> Would this be acceptable to everybody else?
>>>
>>> Thanks!
>>>
>>> Belén
>>>
>>> --
>>> _______________________________________________
>>> toaster mailing list
>>> toaster@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] Handling IMAGE_INSTALL_append
  2015-03-04 12:13 [RFC] Handling IMAGE_INSTALL_append Barros Pena, Belen
@ 2015-03-04 15:58 ` Reyna, David
  2015-03-04 16:36   ` Barros Pena, Belen
  0 siblings, 1 reply; 5+ messages in thread
From: Reyna, David @ 2015-03-04 15:58 UTC (permalink / raw)
  To: BARROS PENA, BELEN; +Cc: Paul Eggleton, toaster

Yes I will take this defect.

David
> On Mar 4, 2015, at 4:14 AM, Barros Pena, Belen <belen.barros.pena@intel.com> wrote:
> 
> 
> 
> On 04/03/2015 11:46, "Damian, Alexandru" <alexandru.damian@intel.com>
> wrote:
> 
>> This needs to be done in the backend - we can't trust whatever the
>> browser is telling us, we have to check it on the server side.
> 
> Thanks, Alex. If nobody fundamentally disagrees, can I go ahead and open a
> Bugzilla entry for this?
> 
> David: can I assign it to you?
> 
> Cheers
> 
> Belén
> 
>> 
>> 
>> Alex
>> 
>> 
>> 
>> On Wed, Mar 4, 2015 at 10:38 AM, Barros Pena, Belen
>> <belen.barros.pena@intel.com> wrote:
>> 
>> So what do you guys think?
>> 
>> Thanks!
>> 
>> Belén
>> 
>> On 04/03/2015 00:32, "Reyna, David" <david.reyna@windriver.com> wrote:
>> 
>>>> From my perspective, option 1 is the best one.
>>> 
>>> And I still agree with that.
>>> 
>>> Trying to have the user do this opens the door to trivial but blocking
>>> defects, and the GUI experience is supposed to be superior and more
>>> guided than the raw command line experience.
>>> 
>>> The fall back is to have the front end interface enforce this invisibly,
>>> in other words always force a leading space when it writes this value to
>>> the backend but present/accept a trimmed value. This is something that
>>> could be done quickly, but then we are spreading this arcane syntax rule
>>> to the frontend away from the presumably more intelligent backend.
>>> 
>>> - David
>>> 
>>>> -----Original Message-----
>>>> From: toaster-bounces@yoctoproject.org [mailto:toaster-
>>>> bounces@yoctoproject.org] On Behalf Of Barros Pena, Belen
>>>> Sent: Tuesday, March 03, 2015 2:47 AM
>>>> To: toaster@yoctoproject.org
>>>> Subject: [Toaster] [RFC] Handling IMAGE_INSTALL_append
>>>> 
>>>> The default project configuration we ship with Toaster includes the
>>>> IMAGE_INSTALL_append variable. This variable requires a space before
>>>> the
>>>> first package name. We have spoken before about taking 2 possible
>>>> approaches to handle this:
>>>> 
>>>> 1. Toaster takes responsibility and adds the space for you. How this
>>>> could
>>>> be done, I am not sure. I guess we can either somehow identify
>>>> IMAGE_INSTALL_append as the type of variable that requires a space
>>>> before
>>>> the first list item, or we can hardcode it.
>>>> 
>>>> 2. Users take responsibility and add the space themselves. Easier to
>>>> implement (we add some help text to the field), but bound to fail
>>>> (users
>>>> don't read help text).
>>>> 
>>>> From my perspective, option 1 is the best one. I don't care if we need
>>>> to
>>>> hardcode it. Adding this variable to the default project configuration
>>>> is
>>>> very much a temporary solution until we provide functionality to
>>>> customise
>>>> the list of packages installed by an image recipe.
>>>> 
>>>> Would this be acceptable to everybody else?
>>>> 
>>>> Thanks!
>>>> 
>>>> Belén
>>>> 
>>>> --
>>>> _______________________________________________
>>>> toaster mailing list
>>>> toaster@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/toaster
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> --
>> Alex Damian
>> Yocto Project
>> 
>> SSG / OTC
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] Handling IMAGE_INSTALL_append
  2015-03-04 15:58 ` Reyna, David
@ 2015-03-04 16:36   ` Barros Pena, Belen
  0 siblings, 0 replies; 5+ messages in thread
From: Barros Pena, Belen @ 2015-03-04 16:36 UTC (permalink / raw)
  To: Reyna, David L (Wind River); +Cc: toaster


On 04/03/2015 15:58, "Reyna, David" <david.reyna@windriver.com> wrote:

>Yes I will take this defect.

All yours:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=7394

Thanks!

Belén

>
>David
>
>Sent from my iPhone
>
>> On Mar 4, 2015, at 4:14 AM, Barros Pena, Belen
>><belen.barros.pena@intel.com> wrote:
>>
>>
>>
>> On 04/03/2015 11:46, "Damian, Alexandru" <alexandru.damian@intel.com>
>> wrote:
>>
>>> This needs to be done in the backend - we can't trust whatever the
>>> browser is telling us, we have to check it on the server side.
>>
>> Thanks, Alex. If nobody fundamentally disagrees, can I go ahead and
>>open a
>> Bugzilla entry for this?
>>
>> David: can I assign it to you?
>>
>> Cheers
>>
>> Belén
>>
>>>
>>>
>>> Alex
>>>
>>>
>>>
>>> On Wed, Mar 4, 2015 at 10:38 AM, Barros Pena, Belen
>>> <belen.barros.pena@intel.com> wrote:
>>>
>>> So what do you guys think?
>>>
>>> Thanks!
>>>
>>> Belén
>>>
>>> On 04/03/2015 00:32, "Reyna, David" <david.reyna@windriver.com> wrote:
>>>
>>>>> From my perspective, option 1 is the best one.
>>>>
>>>> And I still agree with that.
>>>>
>>>> Trying to have the user do this opens the door to trivial but blocking
>>>> defects, and the GUI experience is supposed to be superior and more
>>>> guided than the raw command line experience.
>>>>
>>>> The fall back is to have the front end interface enforce this
>>>>invisibly,
>>>> in other words always force a leading space when it writes this value
>>>>to
>>>> the backend but present/accept a trimmed value. This is something that
>>>> could be done quickly, but then we are spreading this arcane syntax
>>>>rule
>>>> to the frontend away from the presumably more intelligent backend.
>>>>
>>>> - David
>>>>
>>>>> -----Original Message-----
>>>>> From: toaster-bounces@yoctoproject.org [mailto:toaster-
>>>>> bounces@yoctoproject.org] On Behalf Of Barros Pena, Belen
>>>>> Sent: Tuesday, March 03, 2015 2:47 AM
>>>>> To: toaster@yoctoproject.org
>>>>> Subject: [Toaster] [RFC] Handling IMAGE_INSTALL_append
>>>>>
>>>>> The default project configuration we ship with Toaster includes the
>>>>> IMAGE_INSTALL_append variable. This variable requires a space before
>>>>> the
>>>>> first package name. We have spoken before about taking 2 possible
>>>>> approaches to handle this:
>>>>>
>>>>> 1. Toaster takes responsibility and adds the space for you. How this
>>>>> could
>>>>> be done, I am not sure. I guess we can either somehow identify
>>>>> IMAGE_INSTALL_append as the type of variable that requires a space
>>>>> before
>>>>> the first list item, or we can hardcode it.
>>>>>
>>>>> 2. Users take responsibility and add the space themselves. Easier to
>>>>> implement (we add some help text to the field), but bound to fail
>>>>> (users
>>>>> don't read help text).
>>>>>
>>>>> From my perspective, option 1 is the best one. I don't care if we
>>>>>need
>>>>> to
>>>>> hardcode it. Adding this variable to the default project
>>>>>configuration
>>>>> is
>>>>> very much a temporary solution until we provide functionality to
>>>>> customise
>>>>> the list of packages installed by an image recipe.
>>>>>
>>>>> Would this be acceptable to everybody else?
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Belén
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> toaster mailing list
>>>>> toaster@yoctoproject.org
>>>>> https://lists.yoctoproject.org/listinfo/toaster
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Alex Damian
>>> Yocto Project
>>>
>>> SSG / OTC
>>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] Handling IMAGE_INSTALL_append
  2015-03-03 10:47 Barros Pena, Belen
@ 2015-03-04  0:32 ` Reyna, David
  0 siblings, 0 replies; 5+ messages in thread
From: Reyna, David @ 2015-03-04  0:32 UTC (permalink / raw)
  To: BARROS PENA, BELEN, toaster

> From my perspective, option 1 is the best one.

And I still agree with that.

Trying to have the user do this opens the door to trivial but blocking defects, and the GUI experience is supposed to be superior and more guided than the raw command line experience.

The fall back is to have the front end interface enforce this invisibly, in other words always force a leading space when it writes this value to the backend but present/accept a trimmed value. This is something that could be done quickly, but then we are spreading this arcane syntax rule to the frontend away from the presumably more intelligent backend.

- David

> -----Original Message-----
> From: toaster-bounces@yoctoproject.org [mailto:toaster-
> bounces@yoctoproject.org] On Behalf Of Barros Pena, Belen
> Sent: Tuesday, March 03, 2015 2:47 AM
> To: toaster@yoctoproject.org
> Subject: [Toaster] [RFC] Handling IMAGE_INSTALL_append
> 
> The default project configuration we ship with Toaster includes the
> IMAGE_INSTALL_append variable. This variable requires a space before
> the
> first package name. We have spoken before about taking 2 possible
> approaches to handle this:
> 
> 1. Toaster takes responsibility and adds the space for you. How this
> could
> be done, I am not sure. I guess we can either somehow identify
> IMAGE_INSTALL_append as the type of variable that requires a space
> before
> the first list item, or we can hardcode it.
> 
> 2. Users take responsibility and add the space themselves. Easier to
> implement (we add some help text to the field), but bound to fail
> (users
> don't read help text).
> 
> From my perspective, option 1 is the best one. I don't care if we need
> to
> hardcode it. Adding this variable to the default project configuration
> is
> very much a temporary solution until we provide functionality to
> customise
> the list of packages installed by an image recipe.
> 
> Would this be acceptable to everybody else?
> 
> Thanks!
> 
> Belén
> 
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [RFC] Handling IMAGE_INSTALL_append
@ 2015-03-03 10:47 Barros Pena, Belen
  2015-03-04  0:32 ` Reyna, David
  0 siblings, 1 reply; 5+ messages in thread
From: Barros Pena, Belen @ 2015-03-03 10:47 UTC (permalink / raw)
  To: toaster

The default project configuration we ship with Toaster includes the
IMAGE_INSTALL_append variable. This variable requires a space before the
first package name. We have spoken before about taking 2 possible
approaches to handle this:

1. Toaster takes responsibility and adds the space for you. How this could
be done, I am not sure. I guess we can either somehow identify
IMAGE_INSTALL_append as the type of variable that requires a space before
the first list item, or we can hardcode it.

2. Users take responsibility and add the space themselves. Easier to
implement (we add some help text to the field), but bound to fail (users
don't read help text).

From my perspective, option 1 is the best one. I don't care if we need to
hardcode it. Adding this variable to the default project configuration is
very much a temporary solution until we provide functionality to customise
the list of packages installed by an image recipe.

Would this be acceptable to everybody else?

Thanks!

Belén



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-03-04 16:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 12:13 [RFC] Handling IMAGE_INSTALL_append Barros Pena, Belen
2015-03-04 15:58 ` Reyna, David
2015-03-04 16:36   ` Barros Pena, Belen
  -- strict thread matches above, loose matches on Subject: below --
2015-03-03 10:47 Barros Pena, Belen
2015-03-04  0:32 ` Reyna, David

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.