[review-request] 7177 "Most built targets" bug fixes

[review-request] 7177 "Most built targets" bug fixes

[Lerner, Dave]

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=lerner/most_built_target_fixes_7177

Commit
----------
    Fixes for the following for the "Most built targets" section of the
    project page:
    1) limit the number of most built targets to 5,
    2) order the list of most built targets by build count,
    3) select only those builds that had build status of 'fail', 'success',
    or a BuildRequest of 'failed',
    4) if there are no layers in the project then (on refresh) all of the
    checkboxes in the 'Most built targets' list are disabled.
    
    Note that per agreement with UI designer, the only sort on the most
    target list is build count as described in (3) above; secondary sorting
    is random.
...

Testing
---------
Verify each build below gets added to the Most built targets list.
Note: after every test (new target build), the page must be refreshed.

1) Most built targets limited to 5
Build exactly once for some new project:
  core-image-minimal (referred tp as 'minimal' below)
  core-image-base ('base')
  core-image-minimal-dev ('dev')
  core-image-minimal-initramfs ('initramfs')
  bogus-target ('bogus')
Verify that all five project appear

Build a 6th target
  core-image-minimal-mtdutils ('mtdutils')

Validate only 5 of the 6 build-targets appear, but since all are built
just once, the set of 5 build targets is random. On my test
  dev, mtdutils, bogus, base, initramfs
with 'minimal' dropped.

2) Most built targets list is ordered by count
Validate that count matters, force 'minimal' (or the one build not on the top 5 list above) onto and at the top of the list by
building it again. Verify 'minimal' (or step 1 dropped target) is at top of the list.

3) Most built checkboxes enabled when layers exist
check core-image-minimal-dev and core-image-base and then click
Build selected targets.
Verify that both targets are built.

4) delete all layers (refresh page)
Verify that the 5 targets in the list have their checkboxes  disabled.

5) add a layer (refresh the page)
Verify that all 5 targets in the list have their checkboxes enabled.
-------------

Thanks,
Dave Lerner

Re: [review-request] 7177 "Most built targets" bug fixes

[Barros Pena, Belen]

On 14/03/2015 14:24, "Lerner, Dave" <dave.lerner@windriver.com> wrote:

>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=lerner/mo
>st_built_target_fixes_7177

Hi Dave,

This is looking pretty good. We just need to add the 'muted' class to the
label tags when there are no layers in the project. Otherwise, it is hard
to spot the fact that those targets are disabled.

Thanks!

Belén


>
>Commit
>----------
>    Fixes for the following for the "Most built targets" section of the
>    project page:
>    1) limit the number of most built targets to 5,
>    2) order the list of most built targets by build count,
>    3) select only those builds that had build status of 'fail',
>'success',
>    or a BuildRequest of 'failed',
>    4) if there are no layers in the project then (on refresh) all of the
>    checkboxes in the 'Most built targets' list are disabled.
>
>    Note that per agreement with UI designer, the only sort on the most
>    target list is build count as described in (3) above; secondary
>sorting
>    is random.
>...
>
>Testing
>---------
>Verify each build below gets added to the Most built targets list.
>Note: after every test (new target build), the page must be refreshed.
>
>1) Most built targets limited to 5
>Build exactly once for some new project:
>  core-image-minimal (referred tp as 'minimal' below)
>  core-image-base ('base')
>  core-image-minimal-dev ('dev')
>  core-image-minimal-initramfs ('initramfs')
>  bogus-target ('bogus')
>Verify that all five project appear
>
>Build a 6th target
>  core-image-minimal-mtdutils ('mtdutils')
>
>Validate only 5 of the 6 build-targets appear, but since all are built
>just once, the set of 5 build targets is random. On my test
>  dev, mtdutils, bogus, base, initramfs
>with 'minimal' dropped.
>
>2) Most built targets list is ordered by count
>Validate that count matters, force 'minimal' (or the one build not on the
>top 5 list above) onto and at the top of the list by
>building it again. Verify 'minimal' (or step 1 dropped target) is at top
>of the list.
>
>3) Most built checkboxes enabled when layers exist
>check core-image-minimal-dev and core-image-base and then click
>Build selected targets.
>Verify that both targets are built.
>
>4) delete all layers (refresh page)
>Verify that the 5 targets in the list have their checkboxes  disabled.
>
>5) add a layer (refresh the page)
>Verify that all 5 targets in the list have their checkboxes enabled.
>-------------
>
>Thanks,
>Dave Lerner