From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: lustre-devel@lists.lustre.org
Subject: Re: [lustre-devel] [patch] staging: lustre: remove unused variable
Date: Wed, 04 Nov 2015 01:43:03 +0000 [thread overview]
Message-ID: <D25E8C0E.1180A2%andreas.dilger@intel.com> (raw)
In-Reply-To: <20151103221616.GD19280@mwanda>
On 2015/11/03, 15:38, "Simmons, James A." <simmonsja@ornl.gov> wrote:
>>The "->lr_lvb_data" struct member is never used. Delete it.
>>
>>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>---
>>I have compile tested this. I looked through the history and it seems
>>to never have been used. I wonder if we can remove the locking as well.
>
>This is used by the quota and ofd layer which are both server side.
When the server code is merged upstream this can be added to a union that
contains only server-side data that overlaps with a union containing only
client-side data. For now it is fine to remove from the kernel.
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
WARNING: multiple messages have this Message-ID (diff)
From: Dilger, Andreas <andreas.dilger@intel.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [patch] staging: lustre: remove unused variable
Date: Wed, 4 Nov 2015 01:43:03 +0000 [thread overview]
Message-ID: <D25E8C0E.1180A2%andreas.dilger@intel.com> (raw)
On 2015/11/03, 15:38, "Simmons, James A." <simmonsja@ornl.gov> wrote:
>>The "->lr_lvb_data" struct member is never used. Delete it.
>>
>>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>---
>>I have compile tested this. I looked through the history and it seems
>>to never have been used. I wonder if we can remove the locking as well.
>
>This is used by the quota and ofd layer which are both server side.
When the server code is merged upstream this can be added to a union that
contains only server-side data that overlaps with a union containing only
client-side data. For now it is fine to remove from the kernel.
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
next prev parent reply other threads:[~2015-11-04 1:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 22:16 [patch] staging: lustre: remove unused variable Dan Carpenter
2015-11-03 22:16 ` [lustre-devel] " Dan Carpenter
2015-11-03 22:38 ` Simmons, James A.
2015-11-03 22:38 ` [lustre-devel] " Simmons, James A.
2015-11-04 1:23 ` Greg Kroah-Hartman
2015-11-04 1:23 ` [lustre-devel] " Greg Kroah-Hartman
2015-11-04 1:43 ` Dilger, Andreas [this message]
2015-11-04 1:43 ` Dilger, Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D25E8C0E.1180A2%andreas.dilger@intel.com \
--to=andreas.dilger@intel.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.