* [PATCH v2 0/2] remove SDKMACHINE variable
@ 2015-11-05 17:22 Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 1/2] toasterconf: " Ed Bartosh
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Ed Bartosh @ 2015-11-05 17:22 UTC (permalink / raw)
To: toaster
Hi,
This patchset contains two identical changes for toasterconf.json: removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html
The patchset logically belongs to my previous patchset: 8279: Provide a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.
Please, send them after my previous patchset is accepted.
Changes in v2: removed forgotten comma after "PACKAGE_CLASSES": "package_rpm"
The following changes since commit fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
build-appliance-image: Update to jethro head revision (2015-11-03 14:03:03 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove-sdkmachine
Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable
meta-yocto/conf/toasterconf.json | 3 +--
meta/conf/toasterconf.json | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
--
Regards,
Ed
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] toasterconf: remove SDKMACHINE variable
2015-11-05 17:22 [PATCH v2 0/2] remove SDKMACHINE variable Ed Bartosh
@ 2015-11-05 17:22 ` Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 2/2] " Ed Bartosh
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Ed Bartosh @ 2015-11-05 17:22 UTC (permalink / raw)
To: toaster
This variable is not used in toaster anymore.
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
meta/conf/toasterconf.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meta/conf/toasterconf.json b/meta/conf/toasterconf.json
index c8e42ef..1987793 100644
--- a/meta/conf/toasterconf.json
+++ b/meta/conf/toasterconf.json
@@ -4,8 +4,7 @@
"DISTRO" : "poky",
"IMAGE_FSTYPES": "ext3 jffs2 tar.bz2",
"IMAGE_INSTALL_append": "",
- "PACKAGE_CLASSES": "package_rpm",
- "SDKMACHINE" : "x86_64"
+ "PACKAGE_CLASSES": "package_rpm"
},
"layersources": [
{
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] toasterconf: remove SDKMACHINE variable
2015-11-05 17:22 [PATCH v2 0/2] remove SDKMACHINE variable Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 1/2] toasterconf: " Ed Bartosh
@ 2015-11-05 17:22 ` Ed Bartosh
2015-11-05 17:41 ` [PATCH v2 0/2] " Reyna, David
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Ed Bartosh @ 2015-11-05 17:22 UTC (permalink / raw)
To: toaster
This variable is not used in toaster anymore.
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
meta-yocto/conf/toasterconf.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meta-yocto/conf/toasterconf.json b/meta-yocto/conf/toasterconf.json
index 3df1703..3f79f42 100644
--- a/meta-yocto/conf/toasterconf.json
+++ b/meta-yocto/conf/toasterconf.json
@@ -4,8 +4,7 @@
"DISTRO" : "poky",
"IMAGE_FSTYPES": "ext3 jffs2 tar.bz2",
"IMAGE_INSTALL_append": "",
- "PACKAGE_CLASSES": "package_rpm",
- "SDKMACHINE" : "x86_64"
+ "PACKAGE_CLASSES": "package_rpm"
},
"layersources": [
{
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] remove SDKMACHINE variable
2015-11-05 17:22 [PATCH v2 0/2] remove SDKMACHINE variable Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 1/2] toasterconf: " Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 2/2] " Ed Bartosh
@ 2015-11-05 17:41 ` Reyna, David
2015-11-06 12:18 ` Ed Bartosh
2015-11-06 11:40 ` Barros Pena, Belen
[not found] ` <5E53D14CE4667A45B9A06760DE5D13D091C006E1@ALA-MBA.corp.ad.wrs.com>
4 siblings, 1 reply; 8+ messages in thread
From: Reyna, David @ 2015-11-05 17:41 UTC (permalink / raw)
To: Ed Bartosh, toaster
Hi Ed,
Have you tested this patch against the project configure variables page?
Specifically, this variable is also coded into these two files:
views.py
templates/projectconf.html
Are these files being handled in a separate commit?
- David
> -----Original Message-----
> From: toaster-bounces@yoctoproject.org [mailto:toaster-
> bounces@yoctoproject.org] On Behalf Of Ed Bartosh
> Sent: Thursday, November 05, 2015 9:23 AM
> To: toaster@yoctoproject.org
> Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>
> Hi,
>
> This patchset contains two identical changes for toasterconf.json:
> removing
> SDKMACHINE variable. Variable is not used in toaster anymore as it's
> removed
> by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-
> October/003234.html
>
> The patchset logically belongs to my previous patchset: 8279: Provide
> a single way of starting Toaster
> I'm sending this in separate e-mail as below two patches should be
> send to different upstream projects:
> openembedded-core and yocto.
>
> Please, send them after my previous patchset is accepted.
>
> Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
> "package_rpm"
>
> The following changes since commit
> fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>
> build-appliance-image: Update to jethro head revision (2015-11-03
> 14:03:03 +0000)
>
> are available in the git repository at:
>
> git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/log/?h=ed/toaster/remove-sdkmachine
>
> Ed Bartosh (2):
> toasterconf: remove SDKMACHINE variable
> toasterconf: remove SDKMACHINE variable
>
> meta-yocto/conf/toasterconf.json | 3 +--
> meta/conf/toasterconf.json | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> --
> Regards,
> Ed
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] remove SDKMACHINE variable
2015-11-05 17:22 [PATCH v2 0/2] remove SDKMACHINE variable Ed Bartosh
` (2 preceding siblings ...)
2015-11-05 17:41 ` [PATCH v2 0/2] " Reyna, David
@ 2015-11-06 11:40 ` Barros Pena, Belen
[not found] ` <5E53D14CE4667A45B9A06760DE5D13D091C006E1@ALA-MBA.corp.ad.wrs.com>
4 siblings, 0 replies; 8+ messages in thread
From: Barros Pena, Belen @ 2015-11-06 11:40 UTC (permalink / raw)
To: Ed Bartosh, toaster
On 05/11/2015 17:22, "toaster-bounces@yoctoproject.org on behalf of Ed
Bartosh" <toaster-bounces@yoctoproject.org on behalf of
ed.bartosh@linux.intel.com> wrote:
>Hi,
>
>This patchset contains two identical changes for toasterconf.json:
>removing
>SDKMACHINE variable. Variable is not used in toaster anymore as it's
>removed
>by this change:
>https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html
>
>The patchset logically belongs to my previous patchset: 8279: Provide a
>single way of starting Toaster
>I'm sending this in separate e-mail as below two patches should be send
>to different upstream projects:
>openembedded-core and yocto.
>
>Please, send them after my previous patchset is accepted.
>
>Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>"package_rpm"
>
>The following changes since commit
>fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>
> build-appliance-image: Update to jethro head revision (2015-11-03
>14:03:03 +0000)
>
>are available in the git repository at:
>
> git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
>
>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove
>-sdkmachine
No more complaints: both the meta and meta-yocto conf files load without
issues.
Thanks!
Belén
>
>Ed Bartosh (2):
> toasterconf: remove SDKMACHINE variable
> toasterconf: remove SDKMACHINE variable
>
> meta-yocto/conf/toasterconf.json | 3 +--
> meta/conf/toasterconf.json | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>--
>Regards,
>Ed
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] remove SDKMACHINE variable
[not found] ` <5E53D14CE4667A45B9A06760DE5D13D091C006E1@ALA-MBA.corp.ad.wrs.com>
@ 2015-11-06 11:46 ` Barros Pena, Belen
2015-11-06 12:37 ` Barros Pena, Belen
0 siblings, 1 reply; 8+ messages in thread
From: Barros Pena, Belen @ 2015-11-06 11:46 UTC (permalink / raw)
To: Reyna, David L (Wind River), Ed Bartosh, toaster
On 06/11/2015 07:56, "Reyna, David" <david.reyna@windriver.com> wrote:
>Hi Ed and Belén,
>
>> Specifically, this variable is also coded into these two files:
>> views.py
>> templates/projectconf.html
>
>If you want, I can take this task on and remove references to SDKMACHINE
>from these files, given that I am the one who put them in in the first
>place.
Looks like we need some changes in the template. The variable does not
display in the BitBake variables page (as expected, since it is no longer
set in the default configuration), but if you add it, you cannot delete it
(the 'delete' icon is missing). David: since you are familiar with that
template, do you think you could take care of this? When SDKMACHINE is not
defined, you should be able to add it and delete it like any other
variable using the 'add variable' form and the delete icon.
I can open a Bugzilla entry to track the work if you want me to.
Thanks!
Belén
>
>- David
>
>> -----Original Message-----
>> From: Reyna, David
>> Sent: Thursday, November 05, 2015 9:41 AM
>> To: 'Ed Bartosh'; toaster@yoctoproject.org
>> Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>>
>> Hi Ed,
>>
>> Have you tested this patch against the project configure variables
>> page?
>>
>> Specifically, this variable is also coded into these two files:
>>
>> views.py
>> templates/projectconf.html
>>
>> Are these files being handled in a separate commit?
>>
>> - David
>>
>>
>> > -----Original Message-----
>> > From: toaster-bounces@yoctoproject.org [mailto:toaster-
>> > bounces@yoctoproject.org] On Behalf Of Ed Bartosh
>> > Sent: Thursday, November 05, 2015 9:23 AM
>> > To: toaster@yoctoproject.org
>> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>> >
>> > Hi,
>> >
>> > This patchset contains two identical changes for toasterconf.json:
>> > removing
>> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
>> > removed
>> > by this change:
>> https://lists.yoctoproject.org/pipermail/toaster/2015-
>> > October/003234.html
>> >
>> > The patchset logically belongs to my previous patchset: 8279:
>> Provide
>> > a single way of starting Toaster
>> > I'm sending this in separate e-mail as below two patches should be
>> > send to different upstream projects:
>> > openembedded-core and yocto.
>> >
>> > Please, send them after my previous patchset is accepted.
>> >
>> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>> > "package_rpm"
>> >
>> > The following changes since commit
>> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>> >
>> > build-appliance-image: Update to jethro head revision (2015-11-03
>> > 14:03:03 +0000)
>> >
>> > are available in the git repository at:
>> >
>> > git://git.yoctoproject.org/poky-contrib ed/toaster/remove-
>> sdkmachine
>> > http://git.yoctoproject.org/cgit.cgi/poky-
>> > contrib/log/?h=ed/toaster/remove-sdkmachine
>> >
>> > Ed Bartosh (2):
>> > toasterconf: remove SDKMACHINE variable
>> > toasterconf: remove SDKMACHINE variable
>> >
>> > meta-yocto/conf/toasterconf.json | 3 +--
>> > meta/conf/toasterconf.json | 3 +--
>> > 2 files changed, 2 insertions(+), 4 deletions(-)
>> >
>> > --
>> > Regards,
>> > Ed
>> >
>> > --
>> > _______________________________________________
>> > toaster mailing list
>> > toaster@yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] remove SDKMACHINE variable
2015-11-05 17:41 ` [PATCH v2 0/2] " Reyna, David
@ 2015-11-06 12:18 ` Ed Bartosh
0 siblings, 0 replies; 8+ messages in thread
From: Ed Bartosh @ 2015-11-06 12:18 UTC (permalink / raw)
To: Reyna, David; +Cc: toaster
On Thu, Nov 05, 2015 at 05:41:25PM +0000, Reyna, David wrote:
> Hi Ed,
>
> Have you tested this patch against the project configure variables page?
>
> Specifically, this variable is also coded into these two files:
>
> views.py
> templates/projectconf.html
>
> Are these files being handled in a separate commit?
>
Yep, they're both taken care of in this commit:
https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html
BTW, I mentoned it in the cover letter of this patchset.
Regards,
Ed
> > -----Original Message-----
> > From: toaster-bounces@yoctoproject.org [mailto:toaster-
> > bounces@yoctoproject.org] On Behalf Of Ed Bartosh
> > Sent: Thursday, November 05, 2015 9:23 AM
> > To: toaster@yoctoproject.org
> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
> >
> > Hi,
> >
> > This patchset contains two identical changes for toasterconf.json:
> > removing
> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
> > removed
> > by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-
> > October/003234.html
> >
> > The patchset logically belongs to my previous patchset: 8279: Provide
> > a single way of starting Toaster
> > I'm sending this in separate e-mail as below two patches should be
> > send to different upstream projects:
> > openembedded-core and yocto.
> >
> > Please, send them after my previous patchset is accepted.
> >
> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
> > "package_rpm"
> >
> > The following changes since commit
> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
> >
> > build-appliance-image: Update to jethro head revision (2015-11-03
> > 14:03:03 +0000)
> >
> > are available in the git repository at:
> >
> > git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
> > http://git.yoctoproject.org/cgit.cgi/poky-
> > contrib/log/?h=ed/toaster/remove-sdkmachine
> >
> > Ed Bartosh (2):
> > toasterconf: remove SDKMACHINE variable
> > toasterconf: remove SDKMACHINE variable
> >
> > meta-yocto/conf/toasterconf.json | 3 +--
> > meta/conf/toasterconf.json | 3 +--
> > 2 files changed, 2 insertions(+), 4 deletions(-)
> >
> > --
> > Regards,
> > Ed
> >
> > --
> > _______________________________________________
> > toaster mailing list
> > toaster@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/toaster
--
--
Regards,
Ed
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] remove SDKMACHINE variable
2015-11-06 11:46 ` Barros Pena, Belen
@ 2015-11-06 12:37 ` Barros Pena, Belen
0 siblings, 0 replies; 8+ messages in thread
From: Barros Pena, Belen @ 2015-11-06 12:37 UTC (permalink / raw)
To: Reyna, David L (Wind River), Ed Bartosh, toaster
On 06/11/2015 11:46, "toaster-bounces@yoctoproject.org on behalf of Barros
Pena, Belen" <toaster-bounces@yoctoproject.org on behalf of
belen.barros.pena@intel.com> wrote:
>
>
>On 06/11/2015 07:56, "Reyna, David" <david.reyna@windriver.com> wrote:
>
>>Hi Ed and Belén,
>>
>>> Specifically, this variable is also coded into these two files:
>>> views.py
>>> templates/projectconf.html
>>
>>If you want, I can take this task on and remove references to SDKMACHINE
>>from these files, given that I am the one who put them in in the first
>>place.
>
>Looks like we need some changes in the template. The variable does not
>display in the BitBake variables page (as expected, since it is no longer
>set in the default configuration), but if you add it, you cannot delete it
>(the 'delete' icon is missing). David: since you are familiar with that
>template, do you think you could take care of this? When SDKMACHINE is not
>defined, you should be able to add it and delete it like any other
>variable using the 'add variable' form and the delete icon.
Just ignore me. This commit
https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html
Does take care of the issue I described above.
Thanks!
Belén
>
>I can open a Bugzilla entry to track the work if you want me to.
>
>Thanks!
>
>Belén
>
>
>>
>>- David
>>
>>> -----Original Message-----
>>> From: Reyna, David
>>> Sent: Thursday, November 05, 2015 9:41 AM
>>> To: 'Ed Bartosh'; toaster@yoctoproject.org
>>> Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>>>
>>> Hi Ed,
>>>
>>> Have you tested this patch against the project configure variables
>>> page?
>>>
>>> Specifically, this variable is also coded into these two files:
>>>
>>> views.py
>>> templates/projectconf.html
>>>
>>> Are these files being handled in a separate commit?
>>>
>>> - David
>>>
>>>
>>> > -----Original Message-----
>>> > From: toaster-bounces@yoctoproject.org [mailto:toaster-
>>> > bounces@yoctoproject.org] On Behalf Of Ed Bartosh
>>> > Sent: Thursday, November 05, 2015 9:23 AM
>>> > To: toaster@yoctoproject.org
>>> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>>> >
>>> > Hi,
>>> >
>>> > This patchset contains two identical changes for toasterconf.json:
>>> > removing
>>> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
>>> > removed
>>> > by this change:
>>> https://lists.yoctoproject.org/pipermail/toaster/2015-
>>> > October/003234.html
>>> >
>>> > The patchset logically belongs to my previous patchset: 8279:
>>> Provide
>>> > a single way of starting Toaster
>>> > I'm sending this in separate e-mail as below two patches should be
>>> > send to different upstream projects:
>>> > openembedded-core and yocto.
>>> >
>>> > Please, send them after my previous patchset is accepted.
>>> >
>>> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>>> > "package_rpm"
>>> >
>>> > The following changes since commit
>>> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>>> >
>>> > build-appliance-image: Update to jethro head revision (2015-11-03
>>> > 14:03:03 +0000)
>>> >
>>> > are available in the git repository at:
>>> >
>>> > git://git.yoctoproject.org/poky-contrib ed/toaster/remove-
>>> sdkmachine
>>> > http://git.yoctoproject.org/cgit.cgi/poky-
>>> > contrib/log/?h=ed/toaster/remove-sdkmachine
>>> >
>>> > Ed Bartosh (2):
>>> > toasterconf: remove SDKMACHINE variable
>>> > toasterconf: remove SDKMACHINE variable
>>> >
>>> > meta-yocto/conf/toasterconf.json | 3 +--
>>> > meta/conf/toasterconf.json | 3 +--
>>> > 2 files changed, 2 insertions(+), 4 deletions(-)
>>> >
>>> > --
>>> > Regards,
>>> > Ed
>>> >
>>> > --
>>> > _______________________________________________
>>> > toaster mailing list
>>> > toaster@yoctoproject.org
>>> > https://lists.yoctoproject.org/listinfo/toaster
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-11-06 12:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-05 17:22 [PATCH v2 0/2] remove SDKMACHINE variable Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 1/2] toasterconf: " Ed Bartosh
2015-11-05 17:22 ` [PATCH v2 2/2] " Ed Bartosh
2015-11-05 17:41 ` [PATCH v2 0/2] " Reyna, David
2015-11-06 12:18 ` Ed Bartosh
2015-11-06 11:40 ` Barros Pena, Belen
[not found] ` <5E53D14CE4667A45B9A06760DE5D13D091C006E1@ALA-MBA.corp.ad.wrs.com>
2015-11-06 11:46 ` Barros Pena, Belen
2015-11-06 12:37 ` Barros Pena, Belen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.