From: "Dilger, Andreas" <andreas.dilger@intel.com> To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>, "Drokin, Oleg" <oleg.drokin@intel.com> Cc: "lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Date: Fri, 4 Dec 2015 06:23:43 +0000 [thread overview] Message-ID: <D2867DFB.11E68C%andreas.dilger@intel.com> (raw) In-Reply-To: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> On 2015/12/01, 15:05, "Valdis Kletnieks" <Valdis.Kletnieks@vt.edu> wrote: >Start of a batch series to clean up the Lustre tree. Other people have >done some sparse and checkpatch cleanups, but I found a bunch of >stuff building with W=1. Hello Valdis, thanks for these patches. Strictly speaking, they should also be sent to "Greg Kroah-Hartman <gregkh@linuxfoundation.org>" and also devel@driverdev.osuosl.org because Lustre is still in the staging tree. Also, for the patch subject line, it is standard to use something like: [PATCH 1/6] staging/lustre: Swap inline/const to kill 272 warnings as generated by "git format-patch". Could you please resubmit your patch series so that Greg sees your patches. Cheers, Andreas >Valdis Kletnieks (6): > > Swap inline/const to kill 272 warnings > Fix set-but-unused whinge. > Clean up another C warnining: > Fix another C compiler whine: > Nuke an unsigned >= 0 assert > Nuke another unsigned >= 0 assert > > drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 + > drivers/staging/lustre/lustre/include/lu_object.h | 2 +- > drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 -- > drivers/staging/lustre/lustre/libcfs/module.c | 15 ++++---- > drivers/staging/lustre/lustre/llite/rw.c | 1 - > drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 - > 7 files changed, 26 insertions(+), 41 deletions(-) > >-- >2.6.3 > > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel High Performance Data Division
WARNING: multiple messages have this Message-ID (diff)
From: Dilger, Andreas <andreas.dilger@intel.com> To: lustre-devel@lists.lustre.org Subject: [lustre-devel] [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Date: Fri, 4 Dec 2015 06:23:43 +0000 [thread overview] Message-ID: <D2867DFB.11E68C%andreas.dilger@intel.com> (raw) In-Reply-To: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> On 2015/12/01, 15:05, "Valdis Kletnieks" <Valdis.Kletnieks@vt.edu> wrote: >Start of a batch series to clean up the Lustre tree. Other people have >done some sparse and checkpatch cleanups, but I found a bunch of >stuff building with W=1. Hello Valdis, thanks for these patches. Strictly speaking, they should also be sent to "Greg Kroah-Hartman <gregkh@linuxfoundation.org>" and also devel at driverdev.osuosl.org because Lustre is still in the staging tree. Also, for the patch subject line, it is standard to use something like: [PATCH 1/6] staging/lustre: Swap inline/const to kill 272 warnings as generated by "git format-patch". Could you please resubmit your patch series so that Greg sees your patches. Cheers, Andreas >Valdis Kletnieks (6): > > Swap inline/const to kill 272 warnings > Fix set-but-unused whinge. > Clean up another C warnining: > Fix another C compiler whine: > Nuke an unsigned >= 0 assert > Nuke another unsigned >= 0 assert > > drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 + > drivers/staging/lustre/lustre/include/lu_object.h | 2 +- > drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 -- > drivers/staging/lustre/lustre/libcfs/module.c | 15 ++++---- > drivers/staging/lustre/lustre/llite/rw.c | 1 - > drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 - > 7 files changed, 26 insertions(+), 41 deletions(-) > >-- >2.6.3 > > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel High Performance Data Division
next prev parent reply other threads:[~2015-12-04 6:23 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-01 22:05 [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-01 22:05 ` [lustre cleanups 1/6] Swap inline/const to kill 272 warnings Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-01 22:05 ` [lustre cleanups 2/6] Fix set-but-unused whinge Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-01 22:05 ` [lustre cleanups 3/6] Clean up another C warnining: Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-01 22:05 ` [lustre cleanups 4/6] Fix another C compiler whine: Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-01 22:05 ` [lustre cleanups 5/6] Nuke an unsigned >= 0 assert Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-01 22:05 ` [lustre cleanups 6/6] Nuke another " Valdis Kletnieks 2015-12-01 22:05 ` [lustre-devel] " Valdis Kletnieks 2015-12-04 6:23 ` Dilger, Andreas [this message] 2015-12-04 6:23 ` [lustre-devel] [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Dilger, Andreas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=D2867DFB.11E68C%andreas.dilger@intel.com \ --to=andreas.dilger@intel.com \ --cc=Valdis.Kletnieks@vt.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=lustre-devel@lists.lustre.org \ --cc=oleg.drokin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.