* [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
[not found] <201607021540.sGu2oITV%fengguang.wu@intel.com>
@ 2016-07-02 9:21 ` murray foster
2016-07-08 21:23 ` Handrigan, Paul
0 siblings, 1 reply; 8+ messages in thread
From: murray foster @ 2016-07-02 9:21 UTC (permalink / raw)
To: kbuild test robot
Cc: brian.austin, Paul.Handrigan, kbuild-all, alsa-devel, timur
Mismatching stream names in DAPM route and widget definitions are
causing compilation errors. Fixing these names allows the cs4270
driver to compile and function.
Signed-off-by: Murray Foster <mrafoster@gmail.com>
---
Changes in v2:
- Remove the 's' typo at the beginning of the codec driver.
sound/soc/codecs/cs4270.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
index e07807d..3670086 100644
--- a/sound/soc/codecs/cs4270.c
+++ b/sound/soc/codecs/cs4270.c
@@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"),
};
static const struct snd_soc_dapm_route cs4270_dapm_routes[] = {
- { "Capture", NULL, "AINA" },
- { "Capture", NULL, "AINB" },
+ { "Capture", NULL, "AINL" },
+ { "Capture", NULL, "AINR" },
- { "AOUTA", NULL, "Playback" },
- { "AOUTB", NULL, "Playback" },
+ { "AOUTL", NULL, "Playback" },
+ { "AOUTR", NULL, "Playback" },
};
/**
--
2.4.9
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
2016-07-02 9:21 ` [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch murray foster
@ 2016-07-08 21:23 ` Handrigan, Paul
2016-10-06 18:43 ` murray foster
0 siblings, 1 reply; 8+ messages in thread
From: Handrigan, Paul @ 2016-07-08 21:23 UTC (permalink / raw)
To: murray foster, broonie, Liam Girdwood; +Cc: Austin, Brian, timur, alsa-devel
On 7/2/16, 4:21 AM, "murray foster" <mrafoster@gmail.com> wrote:
>
>Mismatching stream names in DAPM route and widget definitions are
>causing compilation errors. Fixing these names allows the cs4270
>driver to compile and function.
>
>Signed-off-by: Murray Foster <mrafoster@gmail.com>
>---
>Changes in v2:
> - Remove the 's' typo at the beginning of the codec driver.
>
> sound/soc/codecs/cs4270.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
>index e07807d..3670086 100644
>--- a/sound/soc/codecs/cs4270.c
>+++ b/sound/soc/codecs/cs4270.c
>@@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"),
> };
>
> static const struct snd_soc_dapm_route cs4270_dapm_routes[] = {
>- { "Capture", NULL, "AINA" },
>- { "Capture", NULL, "AINB" },
>+ { "Capture", NULL, "AINL" },
>+ { "Capture", NULL, "AINR" },
>
>- { "AOUTA", NULL, "Playback" },
>- { "AOUTB", NULL, "Playback" },
>+ { "AOUTL", NULL, "Playback" },
>+ { "AOUTR", NULL, "Playback" },
> };
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
2016-07-08 21:23 ` Handrigan, Paul
@ 2016-10-06 18:43 ` murray foster
2016-10-06 19:41 ` Lars-Peter Clausen
2016-10-06 19:50 ` Mark Brown
0 siblings, 2 replies; 8+ messages in thread
From: murray foster @ 2016-10-06 18:43 UTC (permalink / raw)
To: Handrigan, Paul; +Cc: Austin, Brian, broonie, Liam Girdwood, alsa-devel
On Fri, 8 Jul 2016, Handrigan, Paul wrote:
>
> Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
>
What's the next step after patch acknowledgement? I'm a newbie on the list
so I'm sure there's some step I've missed or misinterpreted.
Murray
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
2016-10-06 18:43 ` murray foster
@ 2016-10-06 19:41 ` Lars-Peter Clausen
2016-10-06 21:39 ` Mark Brown
2016-10-06 19:50 ` Mark Brown
1 sibling, 1 reply; 8+ messages in thread
From: Lars-Peter Clausen @ 2016-10-06 19:41 UTC (permalink / raw)
To: murray foster, Handrigan, Paul
Cc: Austin, Brian, broonie, Liam Girdwood, alsa-devel
On 10/06/2016 08:43 PM, murray foster wrote:
>
> On Fri, 8 Jul 2016, Handrigan, Paul wrote:
>
>>
>> Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
>>
>
> What's the next step after patch acknowledgement? I'm a newbie on the list
> so I'm sure there's some step I've missed or misinterpreted.
Apply is the next step. But sometimes patches get lost, simply due to the
sheer volume.
Best is to re-send the patch with the Acked-by added to the commit message
and make sure send the patch to maintainers (Mark and Liam) with the ALSA
list on Cc. This will make sure that they see the patch and it gets applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
2016-10-06 18:43 ` murray foster
2016-10-06 19:41 ` Lars-Peter Clausen
@ 2016-10-06 19:50 ` Mark Brown
1 sibling, 0 replies; 8+ messages in thread
From: Mark Brown @ 2016-10-06 19:50 UTC (permalink / raw)
To: murray foster; +Cc: Austin, Brian, alsa-devel, Liam Girdwood, Handrigan, Paul
[-- Attachment #1.1: Type: text/plain, Size: 520 bytes --]
On Thu, Oct 06, 2016 at 11:43:09AM -0700, murray foster wrote:
> What's the next step after patch acknowledgement? I'm a newbie on the list
> so I'm sure there's some step I've missed or misinterpreted.
As documented in SubmittingPatches please send patches to the
maintainers for the code you would like to change. The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
2016-10-06 19:41 ` Lars-Peter Clausen
@ 2016-10-06 21:39 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2016-10-06 21:39 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Austin, Brian, alsa-devel, Liam Girdwood, Handrigan, Paul, murray foster
[-- Attachment #1.1: Type: text/plain, Size: 362 bytes --]
On Thu, Oct 06, 2016 at 09:41:13PM +0200, Lars-Peter Clausen wrote:
> Best is to re-send the patch with the Acked-by added to the commit message
> and make sure send the patch to maintainers (Mark and Liam) with the ALSA
> list on Cc. This will make sure that they see the patch and it gets applied.
I didn't get sent the original e-mail in the first place :(
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
2016-10-09 20:28 murray foster
@ 2016-10-11 13:23 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2016-10-11 13:23 UTC (permalink / raw)
To: murray foster; +Cc: Austin, Brian, alsa-devel, Liam Girdwood, Handrigan, Paul
[-- Attachment #1.1: Type: text/plain, Size: 415 bytes --]
On Sun, Oct 09, 2016 at 01:28:45PM -0700, murray foster wrote:
> Mismatching stream names in DAPM route and widget definitions are
> causing compilation errors. Fixing these names allows the cs4270
> driver to compile and function.
This commit log can't be right, we've got extensive build coverage and
there's no way build coverage could spot a mismatch between strings.
I'm assuming this happens at probe time?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch
@ 2016-10-09 20:28 murray foster
2016-10-11 13:23 ` Mark Brown
0 siblings, 1 reply; 8+ messages in thread
From: murray foster @ 2016-10-09 20:28 UTC (permalink / raw)
To: broonie, Liam Girdwood; +Cc: alsa-devel, Austin, Brian, Handrigan, Paul
Mismatching stream names in DAPM route and widget definitions are
causing compilation errors. Fixing these names allows the cs4270
driver to compile and function.
Signed-off-by: Murray Foster <mrafoster@gmail.com>
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
---
sound/soc/codecs/cs4270.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
index e07807d..3670086 100644
--- a/sound/soc/codecs/cs4270.c
+++ b/sound/soc/codecs/cs4270.c
@@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"),
};
static const struct snd_soc_dapm_route cs4270_dapm_routes[] = {
- { "Capture", NULL, "AINA" },
- { "Capture", NULL, "AINB" },
+ { "Capture", NULL, "AINL" },
+ { "Capture", NULL, "AINR" },
- { "AOUTA", NULL, "Playback" },
- { "AOUTB", NULL, "Playback" },
+ { "AOUTL", NULL, "Playback" },
+ { "AOUTR", NULL, "Playback" },
};
/**
--
2.4.9
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-11 13:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201607021540.sGu2oITV%fengguang.wu@intel.com>
2016-07-02 9:21 ` [PATCH v2] ASoC: cs4270: fix DAPM stream name mismatch murray foster
2016-07-08 21:23 ` Handrigan, Paul
2016-10-06 18:43 ` murray foster
2016-10-06 19:41 ` Lars-Peter Clausen
2016-10-06 21:39 ` Mark Brown
2016-10-06 19:50 ` Mark Brown
2016-10-09 20:28 murray foster
2016-10-11 13:23 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.