All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Refine eDP aux backlight enable sequence.
@ 2019-06-13  5:47 Lee, Shawn C
  2019-06-13  5:41 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Lee, Shawn C @ 2019-06-13  5:47 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Cooper Chiou, Lee

Modify aux backlight enable sequence just like what we
did for genernal eDP panel.
1. Setup PWM freq and brightness level before enable display backlight.
2. Add T8 (valid data to backlight enable) delay.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>

Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
---
 drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
index 7ded95a334db..c112e0b930de 100644
--- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
@@ -216,8 +216,12 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st
 		}
 	}
 
-	set_aux_backlight_enable(intel_dp, true);
 	intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level);
+
+	wait_remaining_ms_from_jiffies(intel_dp->last_power_on,
+				       intel_dp->backlight_on_delay);
+
+	set_aux_backlight_enable(intel_dp, true);
 }
 
 static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state)
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-06-14 17:07 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13  5:47 [PATCH] drm/i915: Refine eDP aux backlight enable sequence Lee, Shawn C
2019-06-13  5:41 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-06-13  6:01 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-13  9:19 ` [PATCH] " Ville Syrjälä
2019-06-13 13:16   ` Jani Nikula
2019-06-14  1:42     ` Lee, Shawn C
2019-06-14  7:58       ` Jani Nikula
2019-06-14 17:07 ` ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.