* ✓ Fi.CI.BAT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
@ 2019-06-19 3:09 ` Patchwork
2019-06-19 7:34 ` [PATCH] " Jani Nikula
` (10 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-19 3:09 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton
URL : https://patchwork.freedesktop.org/series/62362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6300 -> Patchwork_13341
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/
Known issues
------------
Here are the changes found in Patchwork_13341 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@basic-default:
- fi-icl-guc: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@prime_vgem@basic-write:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-icl-u3/igt@prime_vgem@basic-write.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-icl-u3/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
* igt@gem_mmap_gtt@basic-read-no-prefault:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-icl-u3/igt@gem_mmap_gtt@basic-read-no-prefault.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-icl-u3/igt@gem_mmap_gtt@basic-read-no-prefault.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#109485]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][13] ([fdo#103167]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@prime_busy@basic-wait-after-default:
- fi-icl-dsi: [INCOMPLETE][15] ([fdo#107713]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/fi-icl-dsi/igt@prime_busy@basic-wait-after-default.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/fi-icl-dsi/igt@prime_busy@basic-wait-after-default.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (44 -> 36)
------------------------------
Additional (1): fi-gdg-551
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6300 -> Patchwork_13341
CI_DRM_6300: a0694108fecf62a79e0be32e578f25fdcbf466e4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13341: 98ac3031bec3a2e3680bf8c57b86a77a15bbfcea @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
98ac3031bec3 drm/i915: Check backlight type while doing eDP backlight initializaiton
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton
@ 2019-06-19 3:10 Lee, Shawn C
2019-06-19 3:09 ` ✓ Fi.CI.BAT: success for " Patchwork
` (11 more replies)
0 siblings, 12 replies; 20+ messages in thread
From: Lee, Shawn C @ 2019-06-19 3:10 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou, Lee, Jani Nikula
If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
Driver should check panel capability and try to initialize aux backlight.
No matter i915_modparams.enable_dpcd_backlight was enabled or not.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.h | 1 +
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 11 ++++++++++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 4e42cfaf61a7..0b7be6389a07 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -42,6 +42,7 @@ enum intel_backlight_type {
INTEL_BACKLIGHT_DISPLAY_DDI,
INTEL_BACKLIGHT_DSI_DCS,
INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
+ INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
};
struct edp_power_seq {
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 7ded95a334db..0cca5b732ccf 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -261,11 +261,20 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
return false;
}
+static bool
+intel_dp_bios_use_aux_backlight(struct drm_i915_private *dev_priv)
+{
+ if (dev_priv->vbt.backlight.type == INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)
+ return true;
+ return false;
+}
+
int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
{
struct intel_panel *panel = &intel_connector->panel;
- if (!i915_modparams.enable_dpcd_backlight)
+ if (!i915_modparams.enable_dpcd_backlight &&
+ !intel_dp_bios_use_aux_backlight(to_i915(intel_connector->base.dev)))
return -ENODEV;
if (!intel_dp_aux_display_control_capable(intel_connector))
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
2019-06-19 3:09 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-06-19 7:34 ` Jani Nikula
2019-06-19 8:43 ` [PATCH v2] " Lee Shawn C
` (9 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-06-19 7:34 UTC (permalink / raw)
To: Lee, Shawn C, intel-gfx; +Cc: Cooper Chiou, Lee
On Tue, 18 Jun 2019, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
> Driver should check panel capability and try to initialize aux backlight.
> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
The usual thing to do is to set i915.enable_dpcd_backlight initial value
to -1 (i.e. make it an int), and with that default value respect
VBT. Otherwise, respect the value of enable_dpcd_backlight.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
>
> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 11 ++++++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> index 4e42cfaf61a7..0b7be6389a07 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.h
> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> @@ -42,6 +42,7 @@ enum intel_backlight_type {
> INTEL_BACKLIGHT_DISPLAY_DDI,
> INTEL_BACKLIGHT_DSI_DCS,
> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
> };
>
> struct edp_power_seq {
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 7ded95a334db..0cca5b732ccf 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -261,11 +261,20 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
> return false;
> }
>
> +static bool
> +intel_dp_bios_use_aux_backlight(struct drm_i915_private *dev_priv)
> +{
> + if (dev_priv->vbt.backlight.type == INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)
> + return true;
> + return false;
> +}
I think I'd just access dev_priv->vbt.backlight.type directly from
intel_dp_aux_init_backlight_funcs.
BR,
Jani.
> +
> int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
> {
> struct intel_panel *panel = &intel_connector->panel;
>
> - if (!i915_modparams.enable_dpcd_backlight)
> + if (!i915_modparams.enable_dpcd_backlight &&
> + !intel_dp_bios_use_aux_backlight(to_i915(intel_connector->base.dev)))
> return -ENODEV;
>
> if (!intel_dp_aux_display_control_capable(intel_connector))
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v2] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
2019-06-19 3:09 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-19 7:34 ` [PATCH] " Jani Nikula
@ 2019-06-19 8:43 ` Lee Shawn C
2019-06-19 9:40 ` Jani Nikula
2019-06-20 15:44 ` [PATCH v3] " Lee Shawn C
2019-06-19 9:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2) Patchwork
` (8 subsequent siblings)
11 siblings, 2 replies; 20+ messages in thread
From: Lee Shawn C @ 2019-06-19 8:43 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Cooper Chiou
If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
Driver should check panel capability and try to initialize aux backlight.
No matter i915_modparams.enable_dpcd_backlight was enabled or not.
v2: access dev_priv->vbt.backlight.type directly and remove unused function.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.h | 1 +
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 4e42cfaf61a7..0b7be6389a07 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -42,6 +42,7 @@ enum intel_backlight_type {
INTEL_BACKLIGHT_DISPLAY_DDI,
INTEL_BACKLIGHT_DSI_DCS,
INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
+ INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
};
struct edp_power_seq {
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 7ded95a334db..db7c7b9f9b56 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -264,8 +264,10 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
{
struct intel_panel *panel = &intel_connector->panel;
+ struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev);
- if (!i915_modparams.enable_dpcd_backlight)
+ if (!i915_modparams.enable_dpcd_backlight &&
+ (dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
return -ENODEV;
if (!intel_dp_aux_display_control_capable(intel_connector))
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (2 preceding siblings ...)
2019-06-19 8:43 ` [PATCH v2] " Lee Shawn C
@ 2019-06-19 9:26 ` Patchwork
2019-06-19 10:13 ` ✓ Fi.CI.BAT: success " Patchwork
` (7 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-19 9:26 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2)
URL : https://patchwork.freedesktop.org/series/62362/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
74f5fc6b38e7 drm/i915: Check backlight type while doing eDP backlight initializaiton
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
v2: access dev_priv->vbt.backlight.type directly and remove unused function.
-:46: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE'
#46: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:269:
+ if (!i915_modparams.enable_dpcd_backlight &&
+ (dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
total: 0 errors, 1 warnings, 1 checks, 18 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 8:43 ` [PATCH v2] " Lee Shawn C
@ 2019-06-19 9:40 ` Jani Nikula
2019-06-20 2:09 ` Lee, Shawn C
2019-06-20 15:44 ` [PATCH v3] " Lee Shawn C
1 sibling, 1 reply; 20+ messages in thread
From: Jani Nikula @ 2019-06-19 9:40 UTC (permalink / raw)
To: Lee Shawn C, intel-gfx; +Cc: Cooper Chiou
On Wed, 19 Jun 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
> Driver should check panel capability and try to initialize aux backlight.
> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
>
> v2: access dev_priv->vbt.backlight.type directly and remove unused function.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> index 4e42cfaf61a7..0b7be6389a07 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.h
> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> @@ -42,6 +42,7 @@ enum intel_backlight_type {
> INTEL_BACKLIGHT_DISPLAY_DDI,
> INTEL_BACKLIGHT_DSI_DCS,
> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
> };
>
> struct edp_power_seq {
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 7ded95a334db..db7c7b9f9b56 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -264,8 +264,10 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
> int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
> {
> struct intel_panel *panel = &intel_connector->panel;
> + struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev);
>
> - if (!i915_modparams.enable_dpcd_backlight)
> + if (!i915_modparams.enable_dpcd_backlight &&
> + (dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
> return -ENODEV;
There was also this part in the v1 review:
The usual thing to do is to set i915.enable_dpcd_backlight initial value
to -1 (i.e. make it an int), and with that default value respect
VBT. Otherwise, respect the value of enable_dpcd_backlight.
BR,
Jani.
>
> if (!intel_dp_aux_display_control_capable(intel_connector))
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (3 preceding siblings ...)
2019-06-19 9:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2) Patchwork
@ 2019-06-19 10:13 ` Patchwork
2019-06-19 19:41 ` ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton Patchwork
` (6 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-19 10:13 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2)
URL : https://patchwork.freedesktop.org/series/62362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6301 -> Patchwork_13344
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/
Known issues
------------
Here are the changes found in Patchwork_13344 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-icl-u3: [INCOMPLETE][3] ([fdo#107713] / [fdo#109100]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/fi-icl-u3/igt@gem_ctx_create@basic-files.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/fi-icl-u3/igt@gem_ctx_create@basic-files.html
* igt@gem_sync@basic-store-each:
- fi-skl-iommu: [FAIL][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/fi-skl-iommu/igt@gem_sync@basic-store-each.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/fi-skl-iommu/igt@gem_sync@basic-store-each.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#109485]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (52 -> 43)
------------------------------
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6301 -> Patchwork_13344
CI_DRM_6301: d65ad97b4176e73b5c7edfad404cdd962b528baf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5060: c6a0e43633a399899278353e452a52bb41ac96e1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13344: 74f5fc6b38e7742b8308427f7e724a988f3c53ee @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
74f5fc6b38e7 drm/i915: Check backlight type while doing eDP backlight initializaiton
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (4 preceding siblings ...)
2019-06-19 10:13 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-19 19:41 ` Patchwork
2019-06-20 1:40 ` ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2) Patchwork
` (5 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-19 19:41 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton
URL : https://patchwork.freedesktop.org/series/62362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6300_full -> Patchwork_13341_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13341_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-apl5/igt@gem_eio@in-flight-contexts-1us.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-apl1/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@suspend:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([fdo#110913 ]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-kbl7/igt@gem_eio@suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-kbl7/igt@gem_eio@suspend.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_suspend@fence-restore-untiled:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([fdo#104108] / [fdo#107773])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-skl6/igt@i915_suspend@fence-restore-untiled.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-skl10/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-random:
- shard-apl: [PASS][9] -> [FAIL][10] ([fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][11] -> [FAIL][12] ([fdo#105767])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#103184] / [fdo#103232])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-skl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][15] -> [INCOMPLETE][16] ([fdo#105411])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-snb6/igt@kms_flip@flip-vs-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-hsw: [PASS][19] -> [SKIP][20] ([fdo#109271]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109642])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb2/igt@kms_psr@psr2_suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb6/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-apl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_eio@in-flight-10ms:
- shard-kbl: [DMESG-WARN][27] ([fdo#110913 ]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-kbl6/igt@gem_eio@in-flight-10ms.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-kbl3/igt@gem_eio@in-flight-10ms.html
* igt@gem_exec_create@forked:
- shard-glk: [FAIL][29] -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-glk2/igt@gem_exec_create@forked.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-glk1/igt@gem_exec_create@forked.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [INCOMPLETE][31] ([fdo#105411]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-snb5/igt@gem_mmap_gtt@hang.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-snb5/igt@gem_mmap_gtt@hang.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-apl: [DMESG-WARN][33] ([fdo#110913 ]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-apl4/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-apl2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][35] ([fdo#104108]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-skl7/igt@gem_softpin@noreloc-s3.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-skl5/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][37] ([fdo#110913 ]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][39] ([fdo#108566]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-apl1/igt@i915_suspend@debugfs-reader.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-apl8/igt@i915_suspend@debugfs-reader.html
* igt@kms_busy@extended-modeset-hang-oldfb-render-a:
- shard-apl: [INCOMPLETE][41] ([fdo#103927]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-apl3/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-apl2/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [INCOMPLETE][43] ([fdo#103665]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-render-xtiled:
- shard-iclb: [FAIL][45] ([fdo#103184] / [fdo#103232]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb4/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb4/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][47] ([fdo#105363]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [FAIL][49] ([fdo#103167]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][51] ([fdo#109271]) -> [PASS][52] +31 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][53] ([fdo#103166]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_sysfs_edid_timing:
- shard-hsw: [FAIL][57] ([fdo#100047]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-hsw1/igt@kms_sysfs_edid_timing.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-hsw4/igt@kms_sysfs_edid_timing.html
- shard-iclb: [FAIL][59] ([fdo#100047]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-iclb2/igt@kms_sysfs_edid_timing.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-iclb6/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-skl: [FAIL][61] ([fdo#103167]) -> [FAIL][62] ([fdo#108040])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6300/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6300 -> Patchwork_13341
CI_DRM_6300: a0694108fecf62a79e0be32e578f25fdcbf466e4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13341: 98ac3031bec3a2e3680bf8c57b86a77a15bbfcea @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13341/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (5 preceding siblings ...)
2019-06-19 19:41 ` ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton Patchwork
@ 2019-06-20 1:40 ` Patchwork
2019-06-20 19:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3) Patchwork
` (4 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-20 1:40 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2)
URL : https://patchwork.freedesktop.org/series/62362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6301_full -> Patchwork_13344_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13344_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-apl: [PASS][1] -> [DMESG-FAIL][2] ([fdo#108566])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl1/igt@gem_eio@in-flight-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl5/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb4/igt@gem_exec_balancer@smoke.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb6/igt@gem_exec_balancer@smoke.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-kbl3/igt@gem_persistent_relocs@forked-thrashing.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-kbl7/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([fdo#104108] / [fdo#107773])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-skl8/igt@gem_softpin@noreloc-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-skl4/igt@gem_softpin@noreloc-s3.html
* igt@gem_sync@basic-each:
- shard-hsw: [PASS][11] -> [INCOMPLETE][12] ([fdo#103540])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-hsw5/igt@gem_sync@basic-each.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-hsw5/igt@gem_sync@basic-each.html
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108686])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl6/igt@gem_tiled_swapping@non-threaded.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl5/igt@gem_tiled_swapping@non-threaded.html
- shard-hsw: [PASS][15] -> [FAIL][16] ([fdo#108686])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-hsw2/igt@gem_tiled_swapping@non-threaded.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-hsw2/igt@gem_tiled_swapping@non-threaded.html
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([fdo#108686])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-kbl1/igt@gem_tiled_swapping@non-threaded.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-kbl2/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
- shard-hsw: [PASS][21] -> [SKIP][22] ([fdo#109271]) +17 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-hsw2/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-hsw1/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#109507])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-skl2/igt@kms_flip@flip-vs-suspend-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [PASS][27] -> [INCOMPLETE][28] ([fdo#104108])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103166])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-y.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][33] -> [FAIL][34] ([fdo#99912])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl6/igt@kms_setmode@basic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl4/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_eio@wait-wedge-immediate:
- shard-kbl: [DMESG-WARN][35] ([fdo#110913 ]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-kbl3/igt@gem_eio@wait-wedge-immediate.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-kbl7/igt@gem_eio@wait-wedge-immediate.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-snb: [DMESG-WARN][37] ([fdo#110789] / [fdo#110913 ]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-apl: [DMESG-WARN][39] ([fdo#110913 ]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl8/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][41] ([fdo#110913 ]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-apl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
- shard-kbl: [FAIL][45] ([fdo#103232]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][47] ([fdo#104873]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-hsw: [SKIP][49] ([fdo#109271]) -> [PASS][50] +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [FAIL][51] ([fdo#103167]) -> [PASS][52] +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][53] ([fdo#103166]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][57] ([fdo#99912]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-kbl6/igt@kms_setmode@basic.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-kbl6/igt@kms_setmode@basic.html
* igt@tools_test@tools_test:
- shard-glk: [SKIP][59] ([fdo#109271]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-glk4/igt@tools_test@tools_test.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-glk6/igt@tools_test@tools_test.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [FAIL][61] ([fdo#108040]) -> [FAIL][62] ([fdo#103167])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6301/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6301 -> Patchwork_13344
CI_DRM_6301: d65ad97b4176e73b5c7edfad404cdd962b528baf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5060: c6a0e43633a399899278353e452a52bb41ac96e1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13344: 74f5fc6b38e7742b8308427f7e724a988f3c53ee @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13344/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 9:40 ` Jani Nikula
@ 2019-06-20 2:09 ` Lee, Shawn C
2019-06-20 9:00 ` Jani Nikula
0 siblings, 1 reply; 20+ messages in thread
From: Lee, Shawn C @ 2019-06-20 2:09 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx; +Cc: Chiou, Cooper
On Wed, 19 Jun 2019, Jani Nikula <jani.nikula@intel.com> wrote:
>On Wed, 19 Jun 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
>> Driver should check panel capability and try to initialize aux backlight.
>> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
>>
>> v2: access dev_priv->vbt.backlight.type directly and remove unused function.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Jose Roberto de Souza <jose.souza@intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 +++-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h
>> b/drivers/gpu/drm/i915/display/intel_bios.h
>> index 4e42cfaf61a7..0b7be6389a07 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.h
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
>> @@ -42,6 +42,7 @@ enum intel_backlight_type {
>> INTEL_BACKLIGHT_DISPLAY_DDI,
>> INTEL_BACKLIGHT_DSI_DCS,
>> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
>> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
>> };
>>
>> struct edp_power_seq {
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> index 7ded95a334db..db7c7b9f9b56 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> @@ -264,8 +264,10 @@ intel_dp_aux_display_control_capable(struct
>> intel_connector *connector) int
>> intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) {
>> struct intel_panel *panel = &intel_connector->panel;
>> + struct drm_i915_private *dev_priv =
>> +to_i915(intel_connector->base.dev);
>>
>> - if (!i915_modparams.enable_dpcd_backlight)
>> + if (!i915_modparams.enable_dpcd_backlight &&
>> + (dev_priv->vbt.backlight.type !=
>> +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
>> return -ENODEV;
>
>There was also this part in the v1 review:
>
> The usual thing to do is to set i915.enable_dpcd_backlight initial value
> to -1 (i.e. make it an int), and with that default value respect
> VBT. Otherwise, respect the value of enable_dpcd_backlight.
>
>
>BR,
>Jani.
Do you mean we should do following?
1. Change i915.enable_dpcd_backlight type from bool to int.
2. Give default value as -1 for enable_dpcd_backlight in i915_param.h.
3. Add a judgement to check LFP backlight type was aux interface or not.
Between if (!i915_modparams.enable_dpcd_backlight) and
if (!intel_dp_aux_display_control_capable(intel_connector)).
Best regards,
Shawn
>>
>> if (!intel_dp_aux_display_control_capable(intel_connector))
>
>--
>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-20 2:09 ` Lee, Shawn C
@ 2019-06-20 9:00 ` Jani Nikula
0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-06-20 9:00 UTC (permalink / raw)
To: 1560933806-5184-1-git-send-email-shawn.c.lee, intel-gfx; +Cc: Chiou, Cooper
On Thu, 20 Jun 2019, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> On Wed, 19 Jun 2019, Jani Nikula <jani.nikula@intel.com> wrote:
>>On Wed, 19 Jun 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
>>> Driver should check panel capability and try to initialize aux backlight.
>>> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
>>>
>>> v2: access dev_priv->vbt.backlight.type directly and remove unused function.
>>>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: Jose Roberto de Souza <jose.souza@intel.com>
>>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>>
>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
>>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 +++-
>>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h
>>> b/drivers/gpu/drm/i915/display/intel_bios.h
>>> index 4e42cfaf61a7..0b7be6389a07 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_bios.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
>>> @@ -42,6 +42,7 @@ enum intel_backlight_type {
>>> INTEL_BACKLIGHT_DISPLAY_DDI,
>>> INTEL_BACKLIGHT_DSI_DCS,
>>> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
>>> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
>>> };
>>>
>>> struct edp_power_seq {
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> index 7ded95a334db..db7c7b9f9b56 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> @@ -264,8 +264,10 @@ intel_dp_aux_display_control_capable(struct
>>> intel_connector *connector) int
>>> intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) {
>>> struct intel_panel *panel = &intel_connector->panel;
>>> + struct drm_i915_private *dev_priv =
>>> +to_i915(intel_connector->base.dev);
>>>
>>> - if (!i915_modparams.enable_dpcd_backlight)
>>> + if (!i915_modparams.enable_dpcd_backlight &&
>>> + (dev_priv->vbt.backlight.type !=
>>> +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
>>> return -ENODEV;
>>
>>There was also this part in the v1 review:
>>
>> The usual thing to do is to set i915.enable_dpcd_backlight initial value
>> to -1 (i.e. make it an int), and with that default value respect
>> VBT. Otherwise, respect the value of enable_dpcd_backlight.
>>
>>
>>BR,
>>Jani.
>
> Do you mean we should do following?
> 1. Change i915.enable_dpcd_backlight type from bool to int.
Yes.
> 2. Give default value as -1 for enable_dpcd_backlight in i915_param.h.
Yes.
> 3. Add a judgement to check LFP backlight type was aux interface or not.
> Between if (!i915_modparams.enable_dpcd_backlight) and
> if (!intel_dp_aux_display_control_capable(intel_connector)).
Basically replace:
if (!i915_modparams.enable_dpcd_backlight)
return -ENODEV;
with something like this:
if (i915_modparams.enable_dpcd_backlight == 0 ||
(i915_modparams.enable_dpcd_backlight == -1 &&
dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
return -ENODEV;
i.e. if modparam == -1, use vbt, otherwise use modparam. This lets you
override vbt using the modparam.
You'll still have the capability check below like before.
BR,
Jani.
>
> Best regards,
> Shawn
>
>>>
>>> if (!intel_dp_aux_display_control_capable(intel_connector))
>>
>>--
>>Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-19 8:43 ` [PATCH v2] " Lee Shawn C
2019-06-19 9:40 ` Jani Nikula
@ 2019-06-20 15:44 ` Lee Shawn C
2019-06-25 14:03 ` Jani Nikula
1 sibling, 1 reply; 20+ messages in thread
From: Lee Shawn C @ 2019-06-20 15:44 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Cooper Chiou
If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
Driver should check panel capability and try to initialize aux backlight.
No matter i915_modparams.enable_dpcd_backlight was enabled or not.
v2: access dev_priv->vbt.backlight.type directly and remove unused function.
v3: 1. Modify i915.enable_dpcd_backlight type from bool to int and give default
value as 0 (disable).
2. Add a judgement to check LFP backlight type was aux interface or not.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.h | 1 +
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 5 ++++-
drivers/gpu/drm/i915/i915_params.c | 5 +++--
drivers/gpu/drm/i915/i915_params.h | 2 +-
4 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
index 4e42cfaf61a7..0b7be6389a07 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.h
+++ b/drivers/gpu/drm/i915/display/intel_bios.h
@@ -42,6 +42,7 @@ enum intel_backlight_type {
INTEL_BACKLIGHT_DISPLAY_DDI,
INTEL_BACKLIGHT_DSI_DCS,
INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
+ INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
};
struct edp_power_seq {
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 7ded95a334db..6b0b73479fb8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -264,8 +264,11 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
{
struct intel_panel *panel = &intel_connector->panel;
+ struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev);
- if (!i915_modparams.enable_dpcd_backlight)
+ if (i915_modparams.enable_dpcd_backlight == 0 ||
+ (i915_modparams.enable_dpcd_backlight == -1 &&
+ dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
return -ENODEV;
if (!intel_dp_aux_display_control_capable(intel_connector))
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 5b07766a1c26..296452f9efe4 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -169,8 +169,9 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)");
#endif
-i915_param_named(enable_dpcd_backlight, bool, 0600,
- "Enable support for DPCD backlight control (default:false)");
+i915_param_named(enable_dpcd_backlight, int, 0600,
+ "Enable support for DPCD backlight control"
+ "(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)");
#if IS_ENABLED(CONFIG_DRM_I915_GVT)
i915_param_named(enable_gvt, bool, 0400,
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index a4770ce46bd2..d29ade3b7de6 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -64,6 +64,7 @@ struct drm_printer;
param(int, reset, 2) \
param(unsigned int, inject_load_failure, 0) \
param(int, fastboot, -1) \
+ param(int, enable_dpcd_backlight, 0) \
param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \
/* leave bools at the end to not create holes */ \
param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
@@ -76,7 +77,6 @@ struct drm_printer;
param(bool, verbose_state_checks, true) \
param(bool, nuclear_pageflip, false) \
param(bool, enable_dp_mst, true) \
- param(bool, enable_dpcd_backlight, false) \
param(bool, enable_gvt, false)
#define MEMBER(T, member, ...) T member;
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (6 preceding siblings ...)
2019-06-20 1:40 ` ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2) Patchwork
@ 2019-06-20 19:34 ` Patchwork
2019-06-20 19:54 ` ✗ Fi.CI.BAT: failure " Patchwork
` (3 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-20 19:34 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3)
URL : https://patchwork.freedesktop.org/series/62362/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cddef96419ec drm/i915: Check backlight type while doing eDP backlight initializaiton
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
v2: access dev_priv->vbt.backlight.type directly and remove unused function.
-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/i915/i915_params.c:173:
+i915_param_named(enable_dpcd_backlight, int, 0600,
+ "Enable support for DPCD backlight control"
total: 0 errors, 1 warnings, 1 checks, 44 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (7 preceding siblings ...)
2019-06-20 19:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3) Patchwork
@ 2019-06-20 19:54 ` Patchwork
2019-06-25 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4) Patchwork
` (2 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-20 19:54 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3)
URL : https://patchwork.freedesktop.org/series/62362/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6316 -> Patchwork_13370
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13370 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13370, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13370:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-hsw-4770r: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6316/fi-hsw-4770r/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/fi-hsw-4770r/igt@i915_module_load@reload-with-fault-injection.html
Known issues
------------
Here are the changes found in Patchwork_13370 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6316/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_blt:
- fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#108602])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6316/fi-skl-iommu/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/fi-skl-iommu/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][7] -> [DMESG-FAIL][8] ([fdo#110235])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6316/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6316/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-icl-dsi: [INCOMPLETE][11] ([fdo#107713] / [fdo#108840]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6316/fi-icl-dsi/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/fi-icl-dsi/igt@i915_pm_rpm@module-reload.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (53 -> 44)
------------------------------
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u3 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6316 -> Patchwork_13370
CI_DRM_6316: 8c1cf5bd27307e6cb0cdc02a1ac9d29bcdcb5056 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5064: 22850c1906550fb97b405c019275dcfb34be8cf7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13370: cddef96419ecd0a1ca12c8a4846bbd5cf9929134 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
cddef96419ec drm/i915: Check backlight type while doing eDP backlight initializaiton
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13370/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-20 15:44 ` [PATCH v3] " Lee Shawn C
@ 2019-06-25 14:03 ` Jani Nikula
2019-06-25 14:33 ` Lee, Shawn C
0 siblings, 1 reply; 20+ messages in thread
From: Jani Nikula @ 2019-06-25 14:03 UTC (permalink / raw)
To: Lee Shawn C, intel-gfx; +Cc: Cooper Chiou
On Thu, 20 Jun 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
> Driver should check panel capability and try to initialize aux backlight.
> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
>
> v2: access dev_priv->vbt.backlight.type directly and remove unused function.
> v3: 1. Modify i915.enable_dpcd_backlight type from bool to int and give default
> value as 0 (disable).
I was thinking we'd change the default to -1 to trust the VBT, but might
be just as well to start with this and change the default later.
CI flagged errors for some reasons, I've queued a retest. I don't think
it was caused by this patch.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 2. Add a judgement to check LFP backlight type was aux interface or not.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 5 ++++-
> drivers/gpu/drm/i915/i915_params.c | 5 +++--
> drivers/gpu/drm/i915/i915_params.h | 2 +-
> 4 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/intel_bios.h
> index 4e42cfaf61a7..0b7be6389a07 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.h
> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
> @@ -42,6 +42,7 @@ enum intel_backlight_type {
> INTEL_BACKLIGHT_DISPLAY_DDI,
> INTEL_BACKLIGHT_DSI_DCS,
> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
> };
>
> struct edp_power_seq {
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 7ded95a334db..6b0b73479fb8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -264,8 +264,11 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
> int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
> {
> struct intel_panel *panel = &intel_connector->panel;
> + struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev);
>
> - if (!i915_modparams.enable_dpcd_backlight)
> + if (i915_modparams.enable_dpcd_backlight == 0 ||
> + (i915_modparams.enable_dpcd_backlight == -1 &&
> + dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
> return -ENODEV;
>
> if (!intel_dp_aux_display_control_capable(intel_connector))
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 5b07766a1c26..296452f9efe4 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -169,8 +169,9 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
> "Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)");
> #endif
>
> -i915_param_named(enable_dpcd_backlight, bool, 0600,
> - "Enable support for DPCD backlight control (default:false)");
> +i915_param_named(enable_dpcd_backlight, int, 0600,
> + "Enable support for DPCD backlight control"
> + "(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)");
>
> #if IS_ENABLED(CONFIG_DRM_I915_GVT)
> i915_param_named(enable_gvt, bool, 0400,
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index a4770ce46bd2..d29ade3b7de6 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -64,6 +64,7 @@ struct drm_printer;
> param(int, reset, 2) \
> param(unsigned int, inject_load_failure, 0) \
> param(int, fastboot, -1) \
> + param(int, enable_dpcd_backlight, 0) \
> param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \
> /* leave bools at the end to not create holes */ \
> param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
> @@ -76,7 +77,6 @@ struct drm_printer;
> param(bool, verbose_state_checks, true) \
> param(bool, nuclear_pageflip, false) \
> param(bool, enable_dp_mst, true) \
> - param(bool, enable_dpcd_backlight, false) \
> param(bool, enable_gvt, false)
>
> #define MEMBER(T, member, ...) T member;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-25 14:03 ` Jani Nikula
@ 2019-06-25 14:33 ` Lee, Shawn C
2019-06-26 15:04 ` Jani Nikula
0 siblings, 1 reply; 20+ messages in thread
From: Lee, Shawn C @ 2019-06-25 14:33 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx; +Cc: Chiou, Cooper
On Tue, 25 Jun 2019, Jani Nikula <jani.nikula@intel.com> wrote:
>On Thu, 20 Jun 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
>> Driver should check panel capability and try to initialize aux backlight.
>> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
>>
>> v2: access dev_priv->vbt.backlight.type directly and remove unused function.
>> v3: 1. Modify i915.enable_dpcd_backlight type from bool to int and give default
>> value as 0 (disable).
>
>I was thinking we'd change the default to -1 to trust the VBT, but might be just as well to start with this and change the default later.
>
>CI flagged errors for some reasons, I've queued a retest. I don't think it was caused by this patch.
>
>Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
Agree with your comments. That's why we keep the default value to 0. We can change the default in the future if necessary.
Thanks for review.
>
>> 2. Add a judgement to check LFP backlight type was aux interface or not.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Jose Roberto de Souza <jose.souza@intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 5 ++++-
>> drivers/gpu/drm/i915/i915_params.c | 5 +++--
>> drivers/gpu/drm/i915/i915_params.h | 2 +-
>> 4 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h
>> b/drivers/gpu/drm/i915/display/intel_bios.h
>> index 4e42cfaf61a7..0b7be6389a07 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.h
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
>> @@ -42,6 +42,7 @@ enum intel_backlight_type {
>> INTEL_BACKLIGHT_DISPLAY_DDI,
>> INTEL_BACKLIGHT_DSI_DCS,
>> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
>> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
>> };
>>
>> struct edp_power_seq {
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> index 7ded95a334db..6b0b73479fb8 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>> @@ -264,8 +264,11 @@ intel_dp_aux_display_control_capable(struct
>> intel_connector *connector) int
>> intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) {
>> struct intel_panel *panel = &intel_connector->panel;
>> + struct drm_i915_private *dev_priv =
>> +to_i915(intel_connector->base.dev);
>>
>> - if (!i915_modparams.enable_dpcd_backlight)
>> + if (i915_modparams.enable_dpcd_backlight == 0 ||
>> + (i915_modparams.enable_dpcd_backlight == -1 &&
>> + dev_priv->vbt.backlight.type !=
>> +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
>> return -ENODEV;
>>
>> if (!intel_dp_aux_display_control_capable(intel_connector))
>> diff --git a/drivers/gpu/drm/i915/i915_params.c
>> b/drivers/gpu/drm/i915/i915_params.c
>> index 5b07766a1c26..296452f9efe4 100644
>> --- a/drivers/gpu/drm/i915/i915_params.c
>> +++ b/drivers/gpu/drm/i915/i915_params.c
>> @@ -169,8 +169,9 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
>> "Force an error after a number of failure check points (0:disabled
>> (default), N:force failure at the Nth failure check point)"); #endif
>>
>> -i915_param_named(enable_dpcd_backlight, bool, 0600,
>> - "Enable support for DPCD backlight control (default:false)");
>> +i915_param_named(enable_dpcd_backlight, int, 0600,
>> + "Enable support for DPCD backlight control"
>> + "(-1=use per-VBT LFP backlight type setting, 0=disabled [default],
>> +1=enabled)");
>>
>> #if IS_ENABLED(CONFIG_DRM_I915_GVT)
>> i915_param_named(enable_gvt, bool, 0400, diff --git
>> a/drivers/gpu/drm/i915/i915_params.h
>> b/drivers/gpu/drm/i915/i915_params.h
>> index a4770ce46bd2..d29ade3b7de6 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -64,6 +64,7 @@ struct drm_printer;
>> param(int, reset, 2) \
>> param(unsigned int, inject_load_failure, 0) \
>> param(int, fastboot, -1) \
>> + param(int, enable_dpcd_backlight, 0) \
>> param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \
>> /* leave bools at the end to not create holes */ \
>> param(bool, alpha_support,
>> IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \ @@ -76,7 +77,6 @@ struct drm_printer;
>> param(bool, verbose_state_checks, true) \
>> param(bool, nuclear_pageflip, false) \
>> param(bool, enable_dp_mst, true) \
>> - param(bool, enable_dpcd_backlight, false) \
>> param(bool, enable_gvt, false)
>>
>> #define MEMBER(T, member, ...) T member;
>
>--
>Jani Nikula, Intel Open Source Graphics Center
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (8 preceding siblings ...)
2019-06-20 19:54 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-06-25 14:36 ` Patchwork
2019-06-25 15:05 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-25 16:33 ` ✓ Fi.CI.IGT: " Patchwork
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-25 14:36 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4)
URL : https://patchwork.freedesktop.org/series/62362/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3f96429f6768 drm/i915: Check backlight type while doing eDP backlight initializaiton
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
v2: access dev_priv->vbt.backlight.type directly and remove unused function.
-:67: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#67: FILE: drivers/gpu/drm/i915/i915_params.c:173:
+i915_param_named(enable_dpcd_backlight, int, 0600,
+ "Enable support for DPCD backlight control"
total: 0 errors, 1 warnings, 1 checks, 44 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (9 preceding siblings ...)
2019-06-25 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4) Patchwork
@ 2019-06-25 15:05 ` Patchwork
2019-06-25 16:33 ` ✓ Fi.CI.IGT: " Patchwork
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-25 15:05 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4)
URL : https://patchwork.freedesktop.org/series/62362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6342 -> Patchwork_13417
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/
Known issues
------------
Here are the changes found in Patchwork_13417 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@create-close:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/fi-icl-u3/igt@gem_basic@create-close.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/fi-icl-u3/igt@gem_basic@create-close.html
* igt@i915_module_load@reload:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/fi-blb-e6850/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/fi-blb-e6850/igt@i915_module_load@reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-icl-dsi: [PASS][5] -> [DMESG-WARN][6] ([fdo#106107])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/fi-icl-dsi/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/fi-icl-dsi/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
#### Possible fixes ####
* igt@i915_selftest@live_sanitycheck:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [FAIL][9] ([fdo#103167]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
Participating hosts (53 -> 44)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-icl-y fi-icl-guc fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6342 -> Patchwork_13417
CI_DRM_6342: 6eef272b254b34200129af8f2ec1e4cfe1ca6bff @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5067: 5eafa33dbdb1d3c190ac5060161c45152e9a298e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13417: 3f96429f67689730ecad078e7998d245a61f888b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3f96429f6768 drm/i915: Check backlight type while doing eDP backlight initializaiton
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4)
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
` (10 preceding siblings ...)
2019-06-25 15:05 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-25 16:33 ` Patchwork
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-06-25 16:33 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4)
URL : https://patchwork.freedesktop.org/series/62362/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6342_full -> Patchwork_13417_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13417_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-10ms:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-kbl4/igt@gem_eio@in-flight-10ms.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-kbl6/igt@gem_eio@in-flight-10ms.html
- shard-iclb: [PASS][3] -> [DMESG-WARN][4] ([fdo#110913 ]) +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb6/igt@gem_eio@in-flight-10ms.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb6/igt@gem_eio@in-flight-10ms.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-apl7/igt@gem_eio@in-flight-contexts-10ms.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-apl1/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb1/igt@gem_exec_balancer@smoke.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb7/igt@gem_exec_balancer@smoke.html
* igt@gem_partial_pwrite_pread@reads-uncached:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([fdo#110913 ]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-glk8/igt@gem_partial_pwrite_pread@reads-uncached.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-glk3/igt@gem_partial_pwrite_pread@reads-uncached.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#110789] / [fdo#110913 ]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-snb4/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-snb5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_softpin@evict-active:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#110789] / [fdo#110913 ]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw1/igt@gem_softpin@evict-active.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw6/igt@gem_softpin@evict-active.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([fdo#110913 ])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-skl: [PASS][17] -> [DMESG-WARN][18] ([fdo#110913 ]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#110913 ])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_lpsp@screens-disabled:
- shard-hsw: [PASS][21] -> [FAIL][22] ([fdo#110383])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw2/igt@i915_pm_lpsp@screens-disabled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw6/igt@i915_pm_lpsp@screens-disabled.html
* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#104108])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl8/igt@i915_suspend@sysfs-reader.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl4/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [PASS][25] -> [INCOMPLETE][26] ([fdo#103665])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#105363])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb3/igt@kms_flip@flip-vs-expired-vblank.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb7/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-hsw: [PASS][29] -> [SKIP][30] ([fdo#109271]) +29 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-badstride.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([fdo#108566]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#103167]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- shard-skl: [PASS][37] -> [FAIL][38] ([fdo#103167] / [fdo#110379])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl1/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145] / [fdo#110403])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][43] -> [FAIL][44] ([fdo#100047])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb7/igt@kms_sysfs_edid_timing.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb2/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@gem_eio@execbuf:
- shard-apl: [DMESG-WARN][45] ([fdo#110913 ]) -> [PASS][46] +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-apl2/igt@gem_eio@execbuf.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-apl6/igt@gem_eio@execbuf.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [DMESG-WARN][47] ([fdo#110913 ]) -> [PASS][48] +9 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb7/igt@gem_eio@in-flight-contexts-1us.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb4/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-glk: [FAIL][49] ([fdo#110667]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-glk8/igt@gem_eio@in-flight-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-glk2/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@wait-wedge-10ms:
- shard-kbl: [DMESG-WARN][51] ([fdo#110913 ]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-kbl1/igt@gem_eio@wait-wedge-10ms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-kbl6/igt@gem_eio@wait-wedge-10ms.html
- shard-skl: [DMESG-WARN][53] ([fdo#110913 ]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl5/igt@gem_eio@wait-wedge-10ms.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl10/igt@gem_eio@wait-wedge-10ms.html
* igt@gem_exec_schedule@wide-bsd2:
- shard-kbl: [INCOMPLETE][55] ([fdo#103665]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-kbl7/igt@gem_exec_schedule@wide-bsd2.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-kbl6/igt@gem_exec_schedule@wide-bsd2.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [DMESG-WARN][57] ([fdo#110789] / [fdo#110913 ]) -> [PASS][58] +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw2/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw6/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_softpin@evict-active-interruptible:
- shard-glk: [DMESG-WARN][59] ([fdo#110913 ]) -> [PASS][60] +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-glk8/igt@gem_softpin@evict-active-interruptible.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-glk4/igt@gem_softpin@evict-active-interruptible.html
* igt@gem_softpin@noreloc-s3:
- shard-iclb: [INCOMPLETE][61] ([fdo#107713] / [fdo#109100]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb3/igt@gem_softpin@noreloc-s3.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb4/igt@gem_softpin@noreloc-s3.html
- shard-skl: [INCOMPLETE][63] ([fdo#104108]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl3/igt@gem_softpin@noreloc-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl1/igt@gem_softpin@noreloc-s3.html
* igt@gem_softpin@softpin:
- shard-snb: [DMESG-WARN][65] ([fdo#110789] / [fdo#110913 ]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-snb1/igt@gem_softpin@softpin.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-snb6/igt@gem_softpin@softpin.html
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [FAIL][67] ([fdo#108686]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw1/igt@gem_tiled_swapping@non-threaded.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [DMESG-WARN][69] ([fdo#110913 ]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: [SKIP][71] ([fdo#109271]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-snb2/igt@i915_pm_rc6_residency@rc6-accuracy.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-snb5/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
- shard-iclb: [INCOMPLETE][73] ([fdo#107713]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb1/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb8/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-hsw: [SKIP][75] ([fdo#109271]) -> [PASS][76] +7 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw1/igt@kms_flip@2x-flip-vs-fences-interruptible.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw6/igt@kms_flip@2x-flip-vs-fences-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][77] ([fdo#105363]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +4 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-skl: [FAIL][81] ([fdo#103167]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][83] ([fdo#103166]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][85] ([fdo#108341]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb1/igt@kms_psr@no_drrs.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb4/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb5/igt@kms_psr@psr2_cursor_plane_move.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][89] ([fdo#99912]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-apl1/igt@kms_setmode@basic.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-apl1/igt@kms_setmode@basic.html
- shard-skl: [FAIL][91] ([fdo#99912]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-skl1/igt@kms_setmode@basic.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-skl1/igt@kms_setmode@basic.html
- shard-hsw: [FAIL][93] ([fdo#99912]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw2/igt@kms_setmode@basic.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw6/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-b-wait-forked-busy-hang:
- shard-hsw: [DMESG-WARN][95] ([fdo#110913 ]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-hsw5/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-hsw4/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
* igt@perf_pmu@rc6:
- shard-kbl: [SKIP][97] ([fdo#109271]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-kbl2/igt@perf_pmu@rc6.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-kbl7/igt@perf_pmu@rc6.html
#### Warnings ####
* igt@gem_partial_pwrite_pread@write-display:
- shard-iclb: [INCOMPLETE][99] ([fdo#107713] / [fdo#109100]) -> [DMESG-WARN][100] ([fdo#110913 ])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6342/shard-iclb7/igt@gem_partial_pwrite_pread@write-display.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/shard-iclb1/igt@gem_partial_pwrite_pread@write-display.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110379]: https://bugs.freedesktop.org/show_bug.cgi?id=110379
[fdo#110383]: https://bugs.freedesktop.org/show_bug.cgi?id=110383
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110667]: https://bugs.freedesktop.org/show_bug.cgi?id=110667
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13417/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v3] drm/i915: Check backlight type while doing eDP backlight initializaiton
2019-06-25 14:33 ` Lee, Shawn C
@ 2019-06-26 15:04 ` Jani Nikula
0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-06-26 15:04 UTC (permalink / raw)
To: 1561045456-12171-1-git-send-email-shawn.c.lee, intel-gfx; +Cc: Chiou, Cooper
On Tue, 25 Jun 2019, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> On Tue, 25 Jun 2019, Jani Nikula <jani.nikula@intel.com> wrote:
>>On Thu, 20 Jun 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>> If LFP backlight type setting from VBT was "VESA eDP AUX Interface".
>>> Driver should check panel capability and try to initialize aux backlight.
>>> No matter i915_modparams.enable_dpcd_backlight was enabled or not.
>>>
>>> v2: access dev_priv->vbt.backlight.type directly and remove unused function.
>>> v3: 1. Modify i915.enable_dpcd_backlight type from bool to int and give default
>>> value as 0 (disable).
>>
>>I was thinking we'd change the default to -1 to trust the VBT, but might be just as well to start with this and change the default later.
>>
>>CI flagged errors for some reasons, I've queued a retest. I don't think it was caused by this patch.
>>
>>Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>
>
> Agree with your comments. That's why we keep the default value to 0. We can change the default in the future if necessary.
> Thanks for review.
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
>
>>
>>> 2. Add a judgement to check LFP backlight type was aux interface or not.
>>>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: Jose Roberto de Souza <jose.souza@intel.com>
>>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>>
>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_bios.h | 1 +
>>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 5 ++++-
>>> drivers/gpu/drm/i915/i915_params.c | 5 +++--
>>> drivers/gpu/drm/i915/i915_params.h | 2 +-
>>> 4 files changed, 9 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.h
>>> b/drivers/gpu/drm/i915/display/intel_bios.h
>>> index 4e42cfaf61a7..0b7be6389a07 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_bios.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_bios.h
>>> @@ -42,6 +42,7 @@ enum intel_backlight_type {
>>> INTEL_BACKLIGHT_DISPLAY_DDI,
>>> INTEL_BACKLIGHT_DSI_DCS,
>>> INTEL_BACKLIGHT_PANEL_DRIVER_INTERFACE,
>>> + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE,
>>> };
>>>
>>> struct edp_power_seq {
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> index 7ded95a334db..6b0b73479fb8 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>>> @@ -264,8 +264,11 @@ intel_dp_aux_display_control_capable(struct
>>> intel_connector *connector) int
>>> intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) {
>>> struct intel_panel *panel = &intel_connector->panel;
>>> + struct drm_i915_private *dev_priv =
>>> +to_i915(intel_connector->base.dev);
>>>
>>> - if (!i915_modparams.enable_dpcd_backlight)
>>> + if (i915_modparams.enable_dpcd_backlight == 0 ||
>>> + (i915_modparams.enable_dpcd_backlight == -1 &&
>>> + dev_priv->vbt.backlight.type !=
>>> +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE))
>>> return -ENODEV;
>>>
>>> if (!intel_dp_aux_display_control_capable(intel_connector))
>>> diff --git a/drivers/gpu/drm/i915/i915_params.c
>>> b/drivers/gpu/drm/i915/i915_params.c
>>> index 5b07766a1c26..296452f9efe4 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.c
>>> +++ b/drivers/gpu/drm/i915/i915_params.c
>>> @@ -169,8 +169,9 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
>>> "Force an error after a number of failure check points (0:disabled
>>> (default), N:force failure at the Nth failure check point)"); #endif
>>>
>>> -i915_param_named(enable_dpcd_backlight, bool, 0600,
>>> - "Enable support for DPCD backlight control (default:false)");
>>> +i915_param_named(enable_dpcd_backlight, int, 0600,
>>> + "Enable support for DPCD backlight control"
>>> + "(-1=use per-VBT LFP backlight type setting, 0=disabled [default],
>>> +1=enabled)");
>>>
>>> #if IS_ENABLED(CONFIG_DRM_I915_GVT)
>>> i915_param_named(enable_gvt, bool, 0400, diff --git
>>> a/drivers/gpu/drm/i915/i915_params.h
>>> b/drivers/gpu/drm/i915/i915_params.h
>>> index a4770ce46bd2..d29ade3b7de6 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>> @@ -64,6 +64,7 @@ struct drm_printer;
>>> param(int, reset, 2) \
>>> param(unsigned int, inject_load_failure, 0) \
>>> param(int, fastboot, -1) \
>>> + param(int, enable_dpcd_backlight, 0) \
>>> param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \
>>> /* leave bools at the end to not create holes */ \
>>> param(bool, alpha_support,
>>> IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \ @@ -76,7 +77,6 @@ struct drm_printer;
>>> param(bool, verbose_state_checks, true) \
>>> param(bool, nuclear_pageflip, false) \
>>> param(bool, enable_dp_mst, true) \
>>> - param(bool, enable_dpcd_backlight, false) \
>>> param(bool, enable_gvt, false)
>>>
>>> #define MEMBER(T, member, ...) T member;
>>
>>--
>>Jani Nikula, Intel Open Source Graphics Center
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-06-26 15:01 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 3:10 [PATCH] drm/i915: Check backlight type while doing eDP backlight initializaiton Lee, Shawn C
2019-06-19 3:09 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-19 7:34 ` [PATCH] " Jani Nikula
2019-06-19 8:43 ` [PATCH v2] " Lee Shawn C
2019-06-19 9:40 ` Jani Nikula
2019-06-20 2:09 ` Lee, Shawn C
2019-06-20 9:00 ` Jani Nikula
2019-06-20 15:44 ` [PATCH v3] " Lee Shawn C
2019-06-25 14:03 ` Jani Nikula
2019-06-25 14:33 ` Lee, Shawn C
2019-06-26 15:04 ` Jani Nikula
2019-06-19 9:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2) Patchwork
2019-06-19 10:13 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-19 19:41 ` ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton Patchwork
2019-06-20 1:40 ` ✓ Fi.CI.IGT: success for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev2) Patchwork
2019-06-20 19:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev3) Patchwork
2019-06-20 19:54 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-06-25 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check backlight type while doing eDP backlight initializaiton (rev4) Patchwork
2019-06-25 15:05 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-25 16:33 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.