All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Doug Thompson <dougthompson@xmission.com>,
	Peter Tyser <ptyser@xes-inc.com>, Dave Jiang <djiang@mvista.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
Date: Sun, 11 Jul 2010 11:20:57 -0500	[thread overview]
Message-ID: <D4D6F1B7-CCA0-49ED-8CDD-8F9385DDF03E@kernel.crashing.org> (raw)
In-Reply-To: <20100708045627.GA32489@oksana.dev.rtsoft.ru>


On Jul 7, 2010, at 11:56 PM, Anton Vorontsov wrote:

> On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote:
>> On Fri, 2 Jul 2010 16:41:11 +0400
>> Anton Vorontsov <avorontsov@mvista.com> wrote:
>> 
>>> Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
>>> Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
>>> driver became non-selectable.
>> 
>> hm.  5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
>> six months ago.  How come nobody noticed?
> 
> Dunno. Well, it's hard to notice these sorts of things until
> somebody actually needs this driver on MPC85xx platform. :-)
> 
>>> This patch fixes the issue by switching to PPC_85xx symbol.
>>> 
>>> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
>>> ---
> [...]
>>> -	depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
>>> +	depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
>>> 	help
>>> 	  Support for error detection and correction on the Freescale
>>> 	  MPC8349, MPC8560, MPC8540, MPC8548
>> 
>> I suppose we shold scoot this into 2.6.35 and mark it for -stable
>> backporting.  All very odd.
> 
> Yeah, -stable 2.6.{33,34} sounds good.
> 
> Thanks.

we should add this to mpc85xx_defconfig so we build by default.

- k

WARNING: multiple messages have this Message-ID (diff)
From: Kumar Gala <galak@kernel.crashing.org>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Peter Tyser <ptyser@xes-inc.com>,
	linux-kernel@vger.kernel.org, Dave Jiang <djiang@mvista.com>,
	linuxppc-dev@ozlabs.org,
	Doug Thompson <dougthompson@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
Date: Sun, 11 Jul 2010 11:20:57 -0500	[thread overview]
Message-ID: <D4D6F1B7-CCA0-49ED-8CDD-8F9385DDF03E@kernel.crashing.org> (raw)
In-Reply-To: <20100708045627.GA32489@oksana.dev.rtsoft.ru>


On Jul 7, 2010, at 11:56 PM, Anton Vorontsov wrote:

> On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote:
>> On Fri, 2 Jul 2010 16:41:11 +0400
>> Anton Vorontsov <avorontsov@mvista.com> wrote:
>> 
>>> Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
>>> Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
>>> driver became non-selectable.
>> 
>> hm.  5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
>> six months ago.  How come nobody noticed?
> 
> Dunno. Well, it's hard to notice these sorts of things until
> somebody actually needs this driver on MPC85xx platform. :-)
> 
>>> This patch fixes the issue by switching to PPC_85xx symbol.
>>> 
>>> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
>>> ---
> [...]
>>> -	depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
>>> +	depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
>>> 	help
>>> 	  Support for error detection and correction on the Freescale
>>> 	  MPC8349, MPC8560, MPC8540, MPC8548
>> 
>> I suppose we shold scoot this into 2.6.35 and mark it for -stable
>> backporting.  All very odd.
> 
> Yeah, -stable 2.6.{33,34} sounds good.
> 
> Thanks.

we should add this to mpc85xx_defconfig so we build by default.

- k

  reply	other threads:[~2010-07-11 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 12:41 [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency Anton Vorontsov
2010-07-02 12:41 ` Anton Vorontsov
2010-07-07 21:45 ` Andrew Morton
2010-07-07 21:45   ` Andrew Morton
2010-07-08  4:56   ` Anton Vorontsov
2010-07-08  4:56     ` Anton Vorontsov
2010-07-11 16:20     ` Kumar Gala [this message]
2010-07-11 16:20       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D4D6F1B7-CCA0-49ED-8CDD-8F9385DDF03E@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=cbouatmailru@gmail.com \
    --cc=djiang@mvista.com \
    --cc=dougthompson@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=ptyser@xes-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.