All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2)
Date: Thu, 8 Sep 2011 00:04:16 +0200	[thread overview]
Message-ID: <D58A56E6-6893-4C4D-96DA-30B9245F92C6@suse.de> (raw)
In-Reply-To: <4E67EA19.5080200@codemonkey.ws>


On 08.09.2011, at 00:03, Anthony Liguori wrote:

> On 09/07/2011 04:56 PM, Alexander Graf wrote:
>> 
>> On 02.09.2011, at 19:34, Anthony Liguori wrote:
>> 
>>> This is my attempt to jump-start the QAPI switch over.  All of the hard work
>>> is already done in my qapi branch, we just need to start merging stuff.
>>> 
>>> To simplify the merge process, I've introduced a new mode to the code generator
>>> that lets us do conversions without using the new QMP server.
>>> 
>>> Once this series is merged, anything that touchs QMP (to modify a command or
>>> add a new command) must do it through QAPI--no exceptions.
>>> 
>>> This series also includes Dans change to the 'change' command.  I'm not thrilled
>>> about people using this command but its better to err on the side of caution.
>>> It's now officially deprecated with much more robust replacement commands.
>>> 
>>> Since v1, I've tried to address all review comments.  I've also tested the
>>> modified commands extensively.
>> 
>> Just stumbled over this while trying to build. Smells like missing Makefile dependencies (works just fine with -j1), but I figured I'd give you a heads up on this. It's a fresh checkout with nothing done but ./configure; make -j.
>> 
>> 
>> agraf@e77:/dev/shm/qemu>  make -j
>>   GEN   i386-softmmu/config-devices.mak
>>   GEN   arm-softmmu/config-devices.mak
>>   GEN   x86_64-softmmu/config-devices.mak
>>   GEN   cris-softmmu/config-devices.mak
>>   GEN   lm32-softmmu/config-devices.mak
>>   GEN   m68k-softmmu/config-devices.mak
>>   GEN   microblaze-softmmu/config-devices.mak
>>   GEN   microblazeel-softmmu/config-devices.mak
>>   GEN   mips-softmmu/config-devices.mak
>>   GEN   mipsel-softmmu/config-devices.mak
>>   GEN   mips64-softmmu/config-devices.mak
>>   GEN   mips64el-softmmu/config-devices.mak
>>   GEN   ppcemb-softmmu/config-devices.mak
>>   GEN   ppc-softmmu/config-devices.mak
>>   GEN   ppc64-softmmu/config-devices.mak
>>   GEN   sh4-softmmu/config-devices.mak
>>   GEN   sh4eb-softmmu/config-devices.mak
>>   GEN   sparc-softmmu/config-devices.mak
>>   GEN   sparc64-softmmu/config-devices.mak
>>   GEN   i386-linux-user/config-devices.mak
>>   GEN   s390x-softmmu/config-devices.mak
>>   GEN   x86_64-linux-user/config-devices.mak
>>   GEN   alpha-linux-user/config-devices.mak
>>   GEN   arm-linux-user/config-devices.mak
>>   GEN   armeb-linux-user/config-devices.mak
>>   GEN   cris-linux-user/config-devices.mak
>>   GEN   m68k-linux-user/config-devices.mak
>>   GEN   microblaze-linux-user/config-devices.mak
>>   GEN   microblazeel-linux-user/config-devices.mak
>>   GEN   mips-linux-user/config-devices.mak
>>   GEN   mipsel-linux-user/config-devices.mak
>>   GEN   ppc-linux-user/config-devices.mak
>>   GEN   ppc64-linux-user/config-devices.mak
>>   GEN   sh4-linux-user/config-devices.mak
>>   GEN   ppc64abi32-linux-user/config-devices.mak
>>   GEN   sh4eb-linux-user/config-devices.mak
>>   GEN   sparc64-linux-user/config-devices.mak
>>   GEN   sparc32plus-linux-user/config-devices.mak
>>   GEN   unicore32-linux-user/config-devices.mak
>>   GEN   sparc-linux-user/config-devices.mak
>>   GEN   s390x-linux-user/config-devices.mak
>>   GEN   config-all-devices.mak
>>   GEN   config-host.h
>>   GEN   trace.h
>>   GEN   qemu-options.def
>>   GEN   qapi-generated/qga-qapi-visit.h
>>   GEN   trace.c
>>   CC    trace/default.o
>>   CC    trace/control.o
>>   GEN   qemu-img-cmds.h
>> cc1: error: qapi-generated: No such file or directory
>> cc1: error: qapi-generated: No such file or directory
> 
> I've seen this before too but this is due to guest-agent, not this patch series.

Ah, sorry, didn't track down what exactly was going wrong where and figured since it fails on qapi, it'd be related :)

Alex

  reply	other threads:[~2011-09-07 22:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02 17:34 [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2) Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 01/15] error: let error_is_type take a NULL error Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 02/15] qerror: add qerror_report_err() (v2) Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 03/15] qapi: add code generation support for middle mode Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 04/15] qapi: use middle mode in QMP server (v2) Anthony Liguori
2011-09-02 20:39   ` Luiz Capitulino
2011-09-02 17:34 ` [Qemu-devel] [PATCH 05/15] qapi: convert query-name Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 06/15] block: add unsafe_probe Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 07/15] monitor: expose readline state Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 08/15] qerror: add additional parameter to QERR_DEVICE_ENCRYPTED Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 09/15] qapi: convert eject (qmp and hmp) to QAPI Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 10/15] qapi: convert block_passwd and add set-blockdev-password Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 11/15] qapi: add change-vnc-password (v2) Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 12/15] qapi: add change-vnc-listen (v2) Anthony Liguori
2011-09-02 20:50   ` Luiz Capitulino
2011-09-12  9:17     ` Daniel P. Berrange
2011-09-12  9:28       ` Daniel P. Berrange
2011-09-02 17:34 ` [Qemu-devel] [PATCH 13/15] qapi: introduce drive-change (v2) Anthony Liguori
2011-09-02 21:06   ` Luiz Capitulino
2011-09-02 21:10     ` Luiz Capitulino
2011-09-02 17:34 ` [Qemu-devel] [PATCH 14/15] qapi: convert change (v2) Anthony Liguori
2011-09-02 17:34 ` [Qemu-devel] [PATCH 15/15] vnc: don't demote authentication protocol when disabling login Anthony Liguori
2011-09-07 21:56 ` [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2) Alexander Graf
2011-09-07 22:03   ` Anthony Liguori
2011-09-07 22:04     ` Alexander Graf [this message]
2011-09-07 22:24       ` Anthony Liguori
2011-09-07 23:12         ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D58A56E6-6893-4C4D-96DA-30B9245F92C6@suse.de \
    --to=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.