All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS
@ 2017-07-21 16:11 Arnd Bergmann
  2017-07-24  6:44   ` Javali, Nilesh
  0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-07-21 16:11 UTC (permalink / raw)
  To: QLogic-Storage-Upstream, James E.J. Bottomley, Martin K. Petersen
  Cc: Arnd Bergmann, Saurav Kashyap, Manish Rangankar,
	Adheer Chandravanshi, linux-scsi, linux-kernel

Without the base library support, we get a link failure

drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
qedi_main.c:(.text+0x2d8e): undefined reference to `iscsi_boot_create_target'
qedi_main.c:(.text+0x2dee): undefined reference to `iscsi_boot_create_initiator'
qedi_main.c:(.text+0x2e1c): undefined reference to `iscsi_boot_create_ethernet'

This selects the Kconfig symbol like the other two users of that
module do.

Fixes: c57ec8fb7c02 ("scsi: qedi: Add support for Boot from SAN over iSCSI offload")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/qedi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
index 21331453db7b..8deb8723c4dd 100644
--- a/drivers/scsi/qedi/Kconfig
+++ b/drivers/scsi/qedi/Kconfig
@@ -2,6 +2,7 @@ config QEDI
 	tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
 	depends on PCI && SCSI && UIO
 	depends on QED
+	select ISCSI_BOOT_SYSFS
 	select SCSI_ISCSI_ATTRS
 	select QED_LL2
 	select QED_ISCSI
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS
  2017-07-21 16:11 [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS Arnd Bergmann
@ 2017-07-24  6:44   ` Javali, Nilesh
  0 siblings, 0 replies; 3+ messages in thread
From: Javali, Nilesh @ 2017-07-24  6:44 UTC (permalink / raw)
  To: Arnd Bergmann, Dept-Eng QLogic Storage Upstream,
	James E.J. Bottomley, Martin K. Petersen
  Cc: Kashyap, Saurav, Rangankar, Manish, Adheer Chandravanshi,
	linux-scsi, linux-kernel


On 21/07/17, 9:41 PM, "Arnd Bergmann" <arnd@arndb.de> wrote:

>Without the base library support, we get a link failure
>
>drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
>qedi_main.c:(.text+0x2d8e): undefined reference to
>`iscsi_boot_create_target'
>qedi_main.c:(.text+0x2dee): undefined reference to
>`iscsi_boot_create_initiator'
>qedi_main.c:(.text+0x2e1c): undefined reference to
>`iscsi_boot_create_ethernet'
>
>This selects the Kconfig symbol like the other two users of that
>module do.
>
>Fixes: c57ec8fb7c02 ("scsi: qedi: Add support for Boot from SAN over
>iSCSI offload")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/scsi/qedi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
>index 21331453db7b..8deb8723c4dd 100644
>--- a/drivers/scsi/qedi/Kconfig
>+++ b/drivers/scsi/qedi/Kconfig
>@@ -2,6 +2,7 @@ config QEDI
> 	tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
> 	depends on PCI && SCSI && UIO
> 	depends on QED
>+	select ISCSI_BOOT_SYSFS
> 	select SCSI_ISCSI_ATTRS
> 	select QED_LL2
> 	select QED_ISCSI
>-- 
>2.9.0
>

NACK. The fix already posted to address this issue,
http://marc.info/?l=linux-scsi&m=150045528332067&w=2

Thanks,
Nilesh

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS
@ 2017-07-24  6:44   ` Javali, Nilesh
  0 siblings, 0 replies; 3+ messages in thread
From: Javali, Nilesh @ 2017-07-24  6:44 UTC (permalink / raw)
  To: Arnd Bergmann, Dept-Eng QLogic Storage Upstream,
	James E.J. Bottomley, Martin K. Petersen
  Cc: Kashyap, Saurav, Rangankar, Manish, Adheer Chandravanshi,
	linux-scsi, linux-kernel


On 21/07/17, 9:41 PM, "Arnd Bergmann" <arnd@arndb.de> wrote:

>Without the base library support, we get a link failure
>
>drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
>qedi_main.c:(.text+0x2d8e): undefined reference to
>`iscsi_boot_create_target'
>qedi_main.c:(.text+0x2dee): undefined reference to
>`iscsi_boot_create_initiator'
>qedi_main.c:(.text+0x2e1c): undefined reference to
>`iscsi_boot_create_ethernet'
>
>This selects the Kconfig symbol like the other two users of that
>module do.
>
>Fixes: c57ec8fb7c02 ("scsi: qedi: Add support for Boot from SAN over
>iSCSI offload")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/scsi/qedi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
>index 21331453db7b..8deb8723c4dd 100644
>--- a/drivers/scsi/qedi/Kconfig
>+++ b/drivers/scsi/qedi/Kconfig
>@@ -2,6 +2,7 @@ config QEDI
> 	tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
> 	depends on PCI && SCSI && UIO
> 	depends on QED
>+	select ISCSI_BOOT_SYSFS
> 	select SCSI_ISCSI_ATTRS
> 	select QED_LL2
> 	select QED_ISCSI
>-- 
>2.9.0
>

NACK. The fix already posted to address this issue,
http://marc.info/?l=linux-scsi&m=150045528332067&w=2

Thanks,
Nilesh

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-24  6:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-21 16:11 [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS Arnd Bergmann
2017-07-24  6:44 ` Javali, Nilesh
2017-07-24  6:44   ` Javali, Nilesh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.