All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rangankar, Manish" <Manish.Rangankar@cavium.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Dept-Eng QLogic Storage Upstream
	<QLogic-Storage-Upstream@cavium.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] scsi: qedi: off by one in qedi_get_cmd_from_tid()
Date: Mon, 28 Aug 2017 05:34:24 +0000	[thread overview]
Message-ID: <D5C9A8DE.3C608%manish.rangankar@cavium.com> (raw)
In-Reply-To: <20170825103657.6kwprvwfks7szn3b@mwanda>



On 25/08/17 4:06 PM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:

>The > here should be >= or we end up reading one element beyond the end
>of the qedi->itt_map[] array.  The qedi->itt_map[] array is allocated in
>qedi_alloc_itt().
>
>Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI
>driver framework.")
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
>index c4a470bab4dd..cccc34adc0e0 100644
>--- a/drivers/scsi/qedi/qedi_main.c
>+++ b/drivers/scsi/qedi/qedi_main.c
>@@ -1576,7 +1576,7 @@ struct qedi_cmd *qedi_get_cmd_from_tid(struct
>qedi_ctx *qedi, u32 tid)
> {
> 	struct qedi_cmd *cmd = NULL;
> 
>-	if (tid > MAX_ISCSI_TASK_ENTRIES)
>+	if (tid >= MAX_ISCSI_TASK_ENTRIES)
> 		return NULL;
> 
> 	cmd = qedi->itt_map[tid].p_cmd;

Thanks for the patch.

Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>


>


  reply	other threads:[~2017-08-28  5:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 10:36 [PATCH] scsi: qedi: off by one in qedi_get_cmd_from_tid() Dan Carpenter
2017-08-25 10:36 ` Dan Carpenter
2017-08-28  5:34 ` Rangankar, Manish [this message]
2017-08-29  2:13 ` Martin K. Petersen
2017-08-29  2:13   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D5C9A8DE.3C608%manish.rangankar@cavium.com \
    --to=manish.rangankar@cavium.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=dan.carpenter@oracle.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.