From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QLogic-Storage-Upstream@cavium.com,
Manish Rangankar <manish.rangankar@cavium.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qedi: off by one in qedi_get_cmd_from_tid()
Date: Tue, 29 Aug 2017 02:13:22 +0000 [thread overview]
Message-ID: <yq1378b2kal.fsf@oracle.com> (raw)
In-Reply-To: <20170825103657.6kwprvwfks7szn3b@mwanda> (Dan Carpenter's message of "Fri, 25 Aug 2017 13:36:57 +0300")
Dan,
> The > here should be >= or we end up reading one element beyond the
> end of the qedi->itt_map[] array. The qedi->itt_map[] array is
> allocated in qedi_alloc_itt().
Applied to 4.13/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QLogic-Storage-Upstream@cavium.com,
Manish Rangankar <manish.rangankar@cavium.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qedi: off by one in qedi_get_cmd_from_tid()
Date: Mon, 28 Aug 2017 22:13:22 -0400 [thread overview]
Message-ID: <yq1378b2kal.fsf@oracle.com> (raw)
In-Reply-To: <20170825103657.6kwprvwfks7szn3b@mwanda> (Dan Carpenter's message of "Fri, 25 Aug 2017 13:36:57 +0300")
Dan,
> The > here should be >= or we end up reading one element beyond the
> end of the qedi->itt_map[] array. The qedi->itt_map[] array is
> allocated in qedi_alloc_itt().
Applied to 4.13/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-29 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 10:36 [PATCH] scsi: qedi: off by one in qedi_get_cmd_from_tid() Dan Carpenter
2017-08-25 10:36 ` Dan Carpenter
2017-08-28 5:34 ` Rangankar, Manish
2017-08-29 2:13 ` Martin K. Petersen [this message]
2017-08-29 2:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1378b2kal.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manish.rangankar@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.