guidelines on new entity-manager classes

guidelines on new entity-manager classes

[Brad Bishop]

Hi James

another EM question for you...

Are there any guidelines or best practices on upstreaming EM configurations?  Put another way, if I wanted to ensure that you would accept my configurations with new types or classes (e.g. Pid, ADC, etc..), what would I need to do up front to make that process as smooth as it can be?

thx - brad

Re: guidelines on new entity-manager classes

[James Feist]

On 11/25/19 5:02 PM, Brad Bishop wrote:
> Hi James
> 
> another EM question for you...
> 
> Are there any guidelines or best practices on upstreaming EM configurations?  Put another way, if I wanted to ensure that you would accept my configurations with new types or classes (e.g. Pid, ADC, etc..), what would I need to do up front to make that process as smooth as it can be?

EM configurations are meant to be flexible, and as long as the daemon 
understands it, and the Type is unique, there shouldn't be any issues.
There is a script here to make it a bit more pretty that CI will fail if 
it is not ran 
https://github.com/openbmc/entity-manager/blob/master/scripts/autojson.py. 
The only real things that block configuration reviews are things that 
can make them shorter (using the template stuff when possible). But as 
they are per vendor, I normally let each vendor own their own destiny 
with the files.

There is a json schema 
https://github.com/openbmc/entity-manager/blob/master/schemas/global.json 
that I eventually have the dream of creating a script to generate a 
schema for every checked-in Type, but I'm not there yet.

-James

> 
> thx - brad
> 

RE: [ExternalEmail] Re: guidelines on new entity-manager classes

[Troy.Lee]

Hi James,

Is there a cmake option to NOT install entity-manager/configurations?
It would be easier for vendors to install their own configurations.

Thanks,
Troy Lee

-----Original Message-----
From: openbmc <openbmc-bounces+troy.lee=vertiv.com@lists.ozlabs.org> On Behalf Of James Feist
Sent: Wednesday, November 27, 2019 1:29 AM
To: Brad Bishop <bradleyb@fuzziesquirrel.com>
Cc: Shawn McCarney <shawnmm@linux.vnet.ibm.com>; OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: [ExternalEmail] Re: guidelines on new entity-manager classes

On 11/25/19 5:02 PM, Brad Bishop wrote:
> Hi James
>
> another EM question for you...
>
> Are there any guidelines or best practices on upstreaming EM configurations?  Put another way, if I wanted to ensure that you would accept my configurations with new types or classes (e.g. Pid, ADC, etc..), what would I need to do up front to make that process as smooth as it can be?

EM configurations are meant to be flexible, and as long as the daemon understands it, and the Type is unique, there shouldn't be any issues.
There is a script here to make it a bit more pretty that CI will fail if it is not ran https://github.com/openbmc/entity-manager/blob/master/scripts/autojson.py.
The only real things that block configuration reviews are things that can make them shorter (using the template stuff when possible). But as they are per vendor, I normally let each vendor own their own destiny with the files.

There is a json schema
https://github.com/openbmc/entity-manager/blob/master/schemas/global.json
that I eventually have the dream of creating a script to generate a schema for every checked-in Type, but I'm not there yet.

-James

>
> thx - brad
>
CONFIDENTIALITY NOTICE: This e-mail and any files transmitted with it are intended solely for the use of the individual or entity to whom they are addressed and may contain confidential and privileged information protected by law. If you received this e-mail in error, any review, use, dissemination, distribution, or copying of the e-mail is strictly prohibited. Please notify the sender immediately by return e-mail and delete all copies from your system.

Re: [ExternalEmail] Re: guidelines on new entity-manager classes

[Vijay Khemka]

Tony,
You can upload your own config file in entity manager repository. Or you can also install it through bbappend file.

Regards
-Vijay

On 11/27/19, 10:43 PM, "openbmc on behalf of Troy.Lee@vertiv.com" <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of Troy.Lee@vertiv.com> wrote:

    Hi James,
    
    Is there a cmake option to NOT install entity-manager/configurations?
    It would be easier for vendors to install their own configurations.
    
    Thanks,
    Troy Lee
    
    -----Original Message-----
    From: openbmc <openbmc-bounces+troy.lee=vertiv.com@lists.ozlabs.org> On Behalf Of James Feist
    Sent: Wednesday, November 27, 2019 1:29 AM
    To: Brad Bishop <bradleyb@fuzziesquirrel.com>
    Cc: Shawn McCarney <shawnmm@linux.vnet.ibm.com>; OpenBMC Maillist <openbmc@lists.ozlabs.org>
    Subject: [ExternalEmail] Re: guidelines on new entity-manager classes
    
    On 11/25/19 5:02 PM, Brad Bishop wrote:
    > Hi James
    >
    > another EM question for you...
    >
    > Are there any guidelines or best practices on upstreaming EM configurations?  Put another way, if I wanted to ensure that you would accept my configurations with new types or classes (e.g. Pid, ADC, etc..), what would I need to do up front to make that process as smooth as it can be?
    
    EM configurations are meant to be flexible, and as long as the daemon understands it, and the Type is unique, there shouldn't be any issues.
    There is a script here to make it a bit more pretty that CI will fail if it is not ran https://github.com/openbmc/entity-manager/blob/master/scripts/autojson.py.
    The only real things that block configuration reviews are things that can make them shorter (using the template stuff when possible). But as they are per vendor, I normally let each vendor own their own destiny with the files.
    
    There is a json schema
    https://github.com/openbmc/entity-manager/blob/master/schemas/global.json
    that I eventually have the dream of creating a script to generate a schema for every checked-in Type, but I'm not there yet.
    
    -James
    
    >
    > thx - brad
    >
    CONFIDENTIALITY NOTICE: This e-mail and any files transmitted with it are intended solely for the use of the individual or entity to whom they are addressed and may contain confidential and privileged information protected by law. If you received this e-mail in error, any review, use, dissemination, distribution, or copying of the e-mail is strictly prohibited. Please notify the sender immediately by return e-mail and delete all copies from your system.