From: Haakon Bugge <haakon.bugge@oracle.com>
To: "yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>
Cc: Doug Ledford <dledford@redhat.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
OFED mailing list <linux-rdma@vger.kernel.org>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment
Date: Mon, 6 Dec 2021 14:27:18 +0000 [thread overview]
Message-ID: <D8348428-539D-4C4D-8D21-C23C1B0E80EB@oracle.com> (raw)
In-Reply-To: <20211207064607.541695-1-yanjun.zhu@linux.dev>
> On 7 Dec 2021, at 07:46, yanjun.zhu@linux.dev wrote:
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The struct member variable create_flags are assigned twice.
may be "... is assigned twice." ?
> Remove the unnecessary assignment.
>
> Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
LGTM, so
Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
Thxs, Håkon
> ---
> drivers/infiniband/core/uverbs_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> index d1345d76d9b1..6b6393176b3c 100644
> --- a/drivers/infiniband/core/uverbs_cmd.c
> +++ b/drivers/infiniband/core/uverbs_cmd.c
> @@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
> attr.sq_sig_type = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
> IB_SIGNAL_REQ_WR;
> attr.qp_type = cmd->qp_type;
> - attr.create_flags = 0;
>
> attr.cap.max_send_wr = cmd->max_send_wr;
> attr.cap.max_recv_wr = cmd->max_recv_wr;
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-12-06 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 6:46 [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment yanjun.zhu
2021-12-06 14:27 ` Haakon Bugge [this message]
2021-12-06 23:22 ` Yanjun Zhu
2021-12-06 23:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8348428-539D-4C4D-8D21-C23C1B0E80EB@oracle.com \
--to=haakon.bugge@oracle.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.