* Re: [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment
2021-12-07 6:46 [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment yanjun.zhu
@ 2021-12-06 14:27 ` Haakon Bugge
2021-12-06 23:22 ` Yanjun Zhu
2021-12-06 23:52 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Haakon Bugge @ 2021-12-06 14:27 UTC (permalink / raw)
To: yanjun.zhu; +Cc: Doug Ledford, jgg, OFED mailing list, Leon Romanovsky
> On 7 Dec 2021, at 07:46, yanjun.zhu@linux.dev wrote:
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The struct member variable create_flags are assigned twice.
may be "... is assigned twice." ?
> Remove the unnecessary assignment.
>
> Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
LGTM, so
Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
Thxs, Håkon
> ---
> drivers/infiniband/core/uverbs_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> index d1345d76d9b1..6b6393176b3c 100644
> --- a/drivers/infiniband/core/uverbs_cmd.c
> +++ b/drivers/infiniband/core/uverbs_cmd.c
> @@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
> attr.sq_sig_type = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
> IB_SIGNAL_REQ_WR;
> attr.qp_type = cmd->qp_type;
> - attr.create_flags = 0;
>
> attr.cap.max_send_wr = cmd->max_send_wr;
> attr.cap.max_recv_wr = cmd->max_recv_wr;
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment
2021-12-06 14:27 ` Haakon Bugge
@ 2021-12-06 23:22 ` Yanjun Zhu
0 siblings, 0 replies; 4+ messages in thread
From: Yanjun Zhu @ 2021-12-06 23:22 UTC (permalink / raw)
To: Haakon Bugge, yanjun.zhu
Cc: Doug Ledford, jgg, OFED mailing list, Leon Romanovsky
在 2021/12/6 22:27, Haakon Bugge 写道:
>
>
>> On 7 Dec 2021, at 07:46, yanjun.zhu@linux.dev wrote:
>>
>> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>>
>> The struct member variable create_flags are assigned twice.
>
> may be "... is assigned twice." ?
My bad. Thanks.
Zhu Yanjun
>
>> Remove the unnecessary assignment.
>>
>> Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> LGTM, so
>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
>
>
>
> Thxs, Håkon
>
>> ---
>> drivers/infiniband/core/uverbs_cmd.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
>> index d1345d76d9b1..6b6393176b3c 100644
>> --- a/drivers/infiniband/core/uverbs_cmd.c
>> +++ b/drivers/infiniband/core/uverbs_cmd.c
>> @@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
>> attr.sq_sig_type = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
>> IB_SIGNAL_REQ_WR;
>> attr.qp_type = cmd->qp_type;
>> - attr.create_flags = 0;
>>
>> attr.cap.max_send_wr = cmd->max_send_wr;
>> attr.cap.max_recv_wr = cmd->max_recv_wr;
>> --
>> 2.27.0
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment
2021-12-07 6:46 [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment yanjun.zhu
2021-12-06 14:27 ` Haakon Bugge
@ 2021-12-06 23:52 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2021-12-06 23:52 UTC (permalink / raw)
To: yanjun.zhu; +Cc: dledford, linux-rdma, leon
On Tue, Dec 07, 2021 at 01:46:07AM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The struct member variable create_flags are assigned twice.
> Remove the unnecessary assignment.
>
> Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
> drivers/infiniband/core/uverbs_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment
@ 2021-12-07 6:46 yanjun.zhu
2021-12-06 14:27 ` Haakon Bugge
2021-12-06 23:52 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: yanjun.zhu @ 2021-12-07 6:46 UTC (permalink / raw)
To: dledford, jgg, linux-rdma, yanjun.zhu, leon
From: Zhu Yanjun <yanjun.zhu@linux.dev>
The struct member variable create_flags are assigned twice.
Remove the unnecessary assignment.
Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths")
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/core/uverbs_cmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index d1345d76d9b1..6b6393176b3c 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
attr.sq_sig_type = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR :
IB_SIGNAL_REQ_WR;
attr.qp_type = cmd->qp_type;
- attr.create_flags = 0;
attr.cap.max_send_wr = cmd->max_send_wr;
attr.cap.max_recv_wr = cmd->max_recv_wr;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-06 23:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-07 6:46 [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment yanjun.zhu
2021-12-06 14:27 ` Haakon Bugge
2021-12-06 23:22 ` Yanjun Zhu
2021-12-06 23:52 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.