[Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

[Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

[Programmingkid]

This patchset adds QKeyCode support to the adb and cocoa code. 

Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
and adb-keys.h files. Only the cocoa.m file changes are Mac specific.

If you are using Linux as a guest, then the xev command is what you could use to
test out these patches. For a Mac OS guest the Key Caps application would help
with testing out these patches.

John Arbuckle (4):
  hw/input/adb.c: implement QKeyCode support
  ui/cocoa.m: switch to QKeyCode
  adb-keys.h: initial commit
  qapi-schema.json: Add power and keypad equal keys

 hw/input/adb.c              | 248 +++++++++++++++++++++++++++-------
 include/hw/input/adb-keys.h | 148 +++++++++++++++++++++
 qapi-schema.json            |   3 +-
 ui/cocoa.m                  | 317 ++++++++++++++++++++------------------------
 4 files changed, 493 insertions(+), 223 deletions(-)
 create mode 100644 include/hw/input/adb-keys.h

-- 
v5 changes to only adb-keys.h and adb.c files.

2.7.2

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

[Peter Maydell]

On 15 March 2016 at 17:13, Programmingkid <programmingkidx@gmail.com> wrote:
> This patchset adds QKeyCode support to the adb and cocoa code.
>
> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
> and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
>
> If you are using Linux as a guest, then the xev command is what you could use to
> test out these patches. For a Mac OS guest the Key Caps application would help
> with testing out these patches.
>
> John Arbuckle (4):
>   hw/input/adb.c: implement QKeyCode support
>   ui/cocoa.m: switch to QKeyCode
>   adb-keys.h: initial commit
>   qapi-schema.json: Add power and keypad equal keys

I've put the qapi-schema.json and the ui/cocoa.m patches into the
cocoa pull I've just sent. For the ADB keyboard part, I definitely
think that the best approach is the suggestion I made on an earlier
series: split the changes up into "move to using QKeyCode and the
adb-keys.h enum values, but don't change any behaviour of what keys
get sent", and "fix bugs, add missing keys, etc" as separate changes.
This will be much easier to review.

thanks
-- PMM

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

[Programmingkid]

On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote:

> On 15 March 2016 at 17:13, Programmingkid <programmingkidx@gmail.com> wrote:
>> This patchset adds QKeyCode support to the adb and cocoa code.
>> 
>> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
>> and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
>> 
>> If you are using Linux as a guest, then the xev command is what you could use to
>> test out these patches. For a Mac OS guest the Key Caps application would help
>> with testing out these patches.
>> 
>> John Arbuckle (4):
>>  hw/input/adb.c: implement QKeyCode support
>>  ui/cocoa.m: switch to QKeyCode
>>  adb-keys.h: initial commit
>>  qapi-schema.json: Add power and keypad equal keys
> 
> I've put the qapi-schema.json and the ui/cocoa.m patches into the
> cocoa pull I've just sent. For the ADB keyboard part, I definitely
> think that the best approach is the suggestion I made on an earlier
> series: split the changes up into "move to using QKeyCode and the
> adb-keys.h enum values, but don't change any behaviour of what keys
> get sent", and "fix bugs, add missing keys, etc" as separate changes.
> This will be much easier to review.

Would it be ok to send the adb-keys.h and adb.c patches separately instead of using a series? It would make things a lot easier for me.

You want the adb.c patch so that it does not have the keypad equals and power keys in it yet? You want those keys added in a separate patch?

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

[Peter Maydell]

On 23 March 2016 at 16:52, Programmingkid <programmingkidx@gmail.com> wrote:
> On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote:
>> I've put the qapi-schema.json and the ui/cocoa.m patches into the
>> cocoa pull I've just sent. For the ADB keyboard part, I definitely
>> think that the best approach is the suggestion I made on an earlier
>> series: split the changes up into "move to using QKeyCode and the
>> adb-keys.h enum values, but don't change any behaviour of what keys
>> get sent", and "fix bugs, add missing keys, etc" as separate changes.
>> This will be much easier to review.
>
> Would it be ok to send the adb-keys.h and adb.c patches separately
> instead of using a series? It would make things a lot easier for me.

Please sort out a config that lets you send patch series properly --
it is a real pain to deal with them at my end otherwise.

> You want the adb.c patch so that it does not have the keypad equals
> and power keys in it yet? You want those keys added in a separate
> patch?

You want three (or more) patches, I guess:
 * new adb-keys.h file
 * changes to adb.c which make no guest-visible changes to behaviour
 * patches which change behaviour, split up to do one thing at a time
   [probably at least "support power key", "don't send 'A' for unknown
   keycodes", and "other changes"]

thanks
-- PMM