All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH u-boot v2019.04-aspeed-openbmc] configs: aspeed-common: Add redundant env for mmc
@ 2021-06-18 15:14 Adriana Kobylak
  2021-06-22 12:55 ` Joel Stanley
  0 siblings, 1 reply; 3+ messages in thread
From: Adriana Kobylak @ 2021-06-18 15:14 UTC (permalink / raw)
  To: joel, openbmc; +Cc: Adriana Kobylak, Eddie James

From: Adriana Kobylak <anoo@us.ibm.com>

If the env is in MMC, specify the location of the redundant environment.
Per the ast2600_openbmc_spl_emmc_defconfig, the environment is located
at byte offset 0x5000 in the user data partition, and is sized at
0x10000. The redundant environment follows it immediately and is the
same size.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
---
 include/configs/aspeed-common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/configs/aspeed-common.h b/include/configs/aspeed-common.h
index 8f404570b1..59449d36d0 100644
--- a/include/configs/aspeed-common.h
+++ b/include/configs/aspeed-common.h
@@ -83,6 +83,7 @@
 #ifdef CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV		0
 #define CONFIG_SYS_MMC_ENV_PART		0
+#define CONFIG_ENV_OFFSET_REDUND	0x15000
 #endif
 
 #endif	/* __ASPEED_COMMON_CONFIG_H */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH u-boot v2019.04-aspeed-openbmc] configs: aspeed-common: Add redundant env for mmc
  2021-06-18 15:14 [PATCH u-boot v2019.04-aspeed-openbmc] configs: aspeed-common: Add redundant env for mmc Adriana Kobylak
@ 2021-06-22 12:55 ` Joel Stanley
  2021-06-23 20:05   ` Adriana Kobylak
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2021-06-22 12:55 UTC (permalink / raw)
  To: Adriana Kobylak; +Cc: OpenBMC Maillist, Adriana Kobylak, Eddie James

On Fri, 18 Jun 2021 at 15:14, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> If the env is in MMC, specify the location of the redundant environment.
> Per the ast2600_openbmc_spl_emmc_defconfig, the environment is located
> at byte offset 0x5000 in the user data partition, and is sized at
> 0x10000. The redundant environment follows it immediately and is the
> same size.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
>  include/configs/aspeed-common.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/aspeed-common.h b/include/configs/aspeed-common.h
> index 8f404570b1..59449d36d0 100644
> --- a/include/configs/aspeed-common.h
> +++ b/include/configs/aspeed-common.h
> @@ -83,6 +83,7 @@
>  #ifdef CONFIG_ENV_IS_IN_MMC
>  #define CONFIG_SYS_MMC_ENV_DEV         0
>  #define CONFIG_SYS_MMC_ENV_PART                0
> +#define CONFIG_ENV_OFFSET_REDUND       0x15000

Would it make more sense to write it like this:

#define CONFIG_ENV_OFFSET_REDUND (CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)


>  #endif
>
>  #endif /* __ASPEED_COMMON_CONFIG_H */
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH u-boot v2019.04-aspeed-openbmc] configs: aspeed-common: Add redundant env for mmc
  2021-06-22 12:55 ` Joel Stanley
@ 2021-06-23 20:05   ` Adriana Kobylak
  0 siblings, 0 replies; 3+ messages in thread
From: Adriana Kobylak @ 2021-06-23 20:05 UTC (permalink / raw)
  To: Joel Stanley; +Cc: OpenBMC Maillist, Adriana Kobylak, Eddie James

[-- Attachment #1: Type: text/html, Size: 7773 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-23 20:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 15:14 [PATCH u-boot v2019.04-aspeed-openbmc] configs: aspeed-common: Add redundant env for mmc Adriana Kobylak
2021-06-22 12:55 ` Joel Stanley
2021-06-23 20:05   ` Adriana Kobylak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.