* [RFC] Support for SGMII 2500
@ 2017-11-28 7:25 ` Madalin-cristian Bucur
0 siblings, 0 replies; 16+ messages in thread
From: Madalin-cristian Bucur @ 2017-11-28 7:25 UTC (permalink / raw)
To: Andrew Lunn, f.fainelli, netdev; +Cc: u-boot, Bhaskar Upadhaya
Hi,
There is a disconnect between the SGMII 2500 support in u-boot and Linux.
Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps
by using the PHY connection type "sgmii-2500" in the device tree:
phy-connection-type = "sgmii-2500";
This is supported by u-boot, in include/phy.h:
typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
PHY_INTERFACE_MODE_SGMII_2500,
...
static const char *phy_interface_strings[] = {
[PHY_INTERFACE_MODE_MII] = "mii",
[PHY_INTERFACE_MODE_GMII] = "gmii",
[PHY_INTERFACE_MODE_SGMII] = "sgmii",
[PHY_INTERFACE_MODE_SGMII_2500] = "sgmii-2500",
...
since this commit:
commit c35f8693942d8284c635592f263a0fe11abe1d1d
Author: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Date: Thu Oct 23 17:20:57 2014 +0800
net/fm: add 2.5G SGMII support
As auto-negotiation is not supported for 2.5G SGMII, we need
to add a new type PHY_INTERFACE_MODE_SGMII_2500 to differentiate
SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
In the Linux kernel we do not have a separate define for SGMII_2500, should we add
something like the change below?
Thanks,
Madalin
---
diff --git a/include/linux/phy.h b/include/linux/phy.h
index dc82a07..086f7a3 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -68,6 +68,7 @@ typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
+ PHY_INTERFACE_MODE_SGMII_2500,
PHY_INTERFACE_MODE_TBI,
PHY_INTERFACE_MODE_REVMII,
PHY_INTERFACE_MODE_RMII,
@@ -123,6 +124,8 @@ static inline const char *phy_modes(phy_interface_t interface)
return "gmii";
case PHY_INTERFACE_MODE_SGMII:
return "sgmii";
+ case PHY_INTERFACE_MODE_SGMII_2500:
+ return "sgmii-2500";
case PHY_INTERFACE_MODE_TBI:
return "tbi";
case PHY_INTERFACE_MODE_REVMII:
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
^ permalink raw reply related [flat|nested] 16+ messages in thread* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 7:25 ` Madalin-cristian Bucur
0 siblings, 0 replies; 16+ messages in thread
From: Madalin-cristian Bucur @ 2017-11-28 7:25 UTC (permalink / raw)
To: u-boot
Hi,
There is a disconnect between the SGMII 2500 support in u-boot and Linux.
Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps
by using the PHY connection type "sgmii-2500" in the device tree:
phy-connection-type = "sgmii-2500";
This is supported by u-boot, in include/phy.h:
typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
PHY_INTERFACE_MODE_SGMII_2500,
...
static const char *phy_interface_strings[] = {
[PHY_INTERFACE_MODE_MII] = "mii",
[PHY_INTERFACE_MODE_GMII] = "gmii",
[PHY_INTERFACE_MODE_SGMII] = "sgmii",
[PHY_INTERFACE_MODE_SGMII_2500] = "sgmii-2500",
...
since this commit:
commit c35f8693942d8284c635592f263a0fe11abe1d1d
Author: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Date: Thu Oct 23 17:20:57 2014 +0800
net/fm: add 2.5G SGMII support
As auto-negotiation is not supported for 2.5G SGMII, we need
to add a new type PHY_INTERFACE_MODE_SGMII_2500 to differentiate
SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
In the Linux kernel we do not have a separate define for SGMII_2500, should we add
something like the change below?
Thanks,
Madalin
---
diff --git a/include/linux/phy.h b/include/linux/phy.h
index dc82a07..086f7a3 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -68,6 +68,7 @@ typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
+ PHY_INTERFACE_MODE_SGMII_2500,
PHY_INTERFACE_MODE_TBI,
PHY_INTERFACE_MODE_REVMII,
PHY_INTERFACE_MODE_RMII,
@@ -123,6 +124,8 @@ static inline const char *phy_modes(phy_interface_t interface)
return "gmii";
case PHY_INTERFACE_MODE_SGMII:
return "sgmii";
+ case PHY_INTERFACE_MODE_SGMII_2500:
+ return "sgmii-2500";
case PHY_INTERFACE_MODE_TBI:
return "tbi";
case PHY_INTERFACE_MODE_REVMII:
^ permalink raw reply related [flat|nested] 16+ messages in thread* RE: [RFC] Support for SGMII 2500
2017-11-28 7:25 ` [U-Boot] " Madalin-cristian Bucur
@ 2017-11-28 7:27 ` Bhaskar Upadhaya
-1 siblings, 0 replies; 16+ messages in thread
From: Bhaskar Upadhaya @ 2017-11-28 7:27 UTC (permalink / raw)
To: Madalin-cristian Bucur, Andrew Lunn, f.fainelli, netdev,
Anji Jagarlmudi, Calvin Johnson, Prabhakar Kushwaha,
Poonam Aggrwal
Cc: Shengzhou Liu, York Sun, u-boot
+ Anji, Calvin, Prabhakar, Poonam.
-----Original Message-----
From: Madalin-cristian Bucur
Sent: Tuesday, November 28, 2017 12:56 PM
To: Andrew Lunn <andrew@lunn.ch>; f.fainelli@gmail.com; netdev@vger.kernel.org
Cc: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; Shengzhou Liu <shengzhou.liu@nxp.com>; York Sun <york.sun@nxp.com>; u-boot@lists.denx.de
Subject: [RFC] Support for SGMII 2500
Hi,
There is a disconnect between the SGMII 2500 support in u-boot and Linux.
Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps by using the PHY connection type "sgmii-2500" in the device tree:
phy-connection-type = "sgmii-2500";
This is supported by u-boot, in include/phy.h:
typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
PHY_INTERFACE_MODE_SGMII_2500,
...
static const char *phy_interface_strings[] = {
[PHY_INTERFACE_MODE_MII] = "mii",
[PHY_INTERFACE_MODE_GMII] = "gmii",
[PHY_INTERFACE_MODE_SGMII] = "sgmii",
[PHY_INTERFACE_MODE_SGMII_2500] = "sgmii-2500",
...
since this commit:
commit c35f8693942d8284c635592f263a0fe11abe1d1d
Author: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Date: Thu Oct 23 17:20:57 2014 +0800
net/fm: add 2.5G SGMII support
As auto-negotiation is not supported for 2.5G SGMII, we need
to add a new type PHY_INTERFACE_MODE_SGMII_2500 to differentiate
SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
In the Linux kernel we do not have a separate define for SGMII_2500, should we add something like the change below?
Thanks,
Madalin
---
diff --git a/include/linux/phy.h b/include/linux/phy.h index dc82a07..086f7a3 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -68,6 +68,7 @@ typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
+ PHY_INTERFACE_MODE_SGMII_2500,
PHY_INTERFACE_MODE_TBI,
PHY_INTERFACE_MODE_REVMII,
PHY_INTERFACE_MODE_RMII,
@@ -123,6 +124,8 @@ static inline const char *phy_modes(phy_interface_t interface)
return "gmii";
case PHY_INTERFACE_MODE_SGMII:
return "sgmii";
+ case PHY_INTERFACE_MODE_SGMII_2500:
+ return "sgmii-2500";
case PHY_INTERFACE_MODE_TBI:
return "tbi";
case PHY_INTERFACE_MODE_REVMII:
^ permalink raw reply [flat|nested] 16+ messages in thread* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 7:27 ` Bhaskar Upadhaya
0 siblings, 0 replies; 16+ messages in thread
From: Bhaskar Upadhaya @ 2017-11-28 7:27 UTC (permalink / raw)
To: u-boot
+ Anji, Calvin, Prabhakar, Poonam.
-----Original Message-----
From: Madalin-cristian Bucur
Sent: Tuesday, November 28, 2017 12:56 PM
To: Andrew Lunn <andrew@lunn.ch>; f.fainelli at gmail.com; netdev at vger.kernel.org
Cc: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; Shengzhou Liu <shengzhou.liu@nxp.com>; York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
Subject: [RFC] Support for SGMII 2500
Hi,
There is a disconnect between the SGMII 2500 support in u-boot and Linux.
Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps by using the PHY connection type "sgmii-2500" in the device tree:
phy-connection-type = "sgmii-2500";
This is supported by u-boot, in include/phy.h:
typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
PHY_INTERFACE_MODE_SGMII_2500,
...
static const char *phy_interface_strings[] = {
[PHY_INTERFACE_MODE_MII] = "mii",
[PHY_INTERFACE_MODE_GMII] = "gmii",
[PHY_INTERFACE_MODE_SGMII] = "sgmii",
[PHY_INTERFACE_MODE_SGMII_2500] = "sgmii-2500",
...
since this commit:
commit c35f8693942d8284c635592f263a0fe11abe1d1d
Author: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Date: Thu Oct 23 17:20:57 2014 +0800
net/fm: add 2.5G SGMII support
As auto-negotiation is not supported for 2.5G SGMII, we need
to add a new type PHY_INTERFACE_MODE_SGMII_2500 to differentiate
SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
In the Linux kernel we do not have a separate define for SGMII_2500, should we add something like the change below?
Thanks,
Madalin
---
diff --git a/include/linux/phy.h b/include/linux/phy.h index dc82a07..086f7a3 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -68,6 +68,7 @@ typedef enum {
PHY_INTERFACE_MODE_MII,
PHY_INTERFACE_MODE_GMII,
PHY_INTERFACE_MODE_SGMII,
+ PHY_INTERFACE_MODE_SGMII_2500,
PHY_INTERFACE_MODE_TBI,
PHY_INTERFACE_MODE_REVMII,
PHY_INTERFACE_MODE_RMII,
@@ -123,6 +124,8 @@ static inline const char *phy_modes(phy_interface_t interface)
return "gmii";
case PHY_INTERFACE_MODE_SGMII:
return "sgmii";
+ case PHY_INTERFACE_MODE_SGMII_2500:
+ return "sgmii-2500";
case PHY_INTERFACE_MODE_TBI:
return "tbi";
case PHY_INTERFACE_MODE_REVMII:
^ permalink raw reply [flat|nested] 16+ messages in thread* RE: [RFC] Support for SGMII 2500
2017-11-28 7:27 ` [U-Boot] " Bhaskar Upadhaya
@ 2017-11-28 8:16 ` Prabhakar Kushwaha
-1 siblings, 0 replies; 16+ messages in thread
From: Prabhakar Kushwaha @ 2017-11-28 8:16 UTC (permalink / raw)
To: Bhaskar Upadhaya, Madalin-cristian Bucur, Andrew Lunn,
f.fainelli, netdev, Anji Jagarlmudi, Calvin Johnson,
Poonam Aggrwal
Cc: Shengzhou Liu, York Sun, u-boot
Hi Madalin,
> -----Original Message-----
> From: Bhaskar Upadhaya
> Sent: Tuesday, November 28, 2017 12:57 PM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>; Andrew Lunn
> <andrew@lunn.ch>; f.fainelli@gmail.com; netdev@vger.kernel.org; Anji
> Jagarlmudi <anji.jagarlmudi@nxp.com>; Calvin Johnson
> <calvin.johnson@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Poonam Aggrwal
> <poonam.aggrwal@nxp.com>
> Cc: Shengzhou Liu <shengzhou.liu@nxp.com>; York Sun <york.sun@nxp.com>; u-
> boot@lists.denx.de
> Subject: RE: [RFC] Support for SGMII 2500
>
> + Anji, Calvin, Prabhakar, Poonam.
>
> -----Original Message-----
> From: Madalin-cristian Bucur
> Sent: Tuesday, November 28, 2017 12:56 PM
> To: Andrew Lunn <andrew@lunn.ch>; f.fainelli@gmail.com;
> netdev@vger.kernel.org
> Cc: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; Shengzhou Liu
> <shengzhou.liu@nxp.com>; York Sun <york.sun@nxp.com>; u-
> boot@lists.denx.de
> Subject: [RFC] Support for SGMII 2500
>
> Hi,
>
> There is a disconnect between the SGMII 2500 support in u-boot and Linux.
> Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps by
> using the PHY connection type "sgmii-2500" in the device tree:
>
> phy-connection-type = "sgmii-2500";
>
> This is supported by u-boot, in include/phy.h:
>
> typedef enum {
> PHY_INTERFACE_MODE_MII,
> PHY_INTERFACE_MODE_GMII,
> PHY_INTERFACE_MODE_SGMII,
> PHY_INTERFACE_MODE_SGMII_2500,
> ...
>
> static const char *phy_interface_strings[] = {
> [PHY_INTERFACE_MODE_MII] = "mii",
> [PHY_INTERFACE_MODE_GMII] = "gmii",
> [PHY_INTERFACE_MODE_SGMII] = "sgmii",
> [PHY_INTERFACE_MODE_SGMII_2500] = "sgmii-2500",
> ...
>
> since this commit:
>
> commit c35f8693942d8284c635592f263a0fe11abe1d1d
> Author: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Date: Thu Oct 23 17:20:57 2014 +0800
>
> net/fm: add 2.5G SGMII support
>
> As auto-negotiation is not supported for 2.5G SGMII, we need
> to add a new type PHY_INTERFACE_MODE_SGMII_2500 to
> differentiate
> SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Reviewed-by: York Sun <yorksun@freescale.com>
>
> In the Linux kernel we do not have a separate define for SGMII_2500, should we
> add something like the change below?
>
If there is no separate define in Linux. Than how it deals with auto-negotiation.
Can same approach be used in u-boot?
--pk
^ permalink raw reply [flat|nested] 16+ messages in thread* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 8:16 ` Prabhakar Kushwaha
0 siblings, 0 replies; 16+ messages in thread
From: Prabhakar Kushwaha @ 2017-11-28 8:16 UTC (permalink / raw)
To: u-boot
Hi Madalin,
> -----Original Message-----
> From: Bhaskar Upadhaya
> Sent: Tuesday, November 28, 2017 12:57 PM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>; Andrew Lunn
> <andrew@lunn.ch>; f.fainelli at gmail.com; netdev at vger.kernel.org; Anji
> Jagarlmudi <anji.jagarlmudi@nxp.com>; Calvin Johnson
> <calvin.johnson@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Poonam Aggrwal
> <poonam.aggrwal@nxp.com>
> Cc: Shengzhou Liu <shengzhou.liu@nxp.com>; York Sun <york.sun@nxp.com>; u-
> boot at lists.denx.de
> Subject: RE: [RFC] Support for SGMII 2500
>
> + Anji, Calvin, Prabhakar, Poonam.
>
> -----Original Message-----
> From: Madalin-cristian Bucur
> Sent: Tuesday, November 28, 2017 12:56 PM
> To: Andrew Lunn <andrew@lunn.ch>; f.fainelli at gmail.com;
> netdev at vger.kernel.org
> Cc: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; Shengzhou Liu
> <shengzhou.liu@nxp.com>; York Sun <york.sun@nxp.com>; u-
> boot at lists.denx.de
> Subject: [RFC] Support for SGMII 2500
>
> Hi,
>
> There is a disconnect between the SGMII 2500 support in u-boot and Linux.
> Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps by
> using the PHY connection type "sgmii-2500" in the device tree:
>
> phy-connection-type = "sgmii-2500";
>
> This is supported by u-boot, in include/phy.h:
>
> typedef enum {
> PHY_INTERFACE_MODE_MII,
> PHY_INTERFACE_MODE_GMII,
> PHY_INTERFACE_MODE_SGMII,
> PHY_INTERFACE_MODE_SGMII_2500,
> ...
>
> static const char *phy_interface_strings[] = {
> [PHY_INTERFACE_MODE_MII] = "mii",
> [PHY_INTERFACE_MODE_GMII] = "gmii",
> [PHY_INTERFACE_MODE_SGMII] = "sgmii",
> [PHY_INTERFACE_MODE_SGMII_2500] = "sgmii-2500",
> ...
>
> since this commit:
>
> commit c35f8693942d8284c635592f263a0fe11abe1d1d
> Author: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Date: Thu Oct 23 17:20:57 2014 +0800
>
> net/fm: add 2.5G SGMII support
>
> As auto-negotiation is not supported for 2.5G SGMII, we need
> to add a new type PHY_INTERFACE_MODE_SGMII_2500 to
> differentiate
> SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Reviewed-by: York Sun <yorksun@freescale.com>
>
> In the Linux kernel we do not have a separate define for SGMII_2500, should we
> add something like the change below?
>
If there is no separate define in Linux. Than how it deals with auto-negotiation.
Can same approach be used in u-boot?
--pk
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC] Support for SGMII 2500
2017-11-28 7:25 ` [U-Boot] " Madalin-cristian Bucur
@ 2017-11-28 13:30 ` Andrew Lunn
-1 siblings, 0 replies; 16+ messages in thread
From: Andrew Lunn @ 2017-11-28 13:30 UTC (permalink / raw)
To: Madalin-cristian Bucur
Cc: f.fainelli, netdev, Bhaskar Upadhaya, Shengzhou Liu, York Sun, u-boot
On Tue, Nov 28, 2017 at 07:25:48AM +0000, Madalin-cristian Bucur wrote:
> Hi,
>
> There is a disconnect between the SGMII 2500 support in u-boot and Linux.
> Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps
> by using the PHY connection type "sgmii-2500" in the device tree:
Hi Madalin
What MAC and PHY are you using?
I did a quick search for SGMII 2.5, and all i keep coming across is
2500BASE-X. I just want to make sure you really do need SGMII at 2500,
and not 2500BASE-X, which is already supported.
Thanks
Andrew
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 13:30 ` Andrew Lunn
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Lunn @ 2017-11-28 13:30 UTC (permalink / raw)
To: u-boot
On Tue, Nov 28, 2017 at 07:25:48AM +0000, Madalin-cristian Bucur wrote:
> Hi,
>
> There is a disconnect between the SGMII 2500 support in u-boot and Linux.
> Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps
> by using the PHY connection type "sgmii-2500" in the device tree:
Hi Madalin
What MAC and PHY are you using?
I did a quick search for SGMII 2.5, and all i keep coming across is
2500BASE-X. I just want to make sure you really do need SGMII at 2500,
and not 2500BASE-X, which is already supported.
Thanks
Andrew
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [RFC] Support for SGMII 2500
2017-11-28 13:30 ` [U-Boot] " Andrew Lunn
@ 2017-11-28 13:55 ` Madalin-cristian Bucur
-1 siblings, 0 replies; 16+ messages in thread
From: Madalin-cristian Bucur @ 2017-11-28 13:55 UTC (permalink / raw)
To: Andrew Lunn, Bhaskar Upadhaya
Cc: f.fainelli, netdev, Shengzhou Liu, York Sun, u-boot,
Anji Jagarlmudi, Calvin Johnson, Poonam Aggrwal,
Prabhakar Kushwaha
> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@lunn.ch]
> Sent: Tuesday, November 28, 2017 3:30 PM
> Subject: Re: [RFC] Support for SGMII 2500
>
> On Tue, Nov 28, 2017 at 07:25:48AM +0000, Madalin-cristian Bucur wrote:
> > Hi,
> >
> > There is a disconnect between the SGMII 2500 support in u-boot and
> Linux.
> > Bhaskar is trying to add support for a SGMII interface working at
> 2.5Gbps
> > by using the PHY connection type "sgmii-2500" in the device tree:
>
> Hi Madalin
>
> What MAC and PHY are you using?
>
> I did a quick search for SGMII 2.5, and all i keep coming across is
> 2500BASE-X. I just want to make sure you really do need SGMII at 2500,
> and not 2500BASE-X, which is already supported.
>
> Thanks
> Andrew
Hi Andrew,
Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia AQR107
PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, but it
seems the HW actually works in SGMII mode. The QDS boards are lower volume,
higher spec boards than the RDBs [3], they exercise most of the HW capabilities.
Regards,
Madalin
[1] https://www.nxp.com/products/processors-and-microcontrollers/arm-based-processors-and-mcus/qoriq-layerscape-arm-processors/qoriq-layerscape-1012a-low-power-communication-processor:LS1012A
[2] https://www.aquantia.com/products/enterprise/aqr107/
[3] https://www.nxp.com/support/developer-resources/software-development-tools/qoriq-developer-resources/qoriq-ls1012a-reference-design-board:LS1012A-RDB
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 13:55 ` Madalin-cristian Bucur
0 siblings, 0 replies; 16+ messages in thread
From: Madalin-cristian Bucur @ 2017-11-28 13:55 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Andrew Lunn [mailto:andrew at lunn.ch]
> Sent: Tuesday, November 28, 2017 3:30 PM
> Subject: Re: [RFC] Support for SGMII 2500
>
> On Tue, Nov 28, 2017 at 07:25:48AM +0000, Madalin-cristian Bucur wrote:
> > Hi,
> >
> > There is a disconnect between the SGMII 2500 support in u-boot and
> Linux.
> > Bhaskar is trying to add support for a SGMII interface working at
> 2.5Gbps
> > by using the PHY connection type "sgmii-2500" in the device tree:
>
> Hi Madalin
>
> What MAC and PHY are you using?
>
> I did a quick search for SGMII 2.5, and all i keep coming across is
> 2500BASE-X. I just want to make sure you really do need SGMII at 2500,
> and not 2500BASE-X, which is already supported.
>
> Thanks
> Andrew
Hi Andrew,
Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia AQR107
PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, but it
seems the HW actually works in SGMII mode. The QDS boards are lower volume,
higher spec boards than the RDBs [3], they exercise most of the HW capabilities.
Regards,
Madalin
[1] https://www.nxp.com/products/processors-and-microcontrollers/arm-based-processors-and-mcus/qoriq-layerscape-arm-processors/qoriq-layerscape-1012a-low-power-communication-processor:LS1012A
[2] https://www.aquantia.com/products/enterprise/aqr107/
[3] https://www.nxp.com/support/developer-resources/software-development-tools/qoriq-developer-resources/qoriq-ls1012a-reference-design-board:LS1012A-RDB
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC] Support for SGMII 2500
2017-11-28 13:55 ` [U-Boot] " Madalin-cristian Bucur
@ 2017-11-28 14:13 ` Andrew Lunn
-1 siblings, 0 replies; 16+ messages in thread
From: Andrew Lunn @ 2017-11-28 14:13 UTC (permalink / raw)
To: Madalin-cristian Bucur
Cc: Bhaskar Upadhaya, f.fainelli, netdev, Shengzhou Liu, York Sun,
u-boot, Anji Jagarlmudi, Calvin Johnson, Poonam Aggrwal,
Prabhakar Kushwaha
> Hi Andrew,
>
> Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia AQR107
> PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, but it
> seems the HW actually works in SGMII mode. The QDS boards are lower volume,
> higher spec boards than the RDBs [3], they exercise most of the HW capabilities.
The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
with the MAC? Ideally you want to use 2500Base-X, since this is wider
known.
Anyway, you seem to have a legitimate need for it.
However, i would prefer a different name. The convention is to put the
number first. So PHY_INTERFACE_MODE_2500SGMII.
Andrew
^ permalink raw reply [flat|nested] 16+ messages in thread* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 14:13 ` Andrew Lunn
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Lunn @ 2017-11-28 14:13 UTC (permalink / raw)
To: u-boot
> Hi Andrew,
>
> Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia AQR107
> PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, but it
> seems the HW actually works in SGMII mode. The QDS boards are lower volume,
> higher spec boards than the RDBs [3], they exercise most of the HW capabilities.
The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
with the MAC? Ideally you want to use 2500Base-X, since this is wider
known.
Anyway, you seem to have a legitimate need for it.
However, i would prefer a different name. The convention is to put the
number first. So PHY_INTERFACE_MODE_2500SGMII.
Andrew
^ permalink raw reply [flat|nested] 16+ messages in thread* RE: [RFC] Support for SGMII 2500
2017-11-28 14:13 ` [U-Boot] " Andrew Lunn
@ 2017-11-28 15:37 ` Madalin-cristian Bucur
-1 siblings, 0 replies; 16+ messages in thread
From: Madalin-cristian Bucur @ 2017-11-28 15:37 UTC (permalink / raw)
To: Andrew Lunn
Cc: Bhaskar Upadhaya, f.fainelli, netdev, Shengzhou Liu, York Sun,
u-boot, Anji Jagarlmudi, Calvin Johnson, Poonam Aggrwal,
Prabhakar Kushwaha
> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@lunn.ch]
> Sent: Tuesday, November 28, 2017 4:13 PM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
> Subject: Re: [RFC] Support for SGMII 2500
>
> > Hi Andrew,
> >
> > Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia
> AQR107
> > PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too,
> but it
> > seems the HW actually works in SGMII mode. The QDS boards are lower
> volume,
> > higher spec boards than the RDBs [3], they exercise most of the HW
> capabilities.
>
> The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
> with the MAC? Ideally you want to use 2500Base-X, since this is wider
> known.
>
> Anyway, you seem to have a legitimate need for it.
>
> However, i would prefer a different name. The convention is to put the
> number first. So PHY_INTERFACE_MODE_2500SGMII.
>
> Andrew
OK,
I just wanted to make sure 2.5G SGMII is to be added separately from the
"normal" SGMII, as it was done in u-boot. Thanks also for the naming hint.
Madalin
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 15:37 ` Madalin-cristian Bucur
0 siblings, 0 replies; 16+ messages in thread
From: Madalin-cristian Bucur @ 2017-11-28 15:37 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Andrew Lunn [mailto:andrew at lunn.ch]
> Sent: Tuesday, November 28, 2017 4:13 PM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
> Subject: Re: [RFC] Support for SGMII 2500
>
> > Hi Andrew,
> >
> > Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia
> AQR107
> > PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too,
> but it
> > seems the HW actually works in SGMII mode. The QDS boards are lower
> volume,
> > higher spec boards than the RDBs [3], they exercise most of the HW
> capabilities.
>
> The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
> with the MAC? Ideally you want to use 2500Base-X, since this is wider
> known.
>
> Anyway, you seem to have a legitimate need for it.
>
> However, i would prefer a different name. The convention is to put the
> number first. So PHY_INTERFACE_MODE_2500SGMII.
>
> Andrew
OK,
I just wanted to make sure 2.5G SGMII is to be added separately from the
"normal" SGMII, as it was done in u-boot. Thanks also for the naming hint.
Madalin
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC] Support for SGMII 2500
2017-11-28 15:37 ` [U-Boot] " Madalin-cristian Bucur
@ 2017-11-28 17:51 ` Florian Fainelli
-1 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2017-11-28 17:51 UTC (permalink / raw)
To: Madalin-cristian Bucur, Andrew Lunn
Cc: netdev, Bhaskar Upadhaya, linux, Anji Jagarlmudi, u-boot
On 11/28/2017 07:37 AM, Madalin-cristian Bucur wrote:
>> -----Original Message-----
>> From: Andrew Lunn [mailto:andrew@lunn.ch]
>> Sent: Tuesday, November 28, 2017 4:13 PM
>> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
>> Subject: Re: [RFC] Support for SGMII 2500
>>
>>> Hi Andrew,
>>>
>>> Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia
>> AQR107
>>> PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too,
>> but it
>>> seems the HW actually works in SGMII mode. The QDS boards are lower
>> volume,
>>> higher spec boards than the RDBs [3], they exercise most of the HW
>> capabilities.
>>
>> The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
>> with the MAC? Ideally you want to use 2500Base-X, since this is wider
>> known.
>>
>> Anyway, you seem to have a legitimate need for it.
>>
>> However, i would prefer a different name. The convention is to put the
>> number first. So PHY_INTERFACE_MODE_2500SGMII.
>>
>> Andrew
>
> OK,
>
> I just wanted to make sure 2.5G SGMII is to be added separately from the
> "normal" SGMII, as it was done in u-boot. Thanks also for the naming hint.
Sorry for chiming in that late, but what is 2.5G SGMII exactly? Either
you can use SGMII auto-negotiation, and in which case, why is not 2.5G
selected, or you can't and you might want to use a fixed-link property then.
--
Florian
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 16+ messages in thread
* [U-Boot] [RFC] Support for SGMII 2500
@ 2017-11-28 17:51 ` Florian Fainelli
0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2017-11-28 17:51 UTC (permalink / raw)
To: u-boot
On 11/28/2017 07:37 AM, Madalin-cristian Bucur wrote:
>> -----Original Message-----
>> From: Andrew Lunn [mailto:andrew at lunn.ch]
>> Sent: Tuesday, November 28, 2017 4:13 PM
>> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
>> Subject: Re: [RFC] Support for SGMII 2500
>>
>>> Hi Andrew,
>>>
>>> Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia
>> AQR107
>>> PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too,
>> but it
>>> seems the HW actually works in SGMII mode. The QDS boards are lower
>> volume,
>>> higher spec boards than the RDBs [3], they exercise most of the HW
>> capabilities.
>>
>> The webpage for the AQR107 lists 2500Base-X, so i assume the issue is
>> with the MAC? Ideally you want to use 2500Base-X, since this is wider
>> known.
>>
>> Anyway, you seem to have a legitimate need for it.
>>
>> However, i would prefer a different name. The convention is to put the
>> number first. So PHY_INTERFACE_MODE_2500SGMII.
>>
>> Andrew
>
> OK,
>
> I just wanted to make sure 2.5G SGMII is to be added separately from the
> "normal" SGMII, as it was done in u-boot. Thanks also for the naming hint.
Sorry for chiming in that late, but what is 2.5G SGMII exactly? Either
you can use SGMII auto-negotiation, and in which case, why is not 2.5G
selected, or you can't and you might want to use a fixed-link property then.
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-11-28 17:51 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 7:25 [RFC] Support for SGMII 2500 Madalin-cristian Bucur
2017-11-28 7:25 ` [U-Boot] " Madalin-cristian Bucur
2017-11-28 7:27 ` Bhaskar Upadhaya
2017-11-28 7:27 ` [U-Boot] " Bhaskar Upadhaya
2017-11-28 8:16 ` Prabhakar Kushwaha
2017-11-28 8:16 ` [U-Boot] " Prabhakar Kushwaha
2017-11-28 13:30 ` Andrew Lunn
2017-11-28 13:30 ` [U-Boot] " Andrew Lunn
2017-11-28 13:55 ` Madalin-cristian Bucur
2017-11-28 13:55 ` [U-Boot] " Madalin-cristian Bucur
2017-11-28 14:13 ` Andrew Lunn
2017-11-28 14:13 ` [U-Boot] " Andrew Lunn
2017-11-28 15:37 ` Madalin-cristian Bucur
2017-11-28 15:37 ` [U-Boot] " Madalin-cristian Bucur
2017-11-28 17:51 ` Florian Fainelli
2017-11-28 17:51 ` [U-Boot] " Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.