From: Anson Huang <anson.huang@nxp.com> To: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, "rui.zhang@intel.com" <rui.zhang@intel.com>, "amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>, Aisheng Dong <aisheng.dong@nxp.com>, "linux@roeck-us.net" <linux@roeck-us.net>, "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>, "krzk@kernel.org" <krzk@kernel.org>, Andy Duan <fugang.duan@nxp.com>, Peng Fan <peng.fan@nxp.com>, Daniel Baluta <daniel.baluta@nxp.com>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "olof@lixom.net" <olof@lixom.net>, "dinguyen@kernel.org" <dinguyen@kernel.org>, Leonard Crestez <leonard.crestez@nxp.com>, "marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting sensor ID from DT Date: Fri, 21 Feb 2020 09:26:29 +0000 [thread overview] Message-ID: <DB3PR0402MB39161BB726FE5413F30F0263F5120@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200221091112.GA10516@linaro.org> Hi, Daniel > Subject: Re: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting > sensor ID from DT > > Hi, > > On Thu, Feb 20, 2020 at 09:10:25AM +0800, Anson Huang wrote: > > This patch adds new API thermal_zone_of_get_sensor_id() to provide the > > feature of getting sensor ID from DT thermal zone's node. It's useful > > for thermal driver to register the specific thermal zone devices from > > DT in a common way. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > Changes since V14: > > - improve the commit message and comment, no code change. > > --- > > drivers/thermal/of-thermal.c | 65 +++++++++++++++++++++++++++++++++- > ---------- > > include/linux/thermal.h | 10 +++++++ > > 2 files changed, 59 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/thermal/of-thermal.c > > b/drivers/thermal/of-thermal.c index ef0baa9..0f57108 100644 > > --- a/drivers/thermal/of-thermal.c > > +++ b/drivers/thermal/of-thermal.c > > @@ -449,6 +449,53 @@ thermal_zone_of_add_sensor(struct device_node > > *zone, } > > > > /** > > + * thermal_zone_of_get_sensor_id - get sensor ID from a DT thermal > > + zone > > + * @tz_np: a valid thermal zone device node. > > + * @sensor_np: a sensor node of a valid sensor device. > > + * @id: the sensor ID returned if success. > > + * > > + * This function will get sensor ID from a given thermal zone node > > + and > > + * the sensor node must match the temperature provider @sensor_np. > > + * > > + * Return: 0 on success, proper error code otherwise. > > + */ > > + > > +int thermal_zone_of_get_sensor_id(struct device_node *tz_np, > > + struct device_node *sensor_np, > > + u32 *id) > > +{ > > + struct of_phandle_args sensor_specs; > > + int ret; > > + > > + ret = of_parse_phandle_with_args(tz_np, > > + "thermal-sensors", > > + "#thermal-sensor-cells", > > + 0, > > + &sensor_specs); > > + if (ret) > > + return ret; > > + > > + if (sensor_specs.np != sensor_np) { > > + of_node_put(sensor_specs.np); > > + return -ENODEV; > > + } > > + > > + if (sensor_specs.args_count >= 1) { > > For the sake of clarity, move the sanity tests before: > > if (sensor_specs.args_count > 1) > pr_warn("..."); > > *id = sensor_specs.args_count ? sensor_specs.args[0] : 0; > Make sense, will improve it in V16. > > + *id = sensor_specs.args[0]; > > + WARN(sensor_specs.args_count > 1, > > + "%pOFn: too many cells in sensor specifier %d\n", > > + sensor_specs.np, sensor_specs.args_count); > > + } else { > > + *id = 0; > > + } > > + > > + of_node_put(sensor_specs.np); > > + > > + return 0; > > +} > > +EXPORT_SYMBOL_GPL(thermal_zone_of_get_sensor_id); > > + > > +/** > > * thermal_zone_of_sensor_register - registers a sensor to a DT thermal > zone > > * @dev: a valid struct device pointer of a sensor device. Must contain > > * a valid .of_node, for the sensor node. > > @@ -499,36 +546,22 @@ thermal_zone_of_sensor_register(struct device > *dev, int sensor_id, void *data, > > sensor_np = of_node_get(dev->of_node); > > > > for_each_available_child_of_node(np, child) { > > - struct of_phandle_args sensor_specs; > > int ret, id; > > > > /* For now, thermal framework supports only 1 sensor per > zone */ > > - ret = of_parse_phandle_with_args(child, "thermal-sensors", > > - "#thermal-sensor-cells", > > - 0, &sensor_specs); > > + ret = thermal_zone_of_get_sensor_id(child, sensor_np, &id); > > if (ret) > > continue; > > > > - if (sensor_specs.args_count >= 1) { > > - id = sensor_specs.args[0]; > > - WARN(sensor_specs.args_count > 1, > > - "%pOFn: too many cells in sensor specifier %d\n", > > - sensor_specs.np, sensor_specs.args_count); > > - } else { > > - id = 0; > > - } > > Please take also the opportunity to factor out the function > thermal_zone_of_sensor_register(). Sorry, I do NOT quite understand terms "factor out the function ...", could you please advise more detail? Thanks, Anson
WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com> To: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>, Peng Fan <peng.fan@nxp.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>, Leonard Crestez <leonard.crestez@nxp.com>, "will@kernel.org" <will@kernel.org>, "amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>, "festevam@gmail.com" <festevam@gmail.com>, "krzk@kernel.org" <krzk@kernel.org>, "marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>, dl-linux-imx <linux-imx@nxp.com>, "rui.zhang@intel.com" <rui.zhang@intel.com>, "linux@roeck-us.net" <linux@roeck-us.net>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, Daniel Baluta <daniel.baluta@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Aisheng Dong <aisheng.dong@nxp.com>, Andy Duan <fugang.duan@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dinguyen@kernel.org" <dinguyen@kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "olof@lixom.net" <olof@lixom.net>, "shawnguo@kernel.org" <shawnguo@kernel.org> Subject: RE: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting sensor ID from DT Date: Fri, 21 Feb 2020 09:26:29 +0000 [thread overview] Message-ID: <DB3PR0402MB39161BB726FE5413F30F0263F5120@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200221091112.GA10516@linaro.org> Hi, Daniel > Subject: Re: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting > sensor ID from DT > > Hi, > > On Thu, Feb 20, 2020 at 09:10:25AM +0800, Anson Huang wrote: > > This patch adds new API thermal_zone_of_get_sensor_id() to provide the > > feature of getting sensor ID from DT thermal zone's node. It's useful > > for thermal driver to register the specific thermal zone devices from > > DT in a common way. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > Changes since V14: > > - improve the commit message and comment, no code change. > > --- > > drivers/thermal/of-thermal.c | 65 +++++++++++++++++++++++++++++++++- > ---------- > > include/linux/thermal.h | 10 +++++++ > > 2 files changed, 59 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/thermal/of-thermal.c > > b/drivers/thermal/of-thermal.c index ef0baa9..0f57108 100644 > > --- a/drivers/thermal/of-thermal.c > > +++ b/drivers/thermal/of-thermal.c > > @@ -449,6 +449,53 @@ thermal_zone_of_add_sensor(struct device_node > > *zone, } > > > > /** > > + * thermal_zone_of_get_sensor_id - get sensor ID from a DT thermal > > + zone > > + * @tz_np: a valid thermal zone device node. > > + * @sensor_np: a sensor node of a valid sensor device. > > + * @id: the sensor ID returned if success. > > + * > > + * This function will get sensor ID from a given thermal zone node > > + and > > + * the sensor node must match the temperature provider @sensor_np. > > + * > > + * Return: 0 on success, proper error code otherwise. > > + */ > > + > > +int thermal_zone_of_get_sensor_id(struct device_node *tz_np, > > + struct device_node *sensor_np, > > + u32 *id) > > +{ > > + struct of_phandle_args sensor_specs; > > + int ret; > > + > > + ret = of_parse_phandle_with_args(tz_np, > > + "thermal-sensors", > > + "#thermal-sensor-cells", > > + 0, > > + &sensor_specs); > > + if (ret) > > + return ret; > > + > > + if (sensor_specs.np != sensor_np) { > > + of_node_put(sensor_specs.np); > > + return -ENODEV; > > + } > > + > > + if (sensor_specs.args_count >= 1) { > > For the sake of clarity, move the sanity tests before: > > if (sensor_specs.args_count > 1) > pr_warn("..."); > > *id = sensor_specs.args_count ? sensor_specs.args[0] : 0; > Make sense, will improve it in V16. > > + *id = sensor_specs.args[0]; > > + WARN(sensor_specs.args_count > 1, > > + "%pOFn: too many cells in sensor specifier %d\n", > > + sensor_specs.np, sensor_specs.args_count); > > + } else { > > + *id = 0; > > + } > > + > > + of_node_put(sensor_specs.np); > > + > > + return 0; > > +} > > +EXPORT_SYMBOL_GPL(thermal_zone_of_get_sensor_id); > > + > > +/** > > * thermal_zone_of_sensor_register - registers a sensor to a DT thermal > zone > > * @dev: a valid struct device pointer of a sensor device. Must contain > > * a valid .of_node, for the sensor node. > > @@ -499,36 +546,22 @@ thermal_zone_of_sensor_register(struct device > *dev, int sensor_id, void *data, > > sensor_np = of_node_get(dev->of_node); > > > > for_each_available_child_of_node(np, child) { > > - struct of_phandle_args sensor_specs; > > int ret, id; > > > > /* For now, thermal framework supports only 1 sensor per > zone */ > > - ret = of_parse_phandle_with_args(child, "thermal-sensors", > > - "#thermal-sensor-cells", > > - 0, &sensor_specs); > > + ret = thermal_zone_of_get_sensor_id(child, sensor_np, &id); > > if (ret) > > continue; > > > > - if (sensor_specs.args_count >= 1) { > > - id = sensor_specs.args[0]; > > - WARN(sensor_specs.args_count > 1, > > - "%pOFn: too many cells in sensor specifier %d\n", > > - sensor_specs.np, sensor_specs.args_count); > > - } else { > > - id = 0; > > - } > > Please take also the opportunity to factor out the function > thermal_zone_of_sensor_register(). Sorry, I do NOT quite understand terms "factor out the function ...", could you please advise more detail? Thanks, Anson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-21 9:26 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-20 1:10 [PATCH V15 RESEND 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang 2020-02-20 1:10 ` Anson Huang 2020-02-20 1:10 ` [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting sensor ID from DT Anson Huang 2020-02-20 1:10 ` Anson Huang 2020-02-21 9:11 ` Daniel Lezcano 2020-02-21 9:11 ` Daniel Lezcano 2020-02-21 9:26 ` Anson Huang [this message] 2020-02-21 9:26 ` Anson Huang 2020-02-21 13:12 ` Daniel Lezcano 2020-02-21 13:12 ` Daniel Lezcano 2020-02-20 1:10 ` [PATCH V15 RESEND 3/5] thermal: imx_sc: add i.MX system controller thermal support Anson Huang 2020-02-20 1:10 ` Anson Huang 2020-02-21 12:53 ` Daniel Lezcano 2020-02-21 12:53 ` Daniel Lezcano 2020-02-21 23:46 ` Anson Huang 2020-02-21 23:46 ` Anson Huang 2020-02-22 7:39 ` Daniel Lezcano 2020-02-22 7:39 ` Daniel Lezcano 2020-02-20 1:10 ` [PATCH V15 RESEND 4/5] defconfig: arm64: " Anson Huang 2020-02-20 1:10 ` Anson Huang 2020-02-20 1:10 ` [PATCH V15 RESEND 5/5] arm64: dts: imx: add i.MX8QXP " Anson Huang 2020-02-20 1:10 ` Anson Huang 2020-02-21 13:04 ` Daniel Lezcano 2020-02-21 13:04 ` Daniel Lezcano 2020-02-21 23:53 ` Anson Huang 2020-02-21 23:53 ` Anson Huang 2020-02-22 7:51 ` Daniel Lezcano 2020-02-22 7:51 ` Daniel Lezcano 2020-02-22 12:19 ` Anson Huang 2020-02-22 12:19 ` Anson Huang 2020-02-21 13:05 ` Daniel Lezcano 2020-02-21 13:05 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB3PR0402MB39161BB726FE5413F30F0263F5120@DB3PR0402MB3916.eurprd04.prod.outlook.com \ --to=anson.huang@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=amit.kucheria@verdurent.com \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.baluta@nxp.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@kernel.org \ --cc=festevam@gmail.com \ --cc=fugang.duan@nxp.com \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=marcin.juszkiewicz@linaro.org \ --cc=mark.rutland@arm.com \ --cc=olof@lixom.net \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.